Hi Marcel,
A friendly ping on this patch. :)
Regards,
Miao
On Wed, Jan 27, 2021 at 9:17 AM Miao-chen Chou wrote:
>
> This moves msft_do_close() from hci_dev_do_close() to
> hci_unregister_dev() to avoid clearing MSFT extension info. This also
> re-reads MSFT info upon every msft_do
MSFT support debug log in syslog
(2) restart bluetoothd and verify msft_do_close() doesn't get invoked
and msft_do_open re-reads the MSFT support.
Signed-off-by: Miao-chen Chou
Reviewed-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
Reviewed-by: Alain Michaud
---
Changes in v4:
do_open() if MSFT extension
> > has been initialized.
> >
> > The following test steps were performed.
> > (1) boot the test device and verify the MSFT support debug log in syslog
> > (2) restart bluetoothd and verify msft_do_close() doesn't get invoked
> >
the MSFT support debug log in syslog
(2) restart bluetoothd and verify msft_do_close() doesn't get invoked
Signed-off-by: Miao-chen Chou
Reviewed-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
---
Hi Maintainers,
This patch fixes the life cycle of MSFT HCI extension. The current
symm
Hi Marcel,
On Fri, Dec 18, 2020 at 1:39 PM Marcel Holtmann wrote:
>
> Hi Miao-chen,
>
> > This moves msft_do_close() from hci_dev_do_close() to
> > hci_unregister_dev() to avoid clearing MSFT extension info. This also
> > avoids retrieving MSFT info upon every msft_do_open() if MSFT extension
> >
the MSFT support debug log in syslog
(2) restart bluetoothd and verify msft_do_close() doesn't get invoked
Signed-off-by: Miao-chen Chou
Reviewed-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
---
(no changes since v1)
net/bluetooth/hci_core.c | 4 ++--
net/bluetooth/msft.c
the MSFT support debug log in syslog
(2) restart bluetoothd and verify msft_do_close() doesn't get invoked
Signed-off-by: Miao-chen Chou
Reviewed-by: Abhishek Pandit-Subedi
Reviewed-by: Archie Pusaka
---
net/bluetooth/hci_core.c | 4 ++--
net/bluetooth/msft.c | 3 ++-
2 files chang
the host was not awaken by random
advertisements.
Signed-off-by: Miao-chen Chou
Reviewed-by: Abhishek Pandit-Subedi
---
net/bluetooth/hci_request.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
index
Hi Marcel,
In case you missed this thread, my suggestion is to revert the
previous patch and apply this patch. Please see my earlier email for
the reason. Thanks.
Regards,
Miao
On Tue, Jun 30, 2020 at 2:55 PM Miao-chen Chou wrote:
>
> Hi Marcel,
>
> hci_unregister_dev() is invo
nd verify that no kernel oops is triggered.
> >
> > Signed-off-by: Miao-chen Chou
> > Reviewed-by: Abhishek Pandit-Subedi
> > Reviewed-by: Alain Michaud
> > ---
> >
> > net/bluetooth/hci_core.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
>
This fixes the kernel oops by removing unnecessary background scan
update from hci_adv_monitors_clear() which shouldn't invoke any work
queue.
The following test was performed.
- Run "rmmod btusb" and verify that no kernel oops is triggered.
Signed-off-by: Miao-chen Chou
Review
Hi Marcel,
https://patchwork.kernel.org/patch/11606491/ was uploaded for review.
Thanks,
Miao
On Fri, Jun 12, 2020 at 11:17 PM Marcel Holtmann wrote:
>
> Hi Miao-chen,
>
> > The name in the mgmt-api.txt doc is "Add Advertisement Patterns
> > Monitor Command", and Luiz changed the name from
> >
with valid and invalid handles.
Signed-off-by: Miao-chen Chou
---
Changes in v5:
- Fix warnings.
Changes in v4:
- Fix warnings.
Changes in v3:
- Update the opcode in the mgmt table.
- Convert the endianness of the returned handle.
Changes in v2: None
include/net/bluetooth/hci_core.h | 1
This notifies management sockets on MGMT_EV_ADV_MONITOR_ADDED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-add command on one
console and observe a MGMT_EV_ADV_MONITOR_ADDED event on the other
Signed-off-by: Miao-chen Chou
---
Changes in v5: None
-chen Chou
---
Changes in v5: None
Changes in v4: None
Changes in v3:
- Update the opcode in the mgmt table.
Changes in v2:
- Convert the values from little-endian to CPU order.
- Fix comment style and improve readability.
include/net/bluetooth/hci_core.h | 24 ++
net/bluetooth
LE peripheral paired, repeat (2) and observe the passive
scanning continues.
(5) with a ADV monitor, suspend/resume the host and observe the passive
scanning continues.
Signed-off-by: Miao-chen Chou
---
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
include/net
advmon-add with valid and invalid inputs.
- Issue btmgmt advmon-add more the allowed number of monitors.
Signed-off-by: Miao-chen Chou
---
Changes in v5: None
Changes in v4: None
Changes in v3:
- Update the opcode in the mgmt table.
- Convert the endianness of the returned handle.
Changes in v2
-off-by: Miao-chen Chou
---
Changes in v5: None
Changes in v4: None
Changes in v3:
- Update command/event opcodes.
- Correct data types.
Changes in v2: None
include/net/bluetooth/mgmt.h | 49
1 file changed, 49 insertions(+)
diff --git a/include/net
This notifies management sockets on MGMT_EV_ADV_MONITOR_REMOVED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-remove command on one
console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other.
Signed-off-by: Miao-chen Chou
---
Changes in
Hi Jakub,
I uploaded v4 to address these. Thanks for the reminder.
Regards,
Miao
On Fri, Jun 12, 2020 at 10:49 AM Jakub Kicinski wrote:
>
> On Thu, 11 Jun 2020 23:15:26 -0700 Miao-chen Chou wrote:
> > This adds the request handler of MGMT_OP_REMOVE_ADV_MONITOR command.
>
LE peripheral paired, repeat (2) and observe the passive
scanning continues.
(5) with a ADV monitor, suspend/resume the host and observe the passive
scanning continues.
Signed-off-by: Miao-chen Chou
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
include/net/bluetooth
This notifies management sockets on MGMT_EV_ADV_MONITOR_REMOVED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-remove command on one
console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other.
Signed-off-by: Miao-chen Chou
---
Changes in
with valid and invalid handles.
Signed-off-by: Miao-chen Chou
---
Changes in v4:
- Fix warnings.
Changes in v3:
- Update the opcode in the mgmt table.
- Convert the endianness of the returned handle.
Changes in v2: None
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c
-chen Chou
---
Changes in v4: None
Changes in v3:
- Update the opcode in the mgmt table.
Changes in v2:
- Convert the values from little-endian to CPU order.
- Fix comment style and improve readability.
include/net/bluetooth/hci_core.h | 24 ++
net/bluetooth/hci_core.c | 10
advmon-add with valid and invalid inputs.
- Issue btmgmt advmon-add more the allowed number of monitors.
Signed-off-by: Miao-chen Chou
---
Changes in v4: None
Changes in v3:
- Update the opcode in the mgmt table.
- Convert the endianness of the returned handle.
Changes in v2: None
include/net
-off-by: Miao-chen Chou
---
Changes in v4: None
Changes in v3:
- Update command/event opcodes.
- Correct data types.
Changes in v2: None
include/net/bluetooth/mgmt.h | 49
1 file changed, 49 insertions(+)
diff --git a/include/net/bluetooth/mgmt.h b/include
This notifies management sockets on MGMT_EV_ADV_MONITOR_ADDED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-add command on one
console and observe a MGMT_EV_ADV_MONITOR_ADDED event on the other
Signed-off-by: Miao-chen Chou
---
Changes in v4: None
Hi Marcel,
The name in the mgmt-api.txt doc is "Add Advertisement Patterns
Monitor Command", and Luiz changed the name from
MGMT_OP_ADD_ADV_PATTERNS_MONITOR to MGMT_OP_ADD_ADV_MONITOR before
applied. So we either change the doc or change the header file to
match. Based on the outcome I may need to
> > - Advertisement Monitor Added event
> > - Advertisement Monitor Removed event
> >
> > Signed-off-by: Miao-chen Chou
> > ---
> >
> > Changes in v2: None
> >
> > include/net/bluetooth/mgmt.h | 49
> > 1
advmon-add with valid and invalid inputs.
- Issue btmgmt advmon-add more the allowed number of monitors.
Signed-off-by: Miao-chen Chou
---
Changes in v3:
- Update the opcode in the mgmt table.
- Convert the endianness of the returned handle.
Changes in v2: None
include/net/bluetooth
-off-by: Miao-chen Chou
---
Changes in v3:
- Update command/event opcodes.
- Correct data types.
Changes in v2: None
include/net/bluetooth/mgmt.h | 49
1 file changed, 49 insertions(+)
diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
with valid and invalid handles.
Signed-off-by: Miao-chen Chou
---
Changes in v3:
- Update the opcode in the mgmt table.
- Convert the endianness of the returned handle.
Changes in v2: None
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c | 31
This notifies management sockets on MGMT_EV_ADV_MONITOR_ADDED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-add command on one
console and observe a MGMT_EV_ADV_MONITOR_ADDED event on the other
Signed-off-by: Miao-chen Chou
---
Changes in v3
LE peripheral paired, repeat (2) and observe the passive
scanning continues.
(5) with a ADV monitor, suspend/resume the host and observe the passive
scanning continues.
Signed-off-by: Miao-chen Chou
---
Changes in v3: None
Changes in v2: None
include/net/bluetooth/hci_core.h | 1 +
net
This notifies management sockets on MGMT_EV_ADV_MONITOR_REMOVED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-remove command on one
console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other.
Signed-off-by: Miao-chen Chou
---
Changes in
-chen Chou
---
Changes in v3:
- Update the opcode in the mgmt table.
Changes in v2:
- Convert the values from little-endian to CPU order.
- Fix comment style and improve readability.
include/net/bluetooth/hci_core.h | 24 ++
net/bluetooth/hci_core.c | 10 +-
net/bluetooth
r-based monitoring is not yet in place, this
> > report only the supported features but not the enabled features.
> >
> > The following test was performed.
> > - Issuing btmgmt advmon-features.
> >
> > Signed-off-by: Miao-chen Chou
> > ---
> >
> >
This notifies management sockets on MGMT_EV_ADV_MONITOR_REMOVED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-remove command on one
console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other.
Signed-off-by: Miao-chen Chou
---
Changes in
-off-by: Miao-chen Chou
---
Changes in v2: None
include/net/bluetooth/mgmt.h | 49
1 file changed, 49 insertions(+)
diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index 16e0d87bd8fae..df36c50d15f53 100644
--- a/include/net/bluetooth
-chen Chou
---
Changes in v2:
- Convert the values from little-endian to CPU order.
- Fix comment style and improve readability.
include/net/bluetooth/hci_core.h | 24
net/bluetooth/hci_core.c | 10 ++-
net/bluetooth/mgmt.c | 48
This notifies management sockets on MGMT_EV_ADV_MONITOR_ADDED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-add command on one
console and observe a MGMT_EV_ADV_MONITOR_ADDED event on the other
Signed-off-by: Miao-chen Chou
---
Changes in v2: None
with valid and invalid handles.
Signed-off-by: Miao-chen Chou
---
Changes in v2: None
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c | 31 +++
net/bluetooth/mgmt.c | 32
3 files changed, 64
advmon-add with valid and invalid inputs.
- Issue btmgmt advmon-add more the allowed number of monitors.
Signed-off-by: Miao-chen Chou
---
Changes in v2: None
include/net/bluetooth/hci_core.h | 2 +
net/bluetooth/hci_core.c | 40 +
net/bluetooth/mgmt.c | 100
LE peripheral paired, repeat (2) and observe the passive
scanning continues.
(5) with a ADV monitor, suspend/resume the host and observe the passive
scanning continues.
Signed-off-by: Miao-chen Chou
---
Changes in v2: None
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c
advmon-add with valid and invalid inputs.
- Issue btmgmt advmon-add more the allowed number of monitors.
Signed-off-by: Miao-chen Chou
---
include/net/bluetooth/hci_core.h | 2 +
net/bluetooth/hci_core.c | 40 +
net/bluetooth/mgmt.c | 100
-chen Chou
---
include/net/bluetooth/hci_core.h | 24 +
net/bluetooth/hci_core.c | 10 ++-
net/bluetooth/mgmt.c | 46
net/bluetooth/msft.c | 7 +
net/bluetooth/msft.h | 9 +++
5 files changed
with valid and invalid handles.
Signed-off-by: Miao-chen Chou
---
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c | 31 +++
net/bluetooth/mgmt.c | 32
3 files changed, 64 insertions(+)
diff --git
This notifies management sockets on MGMT_EV_ADV_MONITOR_ADDED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-add command on one
console and observe a MGMT_EV_ADV_MONITOR_ADDED event on the other
Signed-off-by: Miao-chen Chou
---
net/bluetooth
-off-by: Miao-chen Chou
---
include/net/bluetooth/mgmt.h | 49
1 file changed, 49 insertions(+)
diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index 16e0d87bd8fae..df36c50d15f53 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include
This notifies management sockets on MGMT_EV_ADV_MONITOR_REMOVED event.
The following test was performed.
- Start two btmgmt consoles, issue a btmgmt advmon-remove command on one
console and observe a MGMT_EV_ADV_MONITOR_REMOVED event on the other.
Signed-off-by: Miao-chen Chou
---
net
LE peripheral paired, repeat (2) and observe the passive
scanning continues.
(5) with a ADV monitor, suspend/resume the host and observe the passive
scanning continues.
Signed-off-by: Miao-chen Chou
---
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c | 13
51 matches
Mail list logo
