On Fri, 3 Jun 2016 14:32:46 -0700
Guenter Roeck wrote:
> gcc-6 reports the following error with -Werror=unused-const-variable.
>
> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> 'b43_phyops_a' defined but not used
>
> Turns out a lot of code in this file is unused, so let's r
On Fri, 3 Jun 2016 21:11:51 -0700
Guenter Roeck wrote:
> +static void __b43_phy_initg(struct b43_wldev *dev)
> +{
> + struct b43_phy *phy = &dev->phy;
> +
> + might_sleep();
> +
> + if (phy->rev >= 6) {
> + if (b43_phy_read(dev, B43_PHY_ENCORE) & B43_PHY_ENCORE_EN)
> +
On Thu, 16 Jun 2016 15:23:37 + (UTC)
Kalle Valo wrote:
> Guenter Roeck wrote:
> > gcc-6 reports the following error with -Werror=unused-const-variable.
> >
> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> > 'b43_phyops_a' defined bu
On Thu, 18 Feb 2016 18:04:36 +0530
Sudip Mukherjee wrote:
> From: Sudip Mukherjee
>
> On error we jumped to the label bcma_out and returned the error code but
> we missed freeing dev.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/net/wireless/broadcom/b43/main.c | 1 +
> 1 file changed,
On Fri, 19 Feb 2016 20:37:18 +0530
Sudip Mukherjee wrote:
> > https://patchwork.kernel.org/patch/8049041/
>
> I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311
> [14e4:4311] (rev 01)".
> I will try to test it on this weekend.
Any news on this one?
--
Michael
pgpLl72Z3
On Mon, 25 Apr 2016 09:40:51 +0200
Lucas Stach wrote:
> On my system the SPROM correctly defines the only wired LED (radio) but
> skips all others, leading to the hardcode to register LEDs with RX and TX
> triggers.
Hm ok. It probably is a good idea to change the condition from
if (sprom[led_in
On Mon, 25 Apr 2016 20:21:36 +0200
Lucas Stach wrote:
> > Numbers please. Did you measure that is actually causes more
> > _wakeups_?
> > How many?
> > The led work is placed in the mac80211 workqueue and LED updates only
> > happen on behalf of mac80211 activities (by default). It only causes
>
On Thu, 16 Jun 2016 18:56:14 +0300
Kalle Valo wrote:
> Michael Büsch writes:
>
> > On Thu, 16 Jun 2016 15:23:37 + (UTC)
> > Kalle Valo wrote:
> >
> >> Guenter Roeck wrote:
> >> > gcc-6 reports the following error with -Werror=unused-const-
On Sun, 18 Oct 2015 00:01:37 +0100
Paul McQuade wrote:
> Moved around pointer to avoid ERROR
>
> Signed-off-by: Paul McQuade
> ---
> drivers/net/wireless/b43/dma.h | 14 +++---
> drivers/net/wireless/b43/main.c | 6 +++---
> drivers/net/wireless/b43/main.h | 2 +-
> drivers/net/wire
On Mon, 19 Oct 2015 17:02:22 +0100
Paul McQuade wrote:
> Fixed Pointer Coding Style
>
> Signed-off-by: Paul McQuade
> ---
> drivers/net/wireless/b43/main.c | 6 +++---
> drivers/net/wireless/b43/main.h | 2 +-
> drivers/net/wireless/b43/xmit.h | 2 +-
> 3 files changed, 5 insertions(+), 5 dele
On Mon, 19 Oct 2015 17:02:23 +0100
Paul McQuade wrote:
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index 058a9f2..086f0ba 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -2502,7 +2502,7 @@ static int lpp
On Tue, 03 Nov 2015 16:05:51 +0100
Arnd Bergmann wrote:
> The SoC variant of the ssb code is now optional like the other
> ones, which means we can build the framwork without any
> front-end, but that results in a warning:
>
> drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but no
On Tue, 03 Nov 2015 17:42:26 +0100
Arnd Bergmann wrote:
> On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote:
> > On Tue, 03 Nov 2015 16:05:51 +0100
> > Arnd Bergmann wrote:
> >
> > > The SoC variant of the ssb code is now optional like the other
> &
On Fri, 19 Jun 2015 14:23:45 +0530
Maninder Singh wrote:
> This patch removes unnecessary label "out" and
> some restructring for using device_create_file directly.
>
> Signed-off-by: Maninder Singh
> Reviewed-by: Rohit Thapliyal
> ---
> drivers/ssb/pci.c |8 +---
> 1 files changed, 1
On Sun, 7 Jun 2015 01:52:51 +0200
Hauke Mehrtens wrote:
> Dan Carpenter reported missing brackets which resulted in reading a
> wrong crystalfreq value. I also noticed that the result of this
> function is ignored.
>
> Reported-By: Dan Carpenter
> Signed-off-by: Hauke Mehrtens
> ---
> driver
On Tue, 10 Apr 2018 21:54:19 +0800
Jia-Ju Bai wrote:
> dma_tx_fragment() is never called in atomic context.
>
> dma_tx_fragment() is only called by b43legacy_dma_tx(), which is
> only called by b43legacy_tx_work().
> b43legacy_tx_work() is only set a parameter of INIT_WORK() in
> b43legacy_wir
On Fri, 02 Jun 2017 09:18:14 +0800
Jia-Ju Bai wrote:
> On 06/02/2017 12:11 AM, Jonathan Corbet wrote:
> > On Thu, 01 Jun 2017 09:05:07 +0800
> > Jia-Ju Bai wrote:
> >
> >> I admit my patches are not well tested, and they may not well fix the bugs.
> >> I am looking forward to opinions and sugg
On Tue, 5 Sep 2017 19:15:50 +0100
Colin King wrote:
> From: Colin Ian King
>
> The u8 char array ret is not being initialized and elements outside
> the range start to end contain just garbage values from the stack.
> This results in a later scan of the array to read potentially
> uninitialize
On Tue, 5 Sep 2017 19:16:58 +0100
Colin King wrote:
> From: Colin Ian King
>
> The u8 char array ret is not being initialized and elements outside
> the range start to end contain just garbage values from the stack.
> This results in a later scan of the array to read potentially
> uninitialize
On Thu, 01 Jun 2017 07:27:20 +0300
Kalle Valo wrote:
> Michael Büsch writes:
>
> >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c
> >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c
> >> > @@ -2859,7 +2859,9 @@ static
On Wed, 31 May 2017 19:07:15 -0500
Larry Finger wrote:
> On 05/31/2017 10:32 AM, Michael Büsch wrote:
> > On Wed, 31 May 2017 13:26:43 +0300
> > Kalle Valo wrote:
> >
> >> Jia-Ju Bai writes:
> >>
> >>> The driver may sle
On Wed, 31 May 2017 13:26:43 +0300
Kalle Valo wrote:
> Jia-Ju Bai writes:
>
> > The driver may sleep under a spin lock, and the function call path is:
> > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave)
> > b43legacy_synchronize_irq
> > synchronize_irq --> may sleep
On Wed, 31 May 2017 18:29:07 +0800
Jia-Ju Bai wrote:
> The driver may sleep under a spin lock, and the function call path is:
> b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave)
> b43legacy_radio_set_interference_mitigation
> b43legacy_radio_interference_mitigation_dis
23 matches
Mail list logo
