incoming VLAN tags when ASF is
enabled. ASF firmware will not parse packets correctly if VLAN tags
are not stripped.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Signed-off-by: David S. Miller [EMAIL PROTECTED]
GIT: e29054f92d7d575631691865c1b95bee5bc974cc
and
[EMAIL
-by: Michael Chan [EMAIL PROTECTED]
You should set both MII and TP, since these copper interfaces
have a MII based twisted-pair physical layer.
MII in this ethtool context means an MII connector on the card
that can connect to an external transceiver, right?
Or does it mean internal MII interface
David Miller wrote:
I'm not so sure about this.
Perhaps, instead, you should do a pci_msi_disable() and
pci_msi_enable() in the error detection and recovery sequence.
If we just detected PCI errors on this slot, I don't think it's
a good idea to continue writing to the config space to
On Fri, 2007-10-19 at 19:04 -0500, [EMAIL PROTECTED] wrote:
I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see
that happening. viz. read_msi_msg() is not called anywhere, and I need
to have valid msg-address_lo and msg-address_hi and msg-data
in order to be able to restore.
[EMAIL PROTECTED]
Signed-off-by: Matt Carlson [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Davem,
This patch is generically needed for recovery from PCI errors,
and not just the tg3 that Matt is working on.
Matt, there are also several msi-related bugs in the pseries
[PATCH 1/3][BNX2]: Update 5709 firmware to 3.7.1.
[PATCH 2/3][BNX2]: Fix Serdes WoL bug.
[PATCH 3/3][BNX2]: Update version to 1.6.8.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
[BNX2]: Fix Serdes WoL bug.
The bug is in the code in bnx2_set_power_state() that assumes copper
devices when setting up WoL. This is no longer true after adding WoL
support for Serdes devices.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
[BNX2]: Update version to 1.6.8.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 2a79ffc..db79602 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -56,8 +56,8 @@
#define DRV_MODULE_NAMEbnx2
#define PFX
On Thu, 2007-10-11 at 19:40 -0700, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Thu, 11 Oct 2007 20:17:16 -0700
+ if (likely(!tg3_has_work(tp))) {
+ struct tg3_hw_status *sblk = tp-hw_status;
+
-- new status block DMA
[TG3]: Fix performance regression on 5705.
A performance regression was introduced by the following commit:
commit ee6a99b539a50b4e9398938a0a6d37f8bf911550
Author: Michael Chan [EMAIL PROTECTED]
Date: Wed Jul 18 21:49:10 2007 -0700
[TG3]: Fix msi issue with kexec/kdump
On Fri, 2007-10-12 at 11:38 -0500, [EMAIL PROTECTED] wrote:
Hi,
On Thu, Aug 02, 2007 at 05:13:39PM -0700, Michael Chan wrote:
On Thu, 2007-08-02 at 18:12 -0500, [EMAIL PROTECTED] wrote:
On Thu, Jul 26, 2007 at 06:12:00PM -0700, Michael Chan wrote:
On Thu, 2007-07-26 at 17:57 -0500
On Thu, 2007-10-11 at 18:14 -0700, David Miller wrote:
+ while (1) {
+ work_done = tg3_poll_work(tp, work_done, budget);
+
+ if (unlikely(tp-tg3_flags TG3_FLAG_TX_RECOVERY_PENDING))
+ goto tx_recovery;
+
+ if
loopback is simply skipped when remote PHY is
present.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 0e4928c..21493e0 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -3776,12 +3776,6 @@ bnx2_init_remote_phy(struct bnx2 *bp
[BNX2]: Fix default WoL setting.
Change the default WoL setting to match the NVRAM's setting. It
always defaulted to WoL disabled before and caused a lot of confusion
for users.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 21493e0
[BNX2]: Update version to 1.6.7.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 574d043..bbfbdaf 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -56,8 +56,8 @@
#define DRV_MODULE_NAMEbnx2
#define PFX
On Mon, 2007-10-08 at 08:18 +0100, Christoph Hellwig wrote:
Just curious: is there a diagram somewhere that shows the relation of
the various tg3 chips to each other and what families exist?
Some high level descriptions of some of the chips can be found here:
On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote:
On Mon, 08 Oct 2007 20:34:41 +0200
Eliezer [EMAIL PROTECTED] wrote:
* The MACRO's for 64 bit stats look like they could be done with
u64 and/or turned into inline's.
The MACRO's modify some of their arguments, plus they
NetArt - Grzegorz Nosek wrote:
I have encountered an error which looks tg3-related. Upon adding some
htb queue rules (which I don't have handy ATM but can provide if
needed), after some time we get such messages in the kernel log:
Please provide the HTB queue rules and the type of traffic
-off-by: Matt Carlson [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index d4ac6e9..4f9fbe2 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -4865,9 +4865,15 @@ static void tg3_restore_pci_state(struct tg3 *tp
is to put the chip into lower
power states when the operating conditions allow it.
Signed-off-by: Matt Carlson [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 4f9fbe2..482b7df 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
[TG3]: Add 5784 and 5764 support.
This patch adds the support for 5784 and 5764 devices.
Signed-off-by: Matt Carlson [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 482b7df..2378ea3 100644
--- a/drivers/net/tg3.c
+++ b
[TG3]: Update version to 3.82.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 2378ea3..b1e5660 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -64,8 +64,8 @@
#define DRV_MODULE_NAMEtg3
#define PFX
[EMAIL PROTECTED]
We also noticed this issue recently, but didn't pay too much attention
to it since it was more of a cosmetic issue. The driver behaves the
same since we rely on cmd-autoneg to decide whether to enable autoneg
or not. Your fix seems reasonable to me. Thanks.
Acked-by: Michael
On Tue, 2007-10-02 at 08:37 -0400, jamal wrote:
The simplest solution seems to me to modify the definition of
TG3_SKB_CB
as i did for e1000 from:
(struct tg3_tx_cbdata *)((__skb)-cb[0])
to:
(struct tg3_tx_cbdata *)((__skb)-cb[8])
that way the vlan tags are always present and no need to
[BNX2]: Add missing napi_disable() in bnx2_close().
bnx2_close() - bnx2_netif_stop() will not call napi_disable() because
the netif_state is not running in bnx2_close(). To avoid confusion,
we change it to disable interrupt and napi directly in bnx2_close().
Signed-off-by: Michael Chan [EMAIL
eliminate the BSS and SBSS firmware sections in bnx2_fw*.h since
these are always zeros.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 4887c31..c50e4c8 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2810,21 +2810,16 @@ load_cpu_fw
[BNX2]: Update version to 1.6.6.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index c50e4c8..db14f35 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -56,8 +56,8 @@
#define DRV_MODULE_NAMEbnx2
#define PFX
On Sun, 2007-09-30 at 14:11 -0400, jamal wrote:
Here are some non-batching related changes that i have in my batching
tree. Like the e1000e, they make the xmit code more readable.
I wouldnt mind if you take them over.
Jamal, in tg3_enqueue_buggy(), we may have to call tg3_tso_bug() which
already reviewed the earlier versions of the patch and have made
some suggestions. This latest one looks ok to me and tested ok.
I'll follow up later with another patch to remove all the zeros in other
firmware sections, and to remove the gzip headers completely.
Acked-by: Michael Chan [EMAIL
[BNX2]: Add PHY workaround for 5709 A1.
Add the DIS_EARLY_DAC PHY workaround for 5709 A1. Without it, link
sometimes does not come up.
Update version to 1.6.5.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 854d80c..66eed22 100644
On Thu, 2007-09-20 at 15:49 +0100, Denys Vlasenko wrote:
Please test these two patches.
I updated them according to your comments.
I've only tested patch #1. It worked after some minor modifications
below.
plain text
document
attachment
(linux-2.6.23-
rc6.bnx2-1.patch)
On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote:
+ /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename)
+* is stripped, 32-bit unpacked size (LE) is prepended instead */
+ sz = *zbuf++;
+ sz = (sz 8) + *zbuf++;
+ sz = (sz 8) + *zbuf++;
+
On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote:
Are you saying that you successfully run-tested it?
I've only reviewed the code. Let's resolve these issues first before
testing the code.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to
On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote:
Hi Michael,
In bnx2_fw.h I see the following:
static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 };
static struct fw_info bnx2_rxp_fw_06 = {
...
.bss= bnx2_RXP_b06FwBss,
...
};
I grepped
On Tue, 2007-09-18 at 18:55 +0100, Denys Vlasenko wrote:
On Tuesday 18 September 2007 19:45, Michael Chan wrote:
We can compress all the different sections of the firmware. Currently,
we only compress the biggest chunks and the rest are uncompressed.
These zeros should compress to almost
On Tue, 2007-09-18 at 23:37 +0200, Willy Tarreau wrote:
Michael, doesn't a functional-yet-suboptimal firmware exist ? I mean,
just the same principle as we all have kernels, boot CDs, statically
built tools, etc... which run everywhere. If you have such a beast,
maybe it would be a
On Fri, 2007-09-14 at 10:14 +0200, Ingo Oeser wrote:
Michael Chan schrieb:
On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote:
Erm, Wouldn't it be possible to print a warning when the driver loads,
saying that the firmware is outdated ?
It's possible, but would require
On Fri, 2007-09-14 at 09:18 -0700, Roland Dreier wrote:
However, do you have any plans to support iSCSI offload for targets?
Also, looking at the first CNIC patch, I can't help but notice that
you seem to have at least some support for iWARP there. How does the
CNIC look? Does it share the
Lucas Nussbaum wrote:
This used to work, and broke between 2.6.16 and 2.6.17. Using
git bissect,
I could trace this back to that commit:
commit bc1c756741b065cfebf850e4164c0e2aae9d527f
Author: Michael Chan [EMAIL PROTECTED]
Date: Mon Mar 20 17:48:03 2006 -0800
[TG3]: Support
On Thu, 2007-09-13 at 17:41 +0200, Lucas Nussbaum wrote:
# ethtool -i eth0
driver: tg3
version: 3.65
firmware-version: 5703-v2.21a
bus-info: :02:02.0
The firmware is quite old and needs to be upgraded to fix the problem.
I'll have someone contact you to get it upgraded.
What do you
On Thu, 2007-09-13 at 21:28 +0200, Lucas Nussbaum wrote:
Erm, Wouldn't it be possible to print a warning when the driver loads,
saying that the firmware is outdated ?
It's possible, but would require the driver to parse the version string.
The driver currently reports the version string for
On Thu, 2007-09-13 at 14:11 -0700, Roland Dreier wrote:
I've been meaning to track down the bnx2 iscsi offload patch to look
and see if this issue is addressed, since the same problem seems to
exist: it seems an iscsi connection and a main stack tcp connection
might share the same 4-tuple
Christoph Hellwig wrote:
Most of it should just go away, and the other bits shouldn't
change over
the lifetime of the driver except for additions. So there
really isn't
any point in auto-generating it.
Yes, I agree with Mike Christie on this. These values in
question are defined in
On Thu, 2007-09-06 at 12:50 -0700, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Thu, 06 Sep 2007 12:05:30 -0700
The HT1000 bridge may very well have an MSI issue. I'm checking with
ServerWorks and I will do some testing to confirm. If confirmed, we can
disable MSI
Andy Gospodarek wrote:
This patch was designed to address tg3 and bnx2 messages printed on
systems with HT1000 chips IIRC. Are we going back to those
messages on
bnx2 or is there a workaround in that driver needed too?
Andy, I've checked all the Broadcom chips including bnx2 chips, only
On Thu, 2007-09-06 at 11:41 -0400, Andy Gospodarek wrote:
On Thu, Sep 06, 2007 at 07:34:23AM -0700, David Miller wrote:
From: Andy Gospodarek [EMAIL PROTECTED]
Date: Thu, 6 Sep 2007 09:45:16 -0400
Is is really necessary to get rid of the HT1000 patch?
Yes, absolutely and without a
to workaround the
problem by disabling MSI on ServerWorks HT1000 bridge chips commonly
found with the 5714.
We workaround this chip bug by enabling INTX after we enable MSI and
after we resume from suspend.
Update version to 3.81.
This problem was discovered by David Miller.
Signed-off-by: Michael
open-iscsi driver to support iSCSI offload on bnx2 devices.
Signed-off-by: Anil Veerabhadrappa [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
---
drivers/net/Kconfig | 10 +
drivers/net/Makefile |1 +
drivers/net/bnx2.c
PROTECTED]
Acked-by: Michael Chan [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2007-08-28 at 22:10 +0100, Christoph Hellwig wrote:
On Tue, Aug 28, 2007 at 02:05:30PM -0700, Arjan van de Ven wrote:
bnx2.c (incorrectly) sets current-state directly to
TASK_UNINTERRUPTIBLE, without going through set_task_state(). However
all the code wants to do is an msleep so
On Tue, 2007-08-28 at 19:07 -0300, Arnaldo Carvalho de Melo wrote:
Em Tue, Aug 28, 2007 at 10:39:26PM +0100, Christoph Hellwig escreveu:
On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 28 Aug 2007 15:21:30 -0700
On Tue, 2007-08-28 at 17:25 -0700, David Miller wrote:
The new NAPI struct patch is in there, one caveat of the new
behavior is that in drivers that conditionalize NAPI support
we can't be lazy and do the napi_{enable,disable}() outside
of the ifdefs any longer. I tried to audit all the
David Miller wrote:
4) NETPOLL put hopefully into a working state.
It's no longer necessary to change the tx locking scheme
in bnx2.c and tg3.c, right? May be you forgot to revert
the tx locking changes you did in V4?
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
Jeff Garzik wrote:
Michael Chan wrote:
[BNX2]: Add iSCSI support to BNX2 devices.
Modify bnx2 and add a cnic driver to support some offload functions
needed by iSCSI.
Add a new open-iscsi driver to support iSCSI offload on
bnx2 devices.
Signed-off-by: Anil Veerabhadrappa
fix this by always saving and restoring the PCI state in
bnx2_suspend() and bnx2_resume() regardless of netif_running() state.
Update version to 1.6.4.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index d53dfc5..24e7f9a 100644
--- a/drivers
[BNX2]: Add iSCSI support to BNX2 devices.
Modify bnx2 and add a cnic driver to support some offload functions
needed by iSCSI.
Add a new open-iscsi driver to support iSCSI offload on bnx2 devices.
Signed-off-by: Anil Veerabhadrappa [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED
the PCI state in
tg3_suspend() and tg3_resume() regardless of netif_running() state.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index dc41c05..5874042 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -64,8 +64,8 @@
#define
On Thu, 2007-08-02 at 00:06 +0200, Michael Buesch wrote:
+static inline u32 bnx2x_tx_avail(struct bnx2x_fastpath *fp)
Too big for inlining.
+{
+ u16 used;
+ u32 prod = fp-tx_bd_prod;
+ u32 cons = fp-tx_bd_cons;
+
+ smp_mb();
This barrier needs a comment. Why is
On Thu, 2007-08-02 at 15:06 -0700, David Miller wrote:
From: Michael Chan [EMAIL PROTECTED]
Date: Thu, 02 Aug 2007 12:10:29 -0700
Alternatively, we can also fix it by calling pci_enable_device() again
in tg3_open(). But I think it is better to just always save and restore
in suspend
On Tue, 2007-07-31 at 17:45 -0700, Andrew Morton wrote:
On Tue, 31 Jul 2007 11:28:32 +0200 Joachim Deguara
[EMAIL PROTECTED] wrote:
On my Acer Ferrari 1000 the tg3 ethernet no longer is available
after a
suspend to ram with the latet 2.6.23-rc1-git9.
It seems to work for me on the same
On Wed, 2007-08-01 at 10:01 +0200, Joachim Deguara wrote:
Here are the lspci outputs for the tg3
You have 2 Broadcom devices in your system. 07:00.0 is a wireless
device, I think. 8:4.0 is the tg3 device.
It's clear that the tg3 device is still in D3 state after resume and
that explains why
On Wed, 2007-08-01 at 10:47 -0700, Michael Chan wrote:
You have 2 Broadcom devices in your system. 07:00.0 is a wireless
device, I think. 8:4.0 is the tg3 device.
It's clear that the tg3 device is still in D3 state after resume and
that explains why all register accesses fail. tg3_resume
On Thu, 2007-07-26 at 00:15 -0700, David Miller wrote:
The netpoll code has to take that anyways in order to call
into -hard_start_xmit() to send out the packet it has
pending, I'm leveraging that as a synchronization mechanism
in the drivers because the locking options are limited
given
David Miller wrote:
/* run TX completion thread */
if (sblk-idx[0].tx_consumer != tp-tx_cons) {
- tg3_tx(tp);
+ netif_tx_lock(netdev);
+ __tg3_tx(tp);
+ netif_tx_unlock(netdev);
This will lead to more and longer lock contentions
David Miller wrote:
So that -poll_controller() can process TX acks by just having
the TX lock and interrupts disabled.
Can you think of another way to process TX acks from absolutely
any execution context whatsoever? That's what we need and
preferably in some generic way, and the above is
David Miller wrote:
As a result there is no more messing around with fake NAPI polls and
all that other crap, instead -poll_controller() merely has to try to
process TX queue acks to free up space and wake up the transmit
queue(s) of the device.
I think we also need to take care of link
On Sun, 2007-07-22 at 13:43 +0200, patric wrote:
patric wrote:
Hi,
Think i got something working for me at least, and the fix is quite
minimal and only downside that i could see from it was that you might
get a small delay when bringing up the interface, but that's probably
On Fri, 2007-07-20 at 18:59 +0200, patric wrote:
Thanks... That's a confirmation on what i suspected.. I think i'll dig
into the code instead and try to figure out some way of making it work a
bit better for my setup atleast...
I'll post a patch later if i get something working... Btw, do
On Thu, 2007-07-19 at 15:24 +0200, patric wrote:
Just a hypothetical question. If the 2 network cards starts the
autonegotiation would it be possible that they get into a loop where
they are chasing each others state? Maybe a fix could be to add a sleep
of a random length that would
is to
have our own functions save and restore precisely what we need. We
also change it to save and restore state inside tg3_chip_reset() in a
more straight forward way.
Thanks to Tina for helping to test and debug the problem.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers
flash
only requires the buffered operation bit to be set.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index d23861c..311c859 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -126,91 +126,102 @@ static struct pci_device_id bnx2_pci_tbl
[BNX2]: Add delay before reading firmware version.
The management firmware may still be loading during bnx2_init_one()
because of the D3hot - D0 transition and the firmware version may
not be available without waiting a bit.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net
[BNX2]: Use constants for stats ticks.
Change all stats related magic numbers to constants.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 28399d8..2dd002b 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -4123,7 +4123,7
[BNX2]: Update version to 1.6.3.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 2dd002b..a729da0 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -54,8 +54,8 @@
#define DRV_MODULE_NAMEbnx2
#define PFX
[NET]: Add ethtool support for NETIF_F_IPV6_CSUM devices.
Add ethtool utility function to set or clear IPV6_CSUM feature flag.
Modify tg3.c and bnx2.c to use this function when doing ethtool -K
to change tx checksum.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c
to call tg3_netif_start() (which clears the
irq_sync flag) before releasing the tp-lock.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 3a43426..314f5cf 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -3512,9 +3512,9 @@ static inline
it is defined, namely devices before the 5705. This patch
also corrects the link polarity configurations for 5700 devices when
paired against a bcm5411 phy.
Signed-off-by: Matt Carlson [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index
[TG3]: Enable auto MDI.
This patch adds automatic MDI crossover support when autonegotiation is
turned off. Automatic MDI crossover allows link to be established
without the use of a crossover cable.
Signed-off-by: Matt Carlson [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED
[TG3]: Add missing NVRAM strapping.
This patch adds a missing NVRAM strapping for 5755 devices.
Signed-off-by: Matt Carlson [EMAIL PROTECTED]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 4f59e5c..0d40f9d 100644
--- a/drivers/net/tg3.c
[TG3]: Update version to 3.78.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 0d40f9d..3245f16 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -64,8 +64,8 @@
#define DRV_MODULE_NAMEtg3
#define PFX
[BNX2]: Add bnx2_set_default_link().
Put existing code to setup the default link settings in this new
function. This makes it easier to support the remote PHY feature in
the next few patches.
Also change ETHTOOL_ALL_FIBRE_SPEED to include 2500Mbps if supported.
Signed-off-by: Michael Chan
[BNX2]: Add remote PHY bit definitions.
Add new fields in struct bnx2 and other bit definitions in shared
memory to support remote PHY.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.h b/drivers/net/bnx2.h
index 49a5de2..14c0a1e 100644
--- a/drivers/net/bnx2.h
+++ b
remote PHY is present, the 5708S Serdes device practically
becomes a copper device with full control over the 1000Base-T
link settings.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 56bc41e..3268d16 100644
--- a/drivers/net/bnx2.c
+++ b
remote PHY.
mii-tool operations are not supported on remote PHY and we will
return -EOPNOTSUPP.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 3268d16..514ad32 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -5363,17 +5363,25
[BNX2]: Modify link up message.
Modify the link up dmesg to report remote copper or Serdes link.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 514ad32..dc6dcf5 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -604,12 +604,21
-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index dc6dcf5..48f5151 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2547,6 +2547,7 @@ bnx2_interrupt(int irq, void *dev_instance)
{
struct net_device *dev = dev_instance;
struct bnx2
this patch last time and we decided that the -rt
kernel problem alone did not justify this patch. I think the
netpoll problem makes this patch necessary. ]
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 48f5151..3163868 100644
--- a/drivers
[BNX2]: Print management firmware version.
Add management firmware version for ethtool -i.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 3163868..a3ae3b0 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -5546,11 +5546,7
[BNX2]: Update version to 1.6.2.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index a3ae3b0..c590d8c 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -54,8 +54,8 @@
#define DRV_MODULE_NAMEbnx2
#define PFX
On Mon, 2007-07-02 at 14:20 -0700, Matt Carlson wrote:
Also, I think the count, max_per_txd, and nr_frags fields of the
tg3_tx_cbdata struct are not needed.
The count field is not needed also.
+struct tg3_tx_cbdata {
+ u32 base_flags;
+ int count;
+ unsigned int
Tim Mann wrote:
Hi, Michael. We have some IBM blades with a BCM5708-based dual-port
NIC that the bnx2 driver reports as not supporting wake-on-LAN.
(Ethtool says Supports Wake-on: d.) However, IBM says that WoL is
supported by these NICs, and in fact when I tried putting the blade
into
[BNX2]: Enable DMA on 5709.
Add missing code to enable DMA on 5709 A1. The bit is a no-op on
A0 and therefore can be set on all 5709 chips.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index daa62d9..c03282c 100644
--- a/drivers/net/bnx2.c
to initialize the 2nd
halves of all context memory.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 88b33c6..5d69e5b 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -1811,6 +1811,7 @@ bnx2_init_context(struct bnx2 *bp)
vcid = 96
[BNX2]: Update version and reldate.
Update to version 1.5.11.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 58e6f49..a9b833b 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -54,8 +54,8 @@
#define DRV_MODULE_NAME
for
ethtool -C statistics block.
Thanks to Jean-Daniel Pauget [EMAIL PROTECTED] and
CaT [EMAIL PROTECTED] for reporting this rare problem.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index c03282c..5654cc7 100644
--- a/drivers/net/bnx2.c
+++ b
[BNX2]: Add missing wait in bnx2_init_5709_context().
For correctness, we need to wait for the MEM_INIT bit to be cleared
in the BNX2_CTX_COMMAND register before proceeding.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 5d69e5b..daa62d9
[BNX2]: Add missing wait in bnx2_init_5709_context().
For correctness, we need to wait for the MEM_INIT bit to be cleared
in the BNX2_CTX_COMMAND register before proceeding.
[Added return -EBUSY when the MEM_INIT bit doesn't clear, suggested
by Jeff Garzik.]
Signed-off-by: Michael Chan [EMAIL
to use the more efficient
interrupt-driven link changes.
Update version to 3.77.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 923b9c7..a16954c 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -64,8 +64,8 @@
#define
On Wed, 2007-05-30 at 07:36 +1000, Herbert Xu wrote:
I just checked e1000 and it's correct as it does use the csum_offset
when doing TX offload. However, you're definitely right that bnx2
seems to be broken.
A few devices take a offset, starting point, and insertion point. This
looks
On Mon, 2 Apr 2007 11:43:19 +1000 CaT [EMAIL PROTECTED] wrote:
I take minute by minute snapshots of network traffic by sampling
/proc/net/dev and most of the time everything works fine. Occasionally
though I get petabyte byte traffic and corresponding packet traffic.
We were able to
901 - 1000 of 1356 matches
Mail list logo
