From: Andrea Parri (Microsoft) Sent: Thursday, April
15, 2021 3:59 AM
>
> Use blk_mq_unique_tag() to generate requestIDs for StorVSC, avoiding
> all issues with allocating enough entries in the VMbus requestor.
>
> Suggested-by: Michael Kelley
> Signed-off-by: Andre
_MAX_XFER_PAGE_RANGES? It used to be a
fixed 375, but now is NVSP_RSC_MAX, which is 562.
If that's the only change, then
Reviewed-by: Michael Kelley
>
> Signed-off-by: Andres Beltran
> Co-developed-by: Andrea Parri (Microsoft)
> Signed-off-by: Andrea Parri (Mic
thout
too much complexity.
See a few comments inline below.
>
> Suggested-by: Michael Kelley
> Signed-off-by: Andrea Parri (Microsoft)
> ---
> drivers/hv/channel.c | 14 +++---
> drivers/hv/ring_buffer.c | 12 ++---
> drivers/net/hyperv/netvsc.c
len);
> + if (hv_is_isolation_supported())
> + netdev_err(ndev, "Ignore VF_ASSOCIATION msg from the
> host supporting isolation\n");
> + else
> + netvsc_send_vf(ndev, nvmsg, msglen);
> break;
> }
> }
> --
> 2.25.1
Reviewed-by: Michael Kelley
From: Andrea Parri (Microsoft) Sent: Tuesday, January
26, 2021 3:57 AM
>
> Restrict the NVSP protocol version(s) that will be negotiated with the
> host to be NVSP_PROTOCOL_VERSION_61 or greater if the guest is running
> isolated. Moreover, do not advertise the SR-IOV capability and ignore
> NV
From: Sasha Levin Sent: Tuesday, December 22, 2020 6:22 PM
>
> From: "Andrea Parri (Microsoft)"
>
> [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ]
>
> Lack of validation could lead to out-of-bound reads and information
> leaks (cf. usage of nvdev->chan_table[]). Check that the n
hyperv_net.h | 3 ++
> drivers/net/hyperv/netvsc.c | 2 +
> drivers/net/hyperv/rndis_filter.c | 2 +
> drivers/scsi/storvsc_drv.c| 10
> include/linux/hyperv.h| 48 +++---
> net/vmw_vsock/hyperv_transport.c | 4 +-
> 11 files changed, 139 insertions(+), 25 deletions(-)
>
Reviewed-by: Michael Kelley
_err(ndev, "invalid number of allocated sub channel\n");
> + return -EINVAL;
> + }
> nvdev->num_chn = 1 +
> init_packet->msg.v5_msg.subchn_comp.num_subchannels;
>
> --
> 2.25.1
Reviewed-by: Michael Kelley
From: Andrea Parri (Microsoft) Sent: Monday, November
9, 2020 2:07 AM
>
> From: Andres Beltran
>
> Pointers to ring-buffer packets sent by Hyper-V are used within the
> guest VM. Hyper-V can send packets with erroneous values or modify
> packet fields after they are processed by the guest. To
ll be minus 4k (the size of header when
> PAGE_SIZE = 4k) than the original value to keep the ringbuffer total
> size unchanged when PAGE_SIZE = 4k.
>
> Signed-off-by: Boqun Feng
> Cc: Michael Kelley
>
> ---
> Michael,
>
> I drop your Reviewed-by tag because of
ll be minus 4k (the size of header when
> PAGE_SIZE = 4k) than the original value to keep the ringbuffer total
> size unchanged when PAGE_SIZE = 4k.
>
> Signed-off-by: Boqun Feng
> Cc: Jiri Kosina
> Cc: Michael Kelley
> ---
> Michael and Jiri,
>
> I change the code bec
ll be minus 4k (the size of header when
> PAGE_SIZE = 4k) than the original value to keep the ringbuffer total
> size unchanged when PAGE_SIZE = 4k.
>
> Signed-off-by: Boqun Feng
> Cc: Michael Kelley
> Cc: Dmitry Torokhov
> ---
> Michael and Dmitry,
>
> I change the cod
payload->range.offset = sgl[0].offset & ~HV_HYP_PAGE_MASK;
Another nit. The right hand side of the above assignment is already calculated
as
hvpg_offset.
Nits aside,
Reviewed-by: Michael Kelley
> + hvpgoff = sgl[0].offset >> HV_HYP_P
).
>
> So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when
> using vmbus_open() to establish the vmbus connection.
>
> Signed-off-by: Boqun Feng
> ---
> drivers/hv/hv_util.c | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
Reviewed-by: Michael Kelley
version (casting
> 2 * PAGE_SIZE into int to avoid compiler warnings), and it make no
> functional change. If the change is inappropriate, please let me know.
>
> drivers/hid/hid-hyperv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Michael Kelley
pping).
>
> So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when
> using vmbus_open() to establish the vmbus connection.
>
> Signed-off-by: Boqun Feng
> ---
> drivers/input/serio/hyperv-keyboard.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Michael Kelley
drivers/net/hyperv/netvsc.c | 2 +-
> drivers/net/hyperv/netvsc_drv.c | 46 +++
> drivers/net/hyperv/rndis_filter.c | 13 -
> 3 files changed, 30 insertions(+), 31 deletions(-)
>
Reviewed-by: Michael Kelley
upporting guest whose PAGE_SIZE is not 4k.
>
> Signed-off-by: Boqun Feng
> ---
> include/linux/hyperv.h | 5 +
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Michael Kelley
t; drivers/hv/channel.c | 13 -
> include/linux/hyperv.h | 15 +++
> 2 files changed, 15 insertions(+), 13 deletions(-)
>
Reviewed-by: Michael Kelley
sertions(+), 2 deletions(-)
>
Reviewed-by: Michael Kelley
everal general interfaces to
> describe the differences between normal buffer GPADL and ringbuffer
> GPADL.
>
> Signed-off-by: Boqun Feng
> ---
> drivers/hv/channel.c | 160 +++--
> include/linux/hyperv.h | 44 +++-
> 2 files changed, 183 insertions(+), 21 deletions(-)
>
Reviewed-by: Michael Kelley
s_open() in two patches to make it easy to review.
>
> Signed-off-by: Boqun Feng
> Reviewed-by: Wei Liu
> ---
> drivers/hv/channel.c | 309 ++-
> 1 file changed, 155 insertions(+), 154 deletions(-)
>
Reviewed-by: Michael Kelley
size guests. No functional changes on x86, since PAGE_SIZE is always 4k
> (equals to HV_HYP_PAGE_SIZE).
>
> Signed-off-by: Boqun Feng
> ---
> drivers/hv/channel.c | 13 +
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
Reviewed-by: Michael Kelley
From: Dexuan Cui Sent: Monday, September 7, 2020 12:14 AM
>
> mlx5_suspend()/resume() keep the network interface, so during hibernation
> netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence
> netvsc_resume() should call netvsc_vf_changed() to switch the data path
> back to
| 1 +
> include/linux/hyperv.h | 1 +
> 4 files changed, 31 insertions(+), 6 deletions(-)
>
Reviewed-by: Michael Kelley
From: Boqun Feng Sent: Saturday, September 5, 2020 7:15
AM
>
> On Sat, Sep 05, 2020 at 02:55:48AM +, Michael Kelley wrote:
> > From: Boqun Feng Sent: Tuesday, September 1, 2020
> > 8:01 PM
> > >
> > > Hyper-V always use 4k page size (HV_HYP_PAGE_SIZ
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM
>
> Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when
> communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE
> as the unit for page related data. For storvsc, the data is
> vmbus_packet_mpb_array. And since in s
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM
>
> When communicating with Hyper-V, HV_HYP_PAGE_SIZE should be used since
> that's the page size used by Hyper-V and Hyper-V expects all
> page-related data using the unit of HY_HYP_PAGE_SIZE, for example, the
> "pfn" in hv_page_buffer is
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM
>
> This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The
> types of GPADL are purely the concept in the guest, IOW the hypervisor
> treat them as the same.
>
> The reason of introducing the types of GPADL is to support g
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM
>
> Pure function movement, no functional changes. The move is made, because
> in a later change, __vmbus_open() will rely on some static functions
> afterwards, so we sperate the move and the modification of
s/sperate/separate/
> __vmbu
From: boqun.f...@gmail.com Sent: Wednesday, July 22,
2020 6:52 PM
>
> On Thu, Jul 23, 2020 at 12:13:07AM +, Michael Kelley wrote:
> > From: Boqun Feng Sent: Monday, July 20, 2020 6:42 PM
> > >
> > > Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when
From: Boqun Feng Sent: Monday, July 20, 2020 6:42 PM
>
> Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when
> communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE
> as the unit for page related data. For storvsc, the data is
> vmbus_packet_mpb_array. And since in scsi_c
From: Boqun Feng Sent: Wednesday, July 22, 2020 4:43 PM
>
> On Wed, Jul 22, 2020 at 11:25:18PM +, Michael Kelley wrote:
> > From: Boqun Feng Sent: Monday, July 20, 2020 6:41 PM
> > >
> > > This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The
&
From: Boqun Feng Sent: Monday, July 20, 2020 6:42 PM
>
> When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> least 2 * PAGE_SIZE: one page for the header and at least one page of
> the data part (because of the alignment requirement for double mapping).
>
> So make sure the
From: Boqun Feng Sent: Monday, July 20, 2020 6:41 PM
>
> This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The
> types of GPADL are purely the concept in the guest, IOW the hypervisor
> treat them as the same.
>
> The reason of introducing the types of GPADL is to support guests
From: Stephen Hemminger Sent: Tuesday, June 30,
2020 10:16 AM
>
> On Tue, 30 Jun 2020 11:31:57 -0400
> Andres Beltran wrote:
>
> > Currently, VMbus drivers use pointers into guest memory as request IDs
> > for interactions with Hyper-V. To be more robust in the face of errors
> > or malicious
From: Nathan Chancellor Sent: Tuesday, April 28,
2020 10:55 AM
>
> Do note that netvsc_xmit still returns int because netvsc_xmit has a
> potential return from netvsc_vf_xmit, which does not return netdev_tx_t
> because of the call to dev_queue_xmit.
>
> I am not sure if that is an oversight th
From: Juliana Rodrigueiro Sent: Thursday,
May 2, 2019 9:14 AM
>
> So I got to the following commit:
>
> commit 6ba34171bcbd10321c6cf554e0c1144d170f9d1a
> Author: Michael Kelley
> Date: Thu Aug 2 03:08:24 2018 +
>
> Drivers: hv: vmbus: Remove
t/hyperv/netvsc.c | 2 +-
> drivers/net/hyperv/netvsc_drv.c | 5 -
> drivers/net/hyperv/rndis_filter.c | 9 +++--
> 4 files changed, 19 insertions(+), 7 deletions(-)
>
Reviewed-by: Michael Kelley
> drivers/net/hyperv/netvsc_drv.c | 134
> 1 file changed, 85 insertions(+), 49 deletions(-)
>
Reviewed-by: Michael Kelley
f RSS indirection table")
> Reported-by: Wei Hu
> Signed-off-by: Haiyang Zhang
> ---
> drivers/net/hyperv/rndis_filter.c | 25 +++--
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
Reviewed-by: Michael Kelley
e have defined a function to calculate available ring buffer
> percentage to write.
>
> Use that function and remove netvsc's private version.
>
> Signed-off-by: Long Li
Reviewed-by: Michael Kelley
> ---
> drivers/net/hyperv/hyperv_net.h | 1 -
> drivers/net/hyperv/n
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> On Behalf
> Of Long Li
> Sent: Tuesday, March 27, 2018 5:49 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen
> Hemminger ; James E . J . Bottomley
> ;
> Martin K . Petersen ;
> de...@linuxdriverproject.org; linux-
> s.
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> On Behalf
> Of Haiyang Zhang
> Sent: Thursday, March 22, 2018 12:01 PM
> To: da...@davemloft.net; netdev@vger.kernel.org
> Cc: Haiyang Zhang ; KY Srinivasan
> ; Stephen
> Hemminger ; o...@aepfle.de; vkuzn...@redhat.com;
>
Add direct #include statements for declarations of csum_tcpudp_magic()
and csum_ipv6_magic(). While the needed #include's are picked up
indirectly for the x86 architecture, they aren't on other
architectures, resulting in compile errors.
Signed-off-by: Michael Kelley
---
drivers/
45 matches
Mail list logo
