Re: [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

nand/raw/marvell_nand.c | 17 + > 1 file changed, 1 insertion(+), 16 deletions(-) > Acked-by: Miquel Raynal <miquel.ray...@bootlin.com> Thanks, Miquèl

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

Hi Boris, On Tue, 13 Feb 2018 09:17:14 +0100, Boris Brezillon <boris.brezil...@bootlin.com> wrote: > On Tue, 13 Feb 2018 08:42:46 +0100 > Miquel Raynal <miquel.ray...@bootlin.com> wrote: > > > Hi Boris, > > > > Just a few comments about the form. >

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

Hi Boris, Just a few comments about the form. Otherwise: Reviewed-by: Miquel Raynal <miquel.ray...@bootlin.com> > diff --git a/drivers/mtd/devices/lart.c b/drivers/mtd/devices/lart.c > index 555b94406e0b..3d6c8ffd351f 100644 > --- a/drivers/mtd/devices/lart.c > +++ b/drivers/

[PATCH net-next] net: mvpp2: fix GOP statistics loop start and stop conditions

and stoping it when the port is up or down will be fine, while minimizing unnecessary CPU usage. Fixes: 118d6298f6f0 ("net: mvpp2: add ethtool GOP statistics") Reported-by: Stefan Chulski <stef...@marvell.com> Signed-off-by: Miquel Raynal <miquel.ray...@free-electrons

Re: [PATCH net-next v3] net: mvpp2: add ethtool GOP statistics

Hi David, > > On Wed, Nov 08, 2017 at 01:54:56PM +0900, David Miller wrote: > >> From: Miquel Raynal <miquel.ray...@free-electrons.com> > >> Date: Mon, 6 Nov 2017 22:56:53 +0100 > >> > >> > Add ethtool statistics support by reading the GOP

[PATCH net-next v4] net: mvpp2: add ethtool GOP statistics

Add ethtool statistics support by reading the GOP statistics from the hardware counters. Also implement a workqueue to gather the statistics every second or some 32-bit counters could overflow. Suggested-by: Stefan Chulski <stef...@marvell.com> Signed-off-by: Miquel Raynal <miquel.ra

Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

Hi Stefan, +David Miller/Net ML > > @@ -6844,6 +7023,10 @@ static int mvpp2_open(struct net_device > > *dev) > > > > mvpp2_start_dev(port); > > > > + /* Start hardware statistics gathering */ > > + queue_delayed_work(priv->stats_queue, >stats_work, > > +

[PATCH net-next v3] net: mvpp2: add ethtool GOP statistics

Add ethtool statistics support by reading the GOP statistics from the hardware counters. Also implement a workqueue to gather the statistics every second or some 32-bit counters could overflow. Suggested-by: Stefan Chulski <stef...@marvell.com> Signed-off-by: Miquel Raynal <miquel.ra

Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

Hi Andrew, > > Here I do have a problem: I choose the IDA solution because it was > > quite straightforward but I agree it would be better to use an > > unique name. Unfortunately, on the Armada-8040-DB that instantiate > > this driver twice, the node name is not unique. There are two CP > >

Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

Hi Andrew, On Fri, 3 Nov 2017 16:19:06 +0100 Andrew Lunn wrote: > > @@ -817,6 +856,12 @@ struct mvpp2 { > > > > /* Maximum number of RXQs per port */ > > unsigned int max_port_rxqs; > > + > > + /* Workqueue to gather hardware statistics with its lock */ > > +

Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

On Fri, 3 Nov 2017 12:04:25 +0100 Miquel Raynal <miquel.ray...@free-electrons.com> wrote: > Add ethtool statistics support by reading the GOP statistics from the > hardware counters. Also implement a workqueue to gather the statistics > every second or some 32-bit counters

[PATCH net-next v2] net: mvpp2: add ethtool GOP statistics

Add ethtool statistics support by reading the GOP statistics from the hardware counters. Also implement a workqueue to gather the statistics every second or some 32-bit counters could overflow. Suggested-by: Stefan Chulski <stef...@marvell.com> Signed-off-by: Miquel Raynal <miquel.ra

Re: [PATCH] net: mvpp2: add ethtool GOP statistics

Hi Florian, > > +static u64 mvpp2_read_count(struct mvpp2_port *port, unsigned int > > offset) +{ > > + bool reg_is_64b = > > + (offset == MVPP2_MIB_GOOD_OCTETS_RCVD_LOW) || > > + (offset == MVPP2_MIB_GOOD_OCTETS_SENT_LOW); > > This does not scale very well, put that in

Re: [PATCH] net: mvpp2: add ethtool GOP statistics

Hi Andrew, Thanks for the review, I forgot to mention this is for net-next, I'll fix the subject line when sending the v2. > > +static struct mvpp2_ethtool_statistics mvpp2_ethtool_stats[] = { > > This can probably be const, and save a few bytes of RAM. Absolutely. > > > + {

[PATCH] net: mvpp2: add ethtool GOP statistics

Add ethtool statistics support by reading the GOP statistics from the hardware counters. Also implement a workqueue to gather the statistics every second or some 32-bit counters could overflow. Suggested-by: Stefan Chulski <stef...@marvell.com> Signed-off-by: Miquel Raynal <miquel.ra