[PATCH] [IPv4] Add strict check for replying net unreachable message

2007-12-06 Thread Mitsuru Chinen
The patch `Reply net unreachable ICMP message' had a bug. A route whose type is blockhole or prohibit type is treated as unreachable type. The case where err is set to ENETUNREACH should be that no route is found in the routing table only. Signed-off-by: Mitsuru Chinen <[EMAIL P

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-06 Thread Mitsuru Chinen
On Thu, 6 Dec 2007 09:47:33 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On 06-12-2007 09:14, Mitsuru Chinen wrote: > > On Thu, 6 Dec 2007 08:49:47 +0100 > > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > >> On 06-12-2007 07:31, Mitsuru Chinen

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-06 Thread Mitsuru Chinen
On Thu, 6 Dec 2007 08:49:47 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On 06-12-2007 07:31, Mitsuru Chinen wrote: > > IPv4 stack doesn't reply any ICMP destination unreachable message > > with net unreachable code when IP detagrams are being discarded > &

[PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-05 Thread Mitsuru Chinen
IPv4 stack doesn't reply any ICMP destination unreachable message with net unreachable code when IP detagrams are being discarded because of no route could be found in the forwarding path. Incidentally, IPv6 stack replies such ICMPv6 message in the similar situation. Signed-off-by: Mitsuru C

[PATCH] [IPv6] SNMP: Increment OutNoRoutes when connecting to unreachable network

2007-12-05 Thread Mitsuru Chinen
IPv6 stack doesn't increment OutNoRoutes counter when IP datagrams is being discarded because no route could be found to transmit them to their destination. IPv6 stack should increment the counter. Incidentally, IPv4 stack increments that counter in such situation. Signed-off-by: Mitsuru C

[PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation

2007-11-01 Thread Mitsuru Chinen
As the checksum verification is postponed till user calls recv or poll, the inrementation of Udp6InErrors counter should be also postponed. Currently, it is postponed in non-blocking operation case. However it should be postponed in all case like the IPv4 code. Signed-off-by: Mitsuru Chinen

Re: [UDP6]: Restore sk_filter optimisation

2007-11-01 Thread Mitsuru Chinen
On Wed, 31 Oct 2007 22:42:57 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Wed, Oct 31, 2007 at 11:05:45PM +0900, Mitsuru Chinen wrote: > > > > > > 1. udp6InDatagrams is incremented instead of udpInErrors > > > > 2. In userland, recvfrom() replies an

Re: [UDP6]: Restore sk_filter optimisation

2007-10-31 Thread Mitsuru Chinen
On Mon, 29 Oct 2007 20:53:28 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Mon, Oct 29, 2007 at 03:33:20PM +0900, Mitsuru Chinen wrote: > > Hello Herbert, > > > > Let me ask a question about this patch. > > After this patch was applied, 2 of the protocol stac

Re: [UDP6]: Restore sk_filter optimisation

2007-10-28 Thread Mitsuru Chinen
EAGAIN. recvfrom() wasn't aware of such a packet before. Are these changes intentional? Best Regards, Mitsuru Chinen <[EMAIL PROTECTED]> On Tue, 6 Mar 2007 12:20:10 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > Hi Dave: > > [UDP6]: Restore sk_filter optimisa

[PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

2007-10-25 Thread Mitsuru Chinen
While displaying ICMP out-going statistics as Out counters in /proc/net/snmp, the memory location for ICMP in-coming statistics was referred by mistake. Acked-by: David L Stevens <[EMAIL PROTECTED]> Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv4/proc.c |2 +- 1 f

[PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified

2007-10-09 Thread Mitsuru Chinen
-by: Mitsuru Chinen <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 6d5c3c2..da8c79c 100644 --- a/net/

Re: [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-05-11 Thread Mitsuru Chinen
On Mon, 7 May 2007 20:29:05 +0900 Mitsuru Chinen <[EMAIL PROTECTED]> wrote: > On Thu, 03 May 2007 03:15:46 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Mitsuru Chinen <[EMAIL PROTECTED]> > > Date: Wed, 2 May 2007 10:05:13 +0900 > &g

Re: [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-05-07 Thread Mitsuru Chinen
On Thu, 03 May 2007 03:15:46 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Mitsuru Chinen <[EMAIL PROTECTED]> > Date: Wed, 2 May 2007 10:05:13 +0900 > > > [IPV4] SNMP: Display new statistics at /proc/net/netstat > > > > This displays the sta

Re: [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-05-01 Thread Mitsuru Chinen
On Mon, 30 Apr 2007 00:50:14 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Mitsuru Chinen <[EMAIL PROTECTED]> > Date: Fri, 27 Apr 2007 16:46:30 +0900 > > > On Tue, 17 Apr 2007 20:14:36 +0900 > > Mitsuru Chinen <[EMAIL PROTECTED]> wrote:

Re: [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-04-27 Thread Mitsuru Chinen
On Tue, 17 Apr 2007 20:14:36 +0900 Mitsuru Chinen <[EMAIL PROTECTED]> wrote: > This displays the statistics specified in the updated IP-MIB RFC > (RFC4293) at /proc/net/snmp. As new statistics are placed as the > last elements, this change wouldn't affect netstat, net-snmp

[PATCH 5/6] [IPV4] SNMP: Support OutMcastPkts and OutBcastPkts

2007-04-17 Thread Mitsuru Chinen
A transmitted IP multicast datagram should be counted as OutMcastPkts. By the same token, a transmitted IP broadcast datagram should be counted as OutBcastPkts. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv4/ip_output.c |6 ++ 1 files changed, 6 insertions(+), 0 del

[PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-04-17 Thread Mitsuru Chinen
This displays the statistics specified in the updated IP-MIB RFC (RFC4293) at /proc/net/snmp. As new statistics are placed as the last elements, this change wouldn't affect netstat, net-snmp, etc. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv4/proc.c |6

[PATCH 4/6] [IPV4] SNMP: Support InMcastPkts and InBcastPkts

2007-04-17 Thread Mitsuru Chinen
A received IP multicast datagram should be counted as InMcastPkts. By the same token, a received IP broadcast datagram should be counted as InBcastPkts. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv4/ip_input.c |7 +++ 1 files changed, 7 insertions(+), 0 del

[PATCH 1/6] SNMP: Add definitions for {In,Out}BcastPkts

2007-04-17 Thread Mitsuru Chinen
The updated IP-MIB RFC (RFC4293) specifys new objects, InBcastPkts and OutBcastPkts. This adds definitions for them. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- include/linux/snmp.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/snmp.h b/i

[PATCH 2/6] [IPV4] SNMP: Support InNoRoutes

2007-04-17 Thread Mitsuru Chinen
An IP datagram which is being discarded because of no routes in the forwarding path should be counted as InNoRoutes. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv4/ip_input.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/ipv4/ip_input.c b/ne

[PATCH 3/6] [IPV4] SNMP: Support InTruncatedPkts

2007-04-17 Thread Mitsuru Chinen
An IP datagram which is being discarded because the datagram frame didn't carry enough data should be counted as InTruncatedPkts. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv4/ip_input.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

[PATCH 0/6] SNMP: new statistics specified in RFC4293

2007-04-17 Thread Mitsuru Chinen
] SNMP: Display new statistics at /proc/net/snmp Best Regards, Mitsuru Chinen <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [IPv6] Exclude truncated packets from InHdrErrors statistics

2007-04-03 Thread Mitsuru Chinen
Incoming trancated packets are counted as not only InTruncatedPkts but also InHdrErrors. They should be counted as InTruncatedPkts only. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv6/ip6_input.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] Ensure IF_READY is unset when link is not ready

2007-03-07 Thread Mitsuru Chinen
On Wed, 07 Mar 2007 15:54:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Thu, 08 Mar 2007 10:47:56 +1100 > > > Mitsuru Chinen <[EMAIL PROTECTED]> wrote: > > > > > > On linux-2.6.21-rc2 o

[PATCH] Ensure IF_READY is unset when link is not ready

2007-03-05 Thread Mitsuru Chinen
te of the actual link state. Here's a work around patch. This make IF_READY unset when NETDEV_UP event occurs and the link is not ready. This patch may not be an fundamental fix. But I don't have any other idea now. Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]> --- net/ipv6/a

Re: (usagi-core 31424) Re: [PATCH 7/13] [RFC] [IPV6] Move source address selection into route lookup.

2006-10-19 Thread Mitsuru Chinen
ils. The test log is the same as the last one. When I applied all patches, I got fails, either. Best Regards, -- Mitsuru Chinen <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 7/13] [RFC] [IPV6] Move source address selection into route lookup.

2006-10-17 Thread Mitsuru Chinen
ed wrong tree... Excuse me. I overlooked an error message from patch command. When I appiled the patch manually, we could compile them. We will double-check these patches with TAHI, either. And then, we will report the results. Best Regards, -- Mitsuru Chinen <[EMAIL PROTECTED]>

Re: IPv6 regression in net-2.6.16

2005-12-28 Thread Mitsuru Chinen
_async-job-patch/nd.p2/ The fails occured at the same tests with the async job changeset. Best Regards, -- Mitsuru Chinen <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html