[PATCH v4 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-18 Thread Mugunthan V N
Add support for programmable MAC impedance configuration Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- drivers/net/phy/dp83867.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 91177a4..1

[PATCH v4 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-10-18 Thread Mugunthan V N
implementation. * Corrected the phy delay timings to the optimal value. [1] - http://www.ti.com/lit/ds/symlink/dp83867ir.pdf [2] - http://pastebin.ubuntu.com/23343139/ [3] - git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git dp83867-v4 Mugunthan V N (4): net: phy: dp83867: Add documentation

[PATCH v4 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-18 Thread Mugunthan V N
Add documention of ti,min-output-impedance and ti,max-output-impedance which can be used to correct MAC impedance mismatch using phy extended registers. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 1 file c

[PATCH v4 3/4] ARM: dts: dra72-evm-revc: add phy impedance settings

2016-10-18 Thread Mugunthan V N
The default impedance settings of the phy is not the optimal value, due to this the second ethernet is not working. Fix it with correct values which makes the second ethernet port to work. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++

[PATCH v4 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay

2016-10-18 Thread Mugunthan V N
The current delay settings of the phy are not the optimal value, fix it with correct values. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra72-evm-revc.dts | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/dra

Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-12 Thread Mugunthan V N
On Monday 10 October 2016 06:48 PM, Rob Herring wrote: > On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote: >> Add documention of ti,impedance-control which can be used to > > Needs updating. Oops, will update this in next version. > >> correct MAC impe

[PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-05 Thread Mugunthan V N
Add documention of ti,impedance-control which can be used to correct MAC impedance mismatch using phy extended registers. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 1 file changed, 12 insertions(+) diff

[PATCH v3 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-10-05 Thread Mugunthan V N
value. [1] - http://www.ti.com/lit/ds/symlink/dp83867ir.pdf [2] - http://pastebin.ubuntu.com/23283056/ [3] - git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git dp83867-v3 Mugunthan V N (4): net: phy: dp83867: Add documentation for optional impedance control net: phy: dp83867: add

[PATCH v3 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-05 Thread Mugunthan V N
Add support for programmable MAC impedance configuration Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- drivers/net/phy/dp83867.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 91177a4..1

[PATCH v3 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay

2016-10-05 Thread Mugunthan V N
The current delay settings of the phy are not the optimal value, fix it with correct values. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra72-evm-revc.dts | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/dra

[PATCH v3 3/4] ARM: dts: dra72-evm-revc: add phy impedance settings

2016-10-05 Thread Mugunthan V N
The default impedance settings of the phy is not the optimal value, due to this the second ethernet is not working. Fix it with correct values which makes the second ethernet port to work. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++

Re: [PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings

2016-10-04 Thread Mugunthan V N
On Tuesday 04 October 2016 06:41 PM, Lokesh Vutla wrote: > > On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote: >> > The default impedance settings of the phy is not the optimal >> > value, due to this the second ethernet is not working. Fix it >> >

Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-04 Thread Mugunthan V N
min-output-imepdance")) > > Did you really test this? Or did you make the same typos in your device > tree file? > I have tested this and attached the log in cover letter. Since there is a typo error on both dts and driver it worked as expected. Will send a v3 ASAP. Regards Mugunthan V N

[net-next PATCH] drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay

2016-10-04 Thread Mugunthan V N
Add support to enable CPSW RGMII internal delay (id mode) bits when rgmii internal delay is configured in phy. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- drivers/net/ethernet/ti/cpsw-phy-sel.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ether

[PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-04 Thread Mugunthan V N
Add support for programmable MAC impedance configuration Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- drivers/net/phy/dp83867.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 91177a4..7

[PATCH v2 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-10-04 Thread Mugunthan V N
/dp83867ir.pdf [2] - http://pastebin.ubuntu.com/23274616/ [3] - git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git dp83867-v2 Mugunthan V N (4): net: phy: dp83867: Add documentation for optional impedance control net: phy: dp83867: add support for MAC impedance configuration ARM: dts: dra72

[PATCH v2 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay

2016-10-04 Thread Mugunthan V N
The current delay settings of the phy are not the optimal value, fix it with correct values. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra72-evm-revc.dts | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/dra

[PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings

2016-10-04 Thread Mugunthan V N
The default impedance settings of the phy is not the optimal value, due to this the second ethernet is not working. Fix it with correct values which makes the second ethernet port to work. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++

[PATCH v2 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-04 Thread Mugunthan V N
Add documention of ti,impedance-control which can be used to correct MAC impedance mismatch using phy extended registers. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 1 file changed, 12 insertions(+) diff

Re: [PATCH v4 1/5] net: ethernet: ti: davinci_cpdma: split descs num between all channels

2016-08-22 Thread Mugunthan V N
another, let every channel to have its > own piece of pool. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v4 5/5] net: ethernet: ti: cpsw: add ethtool channels support

2016-08-22 Thread Mugunthan V N
S ethX > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v4 3/5] net: ethernet: ti: cpsw: add multi queue support

2016-08-22 Thread Mugunthan V N
's with single-queue default mode. > > The statistic for every channel can be read with: > $ ethtool -S ethX > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 4/5] net: ethernet: ti: davinci_cpdma: move cpdma channel struct macroses to internals

2016-08-17 Thread Mugunthan V N
only for internal use. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 5/5] net: ethernet: ti: cpsw: add ethtool channels support

2016-08-17 Thread Mugunthan V N
On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote: > These ops allow to control number of channels driver is allowed to > work with at cpdma level. The maximum number of channels is 8 for > rx and 8 for tx. In dual_emac mode the h/w channels are shared > between two interfaces and changing

Re: [PATCH v3 2/5] net: ethernet: ti: davinci_cpdma: fix locking while ctrl_stop

2016-08-16 Thread Mugunthan V N
topping while not all packets were handled > with NAPIs. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 13/13] net: ethernet: ti: cpsw: move ale, cpts and drivers params under cpsw_common

2016-08-10 Thread Mugunthan V N
k <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 10/13] net; ethernet: ti: cpsw: move irq stuff under cpsw_common

2016-08-10 Thread Mugunthan V N
of irqs to 2, as anyway, driver is using only 2, > at least for now. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 12/13] net: ethernet: ti: cpsw: move napi struct to cpsw_common

2016-08-10 Thread Mugunthan V N
Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers

2016-08-10 Thread Mugunthan V N
ich belongs to DEV MMIO space. Kmemleak does not scan IO > memory and so reports memory leaks. > > Hence, mark allocated sk buffers as false positive explicitly. > > Cc: Catalin Marinas <catalin.mari...@arm.com> > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 09/13] net: ethernet: ti: cpsw: move cpdma resources to cpsw_common

2016-08-10 Thread Mugunthan V N
k <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 11/13] net: ethernet: ti: cpsw: move platform data and slaves info to cpsw_common

2016-08-10 Thread Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote: > These data are common for net devs in dual_emac mode. No need to hold > it for every priv instance, so move them under cpsw_common. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunt

Re: [PATCH v3 06/13] net: ethernet: ti: cpsw: create common struct to hold shared driver data

2016-08-10 Thread Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote: > This patch simply create holder for common data and as a start moves > pdev var to it. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 08/13] net: ethernet: ti: cpsw: move links on h/w registers to cpsw_common

2016-08-10 Thread Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote: > The pointers on h/w registers are common for every cpsw_private > instance, so no need to hold them for every ndev. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N &l

Re: [PATCH v3 07/13] net: ethernet: ti: cpsw: replace pdev on dev

2016-08-10 Thread Mugunthan V N
On Wednesday 10 August 2016 04:52 AM, Ivan Khoronzhuk wrote: > No need to hold pdev link when only dev is needed. > This allows to simplify a bunch of cpsw->pdev->dev now and farther. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan

Re: [PATCH] net: ethernet: ti: cpdma: remove used_desc counter

2016-08-09 Thread Mugunthan V N
DMA has been > switched to use genalloc, and may get wrong values on SMP. > > Hence, remove used_desc from struct cpdma_desc_pool. > > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH 1/2] net: davinci_cpdma: reduce time holding ctlr->lock in cpdma_control_set

2016-08-09 Thread Mugunthan V N
> moved out of the critical section. > > Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2 05/14] net: ethernet: ti: cpsw: don't check slave num in runtime

2016-08-09 Thread Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote: > No need to check const slave num in runtime for every packet, > and ndev for slaves w/o ndev is anyway NULL. So remove redundant > check. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Revie

Re: [PATCH v2 04/14] net: ethernet: ti: cpsw: remove clk var from priv

2016-08-09 Thread Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote: > There is no need to hold link to clk, it's used only once > while probe. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2 03/14] net: ethernet: ti: cpsw: remove priv from cpsw_get_slave_port() parameters list

2016-08-09 Thread Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote: > There is no need in priv here. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2 02/14] net: ethernet: ti: cpsw: remove redundant check in napi poll

2016-08-09 Thread Mugunthan V N
khoronz...@linaro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2 01/14] net: ethernet: ti: cpsw: simplify submit routine

2016-08-09 Thread Mugunthan V N
aro.org> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

2016-08-01 Thread Mugunthan V N
+omap ML On Monday 01 August 2016 12:32 PM, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Signed-off-by: Peter Chen <peter.c...@nxp.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

2016-07-29 Thread Mugunthan V N
ot connect to phy %s\n", >>> priv->phy_node->full_name); >>> >> >> phy_node is accessed in case of of_phy_connect() returns error, so it has to >> be >> moved after the dev_err log >> > > Yeah, you are right. I will change it, thanks. > I see one more problem, when you stop and open the interface there is no way to get the phy_node and interface will be unusable, so of_node_put() should be moved to remove() Regards Mugunthan V N

Re: [PATCH v2 3/4] drivers: net: cpsw: use of_platform_depopulate()

2016-07-29 Thread Mugunthan V N
ure that all steps done in > of_platform_populate() are reverted, including cleaning up of > OF_POPULATED flag. > > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove

2016-07-29 Thread Mugunthan V N
trashko <grygorii.stras...@ti.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2 1/4] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-29 Thread Mugunthan V N
tlr to destroy channels") was merged. > > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Mugunthan V N
(!phydev) { > dev_err(emac_dev, "could not connect to phy %s\n", > priv->phy_node->full_name); > phy_node is accessed in case of of_phy_connect() returns error, so it has to be moved after the dev_err log Regards Mugunthan V N

Re: [net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control

2016-07-22 Thread Mugunthan V N
Rob, On Friday 22 July 2016 02:44 AM, Rob Herring wrote: > On Thu, Jul 21, 2016 at 11:52:36AM +0530, Sekhar Nori wrote: >> Nishanth, >> >> On Wednesday 20 July 2016 09:03 PM, Nishanth Menon wrote: >>> On 07/20/2016 09:56 AM, Mugunthan V N wrote: >>>> Add

[net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control

2016-07-20 Thread Mugunthan V N
Add documention of ti,impedance-control which can be used to correct MAC impedance mismatch using phy extended registers. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 7 +++ 1 file changed, 7 insertions(+) diff

[net-next PATCH 3/3] ARM: dts: dra72-evm-revc: fix non-working cpsw second ethernet

2016-07-20 Thread Mugunthan V N
Second ethernet of cpsw is not working, make it work by adding impedance configuration. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/dra72-evm-revc.dts b/arch/arm/bo

[net-next PATCH 2/3] net: phy: dp83867: add support for MAC impedance configuration

2016-07-20 Thread Mugunthan V N
Add support for programmable MAC impedance configuration Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- drivers/net/phy/dp83867.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 91177a4..a

[net-next PATCH 0/3] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-07-20 Thread Mugunthan V N
Add support for configurable impedance control for TI dp83867 phy via devicetree. More documentation in [1] CPSW second ethernet is not working, fix it by enabling impedance configuration on the phy. Public Datasheet - http://www.ti.com/lit/ds/symlink/dp83867ir.pdf Mugunthan V N (3): net: phy

Re: [PATCH v2 00/15] drivers: net: cpsw: improve runtime pm

2016-06-27 Thread Mugunthan V N
t; - davinci_mdio DT updated with proper description of allowed compatible > strings > combinations > > Link on v1: > https://lkml.org/lkml/2016/6/15/362 For the series. Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N > > Grygorii Strashko (15)

Re: [PATCH v2] net: ethernet: ti: cpdma: switch to use genalloc

2016-06-27 Thread Mugunthan V N
gt; Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> Acked-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

2016-06-24 Thread Mugunthan V N
(directed << CPDMA_TO_PORT_SHIFT));\ >> } while (0) >> >> +static void cpdma_desc_pool_destroy(struct cpdma_desc_pool *pool) >> +{ >> +if (!pool) >> +return; >> + >> +WARN_ON(pool->use

Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc

2016-06-24 Thread Mugunthan V N
gt; Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> Acked-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property

2016-06-17 Thread Mugunthan V N
. > > Based on > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > > Since v2: > - add declaration of buf_num in correct order > > Since v1: > - separate device tree and driver patches > - return number of rx buffers from cpdma driver >

Re: [PATCH v2 0/2] net: ethernet: ti: cpsw: delete rx_descs property

2016-06-14 Thread Mugunthan V N
On Tuesday 14 June 2016 06:08 PM, Ivan Khoronzhuk wrote: > > > On 13.06.16 18:19, Andrew F. Davis wrote: >> On 06/13/2016 03:22 AM, Mugunthan V N wrote: >>> On Saturday 11 June 2016 04:34 AM, Schuyler Patton wrote: >>>> >>>> &g

Re: [PATCH v2 0/2] net: ethernet: ti: cpsw: delete rx_descs property

2016-06-13 Thread Mugunthan V N
nnels > > With gigabit networks 64 or 128 rx descriptors is not going to enough to > fix the > DMA overrun problem. Usually we set this number to an arbitrarily large > 2000 > descriptors in external DDR to demonstrate it is possible to not drop > packets. All > this does is move the problem higher up so that the drops occur in network > stack if the ARM is overloaded. With the high speed networks I would like > to propose that the descriptor pool or pools are moved to DDR by > default. It would > be nice to have some reconfigurability or set a pool size that reduces > or eliminates > the DMA issue that is seen in these types of applications. > > This test gets used a lot, which is to send very short UDP packets. If I > have the math > right, a 52 byte (64 byte with the inter-frame gap) UDP packet the > default 64 > descriptors gets consumed in roughly 33uS. There are the switch fifos > which will also > allow some headroom, but a user was dropping packets at the switch when > they > were bursting 360 packets at the processor on a gigabit link > I too agree that rx-descs can be derived from the pool size and descriptor size in driver itself. The current driver uses bd_ram_size to set the pool size when the descriptors are placed in DDR which is wrong. Here I propose an idea to solve Schuyler's concern to keep the descriptors in DDR when a system need more rx descriptors for lossless UDB performance. The DT property rx-descs can be removed and add a new DT property *pool_size* to add support for descriptors memory size in DDR and define a pool size which the system needs for a network to have lossless UDP transfers. So based on no_bd_ram DT entry, the driver can decide whether it can use internal BD-ram or DDR to initialize the cpdma driver. Regards Mugunthan V N

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-04 Thread Mugunthan V N
v); > > if (skb_padto(skb, CPSW_MIN_PACKET_SIZE)) { > cpsw_err(priv, tx_err, "packet pad failed\n"); for cpsw Acked-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH net v3 4/5] dt: cpsw: phy-handle, phy_id, and fixed-link are mutually exclusive

2016-04-28 Thread Mugunthan V N
mark the phy_id property as deprecated, as phy-handle should be > used instead. > > Signed-off-by: David Rivshin <drivs...@allworx.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH] net: ethernet: davinci_emac: Fix devioctl while in fixed link

2016-04-26 Thread Mugunthan V N
; Fixes: 1bb6aa56bb38 ("net: davinci_emac: Add support for fixed-link PHY") > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

2016-04-22 Thread Mugunthan V N
r reported testing v1 on the following [1]: > - emac0 with phy_id and emac1 with fixed phy > - emac0 with phy-handle and emac1 with fixed phy > - emac0 with fixed phy and emac1 with fixed phy > > Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH v2] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-21 Thread Mugunthan V N
as the reviewer. > > Cc: "David S. Miller" <da...@davemloft.net> > Cc: Tony Lindgren <t...@atomide.com> > Cc: Mugunthan V N <mugunthan...@ti.com> > Cc: Richard Cochran <richardcoch...@gmail.com> > Signed-off-by: Grygorii Strashko <grygorii.st

Re: [PATCH 0/2] drivers: net: cpsw: fix ale calls and drop host_port field from cpsw_priv

2016-04-11 Thread Mugunthan V N
changed, 21 insertions(+), 31 deletions(-) > Reviewed-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: am335x: no multicast reception over VLAN

2016-04-05 Thread Mugunthan V N
On Friday 01 April 2016 05:39 PM, Grygorii Strashko wrote: > On 03/31/2016 10:52 AM, Yegor Yefremov wrote: >> On Thu, Mar 31, 2016 at 8:37 AM, Mugunthan V N <mugunthan...@ti.com> wrote: >>> On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote: >>>>>>&

Re: am335x: no multicast reception over VLAN

2016-03-31 Thread Mugunthan V N
On Thursday 31 March 2016 01:22 PM, Yegor Yefremov wrote: > On Thu, Mar 31, 2016 at 8:37 AM, Mugunthan V N <mugunthan...@ti.com> wrote: >> On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote: >>>>>>>> "Mugunthan" == Mugunthan V N <mugunth

Re: am335x: no multicast reception over VLAN

2016-03-31 Thread Mugunthan V N
On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote: >>>>>> "Mugunthan" == Mugunthan V N <mugunthan...@ti.com> writes: > > Hi, > > > You had received these packets as tcpdump will enable promiscuous mode > > so that you receive all

Re: am335x: no multicast reception over VLAN

2016-03-30 Thread Mugunthan V N
On Wednesday 30 March 2016 02:05 PM, Yegor Yefremov wrote: > On Wed, Mar 30, 2016 at 7:33 AM, Mugunthan V N <mugunthan...@ti.com> wrote: >> On Tuesday 29 March 2016 06:14 PM, Grygorii Strashko wrote: >>> On 03/29/2016 03:35 PM, Yegor Yefremov wrote: >>>> On Tu

Re: am335x: no multicast reception over VLAN

2016-03-29 Thread Mugunthan V N
Mugunthan, >>>> >>>> On Tue, Mar 29, 2016 at 6:00 AM, Mugunthan V N <mugunthan...@ti.com> wrote: >>>>> Hi Yegor >>>>> >>>>> On Wednesday 16 March 2016 08:35 PM, Yegor Yefremov wrote: >>>>>> I have

Re: am335x: no multicast reception over VLAN

2016-03-28 Thread Mugunthan V N
d send multicast packets via VLAN. Are you trying multicast tx/rx on eth1 or eth1.100? > > This setup was tested with both 3.18.21 and 4.5 kernels. > > Any idea? > > [1] https://pymotw.com/2/socket/multicast.html > -- Regards Mugunthan V N

Re: [PATCH] drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode

2016-02-14 Thread Mugunthan V N
e this condition obvious and provide a > breadcrumb to follow. > > Cc: Mugunthan V N <mugunthan...@ti.com> > Signed-off-by: David Rivshin <drivs...@allworx.com> Acked-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N

Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x

2015-11-18 Thread Mugunthan V N
> Let's fix the issue by adding handling for dm814x. > > Cc: Mugunthan V N <mugunthan...@ti.com> > Signed-off-by: Tony Lindgren <t...@atomide.com> Acked-by: Mugunthnan V N <mugunthan...@ti.com> Regards Mugunthan V N -- To unsubscribe from this list: send the line &qu

Re: [PATCH] drivers: net: cpsw: Add support for fixed-link PHY

2015-11-04 Thread Mugunthan V N
good to me. Acked-by: Mugunthan V N <mugunthan...@ti.com> Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH] driver: net: cpsw: add no_bd_ram dt parsing

2015-10-12 Thread Mugunthan V N
On Friday 09 October 2015 03:36 PM, Mugunthan V N wrote: > cpdma is capable of placing the dma descriptors in ddr using > dma_alloc_coherent() when the internal bd ram size is not enough. > To utilize this feature pass the DT parameter "no_bd_ram" and > increase bd_ram

[net-next PATCH] driver: net: cpsw: add no_bd_ram dt parsing

2015-10-09 Thread Mugunthan V N
cpdma is capable of placing the dma descriptors in ddr using dma_alloc_coherent() when the internal bd ram size is not enough. To utilize this feature pass the DT parameter "no_bd_ram" and increase bd_ram_size and number of rx descriptors. Signed-off-by: Mugunthan V N <mugunt

[net-next PATCH 1/4] drivers: net: cpsw: davinci_emac: move reading mac id to common file

2015-09-21 Thread Mugunthan V N
Moving mac address reading from ethernet driver to common file for better maintenance and for code reusable. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- drivers/net/ethernet/ti/cpsw-common.c | 58 -- drivers/net/ethernet/ti/cpsw.c

[net-next PATCH 2/4] drivers: net: cpsw-common: add support for reading mac address for dra7 and am437x platforms

2015-09-21 Thread Mugunthan V N
Adding support for reading mac address using syscon driver for dra7 and am437x platforms Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- drivers/net/ethernet/ti/cpsw-common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drive

[net-next PATCH 3/4] arm: dts: dra7: add syscon phandle to cpsw node

2015-09-21 Thread Mugunthan V N
There are 2 MACIDs stored in the control module of the dra7. These are read by the cpsw driver if no valid MACID was found in the devicetree. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/bo

[net-next PATCH 4/4] arm: dts: am4372: add syscon phandle to cpsw node

2015-09-21 Thread Mugunthan V N
There are 2 MACIDs stored in the control module of the am4372. These are read by the cpsw driver if no valid MACID was found in the devicetree. Signed-off-by: Mugunthan V N <mugunthan...@ti.com> --- arch/arm/boot/dts/am4372.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/ar

[net-next PATCH 0/4] Add support for reading macid when DT macid not found

2015-09-21 Thread Mugunthan V N
Did a boot test on dra7-evm [1] and am437x-gp-evm [2]. Pushed a branch [3] for others to test the patch. [1]: http://pastebin.ubuntu.com/12513420/ [2]: http://pastebin.ubuntu.com/12513428/ [3]: git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git cpsw-macid-read-support Mugunthan V N (4

[net-next PATCH v3] drivers: net: cpsw: Add support to drive gpios for ethernet to be functional

2015-09-07 Thread Mugunthan V N
when gpio based muxing is required. This will throw a warning when gpio get fails and returns probe defer. When gpio-pcf857x module is installed, cpsw probes again and ethernet becomes functional. Verified this on DRA72x with pcf as module and ramdisk. Signed-off-by: Mugunthan V N <mugunt

[net-next PATCH v2] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy

2015-09-03 Thread Mugunthan V N
when gpio based muxing is required. This will throw a warning when gpio get fails and returns probe defer. When gpio-pcf857x module is installed, cpsw probes again and ethernet becomes functional. Verified this on DRA72x with pcf as module and ramdisk. Signed-off-by: Mugunthan V N <mugunt

Re: [net-next PATCH] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy

2015-09-02 Thread Mugunthan V N
On Tuesday 01 September 2015 09:06 PM, Tony Lindgren wrote: > * Mugunthan V N <mugunthan...@ti.com> [150901 04:28]: >> --- a/Documentation/devicetree/bindings/net/cpsw.txt >> +++ b/Documentation/devicetree/bindings/net/cpsw.txt >> @@ -26,6 +26,9 @@ Optional

[net-next PATCH] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy

2015-09-01 Thread Mugunthan V N
in DT when gpio based muxing is required. This will through a warning when vgpio get fails and returns probe defer. When gpio-pcf857x module is installed, cpsw probes again and ethernet becomes functional. Verified this on DRA72x with pcf as module and ramdisk [1] Signed-off-by: Mugunthan V N

Re: [net-next PATCH 1/3] drivers: net: cpsw: add am335x errata workarround for interrutps

2015-08-25 Thread Mugunthan V N
On Monday 24 August 2015 03:34 PM, Sekhar Nori wrote: Hi Mugunthan, On Wednesday 12 August 2015 03:22 PM, Mugunthan V N wrote: +static const struct of_device_id cpsw_of_mtable[] = { + { .compatible = ti,cpsw, .data = cpsw_devtype[CPSW], }, + { .compatible = ti,am335x-cpsw, .data

Re: dhcp nfsroot booting failure on bb white

2015-08-12 Thread Mugunthan V N
is with AM335x PG1.0 as there is a errata in CPSW interrupts, PG2.x and other SoCs are working fine. Regards Mugunthan V N -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[net-next PATCH] net: ipv4: increase dhcp inter device timeout

2015-08-12 Thread Mugunthan V N
device timeout to HZ (which is 1S). Signed-off-by: Mugunthan V N mugunthan...@ti.com --- net/ipv4/ipconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 8e7328c..ed4ef09 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4

[net-next PATCH 0/3] Add AM335x PG1.0 CPSW errata workaround

2015-08-12 Thread Mugunthan V N
for AM335x SoC in addition to the masking of interrupts in CPSW. Mugunthan V N (3): drivers: net: cpsw: add am335x errata workarround for interrutps ARM: dts: dra7: update cpsw compatible ARM: dts: am33xx: update cpsw compatible arch/arm/boot/dts/am33xx.dtsi | 2 +- arch/arm/boot/dts/dra7

[net-next PATCH 2/3] ARM: dts: dra7: update cpsw compatible

2015-08-12 Thread Mugunthan V N
CPSW driver has been updated with compatibles for enabling errata workarounds. So updating cpsw compatibles. Signed-off-by: Mugunthan V N mugunthan...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm

[net-next PATCH 3/3] ARM: dts: am33xx: update cpsw compatible

2015-08-12 Thread Mugunthan V N
CPSW driver has been updated with compatibles for enabling errata workarounds. So updating cpsw compatibles. Signed-off-by: Mugunthan V N mugunthan...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch

[net-next PATCH 1/3] drivers: net: cpsw: add am335x errata workarround for interrutps

2015-08-12 Thread Mugunthan V N
pending and CPU is struck in ISR, the workaround is to disable the interrupts in ARM irq controller. [1] http://www.ti.com/lit/er/sprz360f/sprz360f.pdf Signed-off-by: Mugunthan V N mugunthan...@ti.com --- drivers/net/ethernet/ti/cpsw.c | 83 +++--- 1 file changed

Re: [RFC PATCH] net: ipv4: increase dhcp inter device timeout

2015-08-09 Thread Mugunthan V N
timeout: 1/2 second */ You should update comment as well at least. Will update in next version. Regards Mugunthan V N -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[RFC PATCH] net: ipv4: increase dhcp inter device timeout

2015-08-07 Thread Mugunthan V N
device timeout to HZ (which is 1S). Signed-off-by: Mugunthan V N mugunthan...@ti.com --- net/ipv4/ipconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 8e7328c..bdb8cb5 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4

[net-next PATCH v2 3/3] drivers: net: cpsw: add separate napi for tx

2015-08-04 Thread Mugunthan V N
Instead of processing tx events in isr adding separate napi for tx which improves performance by ~180Mbps with omap2plus_defconfig on DRA74x platform. Also cleaning up rx napis by renaming to napi_rx for better understanding the code. Signed-off-by: Mugunthan V N mugunthan...@ti.com --- drivers

[net-next PATCH v2 0/3] CPSW interrupt handling cleanup and performance improvement

2015-08-04 Thread Mugunthan V N
by both interface and only one napi is scheduled for each interrupt. Mugunthan V N (3): drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself drivers: net: cpsw: dual_emac: simplify napi usage drivers: net: cpsw: add separate napi for tx drivers/net

[net-next PATCH v2 2/3] drivers: net: cpsw: dual_emac: simplify napi usage

2015-08-04 Thread Mugunthan V N
Since interrupt is shared between the two ethernet interface and in isr only one napi is scheduled at an instance so having two napis doesn't make any difference. So making napi also as a common resource for the dual ethernet interfaces. Signed-off-by: Mugunthan V N mugunthan...@ti.com

[net-next PATCH v2 1/3] drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself

2015-08-04 Thread Mugunthan V N
CPSW interrupts can be disabled by masking CPSW interrupts and clearing interrupt by writing appropriate EOI. So removing all disable_irq/enable_irq as discussed in [1] [1] http://patchwork.ozlabs.org/patch/492741/ Signed-off-by: Mugunthan V N mugunthan...@ti.com --- drivers/net/ethernet/ti

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-30 Thread Mugunthan V N
On Thursday 30 July 2015 04:27 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: [...] cpsw_ndo_stop calls napi_disable: you

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Mugunthan V N
On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : [...] @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id) struct

  1   2   >