[net-next PATCH v4 07/13] net: netcp: ethss: map vlan priorities to zero flow

2018-04-17 Thread Murali Karicheri
The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ether

[net-next PATCH v4 00/13] Add support for netcp driver on K2G SoC

2018-04-17 Thread Murali Karicheri
Addressed comments from Andrew Lunn and Grygorii Strashko against v2. v2 - Addressed following comments on initial version - split patch 3/5 to multiple patches from Andrew Lunn Murali Karicheri (11): soc: ti: K2G: enhancement to support QMSS in K2G NAVSS soc: ti: K2G: provide APIs

[net-next PATCH v4 04/13] net: netcp: ethss: make sgmii configuration conditional

2018-04-17 Thread Murali Karicheri
As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make sgmii configuration conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ether

[net-next PATCH v4 10/13] Revert "net: netcp: remove dead code from the driver"

2018-04-17 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/

[net-next PATCH v4 08/13] net: netcp: ethss: re-use stats handling code for 2u hardware

2018-04-17 Thread Murali Karicheri
The stats block in 2u cpsw hardware is similar to the one on nu and hence handle it in a similar way by using a macro that includes 2u hardware as well. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 2 +- 1 file changed, 1 insertion

[net-next PATCH v4 11/13] net: netcp: support probe deferral

2018-04-17 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/d

[net-next PATCH v4 02/13] soc: ti: K2G: provide APIs to support driver probe deferral

2018-04-17 Thread Murali Karicheri
driver, needs to defer probe until knav devices are probed and ready to service. To do this, add an API to query the device ready status from the knav dma and qmss devices. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/soc/ti/knav_dma.c| 8 drivers/

[net-next PATCH v4 01/13] soc: ti: K2G: enhancement to support QMSS in K2G NAVSS

2018-04-17 Thread Murali Karicheri
with index less than regions0_size is in region 0. So update the size accordingly in the regions0_size bits of the linking ram size 0 register. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: WingMan Kwok <w-kw...@ti.com> Reviewed-by: Rob Herring <r...@kernel.o

[net-next PATCH v4 09/13] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-04-17 Thread Murali Karicheri
The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali

[net-next PATCH v4 12/13] net: netcp: add api to support set rx mode in netcp modules

2018-04-17 Thread Murali Karicheri
patch. Currently rx modes supported are PROMISCUOUS and NON_PROMISCUOUS modes. Signed-off-by: WingMan Kwok <w-kw...@ti.com> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 1 + drivers/net/ethernet/ti/netcp_core.c | 19 ++

[net-next PATCH v4 06/13] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-04-17 Thread Murali Karicheri
Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drive

[net-next PATCH v4 05/13] net: netcp: ethss: add support for handling rgmii link interface

2018-04-17 Thread Murali Karicheri
2u cpsw hardware on K2G uses rgmii link to interface with Phy. So add support for this interface in the code so that driver can be re-used for 2u hardware. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 2 ++ drivers/net/ether

[net-next PATCH v4 13/13] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-17 Thread Murali Karicheri
scuous mode, ALE will not flood all unicast packets to host port, while in promiscuous mode, it will pass all received unicast packets to host port. Signed-off-by: WingMan Kwok <w-kw...@ti.com> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/

[net-next PATCH v4 03/13] net: netcp: ethss: use macro for checking ss_version consistently

2018-04-17 Thread Murali Karicheri
similar issue with checking XBE version by re-using existing macro IS_SS_ID_XGBE(). Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/net/et

Re: Enable and configure storm prevention in a network device

2018-04-09 Thread Murali Karicheri
Andrew, On 04/06/2018 10:30 AM, Andrew Lunn wrote: > On Thu, Apr 05, 2018 at 03:35:06PM -0700, Florian Fainelli wrote: >> On 04/05/2018 01:20 PM, David Miller wrote: >>> From: Murali Karicheri <m-kariche...@ti.com> >>> Date: Thu, 5 Apr 2018 16:14:49 -0400

Re: Enable and configure storm prevention in a network device

2018-04-09 Thread Murali Karicheri
On 04/05/2018 06:35 PM, Florian Fainelli wrote: > On 04/05/2018 01:20 PM, David Miller wrote: >> From: Murali Karicheri <m-kariche...@ti.com> >> Date: Thu, 5 Apr 2018 16:14:49 -0400 >> >>> Is there a standard way to implement and configure storm prevention >&

Enable and configure storm prevention in a network device

2018-04-05 Thread Murali Karicheri
packets allowed in a certain period of time. Is there a standard way of passing this information from user space to driver? Thanks in advance for your input! -- Murali Karicheri Linux Kernel, Keystone

Re: [net-next 0/2] Add promiscous mode support in k2g network driver

2018-04-02 Thread Murali Karicheri
On 04/02/2018 12:28 PM, David Miller wrote: > From: Murali Karicheri <m-kariche...@ti.com> > Date: Mon, 2 Apr 2018 12:17:17 -0400 > >> This patch adds support for promiscuous mode in network driver for K2G >> SoC. This depends on v3 of my series at >> htt

Re: [net-next 2/2] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-02 Thread Murali Karicheri
Andrew, Thanks for reviewing this! On 04/02/2018 12:47 PM, Andrew Lunn wrote: > On Mon, Apr 02, 2018 at 12:17:19PM -0400, Murali Karicheri wrote: >> +static int gbe_set_rx_mode(void *intf_priv, bool promisc) >> +{ >> +struct gbe_intf *gbe_intf = intf_priv; >> +

[net-next 2/2] net: netcp: ethss: k2g: add promiscuous mode support

2018-04-02 Thread Murali Karicheri
scuous mode, ALE will not flood all unicast packets to host port, while in promiscuous mode, it will pass all received unicast packets to host port. Signed-off-by: WingMan Kwok <w-kw...@ti.com> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/

[net-next 0/2] Add promiscous mode support in k2g network driver

2018-04-02 Thread Murali Karicheri
This patch adds support for promiscuous mode in network driver for K2G SoC. This depends on v3 of my series at https://www.spinics.net/lists/kernel/msg2765942.html I plan to fold this to the above series and submit again when the net-next merge windows opens. At this time, please review and let

[net-next 1/2] net: netcp: add api to support set rx mode in netcp modules

2018-04-02 Thread Murali Karicheri
patch. Currently rx modes supported are PROMISCUOUS and NON_PROMISCUOUS modes. Signed-off-by: WingMan Kwok <w-kw...@ti.com> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 1 + drivers/net/ethernet/ti/netcp_core.c | 19 ++

Re: [net-next PATCH v3 00/11] Add support for netcp driver on K2G SoC

2018-04-02 Thread Murali Karicheri
On 04/02/2018 10:40 AM, David Miller wrote: > > The net-next tree is closed, please resubmit this after the merge window and > the net-next tree is open back up again. > Ok. Will do. Thanks -- Murali Karicheri Linux Kernel, Keystone

[net-next PATCH v3 05/11] net: netcp: ethss: add support for handling sgmii link interface

2018-04-02 Thread Murali Karicheri
2u cpsw hardware on K2G uses sgmii link to interface with Phy. So add support for this interface in the code so that drover can be re-used for 2u hardware. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 2 ++ drivers/net/ether

[net-next PATCH v3 03/11] net: netcp: ethss: use macro for checking ss_version consistently

2018-04-02 Thread Murali Karicheri
similar issue with checking XBE version by re-using existing macro IS_SS_ID_XGBE(). Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/net/et

[net-next PATCH v3 08/11] net: netcp: ethss: re-use stats handling code for 2u hardware

2018-04-02 Thread Murali Karicheri
The stats block in 2u cpsw hardware is similar to the one on nu and hence handle it in a similar way by using a macro that includes 2u hardware as well. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 2 +- 1 file changed, 1 insertion

[net-next PATCH v3 07/11] net: netcp: ethss: map vlan priorities to zero flow

2018-04-02 Thread Murali Karicheri
The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ether

[net-next PATCH v3 01/11] soc: ti: K2G: enhancement to support QMSS in K2G NAVSS

2018-04-02 Thread Murali Karicheri
with index less than regions0_size is in region 0. So update the size accordingly in the regions0_size bits of the linking ram size 0 register. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: WingMan Kwok <w-kw...@ti.com> --- .../bindings/soc/ti/keystone-navi

[net-next PATCH v3 00/11] Add support for netcp driver on K2G SoC

2018-04-02 Thread Murali Karicheri
Andrew Lunn and Grygorii Strashko against v2. v2 - Addressed following comments on initial version - split patch 3/5 to multiple patches from Andrew Lunn Murali Karicheri (11): soc: ti: K2G: enhancement to support QMSS in K2G NAVSS soc: ti: K2G: provide APIs to support driver probe

[net-next PATCH v3 09/11] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-04-02 Thread Murali Karicheri
The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali

[net-next PATCH v3 02/11] soc: ti: K2G: provide APIs to support driver probe deferral

2018-04-02 Thread Murali Karicheri
driver, needs to defer probe until knav devices are probed and ready to service. To do this, add an API to query the device ready status from the knav dma and qmss devices. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/soc/ti/knav_dma.c| 8 drivers/

[net-next PATCH v3 10/11] Revert "net: netcp: remove dead code from the driver"

2018-04-02 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/

[net-next PATCH v3 04/11] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-04-02 Thread Murali Karicheri
As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make call to gbe_sgmii_config() conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/et

[net-next PATCH v3 11/11] net: netcp: support probe deferral

2018-04-02 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/d

[net-next PATCH v3 06/11] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-04-02 Thread Murali Karicheri
Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drive

Re: [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-03-29 Thread Murali Karicheri
t; something which is not RGMII? > Ok. Make sense. > Andrew > -- Murali Karicheri Linux Kernel, Keystone

Re: [net-next PATCH v2 05/10] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-03-29 Thread Murali Karicheri
On 03/27/2018 01:29 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:44PM -0400, Murali Karicheri wrote: >> Introduce rgmii link status to handle link state events for 2u >> cpsw hardware on K2G. >> >> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> &

Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-29 Thread Murali Karicheri
On 03/27/2018 01:18 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: >> As a preparatory patch to add support for 2u cpsw hardware found on >> K2G SoC, make call to gbe_sgmii_config() conditional. This is required >> since 2u uses RG

Re: [net-next,v2,01/10] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-29 Thread Murali Karicheri
0,6 +1749,10 @@ static int knav_queue_probe(struct platform_device >> *pdev) >> return -ENOMEM; >> } >> >> +match = of_match_device(of_match_ptr(keystone_qmss_of_match), dev); >> +if (match && match->data) >> +kdev->version = QMSS_LITE; > > if (match) > kdev->version = match->data; > else > error? Similar to above. This private memory is allocated using kzalloc which initializes everything to zero. So the else part is unnecessary. Murali > [...] > -- Murali Karicheri Linux Kernel, Keystone

Re: [net-next,v2,01/10] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-29 Thread Murali Karicheri
Hi Grygorii, Thanks for reviewing this! On 03/28/2018 03:01 PM, Grygorii Strashko wrote: > Hi Murali, > > On 03/27/2018 11:31 AM, Murali Karicheri wrote: >> Navigator Subsystem (NSS) available on K2G SoC has a cut down >> version of QMSS with less number of queues,

Re: [net-next PATCH v2 05/10] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-03-27 Thread Murali Karicheri
On 03/27/2018 01:29 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:44PM -0400, Murali Karicheri wrote: >> Introduce rgmii link status to handle link state events for 2u >> cpsw hardware on K2G. >> >> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> &

Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-27 Thread Murali Karicheri
On 03/27/2018 01:18 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: >> As a preparatory patch to add support for 2u cpsw hardware found on >> K2G SoC, make call to gbe_sgmii_config() conditional. This is required >> since 2u uses RG

Re: [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-27 Thread Murali Karicheri
On 03/27/2018 01:13 PM, Andrew Lunn wrote: > On Tue, Mar 27, 2018 at 12:31:42PM -0400, Murali Karicheri wrote: >> As a preparatory patch to add support for 2u cpsw hardware found on >> K2G SoC, make call to gbe_sgmii_config() conditional. This is required >> since 2u uses RG

[net-next PATCH v2 00/10] Add support for netcp driver on K2G SoC

2018-03-27 Thread Murali Karicheri
) is at https://pastebin.ubuntu.com/p/6Vh55DW8vT/ This series applies to net-next master branch. Change history: v2 - Addressed following comments on initial version - split patch 3/5 to multiple patches from Andrew Lunn Murali Karicheri (10): soc: ti: K2G: enhancement to support QMSS in NSS soc

[net-next PATCH v2 05/10] net: netcp: ethss: use rgmii link status for 2u cpsw hardware

2018-03-27 Thread Murali Karicheri
Introduce rgmii link status to handle link state events for 2u cpsw hardware on K2G. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/drive

[net-next PATCH v2 07/10] net: netcp: ethss: re-use stats handling code for 2u hardware

2018-03-27 Thread Murali Karicheri
The stats block in 2u cpsw hardware is similar to the one on nu and hence handle it in a similar way by using a macro that includes 2u hardware as well. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 2 +- 1 file changed, 1 insertion

[net-next PATCH v2 02/10] soc: ti: K2G: provide APIs to support driver probe deferral

2018-03-27 Thread Murali Karicheri
driver, needs to defer probe until knav devices are probed and ready to service. To do this, add an API to query the device ready status from the knav dma and qmss devices. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/soc/ti/knav_dma.c| 8 drivers/

[net-next PATCH v2 06/10] net: netcp: ethss: map vlan priorities to zero flow

2018-03-27 Thread Murali Karicheri
The driver currently support only vlan priority zero. So map the vlan priorities to zero flow in hardware. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_ethss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ether

[net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional

2018-03-27 Thread Murali Karicheri
As a preparatory patch to add support for 2u cpsw hardware found on K2G SoC, make call to gbe_sgmii_config() conditional. This is required since 2u uses RGMII interface instead of SGMII and to allow for driver re-use. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/et

[net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes

2018-03-27 Thread Murali Karicheri
The phy used for K2G allows for internal delays to be added optionally to the clock circuitry based on board desing. To add this support, enhance the driver to use of_get_phy_mode() to read the phy-mode from the phy device and pass the same to phy through of_phy_connect(). Signed-off-by: Murali

[net-next PATCH v2 10/10] net: netcp: support probe deferral

2018-03-27 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/d

[net-next PATCH v2 04/10] net: netcp: ethss: add support for handling sgmii link interface

2018-03-27 Thread Murali Karicheri
2u cpsw hardware on K2G uses sgmii link to interface with Phy. So add support for this interface in the code so that drover can be re-used for 2u hardware. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 2 ++ drivers/net/ether

[net-next PATCH v2 01/10] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-27 Thread Murali Karicheri
escriptors with index less than regions0_size is in region 0. So update the size accordingly in the regions0_size bits of the linking ram size 0 register. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: WingMan Kwok <w-kw...@ti.com> --- .../bindings/soc/ti/keyst

[net-next PATCH v2 09/10] Revert "net: netcp: remove dead code from the driver"

2018-03-27 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/

Re: [net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral

2018-03-27 Thread Murali Karicheri
ressed. Regards, Murali > If this was an old hardware which is slowly going away, it would not > be an issue. But it seems like there are new variants of the hardware > being released. So maybe you should go back and re-write the DMA > driver, rather than paper over the cracks? > > Andrew > -- Murali Karicheri Linux Kernel, Keystone

Re: [net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral

2018-03-27 Thread Murali Karicheri
Hello Andrew, On 03/26/2018 04:48 PM, Andrew Lunn wrote: > On Mon, Mar 26, 2018 at 04:15:09PM -0400, Murali Karicheri wrote: >> This patch provide APIs to allow client drivers to support >> probe deferral. On K2G SoC, devices can be probed only >> after the ti_sci_pm_dom

Re: [net-next PATCH 3/5] net: netcp: ethss enhancements to support 2u cpsw h/w on K2G SoC

2018-03-27 Thread Murali Karicheri
On 03/26/2018 04:28 PM, Andrew Lunn wrote: > On Mon, Mar 26, 2018 at 04:15:10PM -0400, Murali Karicheri wrote: >> K2G SoC uses 2u cpsw h/w. It uses RGMII instead of SGMII to interface with >> Phy. This patch enhances the driver to check RGMII status instead of SGMII >>

[net-next PATCH 4/5] Revert "net: netcp: remove dead code from the driver"

2018-03-26 Thread Murali Karicheri
As the probe sequence is not guaranteed contrary to the assumption of the commit 2d8e276a9030, same has to be reverted. commit 2d8e276a9030 ("net: netcp: remove dead code from the driver") Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/

[net-next PATCH 1/5] soc: ti: K2G: enhancement to support QMSS in NSS

2018-03-26 Thread Murali Karicheri
escriptors with index less than regions0_size is in region 0. So update the size accordingly in the regions0_size bits of the linking ram size 0 register. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: WingMan Kwok <w-kw...@ti.com> --- .../bindings/soc/ti/keyst

[net-next PATCH 3/5] net: netcp: ethss enhancements to support 2u cpsw h/w on K2G SoC

2018-03-26 Thread Murali Karicheri
to priority zero. Additionally, When a phy with rgmii interface requires internal delay, the same is set in the phy driver. To support such phy devices, add a phy-mode handling code in the driver using of_get_phy_mode() and pass the obtained phy mode to of_phy_connect() Signed-off-by: Murali

[net-next PATCH 0/5] Add support for netcp driver on K2G SoC

2018-03-26 Thread Murali Karicheri
) is at https://pastebin.ubuntu.com/p/6Vh55DW8vT/ This series applies to net-next master branch. Murali Karicheri (5): soc: ti: K2G: enhancement to support QMSS in NSS soc: ti: K2G: provide APIs to support driver probe deferral net: netcp: ethss enhancements to support 2u cpsw h/w on K2G SoC Revert

[net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral

2018-03-26 Thread Murali Karicheri
driver, needs to defer probe until knav devices are probed and ready to service. To do this, add an API to query the device ready status from the knav dma and qmss devices. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/soc/ti/knav_dma.c| 8 drivers/

[net-next PATCH 5/5] net: netcp: support probe deferral

2018-03-26 Thread Murali Karicheri
The netcp driver shouldn't proceed until the knav qmss and dma devices are ready. So return -EPROBE_DEFER if these devices are not ready. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_core.c | 4 1 file changed, 4 insertions(+) diff --git a/d

Linux bridge of hsr and Ethernet interface. Is this valid?

2017-10-06 Thread Murali Karicheri
a bridge. So your expert opinion is needed. Thanks. -- Murali Karicheri Linux Kernel, Keystone

Re: skb allocation from interrupt handler?

2017-08-09 Thread Murali Karicheri
Hi David, On 08/08/2017 07:00 PM, David Miller wrote: > From: Murali Karicheri <m-kariche...@ti.com> > Date: Tue, 8 Aug 2017 18:17:52 -0400 > >> Is there an skb_alloc function that can be used from interrupt handler? >> Looks like netdev_alloc_skb() >> can't be

Re: skb allocation from interrupt handler?

2017-08-09 Thread Murali Karicheri
;stats.rx_bytes += pkt_info.length; ndev->stats.rx_packets++; Also want to know if there is a real SKB alloc function that can be used from hard irq context. -- Murali Karicheri Linux Kernel, Keystone

skb allocation from interrupt handler?

2017-08-08 Thread Murali Karicheri
+0x374/0x554 [prueth]) [ 652.481793] [] (emac_rx_hardirq [prueth]) from [] (__handle_irq_event_percpu+0x9c/0x128) This is running under RT kernel off 4.9.y -- Murali Karicheri Linux Kernel, Keystone

[net-next PATCH] hsr: fix coding style issues

2017-06-21 Thread Murali Karicheri
This fix coding style issues detected by running checkpatch.pl -f option on files under net/hsr. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- - applies to net-next/master - Test logs at http://pastebin.ubuntu.com/24917637/ net/hsr/hsr_device.c | 49 +---

[net v1 PATCH] hsr: fix incorrect warning

2017-06-12 Thread Murali Karicheri
[] (mld_sendpack+0x420/0x744) As this is an expected path to hsr_get_node() with frame coming from the master interface, add a check to ensure packet is not from the master port and then warn. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- v1 - sending as a separate patch to apply

Re: [PATCH 1/2] hsr: fix coding style issues

2017-06-12 Thread Murali Karicheri
vel, > how it is doing it, and why it is doing it that way. > > For this, submit the erroneous warning removal against 'net' as a single > patch. And then once that propagates into the 'net-next' tree you can > submit the coding style cleanups against 'net-next', thanks. > Thanks. Wi

[PATCH 1/2] hsr: fix coding style issues

2017-06-05 Thread Murali Karicheri
This fix coding style issues detected by running checkpatch.pl -f option on files under net/hsr. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- Logs at http://pastebin.ubuntu.com/24787763/ net/hsr/hsr_device.c | 55 ++-- net/hsr/hsr_forward.c

[PATCH 2/2] hsr: fix incorrect warning

2017-06-05 Thread Murali Karicheri
[] (mld_sendpack+0x420/0x744) As this is an expected path to hsr_get_node() with frame coming from the master interface, add a check to ensure packet is not from the master port and then warn. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- Logs at http://pastebin.ubuntu.com/24

Re: IGMP on IPv6

2017-04-25 Thread Murali Karicheri
On 04/18/2017 06:37 PM, Cong Wang wrote: > On Tue, Apr 18, 2017 at 10:20 AM, Murali Karicheri <m-kariche...@ti.com> > wrote: >> On 04/18/2017 01:12 PM, Murali Karicheri wrote: >>> On 04/17/2017 05:38 PM, Cong Wang wrote: >>>> Hello, >>>> >&g

Re: IGMP on IPv6

2017-04-18 Thread Murali Karicheri
On 04/18/2017 01:12 PM, Murali Karicheri wrote: > On 04/17/2017 05:38 PM, Cong Wang wrote: >> Hello, >> >> On Thu, Apr 13, 2017 at 9:36 AM, Murali Karicheri <m-kariche...@ti.com> >> wrote: >>> On 03/22/2017 11:04 AM, Murali Karicheri wrote: >>

Re: IGMP on IPv6

2017-04-18 Thread Murali Karicheri
On 04/17/2017 05:38 PM, Cong Wang wrote: > Hello, > > On Thu, Apr 13, 2017 at 9:36 AM, Murali Karicheri <m-kariche...@ti.com> wrote: >> On 03/22/2017 11:04 AM, Murali Karicheri wrote: >>> This is going directly to the slave Ethernet interface. >>&

Re: IGMP on IPv6

2017-04-13 Thread Murali Karicheri
On 03/22/2017 11:04 AM, Murali Karicheri wrote: > Hi Liu, > > I saw that you have sent patches to the list for IGMP and have a question on > IGMP on IPv6. > Hope you can clarify. I have posted the question already to the list and is > reproduced > below. Let me know

IGMP on IPv6

2017-03-22 Thread Murali Karicheri
00 01 01 This is going directly to the slave Ethernet interface. When I put a WARN_ONCE, I found this is coming directly from mld_ifc_timer_expire() -> mld_sendpack() -> ip6_output() Do you think this is fixed in latest kernel at master? If so, could you point me to some commits.

IPv6 IGMP issue in v4.4.44 ??

2017-03-21 Thread Murali Karicheri
to the slave Ethernet interface. When I put a WARN_ONCE, I found this is coming directly from mld_ifc_timer_expire() -> mld_sendpack() -> ip6_output() Do you think this is fixed in latest kernel at master? If so, could you point me to some commits. Thanks -- Murali Karicheri Linux Kernel, Keystone

Re: Linux HSR driver question

2017-02-13 Thread Murali Karicheri
On 02/13/2017 10:38 AM, Arvid Brodin wrote: > On 2017-02-09 21:32, Murali Karicheri wrote: >> Hi Arvid, >> >> While I work to add PRP support to the existing Linux HSR driver, I came >> across >> a piece of code related to prune node function. The hsr_

Linux HSR driver question

2017-02-09 Thread Murali Karicheri
sabled? -- Murali Karicheri Linux Kernel, Keystone

Re: iproute2: using .maxattr = IFLA_VLAN_MAX??

2017-01-26 Thread Murali Karicheri
...@trash.net > ... > */ > > Regards, > Rami Rosen > Hi, Rami, Thanks for confirming. I will send out a patch for fixing this when I get a chance to test hsr for my work in the next few days. -- Murali Karicheri Linux Kernel, Keystone

iproute2: using .maxattr = IFLA_VLAN_MAX??

2017-01-23 Thread Murali Karicheri
.print_opt = hsr_print_opt, .print_help = hsr_print_help, }; This appears to be a cut-n-paste bug as the source is based on ip/iplink_vlan.c and should be fixed to IFLA_HSR_MAX. If yes, I will send a patch for this. Thanks. -- Murali Karicheri Linux Kernel, Keystone

[PATCH] net: phy: dp83867: allow RGMII_TXID/RGMII_RXID interface types

2017-01-13 Thread Murali Karicheri
bindings. Also update the DT document accordingly. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- - I had sent this earlier and some how it didn't get through and I haven't seen any comment for this. So sending this again. - Appli

Marvell Phy (1510) issue since v4.7 kernel

2017-01-09 Thread Murali Karicheri
add the below HACK, this works fine. commit e5bd8bfe7f544df03772c094331bb27e1a5a5600 Author: Murali Karicheri <m-kariche...@ti.com> Date: Fri Jan 6 12:22:13 2017 -0500 TEMP: work around in marvel Phy driver for u-boot dhcp timeout Signed-off-by: Murali Karicheri <m-kariche.

[net-next v1 6/8] net: netcp: ale: update to support unknown vlan controls for NU switch

2017-01-06 Thread Murali Karicheri
, not just 3 port. The version mask is 3 bits in NU Switch ALE vs 8 bits on other ALE types. While at it, change the debug print to info print so that ALE version gets displayed in boot log. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com>

[net-next v1 3/8] net: netcp: store network statistics in 64 bits

2017-01-06 Thread Murali Karicheri
t;m-scher...@ti.com> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 18 ++ drivers/net/ethernet/ti/netcp_core.c | 68 +--- 2 files changed, 74 insertions(+

[net-next v1 1/8] net: netcp: extract eflag from desc for rx_hook handling

2017-01-06 Thread Murali Karicheri
processing. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 1 + drivers/net/ethernet/ti/netcp_core.c | 20 +--- include/linux/soc/ti/knav_dma.h | 2 ++ 3 files changed, 20 insertions(+), 3 deletions(-) diff --git a/d

[net-next v1 5/8] net: netcp: use hw capability to remove FCS word from rx packets

2017-01-06 Thread Murali Karicheri
Some of the newer Ethernet switch hw (such as that on k2e/l/g) can strip the Etherenet FCS from packet at the port 0 egress of the switch. So use this capability instead of doing it in software. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek.

[net-next v1 8/8] net: netcp: ale: add proper ale entry mask bits for netcp switch ALE

2017-01-06 Thread Murali Karicheri
in the macros. The parameter nu_switch_ale is configured by the caller driver to indicate the ALE is for that switch and is used in the ALE driver to do customization as needed. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/net

[net-next v1 7/8] net: netcp: ale: use ale_status to size the ale table

2017-01-06 Thread Murali Karicheri
to 2048 per User guide http://www.ti.com/lit/ug/spruhj5/spruhj5.pdf Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/net/ethernet/ti/cpsw_ale.c| 31 ++- drivers/net/ethernet/ti/netcp_ethss.c

[net-next v1 2/8] net: netcp: remove the redundant memmov()

2017-01-06 Thread Murali Karicheri
The psdata is populated with command data by netcp modules to the tail of the buffer and set_words() copy the same to the front of the psdata. So remove the redundant memmov function call. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> --- drivers/net/ethernet/ti/netcp_core

[net-next v1 4/8] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY

2017-01-06 Thread Murali Karicheri
Currently to parse phy-handle, driver doesn't check if the interface is MAC to PHY. This patch add this check for all MAC to PHY interface types supported by the driver. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/net

[net-next v1 0/8] netcp: enhancements and minor fixes

2017-01-06 Thread Murali Karicheri
in 64 bits Murali Karicheri (7): net: netcp: extract eflag from desc for rx_hook handling net: netcp: remove the redundant memmov() net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY net: netcp: use hw capability to remove FCS word from rx packets net: netcp: ale

Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap

2017-01-05 Thread Murali Karicheri
On 01/05/2017 03:42 PM, Murali Karicheri wrote: > Rob, > > On 12/22/2016 04:24 PM, Rob Herring wrote: >> On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >>> From: WingMan Kwok <w-kw...@ti.com> >>> >>> 10gbe phy driver needs to

Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap

2017-01-05 Thread Murali Karicheri
Rob, On 12/22/2016 04:24 PM, Rob Herring wrote: > On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >> From: WingMan Kwok <w-kw...@ti.com> >> >> 10gbe phy driver needs to access the 10gbe subsystem control >> register during phy initialization. T

Re: [PATCH net-next 00/10] netcp: enhancements and minor fixes

2016-12-21 Thread Murali Karicheri
David, On 12/20/2016 07:03 PM, David Miller wrote: > > The net-next tree is not open, do not resubmit this series until it > is open again. > > Thanks. > Ok. Thanks -- Murali Karicheri Linux Kernel, Keystone

[PATCH net-next 06/10] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY

2016-12-20 Thread Murali Karicheri
Currently to parse phy-handle, driver doesn't check if the interface is MAC to PHY. This patch add this check for all MAC to PHY interface types supported by the driver. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/net

[PATCH net-next 00/10] netcp: enhancements and minor fixes

2016-12-20 Thread Murali Karicheri
This series is for net-next. This propagates enhancements and minor bug fixes from internal version of the driver to keep the upstream in sync. Please review and apply if this looks good. Tested on all of K2HK/E/L boards. Thanks Murali Karicheri Michael Scherban (1): net: netcp: store network

[PATCH net-next 02/10] net: netcp: ethss: add support of 10gbe pcsr link status

2016-12-20 Thread Murali Karicheri
hernet link is up or not depends also on the status of the block-lock bit of the PCSR. This patch adds the checking of that bit in order to determine the link status. Signed-off-by: WingMan Kwok <w-kw...@ti.com> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by:

[PATCH net-next 05/10] net: netcp: store network statistics in 64 bits

2016-12-20 Thread Murali Karicheri
t;m-scher...@ti.com> Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Signed-off-by: Sekhar Nori <nsek...@ti.com> --- drivers/net/ethernet/ti/netcp.h | 18 ++ drivers/net/ethernet/ti/netcp_core.c | 68 +--- 2 files changed, 74 insertions(+

  1   2   >