Re: [PATCH 1/3] mv643xx fixes - Disable interrupts on all ports during initialization

2006-06-27 Thread Nathaniel Case
On Tue, 2006-06-27 at 10:16 -0500, John Haller wrote: > Brent Cook wrote: > > This patch disable interrupts on all ports during initialization. The > > current > > assumes that the firmware has already disabled all interrupts on all ports. > > We have encountered some boards that do not always d

Re: [PATCH 1/2] PHYLIB: Add get_link ethtool helper function

2006-06-12 Thread Nathaniel Case
On Sun, 2006-06-11 at 12:13 -0400, Jeff Garzik wrote: > > This adds a phy_ethtool_get_link() function along the same lines as > > phy_ethtool_gset(). This provides drivers utilizing PHYLIB an > > alternative to using ethtool_op_get_link(). This is more desirable > > since the "Link detected" fiel

Re: [PATCH 2/2] PHYLIB/gianfar: Use phy_ethtool_get_link() for get_link op

2006-06-08 Thread Nathaniel Case
This patch makes the gianfar ethtool code use phy_ethtool_get_link() instead of ethtool_op_get_link(). Signed-off-by: Nate Case <[EMAIL PROTECTED]> --- --- a/drivers/net/gianfar_ethtool.c 2006-06-05 11:27:19.0 -0500 +++ b/drivers/net/gianfar_ethtool.c 2006-06-04 19:31:01.

Re: [PATCH 2/2] PHYLIB/gianfar: Use phy_ethtool_get_link() for get_link op

2006-06-08 Thread Nathaniel Case
On Thu, 2006-06-08 at 10:58 -0400, Jeff Garzik wrote: > > +static u32 gfar_get_link(struct net_device *dev) > > +{ > > + struct gfar_private *priv = netdev_priv(dev); > > + struct phy_device *phydev = priv->phydev; > > + > > + if (NULL == phydev) > > + return -ENODEV; > > NAK, retu

[PATCH 1/2] PHYLIB: Add get_link ethtool helper function

2006-06-05 Thread Nathaniel Case
This adds a phy_ethtool_get_link() function along the same lines as phy_ethtool_gset(). This provides drivers utilizing PHYLIB an alternative to using ethtool_op_get_link(). This is more desirable since the "Link detected" field in ethtool would actually reflect the state of the PHY register. Pa

[PATCH 2/2] PHYLIB/gianfar: Use phy_ethtool_get_link() for get_link op

2006-06-05 Thread Nathaniel Case
This patch makes the gianfar ethtool code use phy_ethtool_get_link() instead of ethtool_op_get_link(). Patch depends on previous one (1/2). Signed-off-by: Nate Case <[EMAIL PROTECTED]> --- --- a/drivers/net/gianfar_ethtool.c 2006-06-05 11:27:19.0 -0500 +++ b/drivers/net/gianfar_etht

[PATCH 0/2] PHYLIB: Fix forcing mode reduction

2006-06-05 Thread Nathaniel Case
On Mon, 2006-06-05 at 17:08 -0500, Andy Fleming wrote: > Looks good. Feel free to send these patches to > netdev@vger.kernel.org (you may need to subscribe), and copy Jeff > Garzik <[EMAIL PROTECTED]>. This fixes a problem seen when a port without a cable connected would repeatedly print out