Re: [PATCH v4 2/2] Remove false-positive VLAs when using max()

warning, so this refactors these uses of max() to use the > new const_max() instead. > > [1] https://lkml.org/lkml/2018/3/7/621 For the btrfs portion : Reviewed-by: Nikolay Borisov <nbori...@suse.com> > > Signed-off-by: Kees Cook <keesc...@chromium.org> > --- > drivers/i

Re: [PATCH v2] lockdep: Fix fs_reclaim warning.

On 8.02.2018 13:43, Tetsuo Handa wrote: >>From 361d37a7d36978020dfb4c11ec1f4800937ccb68 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Thu, 8 Feb 2018 10:35:35 +0900 > Subject: [PATCH v2] lockdep: Fix fs_reclaim warning. > > Dave Jones reported

[PATCHv2] igmp: Fix regression caused by igmp sysctl namespace code.

...@gmail.com> Cc: <sta...@vger.kernel.org> # 4.6 Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- Cahnges since v1: * Moved the sysctl initialization to inet_init_net based on Eric Dumazet's suggestion net/ipv4/af_inet.c | 7 +++ net/ipv4/igmp.c| 6 -- 2 files

[PATCH] igmp: Fix regression caused by igmp sysctl namespace code.

uz...@gmail.com> Tested-by: Gerardo Exequiel Pozzi <vmlinuz...@gmail.com> Signed-off-by: Nikolay Borisov <nbori...@suse.com> Cc: <sta...@vger.kernel.org> # 4.6 --- net/ipv4/igmp.c | 6 -- net/ipv4/tcp_ipv4.c | 6 ++ 2 files changed, 6 insertions(+), 6 deletions

Re: net: BUG in unix_notinflight

>> >> >> New report from linux-next/c0b7b2b33bd17f7155956d0338ce92615da686c9 >> >> [ cut here ] >> kernel BUG at net/unix/garbage.c:149! >> invalid opcode: [#1] SMP KASAN >> Dumping ftrace buffer: >>(ftrace buffer empty) >> Modules linked in: >> CPU: 0 PID: 1806

Re: [PATCH] ipv4: Namespaceify tcp_tw_reuse knob

On 24.12.2016 14:43, Haishuang Yan wrote: > Signed-off-by: Haishuang Yan <yanhaishu...@cmss.chinamobile.com> Reviewed-by: Nikolay Borisov <n.borisov.l...@gmail.com>

Re: kernel BUG at net/unix/garbage.c:149!"

[Added Dave Miller to see what's the status of this patch] On 08/30/2016 12:18 PM, Miklos Szeredi wrote: > On Tue, Aug 30, 2016 at 12:37 AM, Miklos Szeredi wrote: >> On Sat, Aug 27, 2016 at 11:55 AM, Miklos Szeredi wrote: > >> crash> list -H

Re: kernel BUG at net/unix/garbage.c:149!"

On 08/30/2016 12:18 PM, Miklos Szeredi wrote: > On Tue, Aug 30, 2016 at 12:37 AM, Miklos Szeredi wrote: >> On Sat, Aug 27, 2016 at 11:55 AM, Miklos Szeredi wrote: > >> crash> list -H gc_inflight_list unix_sock.link -s unix_sock.inflight | >> grep

Re: kernel BUG at net/unix/garbage.c:149!"

On Thu, Aug 25, 2016 at 12:40 AM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: > On 24.08.2016 16:24, Nikolay Borisov wrote: [SNIP] > > One commit which could have to do with that is > > commit fc64869c48494a401b1fb627c9ecc4e6c1d74b0d > Author: Andrey Ryabinin

kernel BUG at net/unix/garbage.c:149!"

Hello, I hit the following BUG: [1851513.239831] [ cut here ] [1851513.240079] kernel BUG at net/unix/garbage.c:149! [1851513.240313] invalid opcode: [#1] SMP [1851513.248320] CPU: 37 PID: 11683 Comm: nginx Tainted: G O 4.4.14-clouder3 #26

Slow veth performance over ipoib interface on 4.7.0 (and earlier) (Was Re: [IPOIB] Excessive TX packet drops due to IPOIB_MAX_PATH_REC_QUEUE)

On 08/01/2016 11:56 AM, Erez Shitrit wrote: > The GID (9000:0:2800:0:bc00:7500:6e:d8a4) is not regular, not from > local subnet prefix. > why is that? > So I managed to debug this and it tuns out the problem lies between veth and ipoib interaction: I've discovered the following strange thing.

ref count of ib_ipoib.ko not incremented when an ip address is set

Hello, I accidentally saw that even having an ip address on an ipoib interface doesn't increment the usage count of the ib_ipoib.ko module: ip a l dev ib0 14: ib0: mtu 65520 qdisc pfifo_fast state UP qlen 256 link/infiniband

Re: [PATCH 1/4] inotify: Add infrastructure to account inotify limits per-namespace

On 06/06/2016 11:05 AM, Cyrill Gorcunov wrote: > On Wed, Jun 01, 2016 at 10:52:57AM +0300, Nikolay Borisov wrote: >> This patch adds the necessary members to user_struct. The idea behind >> the solution is really simple - user the userns pointers as keys into >> a h

Re: [RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

On 06/03/2016 11:41 PM, Eric W. Biederman wrote: > Nikolay Borisov <ker...@kyup.com> writes: > >> On 06/02/2016 07:58 PM, Eric W. Biederman wrote: >>> >>> Nikolay please see my question for you at the end. > [snip] >>> All of that said the

Re: [RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

On 06/02/2016 07:58 PM, Eric W. Biederman wrote: > > Nikolay please see my question for you at the end. > > Jan Kara <j...@suse.cz> writes: > >> On Wed 01-06-16 11:00:06, Eric W. Biederman wrote: >>> Cc'd the containers list. >>>

Re: [RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

On 06/01/2016 07:00 PM, Eric W. Biederman wrote: > Cc'd the containers list. > > > Nikolay Borisov <ker...@kyup.com> writes: > >> Currently the inotify instances/watches are being accounted in the >> user_struct structure. This means that in setups where m

[PATCH 2/4] inotify: Convert inotify limits to be accounted per-realuser/per-namespace

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- fs/notify/inotify/inotify_fsnotify.c | 14 +- fs/notify/inotify/inotify_user.c | 23 +++ include/linux/sched.h| 2 -- 3 files changed, 28 insertions(+), 11 deletions(-) diff --gi

[RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

that building the kernel with !CONFIG_INOTIFY_USER doesn't fail (with patch 1 being applied). However, fdinfo.c doesn't really need inotify.h Nikolay Borisov (4): inotify: Add infrastructure to account inotify limits per-namespace inotify: Convert inotify limits to be accounted per-realuser/per

[PATCH 3/4] misc: Rename the HASH_SIZE macro

This change is required since the inotify-per-namespace code added hashtable.h to the include list of sched.h. This in turn causes compiler warnings since HASH_SIZE is being defined in multiple locations Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- fs/logfs

[PATCH 4/4] inotify: Don't include inotify.h when !CONFIG_INOTIFY_USER

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- fs/notify/fdinfo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c index fd98e5100cab..62068f89d144 100644 --- a/fs/notify/fdinfo.c +++ b/fs/notify/fdinfo.c @@ -13,7 +13,10 @@ #include #i

[PATCH 1/4] inotify: Add infrastructure to account inotify limits per-namespace

scenarios such as a single mapped user in a container deplete the inotify resources for all other users, which map to the exact same real user. Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- fs/notify/inotify/inotify.h | 68 fs/notify/i

Re: ipv6 not bringing up due to qdisc_tx_is_noop failing

On Wed, Mar 16, 2016 at 7:07 PM, Hannes Frederic Sowa <han...@stressinduktion.org> wrote: > Hello, Hi, > > On 16.03.2016 16:29, Nikolay Borisov wrote: >> >> I have stack traces which do show this sequence of events, so my >> questions now are: >> >>

ipv6 not bringing up due to qdisc_tx_is_noop failing

Hello Dave, I've been chasing a rather strange problem and I saw you were the person that authored most of the code involved so I'm addresing you, but will be happy to receive assistance from any one feeling knowledgeable enough on the issue. Basically I have an infiniband card on which I want

Re: [PATCH 0/4] Namespacify inet_peer_* sysctl knobs

On 02/17/2016 09:15 PM, Eric W. Biederman wrote: > Nikolay Borisov <ker...@kyup.com> writes: > >> This series make the inet_peer ttl sysctls to be namespace aware. >> >> Patch 1 adds a namespace association to the inet_peer_base struct, >> which in turn i

[PATCH 3/4] inetpeer: Namespacify inet_peer_minttl sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/ip.h | 1 - include/net/netns/ipv4.h | 1 + net/ipv4/inetpeer.c| 2 +- net/ipv4/sysctl_net_ipv4.c | 15 --- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/include/net/

[PATCH 4/4] inetpeer: Namespacify inet_peer_threshold sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/ip.h | 3 --- include/net/netns/ipv4.h | 1 + net/ipv4/inetpeer.c| 11 --- net/ipv4/sysctl_net_ipv4.c | 17 + 4 files changed, 14 insertions(+), 18 deletions(-) diff --git a/inclu

[PATCH 0/4] Namespacify inet_peer_* sysctl knobs

This series make the inet_peer ttl sysctls to be namespace aware. Patch 1 adds a namespace association to the inet_peer_base struct, which in turn is used to make the sysctls namespace aware. The rest of the patches are straightforward. Nikolay Borisov (4): inetpeer: Add net namespace

[PATCH 2/4] inetpeer: Namespacify inet_peer_maxttl sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/ip.h | 1 - include/net/netns/ipv4.h | 2 ++ net/ipv4/inetpeer.c| 2 +- net/ipv4/sysctl_net_ipv4.c | 15 --- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/include/net/

[PATCH 1/4] inetpeer: Add net namespace assosication in inet_peer_base

This is required so that the inet_peer_* sysctls can be namespacified Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/inetpeer.h | 1 + net/ipv4/route.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/net/inetpeer.h b/include/net/inetpeer.h index 235c78

Re: [PATCH] net: igmp: use IS_ENABLED(CONFIG_IP_MULTICAST) instead of ifdef

urn err; > @@ -2711,13 +2691,10 @@ static int igmp_mc_seq_show(struct seq_file *seq, > void *v) > char *querier; > long delta; > > -#ifdef CONFIG_IP_MULTICAST > - querier = IGMP_V1_SEEN(state->in_dev) ? "V1" : > + querier = !IS_ENABLED(CONFIG_IP_MULTICAST) ? "NONE" : > + IGMP_V1_SEEN(state->in_dev) ? "V1" : > IGMP_V2_SEEN(state->in_dev) ? "V2" : > "V3"; > -#else > - querier = "NONE"; > -#endif > > if (rcu_access_pointer(state->in_dev->mc_list) == im) { > seq_printf(seq, "%d\t%-10s: %5d %7s\n", > Reviewed-by: Nikolay Borisov <ker...@kyup.com>

[PATCH 3/6] ipv4: Namespacify ip_dynaddr sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/ip.h | 3 --- include/net/netns/ipv4.h | 2 ++ net/ipv4/af_inet.c | 10 ++ net/ipv4/sysctl_net_ipv4.c | 15 --- 4 files changed, 12 insertions(+), 18 deletions(-) diff --git a/inclu

[PATCH 1/6] ipv4: Namespaceify ip_default_ttl sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 1 + include/net/route.h | 5 ++--- net/bridge/netfilter/nft_reject_bridge.c | 8 +--- net/ipv4/ip_output.c | 3 --- net/ipv4/ip_sock

[PATCH 5/6] ipv4: namespacify ip fragment max dist sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/inet_frag.h | 1 + net/ipv4/ip_fragment.c | 25 + 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h index 12aac0fd6ee7..909972aa3acd

[PATCH 2/6] igmp: net: Move igmp namespace init to correct file

When igmp related sysctl were namespacified their initializatin was erroneously put into the tcp socket namespace constructor. This patch moves the relevant code into the igmp namespace constructor to keep things consistent. Also sprinkle some #ifdefs to silence warnings Signed-off-by: Nikolay

[PATCH 4/6] ipv4: namespacify ip_early_demux sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/ip.h | 3 --- include/net/netns/ipv4.h | 1 + net/ipv4/ip_input.c| 5 + net/ipv4/sysctl_net_ipv4.c | 15 --- net/ipv6/ip6_input.c | 2 +- 5 files changed, 11 insertions(+), 15 del

[PATCH 6/6] net: Export ip fragment sysctl to unprivileged users

Now that all the ip fragmentation related sysctls are namespaceified there is no reason to hide them anymore from "root" users inside containers. Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- net/ipv4/ip_fragment.c | 4 1 file changed, 4 deletions(-) diff

[PATCH 0/6] Namespacify various ip sysctl knobs

guards to silence compilation warnings. Finally, patch 5 exposes the ip fragmentation related sysctls since all of the knobs are namespaced. Nikolay Borisov (6): ipv4: Namespaceify ip_default_ttl sysctl knob igmp: net: Move igmp namespace init to correct file ipv4: Namespacify ip_dynaddr

Re: linux-next: build warning after merge of the net-next tree

On 02/15/2016 04:09 AM, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > net/ipv4/igmp.c: In function 'igmp_group_added': > net/ipv4/igmp.c:1227:14: warning: unused variable 'net'

[PATCH 2/4] igmp: Namespaceify igmp_max_msf sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/linux/igmp.h | 1 - include/net/netns/ipv4.h | 1 + net/ipv4/igmp.c| 5 + net/ipv4/ip_sockglue.c | 5 +++-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + 6

[PATCH 3/4] igmp: Namespaceify igmp_llm_reports sysctl knob

This was initially introduced in commit df2cf4a78e48 ("IGMP: Inhibit reports for local multicast groups") by defining the sysctl in the ipv4_net_table array, however it was never implemented to be namespace aware. Fix this by changing the code accordingly. Signed-off-by: Nikolay Bo

[PATCH 4/4] igmp: Namespacify igmp_qrv sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/linux/igmp.h | 2 -- include/net/netns/ipv4.h | 1 + net/ipv4/igmp.c| 29 + net/ipv4/sysctl_net_ipv4.c | 20 ++-- net/ipv4/tcp_ipv4.c| 1 + 5 files chang

[PATCH 1/4] igmp: Namespaceify igmp_max_memberships sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/linux/igmp.h | 1 - include/net/netns/ipv4.h | 2 ++ net/ipv4/igmp.c| 4 +--- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 2 ++ 5 files changed, 12 insertions(+), 11 del

[PATCH 0/4] Make igmp sysctl knobs namespace aware

the respective sysctl) so I don't think this is a huge loss. The third patch however, converts igmp_llm_reports which was already defined in the ipv4_net_table but wasn't using any of the net namespace infrastructure. Nikolay Borisov (4): igmp: Namespaceify igmp_max_memberships sysctl knob

[PATCH v2 3/4] igmp: Namespaceify igmp_llm_reports sysctl knob

From: Nikolay Borisov <n.bori...@siteground.com> This was initially introduced in df2cf4a78e488d26 ("IGMP: Inhibit reports for local multicast groups") by defining the sysctl in the ipv4_net_table array, however it was never implemented to be namespace aware. Fix this by c

[RESEND PATCH 1/9] ipv4: Namespaceify tcp syn retries sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 18 +- net/ipv4/tcp.c | 3 ++- net/ipv4/tcp_ipv4.c| 2 ++ net/ipv4/tcp_timer.c | 4 ++-- 6

[RESEND PATCH 2/9] ipv4: Namespaceify tcp synack retries sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h| 1 + include/net/tcp.h | 1 - net/ipv4/inet_connection_sock.c | 7 ++- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c | 1 + net/ipv4/tcp_t

[RESEND PATCH 0/9] Namespaceify more of the tcp sysctl knobs

and it is required to tune the tcp settings for each independently of the host node. I've split the patches to be per-sysctl but after the review if the outcome is positive I'm happy to either send it in one big blob or just. Nikolay Borisov (9): ipv4: Namespaceify tcp syn retries sysctl knob ipv4

[RESEND PATCH 9/9] ipv4: Namespaceify tcp_notsent_lowat sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 4 ++-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_output.c | 3 --- 5 files changed, 11 insertions(+), 12 del

[RESEND PATCH 6/9] ipv4: Namespaceify tcp_retries2 sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_output.c | 3 ++- net/ipv4/tcp_timer.c | 5 ++--- 6 files c

[RESEND PATCH 3/9] ipv4: Namespaceify tcp syncookies sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 - net/ipv4/syncookies.c | 4 +--- net/ipv4/sysctl_net_ipv4.c | 18 +- net/ipv4/tcp_input.c | 10 ++ net/ipv4/tcp_ipv4.c

[RESEND PATCH 5/9] ipv4: Namespaceify tcp_retries1 sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 16 net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_timer.c | 8 5 files changed, 14 insertions(+), 13 del

[RESEND PATCH 4/9] ipv4: Namespaceify tcp reordering sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 2 +- include/net/tcp.h | 4 +++- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp.c | 2 +- net/ipv4/tcp_input.c | 12 ++-- net/ipv4/tcp_ipv4.c| 2 +

[RESEND PATCH 7/9] ipv4: Namespaceify tcp_orphan_retries sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_timer.c | 3 +-- 5 files changed, 10 insertions(+), 10 del

[RESEND PATCH 8/9] ipv4: Namespaceify tcp_fin_timeout sysctl knob

Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 3 +-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp.c | 7 +++ net/ipv4/tcp_ipv4.c| 1 + 5 files changed, 13 insertions(+), 13 del

[PATCH 1/3] ipv4: Namespaceify tcp_keepalive_time sysctl knob

Different net namespaces might have different requirements as to the keepalive time of tcp sockets. This might be required in cases where different firewall rules are in place which require tcp timeout sockets to be increased/decreased independently of the host. Signed-off-by: Nikolay Borisov

[PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

sys wasn't cleaned in case nfnetlink_subsys_register failed. This patch adds the necessary cleanup routine call. Fixes: 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: Register pernet in first place') Signed-off-by: Nikolay Borisov <ke

Re: [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure

On 12/07/2015 02:29 PM, Sergei Shtylyov wrote: > Hello. > > On 12/07/2015 01:13 PM, Nikolay Borisov wrote: > >> Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: > >Double quotes please, that's what scripts/checkpatch.pl enforces now. > >&g

[BUG] Erroneous behavior in try_to_coalesce

Hello, Recently I observed 2 crashes on one of my server with the following backtraces: [22751.889645] [ cut here ] [22751.889660] WARNING: CPU: 38 PID: 12807 at net/core/skbuff.c:3498 skb_try_coalesce+0x34b/0x360() [22751.889661] Modules linked in: tcp_diag inet_diag

[PATCH v3] netfilter: ipset: Fix sleeping memory allocation in atomic context

type to GFP_ATOMIC, to correctly reflect that it is occuring in an atomic context. Fixes: 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type") Acked-by: Jozsef Kadlecsik <kad...@blackhole.kfki.hu> Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- Ch

[PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

FP_ATOMIC, to correctly reflect that it is occuring in an atomic context. Fixes: 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type") Acked-by: Jozsef Kadlecsik <kad...@blackhole.kfki.hu> Signed-off-by: Nikolay Borisov <ker...@kyup.com> --- Changes since V1: * Added

[PATCH] Fix sleeping memory allocation in atomic context

EL allows initiating direct reclaim thus potentially sleeping in the allocation path, this leads to the aforementioned splat. To fix it change that particular allocation type to GFP_ATOMIC, to correctly reflect that it is happening in an atomic context. Signed-off-by: Nikolay Borisov <ker

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

On 10/15/2015 04:32 PM, Eric Dumazet wrote: > On Thu, 2015-10-15 at 13:56 +0300, Nikolay Borisov wrote: >> Commit 00590fdd5be0 introduced RCU locking in list type and in >> doing so introduced a memory allocation in list_set_add, which >> results in the following splat

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

On 10/15/2015 05:32 PM, Eric Dumazet wrote: > On Thu, 2015-10-15 at 16:41 +0300, Nikolay Borisov wrote: >> >> On 10/15/2015 04:32 PM, Eric Dumazet wrote: >>> On Thu, 2015-10-15 at 13:56 +0300, Nikolay Borisov wrote: >>>> Commit 00590fdd5be0 introduced RCU lo

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

On Thu, Oct 15, 2015 at 9:46 PM, Eric Dumazet wrote: > On Thu, 2015-10-15 at 20:25 +0200, Jozsef Kadlecsik wrote: > >> Nikolay answered this pretty well: we wouldn't need the spinlock at all, >> because all commands are serialized anyway with the netlink mutex. But the >>