RE: [PATCH] net: ezchip: fix address space confusion in nps_enet.c

2015-12-08 Thread Noam Camus
>From: Arnd Bergmann [mailto:a...@arndb.de] >Sent: Tuesday, December 08, 2015 5:29 PM >To: David S. Miller >Cc: Noam Camus; Tal Zilcer; netdev@vger.kernel.org; >linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org >Subject: [PATCH] net: ezchip: fix address

Re: [PATCH 13/22] net: Fix dependencies for !HAS_IOMEM archs

2016-01-26 Thread Noam Camus
From: Richard Weinberger Sent: Tuesday, January 26, 2016 12:24 AM >Not every arch has io memory. >So, unbreak the build by fixing the dependencies. >Signed-off-by: Richard Weinberger >--- > drivers/net/ethernet/ezchip/Kconfig | 1 + > drivers/net/phy/Kconfig | 1 + > 2 files changed,

[v1 1/6] NET: nps_enet: replace use of cause register

2015-08-16 Thread Noam Camus
From: Noam Camus When interrupt is received we read directly from control register for RX/TX instead of reading cause register since this register fails to indicate TX done when TX interrupt is "edge mode". Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_ene

[v1 0/6] *** nps_enet fixups ***

2015-08-16 Thread Noam Camus
From: Noam Camus This patch set is a bunch of fixes to make nps_enet work correctly with all platforms, i.e. real device, emulation system, and simulation system. The main trigger for this patch set was that in our emulation system the TX end interrupt is "edge-sensitive" and therefore

[v1 6/6] NET: nps_enet: minor namespace cleanup

2015-08-16 Thread Noam Camus
From: Noam Camus We define buf_int_enable in the minimal namespace it is used. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet

[v1 5/6] NET: nps_enet: TX done acknowledge.

2015-08-16 Thread Noam Camus
From: Noam Camus This is needed for when TX done interrupt is in "level mode". For example it is true for some simulators of this device. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/d

[v1 3/6] NET: nps_enet: TX done race condition

2015-08-16 Thread Noam Camus
From: Noam Camus We need to set tx_skb pointer before send frame. If we receive interrupt before we set pointer we will try to free SKB with wrong pointer. Now we are sure that SKB pointer will never be NULL during handling TX done and check is removed. Signed-off-by: Noam Camus --- drivers

[v1 2/6] NET: nps_enet: reduce processing latency.

2015-08-16 Thread Noam Camus
From: Noam Camus TX handler is minimalistic and there is no need to schedule a NAPI job. Tx done will be processed during hardware interrupt context. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions

[v1 4/6] NET: nps_enet: drop control frames

2015-08-16 Thread Noam Camus
From: Noam Camus We set controller to drop control frames and not trying to pass them on. This is only needed for debug reasons. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net

RE: [v1 0/6] *** nps_enet fixups ***

2015-08-17 Thread Noam Camus
From: David Miller [mailto:da...@davemloft.net] Sent: Monday, August 17, 2015 8:36 PM > You should not move TX completion out of NAPI handling, NAPI poll is exactly > where it belongs. > > If you handle it in hardware interrupt context you have to use > dev_kfree_skb_irq() which defers the oper

[v2 0/5] *** nps_enet fixups ***

2015-08-19 Thread Noam Camus
From: Noam Camus Change v2 TX done is handled back with NAPI poll. Change v1 This patch set is a bunch of fixes to make nps_enet work correctly with all platforms, i.e. real device, emulation system, and simulation system. The main trigger for this patch set was that in our emulation system the

[v2 2/5] NET: nps_enet: TX done race condition

2015-08-19 Thread Noam Camus
From: Noam Camus We need to set tx_skb pointer before send frame. If we receive interrupt before we set pointer we will try to free SKB with wrong pointer. Now we are sure that SKB pointer will never be NULL during handling TX done and check is removed. Signed-off-by: Noam Camus --- drivers

[v2 1/5] NET: nps_enet: replace use of cause register

2015-08-19 Thread Noam Camus
From: Noam Camus When interrupt is received we read directly from control register for RX/TX instead of reading cause register since this register fails to indicate TX done when TX interrupt is "edge mode". Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_ene

[v2 3/5] NET: nps_enet: drop control frames

2015-08-19 Thread Noam Camus
From: Noam Camus We set controller to drop control frames and not trying to pass them on. This is only needed for debug reasons. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net

[v2 5/5] NET: nps_enet: minor namespace cleanup

2015-08-19 Thread Noam Camus
From: Noam Camus We define buf_int_enable in the minimal namespace it is used. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet

[v2 4/5] NET: nps_enet: TX done acknowledge.

2015-08-19 Thread Noam Camus
From: Noam Camus This is needed for when TX done interrupt is in "level mode". For example it is true for some simulators of this device. Signed-off-by: Noam Camus --- drivers/net/ethernet/ezchip/nps_enet.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/d

[PATCH v2] NET: Add ezchip ethernet driver

2015-06-11 Thread Noam Camus
-by: Noam Camus Signed-off-by: Tal Zilcer Acked-by: Alexey Brodkin --- .../devicetree/bindings/net/ezchip_enet.txt| 15 + drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/ezchip/Kconfig

[PATCH v3] NET: Add ezchip ethernet driver

2015-06-11 Thread Noam Camus
-by: Noam Camus Signed-off-by: Tal Zilcer Acked-by: Alexey Brodkin --- Chahges in patch v2,v3: 1) Did some renaming: a) EZCHIP_NPS_LAN to EZCHIP_NPS_MANAGEMENT_ENET b) nps_enet to nps_mgt_enet 2) Update GPL to version 2 3) Remove driver default configuration (y) 4) Change integer

[PATCH v4] NET: Add ezchip ethernet driver

2015-06-13 Thread Noam Camus
From: Noam Camus Simple LAN device for debug or management purposes. Device supports interrupts for RX and TX(completion). Device does not have DMA ability. Signed-off-by: Noam Camus Signed-off-by: Tal Zilcer Acked-by: Alexey Brodkin --- Change log for v4: 1) replace macros with generic ones

[PATCH v5] NET: Add ezchip ethernet driver

2015-06-16 Thread Noam Camus
From: Noam Camus Simple LAN device for debug or management purposes. Device supports interrupts for RX and TX(completion). Device does not have DMA ability. Signed-off-by: Noam Camus Signed-off-by: Tal Zilcer Acked-by: Alexey Brodkin --- Change log for v5: Basically its all based on Florian

RE: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-22 Thread Noam Camus
From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, June 21, 2015 7:22 PM > This builds with several warnings and also doesn't compile. > > drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_read_rx_fifo’: > drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from poi

[PATCH v6] NET: Add ezchip ethernet driver

2015-06-22 Thread Noam Camus
From: Noam Camus Simple LAN device for debug or management purposes. Device supports interrupts for RX and TX(completion). Device does not have DMA ability. Signed-off-by: Noam Camus Signed-off-by: Tal Zilcer Acked-by: Alexey Brodkin --- Change log for v6: Below changes are in response for

RE: [PATCH v5] NET: Add ezchip ethernet driver

2015-06-22 Thread Noam Camus
From: Mahesh Bandewar [mailto:mahe...@google.com] Sent: Monday, June 22, 2015 8:45 PM > > a/drivers/net/ethernet/ezchip/Kconfig > > b/drivers/net/ethernet/ezchip/Kconfig > > new file mode 100644 > > index 000..d031177 > > --- /dev/null > > +++ b/drivers/net/ethernet/ezchip/Kconfig > > @@ -0,

[PATCH v7] NET: Add ezchip ethernet driver

2015-06-23 Thread Noam Camus
From: Noam Camus Simple LAN device for debug or management purposes. Device supports interrupts for RX and TX(completion). Device does not have DMA ability. Signed-off-by: Noam Camus Signed-off-by: Tal Zilcer Acked-by: Alexey Brodkin --- Change log for v7: 1) Update nps_enet_open() comment

[PATCH] NET: Add ezchip ethernet driver

2015-06-09 Thread Noam Camus
-by: Noam Camus --- .../devicetree/bindings/net/ezchip_enet.txt| 15 + drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/ezchip/Kconfig| 30 + drivers/net/ethernet/ezchip/Makefile