[PATCH v2] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
arvell 88E6341 Family] (irq=63) Signed-off-by: Pali Rohár BugLink: https://github.com/globalscaletechnologies/linux/issues/1 Fixes: fee2d546414d ("net: phy: marvell: mv88e6390 temperature sensor reading") Reviewed-by: Marek Behún --- Changes since v1: * create direct mapping table between

Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
On Monday 12 April 2021 18:12:35 Andrew Lunn wrote: > On Mon, Apr 12, 2021 at 05:52:39PM +0200, Pali Rohár wrote: > > On Monday 12 April 2021 17:32:33 Andrew Lunn wrote: > > > > Anyway, now I'm looking at phy/marvell.c driver again and it supports > > > >

Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
On Monday 12 April 2021 17:32:33 Andrew Lunn wrote: > > Anyway, now I'm looking at phy/marvell.c driver again and it supports > > only 88E6341 and 88E6390 families from whole 88E63xxx range. > > > > So do we need to define for now table for more than > > MV88E6XXX_FAMILY_6341 and MV88E6XXX_FAMILY_

Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
On Monday 12 April 2021 16:44:11 Andrew Lunn wrote: > On Mon, Apr 12, 2021 at 03:34:47PM +0200, Pali Rohár wrote: > > On Monday 12 April 2021 15:15:07 Andrew Lunn wrote: > > > > +static u16 mv88e6xxx_physid_for_family(enum mv88e6xxx_family family); > > > > + &g

Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
On Monday 12 April 2021 16:30:03 Andrew Lunn wrote: > > > > +/* This table contains representative model for every family */ > > > > +static const enum mv88e6xxx_model family_model_table[] = { > > > > + [MV88E6XXX_FAMILY_6095] = MV88E6095, > > > > + [MV88E6XXX_FAMILY_6097] = MV88E6097,

Re: [PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
On Monday 12 April 2021 15:15:07 Andrew Lunn wrote: > > +static u16 mv88e6xxx_physid_for_family(enum mv88e6xxx_family family); > > + > > No forward declaration please. Move the code around. It is often best > to do that in a patch which just moves code, no other changes. It > makes it easier to re

[PATCH] net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-12 Thread Pali Rohár
[Marvell 88E6341 Family] (irq=63) Signed-off-by: Pali Rohár BugLink: https://github.com/globalscaletechnologies/linux/issues/1 Fixes: fee2d546414d ("net: phy: marvell: mv88e6390 temperature sensor reading") Reviewed-by: Marek Behún --- drivers/net/dsa/mv88e6xxx/chip.c | 56 +

[PATCH] ath9k: Fix kernel NULL pointer dereference during ath_reset_internal()

2021-04-02 Thread Pali Rohár
led [ 45.579924] CPU features: 0x00040002,200c [ 45.584416] Memory Limit: none [ 45.587564] Rebooting in 3 seconds.. Signed-off-by: Pali Rohár Cc: sta...@vger.kernel.org --- drivers/net/wireless/ath/ath9k/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-29 Thread Pali Rohár
On Friday 26 March 2021 11:43:10 Don Bollinger wrote: > > Hello Don! > > > > I have read whole discussion and your EEPROM patch proposal. But for me it > > looks like some kernel glue code for some old legacy / proprietary access > > method which does not have any usage outside of that old code. >

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-20 Thread Pali Rohár
Hello Don! I have read whole discussion and your EEPROM patch proposal. But for me it looks like some kernel glue code for some old legacy / proprietary access method which does not have any usage outside of that old code. Your code does not contain any quirks which are needed to read different E

Re: [PATCH AUTOSEL 5.11 16/67] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-03-05 Thread Pali Rohár
On Thursday 04 March 2021 17:33:01 Sasha Levin wrote: > On Thu, Feb 25, 2021 at 08:03:06PM +0100, Pali Rohár wrote: > > On Wednesday 24 February 2021 07:49:34 Sasha Levin wrote: > > > From: Pali Rohár > > > > > > [ Upstream commit f0b4f847673299577c29b71d3f3

Re: [PATCH AUTOSEL 5.11 16/67] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-02-25 Thread Pali Rohár
On Wednesday 24 February 2021 07:49:34 Sasha Levin wrote: > From: Pali Rohár > > [ Upstream commit f0b4f847673299577c29b71d3f3acd3c313d81b7 ] Hello! This commit requires also commit~1 from that patch series: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/c

Re: [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-14 Thread Pali Rohár
> According to Errata #23 "The per-CPU GbE interrupt is limited to Core > 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 > familly. > > This is correctly checked for RSS configuration, but the initial queue > mapping is still done by having the queues spread across all the CPU

Re: [PATCH v3] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR

2021-01-27 Thread Pali Rohár
On Tuesday 19 January 2021 21:18:29 Alejandro Colomar (man-pages) wrote: > Hi Pali, > > I was a patch for environ.7 while I found some pattern. > Please see below a minor fix. > > Thanks, > > Alex > > On 1/16/21 11:36 PM, Pali Rohár wrote: > > Unlike S

[PATCH v4 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-26 Thread Pali Rohár
06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár --- Changes in v4: * Rewritten the commit message by Marek's suggestion Changes in v3: * no change Changes in v2: * add this m

[PATCH v4 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-26 Thread Pali Rohár
This is fourth version of patches which add workarounds for RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. The only change since third version is modification of commit messages. Pali Rohár (2): net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips net: sfp: add mode

[PATCH v4 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-26 Thread Pali Rohár
fp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v4: * Rewritten the commit message by Marek's suggestion Changes in v3: * Do not break longer info messages * Do not read memory a

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > This is a third version of patches which add workarounds for > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > Russel's PATCH v2

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 25 January 2021 14:42:21 Russell King - ARM Linux admin wrote: > On Mon, Jan 25, 2021 at 03:23:01PM +0100, Pali Rohár wrote: > > On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > > > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: &g

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > > On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > > > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > > > This

[PATCH] doc: networking: ip-sysctl: Document conf/all/disable_ipv6 and conf/default/disable_ipv6

2021-01-21 Thread Pali Rohár
This patch adds documentation for sysctl conf/all/disable_ipv6 and conf/default/disable_ipv6 settings which is currently missing. Signed-off-by: Pali Rohár --- Documentation/networking/ip-sysctl.rst | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/networking/ip

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-18 Thread Pali Rohár
On Tuesday 12 January 2021 19:22:33 Russell King - ARM Linux admin wrote: > On Tue, Jan 12, 2021 at 09:42:56AM +0100, Heiner Kallweit wrote: > > On 11.01.2021 06:00, Marek Behún wrote: > > > Some multigig SFPs from RollBall and Hilink do not expose functional > > > MDIO access to the internal PHY o

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-18 Thread Pali Rohár
On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > This is a third version of patches which add workarounds for > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > Russel's PATCH v2 2/3 was dropped from this patch series as > it is being handled separately

Re: [PATCH net-next v5 4/5] net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY release

2021-01-18 Thread Pali Rohár
On Thursday 14 January 2021 16:07:19 Russell King - ARM Linux admin wrote: > On Thu, Jan 14, 2021 at 05:43:30AM +0100, Marek Behún wrote: > > Instead of configuring the I2C mdiobus when SFP driver is probed, > > create/destroy the mdiobus before the PHY is probed for/after it is > > released. > >

[PATCH v3] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR

2021-01-16 Thread Pali Rohár
Unlike SIOCGIFADDR and SIOCSIFADDR which are supported by many protocol families, SIOCDIFADDR is supported by AF_INET6 and AF_APPLETALK only. Unlike other protocols, AF_INET6 uses struct in6_ifreq. Signed-off-by: Pali Rohár --- man7/netdevice.7 | 64

Re: [PATCH v2] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR

2021-01-16 Thread Pali Rohár
On Saturday 16 January 2021 01:41:24 Alejandro Colomar (man-pages) wrote: > On 1/12/21 8:26 PM, Pali Rohár wrote: > > On Sunday 10 January 2021 20:57:50 Alejandro Colomar (man-pages) wrote: > >> [ CC += netdev ] > >> > >> On 1/10/21 5:38 PM, Pali Rohár wrote:

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-13 Thread Pali Rohár
On Wednesday 13 January 2021 14:56:13 Andrew Lunn wrote: > On Wed, Jan 13, 2021 at 12:22:04PM +0100, Pali Rohár wrote: > > Hello! See my comments below. > > > > On Monday 11 January 2021 06:00:41 Marek Behún wrote: > > > Some multigig SFPs from RollBall and H

Re: [PATCH net-next v4 4/4] net: sfp: add support for multigig RollBall transceivers

2021-01-13 Thread Pali Rohár
On Wednesday 13 January 2021 11:08:52 Russell King - ARM Linux admin wrote: > On Wed, Jan 13, 2021 at 11:49:36AM +0100, Pali Rohár wrote: > > On Monday 11 January 2021 06:00:44 Marek Behún wrote: > > > @@ -1453,7 +1459,7 @@ static int sfp_sm_probe_phy(struct sfp *sfp,

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-13 Thread Pali Rohár
Hello! See my comments below. On Monday 11 January 2021 06:00:41 Marek Behún wrote: > Some multigig SFPs from RollBall and Hilink do not expose functional > MDIO access to the internal PHY of the SFP via I2C address 0x56 > (although there seems to be read-only clause 22 access on this address). M

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-13 Thread Pali Rohár
On Tuesday 12 January 2021 22:01:14 Marek Behún wrote: > On Tue, 12 Jan 2021 21:54:24 +0100 > Andrew Lunn wrote: > > > > +static int i2c_transfer_rollball(struct i2c_adapter *i2c, > > > + struct i2c_msg *msgs, int num) > > > +{ > > > + u8 saved_page; > > > + int ret; > >

Re: [PATCH net-next v4 4/4] net: sfp: add support for multigig RollBall transceivers

2021-01-13 Thread Pali Rohár
Hello! (See comment below) On Monday 11 January 2021 06:00:44 Marek Behún wrote: > This adds support for multigig copper SFP modules from RollBall/Hilink. > These modules have a specific way to access clause 45 registers of the > internal PHY. > > We also need to wait at least 22 seconds after de

Re: [PATCH net-next v4 3/4] net: sfp: create/destroy I2C mdiobus before PHY probe/after PHY release

2021-01-13 Thread Pali Rohár
t; SFP transceiver. > > Signed-off-by: Marek Behún > Cc: Andrew Lunn > Cc: Russell King Reviewed-by: Pali Rohár > --- > drivers/net/phy/sfp.c | 30 ++ > 1 file changed, 26 insertions(+), 4 deletions(-) > > diff --git a/drivers/

Re: [PATCH net-next v4 2/4] net: phylink: allow attaching phy for SFP modules on 802.3z mode

2021-01-13 Thread Pali Rohár
> Signed-off-by: Marek Behún > Reviewed-by: Russell King > Cc: Andrew Lunn Reviewed-by: Pali Rohár > --- > drivers/net/phy/phylink.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > index

Re: [PATCH v2] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR

2021-01-12 Thread Pali Rohár
On Sunday 10 January 2021 20:57:50 Alejandro Colomar (man-pages) wrote: > [ CC += netdev ] > > On 1/10/21 5:38 PM, Pali Rohár wrote: > > On Saturday 02 January 2021 19:39:52 Pali Rohár wrote: > >> Also add description for struct in6_ifreq which is used for IPv6 addresse

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-12 Thread Pali Rohár
On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > This is a third version of patches which add workarounds for > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > Russel's PATCH v2 2/3 was dropped from this patch series as > it is being handled separately

[PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-11 Thread Pali Rohár
2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v2: * Add explanation why also for second address is used one byte read op * Skip hwmon registration when eep

[PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-11 Thread Pali Rohár
20 05 1e 00 36NT 4 ??.6 40: 00 06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár --- Changes in v2: * add this module also into sfp_module_supported() function Changes in v3

[PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-11 Thread Pali Rohár
This is a third version of patches which add workarounds for RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. Russel's PATCH v2 2/3 was dropped from this patch series as it is being handled separately. Pali Rohár (2): net: sfp: add workaround for Realtek RTL8672 and RTL9601C

Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-09 Thread Pali Rohár
On Saturday 09 January 2021 23:19:54 Russell King - ARM Linux admin wrote: > On Sat, Jan 09, 2021 at 08:14:47PM +0100, Pali Rohár wrote: > > On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > > > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wro

Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-09 Thread Pali Rohár
On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote: > > > From: Russell King > > > > > > Some GPON SFP mo

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 21:21:16 Marek Behún wrote: > On Thu, 7 Jan 2021 19:45:49 + > Russell King - ARM Linux admin wrote: > > > I think you're not reading the code very well. It checks for bytes at > > offset 1..blocksize-1, blocksize+1..2*blocksize-1, etc are zero. It > > does _not_ ch

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 17:40:06 Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 06:19:23PM +0100, Andrew Lunn wrote: > > Did we loose the comment: > > > > /* Some modules (Nokia 3FE46541AA) lock up if byte 0x51 is read as a > > * single read. Switch back to reading 16 byte bl

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 18:19:23 Andrew Lunn wrote: > > + if (sfp->i2c_block_size < 2) { > > + dev_info(sfp->dev, "skipping hwmon device registration " > > + "due to broken EEPROM\n"); > > + dev_info(sfp->dev, "diagnostic EEPROM area cannot be

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 03:02:36 Andrew Lunn wrote: > > + /* hwmon interface needs to access 16bit registers in atomic way to > > +* guarantee coherency of the diagnostic monitoring data. If it is not > > +* possible to guarantee coherency because EEPROM is broken in such way > > +

[PATCH v2 3/3] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-06 Thread Pali Rohár
20 05 1e 00 36NT 4 ??.6 40: 00 06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár --- Changes in v2: * add this module also into sfp_module_supported() function --- drivers

[PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-06 Thread Pali Rohár
module Ubiquiti U-Fiber Instant. Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v2: * Fix author/signed-off-by lines --- drivers/net/phy/sfp.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/sfp.c b

[PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-06 Thread Pali Rohár
2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v2: * Add explanation why also for second address is used one byte read op * Skip hwmon registration when eep

[PATCH v2 0/3] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-06 Thread Pali Rohár
EEPROM is totally broken and does not support reading 16bit values automically. Pali Rohár (2): net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Russell King (1): net: sfp: assume that LOS is not implemented if

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-06 Thread Pali Rohár
6, 2021 at 03:55:32PM +0100, Pali Rohár wrote: > > > > On my tested CarlitoxxPro module is: > > > > > > > > Option values : 0x00 0x1c > > > > Option

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-06 Thread Pali Rohár
On Sunday 03 January 2021 03:41:32 Pali Rohár wrote: > Hello! > > On Sunday 03 January 2021 03:25:23 Thomas Schreiber wrote: > > Hi Pali, > > I have a CarlitoxxPro module and I reported an issue about RX_LOS pin > > to the manufacturer. > > It looks to me that

[ANNOUNCE] igmpproxy 0.3

2021-01-04 Thread Pali Rohár
Hello! I would like to announce a new version of igmpproxy 0.3 https://github.com/pali/igmpproxy/releases/tag/0.3 Changes since previous version: * Show error message when maximum number of multicast groups were exceeded and hint for linux systems how to increase this limit * Improve downstream

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-02 Thread Pali Rohár
. V > Module voltage low alarm threshold: 0. V > Module voltage high warning threshold : 0. V > Module voltage low warning threshold : 0. V > Laser rx power high alarm threshold : 0.1536 mW / -8.14 dBm > Laser rx power low alarm threshold

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-01 Thread Pali Rohár
On Thursday 31 December 2020 18:13:38 Andrew Lunn wrote: > > > Looking at sfp_module_info(), adding a check for i2c_block_size < 2 > > > when determining what length to return. ethtool should do the right > > > thing, know that the second page has not been returned to user space. > > > > But if we

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Thursday 31 December 2020 16:30:33 Andrew Lunn wrote: > On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > >

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Thursday 31 December 2020 16:09:25 Andrew Lunn wrote: > On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > >

Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-31 Thread Pali Rohár
On Wednesday 30 December 2020 19:12:40 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 06:27:07PM +0100, Marek Behún wrote: > > On Wed, 30 Dec 2020 18:06:52 +0100 > > Pali Rohár wrote: > > > > > if (!sfp->type->module_supported(&id) &a

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 18:13:15 Andrew Lunn wrote: > > > Hi Pali > > > > > > I have to agree with Russell here

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 18:13:15 Andrew Lunn wrote: > On Wed, Dec 30, 2020 at 05:05:46PM +, Russell King - ARM Linux admin > wrote: > > On Wed, Dec 30, 2020 at 05:56:34PM +0100, Pali Rohár wrote: > > > This change is really required for those Realtek chips. I tho

Re: [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 18:17:41 Andrew Lunn wrote: > On Wed, Dec 30, 2020 at 05:06:23PM +, Russell King - ARM Linux admin > wrote: > > On Wed, Dec 30, 2020 at 05:57:58PM +0100, Pali Rohár wrote: > > > On Wednesday 30 December 2020 16:13:10 Russell King - ARM Lin

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 17:05:46 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 05:56:34PM +0100, Pali Rohár wrote: > > This change is really required for those Realtek chips. I thought that > > it is obvious that from *both* addresses 0x50 and 0x51 can be re

Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 16:11:51 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 04:47:53PM +0100, Pali Rohár wrote: > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set SFF phys_id > > in their EEPROM. Kernel SFP subsystem currently does n

Re: [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 16:13:10 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 04:47:54PM +0100, Pali Rohár wrote: > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both > > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 16:10:37 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 04:47:52PM +0100, Pali Rohár wrote: > > Workaround for GPON SFP modules based on VSOL V2801F brand was added in > > commit 0d035bed2a4a ("net: sfp: VSOL V2801F / Carli

[PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
d RTL9601C chips. Fixes: 0d035bed2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- drivers/net/phy/sfp.c | 78 --- 1 file changed,

[PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2020-12-30 Thread Pali Rohár
29 55 46 2d 49 4e 53 54 41.??)UF-INSTA 30: 4e 54 20 20 20 20 20 20 34 20 20 20 05 1e 00 36NT 4 ??.6 40: 00 06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár

[PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Pali Rohár
Instant. Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- drivers/net/phy/sfp.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 73f3ecf15260

[PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-30 Thread Pali Rohár
Ubiquiti U-Fiber Instant is recognized. Signed-off-by: Pali Rohár --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 490e78a72dd6..73f3ecf15260 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy

[PATCH 0/4] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2020-12-30 Thread Pali Rohár
available in my git branch sfp-rtl8672: https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=sfp-rtl8672 Pali Rohár (4): net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips net: sfp: allow to use also SFP modules which are detected as SFF net: sfp: assume that LOS

Re: [PATCH 0/3] mwifiex: disable ps_mode by default for stability

2020-12-20 Thread Pali Rohár
Hello! Please CC me in future for mwifiex discussion :-) On Wednesday 28 October 2020 23:24:30 Tsuchiya Yuto wrote: > Hello all, > > On Microsoft Surface devices (PCIe-88W8897), we are observing stability > issues when ps_mode (IEEE power_save) is enabled, then eventually causes > firmware crash

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-09 Thread Pali Rohár
On Wednesday 09 December 2020 16:19:39 Trent Piepho wrote: > On Tuesday, December 8, 2020 5:13:36 PM PST Pali Rohár wrote: > > On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > > > Does this also give userspace a clear point at which to determine MTU > setting, &

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-08 Thread Pali Rohár
On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > On Wednesday, September 23, 2020 3:22:15 AM PST Pali Rohár wrote: > > On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > > > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > > > And this p

Re: [PATCH v2 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

2020-10-21 Thread Pali Rohár
; the DT. > > Signed-off-by: Jérôme Pouiller Looks good! Acked-by: Pali Rohár > --- > include/linux/mmc/sdio_ids.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h > index 12036619346c..20a48162f7f

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-14 Thread Pali Rohár
On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote: > Hello Pali, > > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote: > > Hello! > > > > On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote: > > > +#define SDIO_VENDOR_ID

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-13 Thread Pali Rohár
Hello! On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote: > +#define SDIO_VENDOR_ID_SILABS0x > +#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 > +static const struct sdio_device_id wfx_sdio_ids[] = { > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, Plea

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 13:20:06 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 01:00:13PM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > > >

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > > >

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 11:20:20 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 10:16:40AM +0200, Marcel Holtmann wrote: > > Hi Greg, > > > > I wrote a simple script "sco_features.pl" which show all supported > > codecs by local HCI bluetooth adapter. Script is availa

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > > > On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > > &

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > > CCing other lists and maintainers, hopefully, somebody would have a time to > > look at it... > > > > On Saturday 08 August 2020 15:27:47

Removal of HCI commands, userspace bluetooth regression?

2020-09-29 Thread Pali Rohár
CCing other lists and maintainers, hopefully, somebody would have a time to look at it... On Saturday 08 August 2020 15:27:47 Pali Rohár wrote: > On Wednesday 15 April 2020 00:56:18 Pali Rohár wrote: > > On Sunday 09 February 2020 14:21:37 Pali Rohár wrote: > > > On Saturday

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-23 Thread Pali Rohár
Hello! On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > And this part of code which you write is Realtek specific. > > We currently only have Intel and Realtek platforms to test with. If > making it generic with

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-10 Thread Pali Rohár
On Thursday 10 September 2020 14:04:01 Joseph Hwang wrote: > It is desirable to define the HCI packet payload sizes of > USB alternate settings so that they can be exposed to user > space. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang > --- >

Re: [PATCH v3 2/2] Bluetooth: sco: new getsockopt options BT_SNDMTU/BT_RCVMTU

2020-09-10 Thread Pali Rohár
ting kernels. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang Looks good, Reviewed-by: Pali Rohár > --- > > Changes in v3: > - Fixed the commit message. > > Changes in v2: > - Used BT_SNDMTU/BT_RCVMTU ins

Re: [PATCH v2 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-09-09 Thread Pali Rohár
On Wednesday 09 September 2020 17:42:02 Joseph Hwang wrote: > It is desirable to expose the wideband speech packet length via > a socket option to the user space so that the user space can set > the value correctly in configuring the sco connection. Hello! I'm fine with change below, but I would s

Re: [PATCH v2 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-09 Thread Pali Rohár
On Wednesday 09 September 2020 17:42:01 Joseph Hwang wrote: > It is desirable to define the HCI packet payload sizes of > USB alternate settings so that they can be exposed to user > space. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang > ---

Re: [PATCH v1 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-08-19 Thread Pali Rohár
On Wednesday 19 August 2020 11:21:00 Luiz Augusto von Dentz wrote: > Hi Pali, > > On Wed, Aug 19, 2020 at 7:37 AM Pali Rohár wrote: > > > > On Friday 14 August 2020 12:56:05 Luiz Augusto von Dentz wrote: > > > Hi Joseph, > > > > > > On Thu, Au

Re: [PATCH v1 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-08-19 Thread Pali Rohár
On Friday 14 August 2020 13:07:25 Luiz Augusto von Dentz wrote: > Hi Joseph, > > On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > > > It is desirable to define the HCI packet payload sizes of > > USB alternate settings so that they can be exposed to user > > space. > > > > Reviewed-by: Ala

Re: [PATCH v1 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-08-19 Thread Pali Rohár
On Friday 14 August 2020 12:56:05 Luiz Augusto von Dentz wrote: > Hi Joseph, > > On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > > > It is desirable to expose the wideband speech packet length via > > a socket option to the user space so that the user space can set > > the value correctly

Re: IPv6: proxy_ndp to a network range

2020-07-26 Thread Pali Rohár
Hello, I would like to brisk up this thread again! On Monday 09 May 2016 16:51:10 Alexander Aring wrote: > Hi, > > On Mon, May 09, 2016 at 01:46:13AM -0700, H. Peter Anvin wrote: > > On May 9, 2016 1:39:08 AM PDT, Alexander Aring wrote: > > >Hi, > > > > > >On Mon, May 09, 2016 at 01:06:51AM -070

[PATCH] mwifiex: Fix reporting 'operation not supported' error code

2020-07-03 Thread Pali Rohár
via EOPNOTSUPP macro. This patch fixes problem that mwifiex kernel driver sends to userspace unsupported error codes like: "failed: -524 (No error information)". After applying this patch userspace see: "failed: -95 (Not supported)". Signed-off-by: Pali Rohár --- .../net/wir

[PATCH] mwifiex: Use macro MWIFIEX_MAX_BSS_NUM for specifying limit of interfaces

2020-06-26 Thread Pali Rohár
This macro is already used in mwifiex driver for specifying upper limit and is defined to value 3. So use it also in struct ieee80211_iface_limit. Signed-off-by: Pali Rohár --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH] mwifiex: Add support for NL80211_ATTR_MAX_AP_ASSOC_STA

2020-05-29 Thread Pali Rohár
On Thursday 21 May 2020 14:35:59 Pali Rohár wrote: > SD8997 firmware sends TLV_TYPE_MAX_CONN with struct hw_spec_max_conn to > inform kernel about maximum number of p2p connections and stations in AP > mode. > > During initialization of SD8997 wifi chip kernel prints warning: >

Re: [PATCH] mwifiex: Parse all API_VER_ID properties

2020-05-28 Thread Pali Rohár
On Thursday 21 May 2020 14:34:44 Pali Rohár wrote: > During initialization of SD8997 wifi chip kernel prints warnings: > > mwifiex_sdio mmc0:0001:1: Unknown api_id: 3 > mwifiex_sdio mmc0:0001:1: Unknown api_id: 4 > > This patch adds support for parsing all api ids

[PATCH] mwifiex: Add support for NL80211_ATTR_MAX_AP_ASSOC_STA

2020-05-21 Thread Pali Rohár
support for parsing TLV_TYPE_MAX_CONN (0x217) and sets appropriate cfg80211 member 'max_ap_assoc_sta' from retrieved structure. It allows userspace to retrieve NL80211_ATTR_MAX_AP_ASSOC_STA attribute. Signed-off-by: Pali Rohár --- drivers/net/wireless/marvell/mwifiex/cfg80

[PATCH] mwifiex: Parse all API_VER_ID properties

2020-05-21 Thread Pali Rohár
During initialization of SD8997 wifi chip kernel prints warnings: mwifiex_sdio mmc0:0001:1: Unknown api_id: 3 mwifiex_sdio mmc0:0001:1: Unknown api_id: 4 This patch adds support for parsing all api ids provided by SD8997 firmware. Signed-off-by: Pali Rohár --- drivers/net/wireless/marvell

[PATCH] cw1200: Remove local sdio VENDOR and DEVICE id definitions

2020-05-20 Thread Pali Rohár
They are already present in linux/mmc/sdio_ids.h. Signed-off-by: Pali Rohár --- drivers/net/wireless/st/cw1200/cw1200_sdio.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/cw1200_sdio.c b/drivers/net/wireless/st/cw1200/cw1200_sdio.c

[PATCH] mwifiex: Fix memory corruption in dump_station

2020-05-15 Thread Pali Rohár
just be an array). Such a change may be proposed in the future. In the meantime this patch can backported into stable kernels in this simple form. Fixes: 8baca1a34d4c ("mwifiex: dump station support in uap mode") Signed-off-by: Pali Rohár --- drivers/net/wireless/marvell/mwifiex/cfg80

[PATCH] ipw2x00: Fix comment for CLOCK_BOOTTIME constant

2020-05-08 Thread Pali Rohár
Correct name of constant is CLOCK_BOOTTIME and not CLOCK_BOOTIME. Signed-off-by: Pali Rohár --- drivers/net/wireless/intel/ipw2x00/ipw2200.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.h b/drivers/net/wireless/intel/ipw2x00

[ANNOUNCE] igmpproxy 0.2.1

2018-02-13 Thread Pali Rohár
Hello, new version 0.2.1 of igmpproxy was released which fixes compilation on FreeBSD systems and also fixes broken option -n. It is just a minor version to address these problems. https://github.com/pali/igmpproxy/releases/tag/0.2.1 -- Pali Rohár pali.ro...@gmail.com signature.asc

Re: [PATCH v2 0/6] wl1251: Fix MAC address for Nokia N900

2018-01-27 Thread Pali Rohár
On Friday 05 January 2018 02:45:10 Luis R. Rodriguez wrote: > On Tue, Jan 02, 2018 at 08:23:45PM +0100, Pali Rohár wrote: > > On Friday 10 November 2017 00:38:22 Pali Rohár wrote: > > > This patch series fix processing MAC address for wl1251 chip found in > > > Nokia

  1   2   >