RE: [PATCH v4 05/23] ice: Add devlink params support

2021-04-13 Thread Parav Pandit
+ Jiri. > From: Saleem, Shiraz > Sent: Wednesday, April 14, 2021 5:51 AM > > > Subject: RE: [PATCH v4 05/23] ice: Add devlink params support > > > > > > > > > From: Saleem, Shiraz > > > Sent: Tuesday, April 13, 2021 8:11 PM > > [..] > > > > > > > > Parav is talking about generic ways to customi

RE: [PATCH v4 05/23] ice: Add devlink params support

2021-04-13 Thread Parav Pandit
> From: Saleem, Shiraz > Sent: Tuesday, April 13, 2021 8:11 PM [..] > > > > Parav is talking about generic ways to customize the aux devices > > > > created and that would seem to serve the same function as this. > > > > > > Is there an RFC or something posted for us to look at? > > I do not h

RE: [PATCH v4 05/23] ice: Add devlink params support

2021-04-12 Thread Parav Pandit
> From: Parav Pandit > Sent: Tuesday, April 13, 2021 12:38 AM > > > From: Saleem, Shiraz > > Sent: Monday, April 12, 2021 8:21 PM > > > > > Subject: Re: [PATCH v4 05/23] ice: Add devlink params support > > > > > > On Wed,

RE: [PATCH v4 05/23] ice: Add devlink params support

2021-04-12 Thread Parav Pandit
> From: Saleem, Shiraz > Sent: Monday, April 12, 2021 8:21 PM > > > Subject: Re: [PATCH v4 05/23] ice: Add devlink params support > > > > On Wed, Apr 07, 2021 at 08:58:25PM +, Saleem, Shiraz wrote: > > > > Subject: Re: [PATCH v4 05/23] ice: Add devlink params support > > > > > > > > On Tue

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-09 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Thursday, April 8, 2021 5:46 PM > On Wed, Apr 07, 2021 at 03:44:35PM +0000, Parav Pandit wrote: > > > > If it returns EOPNOTUPP then the remove is never called so if it > > > allocated memory and left it allocated then it is leakin

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-07 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Wednesday, April 7, 2021 8:44 PM > > On Wed, Apr 07, 2021 at 03:06:35PM +, Parav Pandit wrote: > > > > > > > From: Jason Gunthorpe > > > Sent: Tuesday, April 6, 2021 9:17 PM > > > > > > On

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-07 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Tuesday, April 6, 2021 9:17 PM > > On Mon, Apr 05, 2021 at 08:49:56AM +0300, Leon Romanovsky wrote: > > @@ -2293,6 +2295,17 @@ static void ib_sa_event(struct ib_event_handler > *handler, > > } > > } > > > > +static bool ib_sa_client_supported(struct ib_devi

RE: [PATCH v2 05/23] ice: Add devlink params support

2021-03-25 Thread Parav Pandit
> From: Saleem, Shiraz > Sent: Friday, March 26, 2021 1:40 AM > > Subject: RE: [PATCH v2 05/23] ice: Add devlink params support [..] > > > > Resources are better represented as devlink resource. > > Such as, > > > > $ devlink resource set pci/:06:00.0 /rdma/max_qps 16384 $ devlink > > reso

RE: [PATCH v2 05/23] ice: Add devlink params support

2021-03-23 Thread Parav Pandit
Hi Shiraz, > From: Shiraz Saleem > Sent: Wednesday, March 24, 2021 5:30 AM > > Add two new runtime RDMA related devlink parameters to ice driver. > 'rdma_resource_limits_sel' is driver-specific while 'rdma_protocol' is > generic. > Configuration changes result in unplugging the auxiliary RDMA d

RE: mlx5 sub function issue

2021-03-10 Thread Parav Pandit
> Is it convenient > to reveal how many SFs can be created at most? > Yes, it is. We will be doing this, mostly as devlink resource as discussed last time with Jacob, David, Samudrala in past. It is in my todo list already. Until its available, please use the existing tooling. > Ze Wa

RE: mlx5 sub function issue

2021-03-09 Thread Parav Pandit
Hi Ze Wang, > From: ze wang > Sent: Tuesday, March 9, 2021 8:34 AM > > Hi David, > I can see that the variable settings are in effect: > # mlxconfig -d b3:00.0 s PF_BAR2_ENABLE=0 PER_PF_NUM_SF=1 > PF_SF_BAR_SIZE=8 # mlxconfig -d b3:00.0 s PER_PF_NUM_SF=1 > PF_TOTAL_SF=192 PF_SF_BAR_SIZE=8

RE: mlx5 sub function issue

2021-03-09 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Monday, March 8, 2021 9:18 PM > > On 3/8/21 12:21 AM, ze wang wrote: > > mlxconfig tool from mft tools version 4.16.52 or higher to set number of SF. > > > > mlxconfig -d b3:00.0 PF_BAR2_ENABLE=0 PER_PF_NUM_SF=1 > > PF_SF_BAR_SIZE=8 mlxconfig -d b3:00.0 PE

RE: [PATCH] net/mlx5: remove unneeded semicolon

2021-03-03 Thread Parav Pandit
Hi Saeed, > From: Parav Pandit > Sent: Monday, February 22, 2021 3:32 PM > > > > From: Jiapeng Chong > > Sent: Monday, February 22, 2021 3:27 PM > > > > Fix the following coccicheck warnings: > > > > ./drivers/net/ethernet/mellanox/mlx5/c

[PATCH iproute2-next 2/4] utils: Introduce helper routines for generic socket recv

2021-03-01 Thread Parav Pandit
Introduce helper for generic socket receive helper and introduce helper to build command with custom family and version. Use API in subsequent devlink patch. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- include/mnl_utils.h | 6 ++ lib/mnl_utils.c | 25

[PATCH iproute2-next 4/4] devlink: Add error print when unknown values specified

2021-03-01 Thread Parav Pandit
When user specifies either unknown flavour or unknown state during devlink port commands, return appropriate error message. Signed-off-by: Parav Pandit --- devlink/devlink.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index

[PATCH iproute2-next 3/4] devlink: Use generic socket helpers from library

2021-03-01 Thread Parav Pandit
User generic socket helpers from library for netlink generic socket access. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- devlink/devlink.c | 314 ++ devlink/mnlg.c| 121 ++ devlink/mnlg.h| 13 +- 3 files changed

[PATCH iproute2-next 0/4] devlink: Use utils helpers

2021-03-01 Thread Parav Pandit
library Patch-4 print error when user provides invalid flavour or state Parav Pandit (4): devlink: Use library provided string processing APIs utils: Introduce helper routines for generic socket recv devlink: Use generic socket helpers from library devlink: Add error print when unknown values

[PATCH iproute2-next 1/4] devlink: Use library provided string processing APIs

2021-03-01 Thread Parav Pandit
User helper routines provided by library for counting slash and splitting string on delimiter. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- devlink/devlink.c | 43 +-- 1 file changed, 9 insertions(+), 34 deletions(-) diff --git a/devlink

RE: [PATCH] net/mlx5: remove unneeded semicolon

2021-02-22 Thread Parav Pandit
break; > - }; > + } > > return 0; > } > -- > 1.8.3.1 Reviewed-by: Parav Pandit

RE: [PATCH iproute2-next v5 0/5] Add vdpa device management tool

2021-02-11 Thread Parav Pandit
> From: David Ahern > Sent: Thursday, February 11, 2021 9:50 PM > > On 2/10/21 11:34 AM, Parav Pandit wrote: > > Linux vdpa interface allows vdpa device management functionality. > > This includes adding, removing, querying vdpa devices. > > > > vdpa inter

[PATCH iproute2-next v5 5/5] vdpa: Add vdpa tool

2021-02-10 Thread Parav Pandit
"max_vqs": 2, "max_vq_size": 256 } } } Delete the vdpa device after its use: $ vdpa dev del foo2 Signed-off-by: Parav Pandit --- changelog: v3->v4: - added new header file path vdpa/include/uapi/linux to CFLAGS --- Makefile

[PATCH iproute2-next v5 3/5] utils: Add generic socket helpers

2021-02-10 Thread Parav Pandit
Subsequent patch needs to (a) query and use socket family (b) send/receive messages using this family Hence add helper routines to open, close, query family and to perform send receive operations. Signed-off-by: Parav Pandit --- changelog: v2->v3: - split patch from add vdpa tool for soc

[PATCH iproute2-next v5 4/5] utils: Add helper to map string to unsigned int

2021-02-10 Thread Parav Pandit
In subsequent patch need to map a string to a unsigned int. Hence, add an API to map a string to unsigned int. Signed-off-by: Parav Pandit --- changelog: v2->v3: - new patch to reuse string to unsigned int mapping --- include/utils.h | 4 +++- lib/utils.c | 17 +++-- 2 fi

[PATCH iproute2-next v5 0/5] Add vdpa device management tool

2021-02-10 Thread Parav Pandit
using newly added helper routine for number to string mapping v1->v2: - addressed below comments from David - added and used library helpers for socket communication - added and used library functions for string processing helpers - added and used library functions indent processing helpers

[PATCH iproute2-next v5 1/5] Add kernel headers

2021-02-10 Thread Parav Pandit
Add kernel headers to commit from kernel tree [1]. 6acba4951632 ("vdpa_sim_net: Add support for user supported devices") [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Signed-off-by: Parav Pandit --- changelog: v4->v5: - avoided UAPI prefix in the vdpa.

[PATCH iproute2-next v5 2/5] utils: Add helper routines for indent handling

2021-02-10 Thread Parav Pandit
Subsequent patch needs to use 2 char indentation for nested objects. Hence introduce a generic helpers to allocate, deallocate, increment, decrement and to print indent block. Signed-off-by: Parav Pandit --- changelog: v2->v3: - patch split from vdpa tool patch --- include/utils.h |

RE: [PATCH iproute2-next v4 1/5] Add kernel headers

2021-02-10 Thread Parav Pandit
> From: David Ahern > Sent: Monday, February 8, 2021 9:18 PM > > On 2/5/21 11:10 AM, Parav Pandit wrote: > > diff --git a/vdpa/include/uapi/linux/vdpa.h > > b/vdpa/include/uapi/linux/vdpa.h new file mode 100644 index > > ..66a41e4e > > --- /dev/nu

RE: [PATCH net-next v2 7/7] netdevsim: Add netdevsim port add test cases

2021-02-08 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Tuesday, February 9, 2021 2:51 AM > > On Sun, 7 Feb 2021 10:44:12 +0200 Parav Pandit wrote: > > + RET=0 > > + USR_PF_PORT_INDEX=600 > > + USR_PFNUM_A=2 > > + USR_PFNUM_B=3 > > + USR_SF_PORT_INDEX=601 >

[PATCH net-next v2 6/7] netdevsim: Simulate port function set state for a PCI port

2021-02-07 Thread Parav Pandit
"pfnum": 2, "sfnum": 0, "splittable": false, "function": { "hw_addr": "00:11:22:33:44:55", "state": "active", "opstate": &

[PATCH net-next v2 3/7] netdevsim: Simulate get hardware address of a PCI port

2021-02-07 Thread Parav Pandit
"flavour": "pcisf", "controller": 0, "pfnum": 2, "sfnum": 0, "splittable": false, "function": { "hw_addr": "00:00:00:00:00:00" }

[PATCH net-next v2 5/7] netdevsim: Simulate port function state for a PCI port

2021-02-07 Thread Parav Pandit
uot;function": { "hw_addr": "00:00:00:00:00:00", "state": "inactive", "opstate": "detached" } } } } Signed-off-by: Parav Pandit --- drivers/net/netdevsim/dev.c | 1 + dri

[PATCH net-next v2 4/7] netdevsim: Simulate set hardware address of a PCI port

2021-02-07 Thread Parav Pandit
quot;type": "eth", "netdev": "eth2", "flavour": "pcisf", "controller": 0, "pfnum": 2, "sfnum": 0, "splittable": false, "

[PATCH net-next v2 7/7] netdevsim: Add netdevsim port add test cases

2021-02-07 Thread Parav Pandit
Add tests for PCI PF and SF port add, configure and delete. Signed-off-by: Parav Pandit --- .../drivers/net/netdevsim/devlink.sh | 72 ++- 1 file changed, 71 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools

[PATCH net-next v2 2/7] netdevsim: Add support for add and delete PCI SF port

2021-02-07 Thread Parav Pandit
te PCI SF and PF ports: $ devlink port del netdevsim/netdevsim10/66 $ devlink port del netdevsim/netdevsim10/2 $ devlink port del netdevsim/netdevsim10/1 Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- drivers/net/netdevsim/netdevsim.h | 1 + drivers/net/netdevsim/port_fu

[PATCH net-next v2 1/7] netdevsim: Add support for add and delete of a PCI PF port

2021-02-07 Thread Parav Pandit
plittable false Delete newly added devlink port: $ devlink port del netdevsim/netdevsim10/4 issue: 2241444 Signed-off-by: Parav Pandit --- changelog: v1->v2: - fixed warning for unused err value --- drivers/net/netdevsim/Makefile| 2 +- drivers/net/netdevsim/dev.c | 1

[PATCH net-next v2 0/7] netdevsim port add, delete support

2021-02-07 Thread Parav Pandit
ete PCI SF and PF ports: $ devlink port del netdevsim/netdevsim10/2 Patch summary: patch-1 adds support for adding/remove PCI PF port patch-2 adds support for adding/remove PCI SF port patch-3 simulates MAC address query patch-4 simulates setting MAC address patch-5 simulates state query patch-6 s

RE: [PATCH net-next 1/7] netdevsim: Add support for add and delete of a PCI PF port

2021-02-07 Thread Parav Pandit
> From: kernel test robot > Sent: Saturday, February 6, 2021 8:05 PM > > Hi Parav, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url:https://github.com/0day-ci/linux/commits/Parav-Pandi

[PATCH net-next 7/7] netdevsim: Add netdevsim port add test cases

2021-02-06 Thread Parav Pandit
Add tests for PCI PF and SF port add, configure and delete using user specified port index and sfumber; and also using auto generated port index. Signed-off-by: Parav Pandit --- .../drivers/net/netdevsim/devlink.sh | 72 ++- 1 file changed, 71 insertions(+), 1 deletion

[PATCH net-next 6/7] netdevsim: Simulate port function set state for a PCI port

2021-02-06 Thread Parav Pandit
"pfnum": 2, "sfnum": 0, "splittable": false, "function": { "hw_addr": "00:11:22:33:44:55", "state": "active", "opstate": &

[PATCH net-next 3/7] netdevsim: Simulate get hardware address of a PCI port

2021-02-06 Thread Parav Pandit
"flavour": "pcisf", "controller": 0, "pfnum": 2, "sfnum": 0, "splittable": false, "function": { "hw_addr": "00:00:00:00:00:00" }

[PATCH net-next 5/7] netdevsim: Simulate port function state for a PCI port

2021-02-06 Thread Parav Pandit
uot;function": { "hw_addr": "00:00:00:00:00:00", "state": "inactive", "opstate": "detached" } } } } Signed-off-by: Parav Pandit --- drivers/net/netdevsim/dev.c | 1 + dri

[PATCH net-next 4/7] netdevsim: Simulate set hardware address of a PCI port

2021-02-06 Thread Parav Pandit
quot;type": "eth", "netdev": "eth2", "flavour": "pcisf", "controller": 0, "pfnum": 2, "sfnum": 0, "splittable": false, "

[PATCH net-next 2/7] netdevsim: Add support for add and delete PCI SF port

2021-02-06 Thread Parav Pandit
te PCI SF and PF ports: $ devlink port del netdevsim/netdevsim10/66 $ devlink port del netdevsim/netdevsim10/2 $ devlink port del netdevsim/netdevsim10/1 Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- drivers/net/netdevsim/netdevsim.h | 1 + drivers/net/netdevsim/port_fu

[PATCH net-next 1/7] netdevsim: Add support for add and delete of a PCI PF port

2021-02-06 Thread Parav Pandit
plittable false Delete newly added devlink port: $ devlink port del netdevsim/netdevsim10/4 Signed-off-by: Parav Pandit --- drivers/net/netdevsim/Makefile| 2 +- drivers/net/netdevsim/dev.c | 10 + drivers/net/netdevsim/netdevsim.h | 20 ++ drivers/net/netdevsi

[PATCH net-next 0/7] netdevsim port add, delete support

2021-02-06 Thread Parav Pandit
ete PCI SF and PF ports: $ devlink port del netdevsim/netdevsim10/2 Patch summary: patch-1 adds support for adding/remove PCI PF port patch-2 adds support for adding/remove PCI SF port patch-3 simulates MAC address query patch-4 simulates setting MAC address patch-5 simulates state query patch-6 s

[PATCH iproute2-next v4 1/5] Add kernel headers

2021-02-05 Thread Parav Pandit
Add kernel headers to commit from kernel tree [1]. 79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices") [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch: linux-next Signed-off-by: Parav Pandit --- vdpa/include/uapi/linux/vdpa.h

[PATCH iproute2-next v4 0/5] Add vdpa device management tool

2021-02-05 Thread Parav Pandit
sed below comments from David - added and used library helpers for socket communication - added and used library functions for string processing helpers - added and used library functions indent processing helpers Parav Pandit (5): Add kernel headers utils: Add helper routines for indent handlin

[PATCH iproute2-next v4 3/5] utils: Add generic socket helpers

2021-02-05 Thread Parav Pandit
Subsequent patch needs to (a) query and use socket family (b) send/receive messages using this family Hence add helper routines to open, close, query family and to perform send receive operations. Signed-off-by: Parav Pandit --- changelog: v2->v3: - split patch from add vdpa tool for soc

[PATCH iproute2-next v4 2/5] utils: Add helper routines for indent handling

2021-02-05 Thread Parav Pandit
Subsequent patch needs to use 2 char indentation for nested objects. Hence introduce a generic helpers to allocate, deallocate, increment, decrement and to print indent block. Signed-off-by: Parav Pandit --- changelog: v2->v3: - patch split from vdpa tool patch --- include/utils.h |

[PATCH iproute2-next v4 4/5] utils: Add helper to map string to unsigned int

2021-02-05 Thread Parav Pandit
In subsequent patch need to map a string to a unsigned int. Hence, add an API to map a string to unsigned int. Signed-off-by: Parav Pandit --- changelog: v2->v3: - new patch to reuse string to unsigned int mapping --- include/utils.h | 4 +++- lib/utils.c | 17 +++-- 2 fi

[PATCH iproute2-next v4 5/5] vdpa: Add vdpa tool

2021-02-05 Thread Parav Pandit
"max_vqs": 2, "max_vq_size": 256 } } } Delete the vdpa device after its use: $ vdpa dev del foo2 Signed-off-by: Parav Pandit --- Makefile| 2 +- man/man8/vdpa-dev.8 | 96 ++ man/man8/vdpa-mgmtdev.8 | 53 man/man8/v

RE: [PATCH iproute2-next v3 1/5] Add kernel headers

2021-02-05 Thread Parav Pandit
> From: David Ahern > Sent: Thursday, February 4, 2021 7:07 AM > > On 2/2/21 3:35 AM, Parav Pandit wrote: > > Add kernel headers to commit from kernel tree [1]. > >79991caf5202c7 ("vdpa_sim_net: Add support for user supported > > devices") > >

RE: [PATCH iproute2-next v3 0/5] Add vdpa device management tool

2021-02-05 Thread Parav Pandit
> From: Jason Wang > Sent: Friday, February 5, 2021 9:11 AM > > > On 2021/2/4 下午7:15, Adrian Moreno wrote: > > Sorry I have not followed this work as close as I would have wanted. > > Some questions below. > > > > On 2/4/21 4:16 AM, Jason Wang wrote

RE: [PATCH] net/mlx5: docs: correct section reference in table of contents

2021-02-05 Thread Parav Pandit
nction`_ > +- `mlx5 function attributes`_ > - `Devlink health reporters`_ > - `mlx5 tracepoints`_ > > Enabling the driver and kconfig options - > > +=== > > | mlx5 core is modular and most of the major mlx5 core driver features can > be selected (compiled in/out) | at build time via kernel Kconfig flags. > -- > 2.17.1 Thanks. Reviewed-by: Parav Pandit

[PATCH iproute2-next v3 4/5] utils: Add helper to map string to unsigned int

2021-02-02 Thread Parav Pandit
In subsequent patch need to map a string to a unsigned int. Hence, add an API to map a string to unsigned int. Signed-off-by: Parav Pandit --- changelog: v2->v3: - new patch to reuse string to unsigned int mapping --- include/utils.h | 4 +++- lib/utils.c | 17 +++-- 2 fi

[PATCH iproute2-next v3 5/5] vdpa: Add vdpa tool

2021-02-02 Thread Parav Pandit
"max_vqs": 2, "max_vq_size": 256 } } } Delete the vdpa device after its use: $ vdpa dev del foo2 Signed-off-by: Parav Pandit --- Makefile| 2 +- man/man8/vdpa-dev.8 | 96 ++ man/man8/vdpa-mgmtdev.8 | 53 man/man8/v

[PATCH iproute2-next v3 3/5] utils: Add generic socket helpers

2021-02-02 Thread Parav Pandit
Subsequent patch needs to (a) query and use socket family (b) send/receive messages using this family Hence add helper routines to open, close, query family and to perform send receive operations. Signed-off-by: Parav Pandit --- changelog: v2->v3: - split patch from add vdpa tool for soc

[PATCH iproute2-next v3 2/5] utils: Add helper routines for indent handling

2021-02-02 Thread Parav Pandit
Subsequent patch needs to use 2 char indentation for nested objects. Hence introduce a generic helpers to allocate, deallocate, increment, decrement and to print indent block. Signed-off-by: Parav Pandit --- changelog: v2->v3: - patch split from vdpa tool patch --- include/utils.h |

[PATCH iproute2-next v3 1/5] Add kernel headers

2021-02-02 Thread Parav Pandit
Add kernel headers to commit from kernel tree [1]. 79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices") [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch: linux-next Signed-off-by: Parav Pandit --- include/uapi/linux/vdpa.h

[PATCH iproute2-next v3 0/5] Add vdpa device management tool

2021-02-02 Thread Parav Pandit
mments from David - added and used library helpers for socket communication - added and used library functions for string processing helpers - added and used library functions indent processing helpers Parav Pandit (5): Add kernel headers utils: Add helper routines for indent handl

RE: [PATCH iproute2-next v2 0/6] Support devlink port add delete

2021-02-01 Thread Parav Pandit
> From: David Ahern > Sent: Tuesday, February 2, 2021 8:50 AM > > On 2/1/21 2:35 PM, Parav Pandit wrote: > > This patchset implements devlink port add, delete and function state > > management commands. > > > > An example sequence for a PCI SF: >

[PATCH iproute2-next v2 2/6] devlink: Introduce and use string to number mapper

2021-02-01 Thread Parav Pandit
Instead of using static mapping in code, introduce a helper routine to map a value to string. Signed-off-by: Parav Pandit --- changelog: v1->v2: - addressed David's comment to use helper routine to map num->string --- devlink/devlink.c | 30 ++ incl

[PATCH iproute2-next v2 5/6] devlink: Support get port function state

2021-02-01 Thread Parav Pandit
quot;: 0, "pfnum": 0, "sfnum": 88, "splittable": false, "function": { "hw_addr": "00:00:00:00:88:88", "state": "inactive", "opstate&qu

[PATCH iproute2-next v2 1/6] devlink: Update kernel headers

2021-02-01 Thread Parav Pandit
Update kernel headers to commit a556dded9c23 ("devlink: Support get and set state of port function") Signed-off-by: Parav Pandit --- include/uapi/linux/devlink.h | 25 + 1 file changed, 25 insertions(+) diff --git a/include/uapi/linux/devlink.h b/include/

[PATCH iproute2-next v2 6/6] devlink: Support set of port function state

2021-02-01 Thread Parav Pandit
quot;pfnum": 0, "sfnum": 88, "splittable": false, "function": { "hw_addr": "00:00:00:00:88:88", "state": "active", "opstate"

[PATCH iproute2-next v2 3/6] devlink: Introduce PCI SF port flavour and attribute

2021-02-01 Thread Parav Pandit
uot;sfnum": 88, "splittable": false, "function": { "hw_addr": "00:00:00:00:88:88", "state": "active", "opstate": "attached" }

[PATCH iproute2-next v2 4/6] devlink: Supporting add and delete of devlink port

2021-02-01 Thread Parav Pandit
0:00:00:00 state inactive opstate detached Delete newly added devlink port $ devlink port del pci/:06:00.0/32768 Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- changelog: v1->v2: - addressed David's comment to use struct for string->num mapping using helper library

[PATCH iproute2-next v2 0/6] Support devlink port add delete

2021-02-01 Thread Parav Pandit
h-4 adds devlink commands to add and delete a port along with man page Patch-5 shows function state and operational state to user Patch-6 enables user to set function state and adds man page documentation Parav Pandit (6): devlink: Update kernel headers devlink: Introduce and use string to numbe

RE: [PATCH iproute2-next 5/5] devlink: Support set of port function state

2021-02-01 Thread Parav Pandit
> From: David Ahern > Sent: Sunday, January 31, 2021 11:01 PM > > On 1/29/21 9:56 AM, Parav Pandit wrote: > > @@ -1420,6 +1423,22 @@ static int port_flavour_parse(const char > *flavour, uint16_t *value) > > } > > } > > > > +static int p

RE: [PATCH iproute2-next 3/5] devlink: Supporting add and delete of devlink port

2021-02-01 Thread Parav Pandit
> From: David Ahern > Sent: Sunday, January 31, 2021 10:56 PM > > On 1/29/21 9:56 AM, Parav Pandit wrote: > > @@ -1383,6 +1389,37 @@ static int reload_limit_get(struct dl *dl, const > char *limitstr, > > return 0; > > } > > > > +static int por

[PATCH iproute2-next 1/5] devlink: Update kernel headers

2021-01-29 Thread Parav Pandit
Update kernel headers to commit a556dded9c23 ("devlink: Support get and set state of port function") Signed-off-by: Parav Pandit --- include/uapi/linux/devlink.h | 25 + 1 file changed, 25 insertions(+) diff --git a/include/uapi/linux/devlink.h b/include/

[PATCH iproute2-next 3/5] devlink: Supporting add and delete of devlink port

2021-01-29 Thread Parav Pandit
0:00:00:00 state inactive opstate detached Delete newly added devlink port $ devlink port del pci/:06:00.0/32768 Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- devlink/devlink.c | 128 man/man8/devlink-port.8 | 63 +++

[PATCH iproute2-next 4/5] devlink: Support get port function state

2021-01-29 Thread Parav Pandit
quot;: 0, "pfnum": 0, "sfnum": 88, "splittable": false, "function": { "hw_addr": "00:00:00:00:88:88", "state": "inactive", "opstate&quo

[PATCH iproute2-next 5/5] devlink: Support set of port function state

2021-01-29 Thread Parav Pandit
quot;pfnum": 0, "sfnum": 88, "splittable": false, "function": { "hw_addr": "00:00:00:00:88:88", "state": "active", "opstate": &quo

[PATCH iproute2-next 2/5] devlink: Introduce PCI SF port flavour and attribute

2021-01-29 Thread Parav Pandit
uot;sfnum": 88, "splittable": false, "function": { "hw_addr": "00:00:00:00:88:88", "state": "active", "opstate": "attached" }

[PATCH iproute2-next 0/5] Support devlink port add delete

2021-01-29 Thread Parav Pandit
$ devlink port function set pci/:06:00.0/32768 state inactive Delete the port after use: $ devlink port del pci/:06:00.0/32768 Patch summary: Patch-1 updates kernel headers Patch-2 shows PCI SF port attributes Patch-3 adds devlink commands to add and delete a port along with man page Patch-4

RE: [PATCH iproute2-next RESEND] devlink: Extend man page for port function set command

2021-01-28 Thread Parav Pandit
Hi David, Stephen, > From: Parav Pandit > Sent: Tuesday, January 26, 2021 6:54 PM > > Hi Stephen, > > > From: Parav Pandit > > Sent: Friday, January 22, 2021 10:32 AM > > > > Extended devlink-port man page for synopsis, description and example > >

RE: [PATCH iproute2-next v2 2/2] vdpa: Add vdpa tool

2021-01-28 Thread Parav Pandit
Hi David, > From: Parav Pandit > Sent: Friday, January 29, 2021 12:13 AM [..] > --- > changelog: > v1->v2: > - added and used library helpers for socket communication > - added and used library functions for string processing helpers > - added and used library

[PATCH iproute2-next v2 2/2] vdpa: Add vdpa tool

2021-01-28 Thread Parav Pandit
"max_vqs": 2, "max_vq_size": 256 } } } Delete the vdpa device after its use: $ vdpa dev del foo2 Signed-off-by: Parav Pandit --- changelog: v1->v2: - added and used library helpers for socket communication - added and used library funct

[PATCH iproute2-next v2 1/2] Add kernel headers

2021-01-28 Thread Parav Pandit
Add kernel headers to commit from kernel tree [1]. 79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices") [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch: linux-next Signed-off-by: Parav Pandit --- include/uapi/linux/vdpa.h

[PATCH iproute2-next v2 0/2] Add vdpa device management tool

2021-01-28 Thread Parav Pandit
- addressed below comments from David - added and used library helpers for socket communication - added and used library functions for string processing helpers - added and used library functions indent processing helpers Parav Pandit (2): Add kernel headers vdpa: Add vdpa tool Makefile

RE: [PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-26 Thread Parav Pandit
> From: David Ahern > Sent: Tuesday, January 26, 2021 9:53 AM > > Looks fine. A few comments below around code re-use. > > On 1/22/21 4:26 AM, Parav Pandit wrote: > > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c new file mode 100644 index > > ..942524b7 &g

RE: [PATCH iproute2-next RESEND] devlink: Extend man page for port function set command

2021-01-26 Thread Parav Pandit
Hi Stephen, > From: Parav Pandit > Sent: Friday, January 22, 2021 10:32 AM > > Extended devlink-port man page for synopsis, description and example for > setting devlink port function attribute. > > Signed-off-by: Parav Pandit > Reviewed-by: Jiri Pirko Can you

RE: [pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-25 Thread Parav Pandit
Hi Edwin, > From: Edwin Peer > Sent: Monday, January 25, 2021 2:17 AM > > On Fri, Jan 22, 2021 at 11:37 AM Saeed Mahameed > wrote: > > > For more detailed information about subfunctions please see detailed tag > > log below. > > Apologies for the tardy question out of left field, but I've bee

RE: [pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-25 Thread Parav Pandit
> From: Edwin Peer > Sent: Tuesday, January 26, 2021 1:36 AM > > On Mon, Jan 25, 2021 at 11:49 AM Jason Gunthorpe > wrote: > > > I've never seen someone implement a NumVF > 256 by co-opting the bus > > number. > > Usually the VF offset already places the VF routing IDs into a > different bus

[PATCH iproute2-next 2/2] vdpa: Add vdpa tool

2021-01-22 Thread Parav Pandit
"max_vqs": 2, "max_vq_size": 256 } } } Delete the vdpa device after its use: $ vdpa dev del foo2 Signed-off-by: Parav Pandit --- Makefile| 2 +- man/man8/vdpa-dev.8 | 96 + man/man8/vdpa-mgmtdev.8 | 53 +++ man/man8/

[PATCH iproute2-next 1/2] Add kernel headers

2021-01-22 Thread Parav Pandit
Add kernel headers to commit from kernel tree [1]. 79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices") [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch: linux-next Signed-off-by: Parav Pandit --- include/uapi/linux/vdpa.h

[PATCH iproute2-next 0/2] Add vdpa device management tool

2021-01-22 Thread Parav Pandit
mary: Patch-1 adds kernel headers for vdpa subsystem Patch-2 adds vdpa tool and its man pages Kernel headers are from the vhost kernel tree [1] from branch linux-next. [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git Parav Pandit (2): Add kernel headers vdpa: Add vdpa tool

[PATCH iproute2-next RESEND] devlink: Extend man page for port function set command

2021-01-21 Thread Parav Pandit
Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- man/man8/devlink-port.8 | 21 + 1 file changed, 21 insertions(+) diff --git a/man/man8/devlink-port.8 b

RE: [net-next V9 04/14] devlink: Support get and set state of port function

2021-01-21 Thread Parav Pandit
> From: Samudrala, Sridhar > Sent: Friday, January 22, 2021 2:23 AM > > On 1/21/2021 12:52 AM, Saeed Mahameed wrote: > > From: Parav Pandit > > > > devlink port function can be in active or inactive state. > > Allow users to get and set port function's

RE: [net-next V9 03/14] devlink: Support add and delete devlink port

2021-01-21 Thread Parav Pandit
> From: Samudrala, Sridhar > Sent: Friday, January 22, 2021 2:21 AM > > > $ devlink port show > > pci/:06:00.0/65535: type eth netdev ens2f0np0 flavour physical > > port 0 splittable false > > > > $ devlink port add pci/:06:00.0 flavour pcisf pfnum 0 sfnum 88 > > Do we need to specify

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-19 Thread Parav Pandit
> From: Virtualization On > Behalf Of Parav Pandit > > > From: Jason Wang > > Sent: Tuesday, January 19, 2021 4:39 PM > > To: Parav Pandit ; Michael S. Tsirkin > > > > Cc: virtualizat...@lists.linux-foundation.org; Eli Cohen > > ; netdev@vger

RE: [net-next V7 03/14] devlink: Support add and delete devlink port

2021-01-19 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, January 20, 2021 8:58 AM > > On Mon, 18 Jan 2021 12:12:20 -0800 Saeed Mahameed wrote: > > From: Parav Pandit > > Saeed, this is closed to being merged - when you post the next version please > make sure to CC appropriate

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-19 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, January 19, 2021 4:39 PM > To: Parav Pandit ; Michael S. Tsirkin > Cc: virtualizat...@lists.linux-foundation.org; Eli Cohen ; > netdev@vger.kernel.org; Sean Mooney > Subject: Re: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user &

RE: [PATCH 0/7] Introduce vdpa management tool

2021-01-18 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Wednesday, December 9, 2020 4:17 AM > > On 11/26/20 8:53 PM, Jason Wang wrote: > > 1. Where does userspace vdpa tool reside which users can use? > > Ans: vdpa tool can possibly reside in iproute2 [1] as it enables user > > to create vdpa net devices. > > ip

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-18 Thread Parav Pandit
Hi Michael, Jason, > From: Jason Wang > Sent: Friday, January 15, 2021 11:09 AM > > > Thanks for the clarification. I think we'd better document the above in the > patch that introduces the mac setting from management API. Can we proceed with this patchset? We like to progress next to iproute2

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-14 Thread Parav Pandit
> From: Jason Wang > Sent: Friday, January 15, 2021 11:09 AM > > > On 2021/1/14 下午3:58, Parav Pandit wrote: > > > >> From: Jason Wang > >> Sent: Thursday, January 14, 2021 9:48 AM > >> > >> On 2021/1/7 上午11:48, Parav Pandit wro

RE: [net-next V6 02/14] devlink: Introduce PCI SF port flavour and port attribute

2021-01-14 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Thursday, January 14, 2021 11:52 PM > > On Thu, 14 Jan 2021 17:53:09 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Thursday, January 14, 2021 11:13 PM > > > > > > On Wed,

RE: [net-next V6 02/14] devlink: Introduce PCI SF port flavour and port attribute

2021-01-14 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Thursday, January 14, 2021 11:13 PM > > On Wed, 13 Jan 2021 11:27:18 -0800 Saeed Mahameed wrote: > > /** > > * struct devlink_port_attrs - devlink port object > > * @flavour: flavour of the port > > @@ -114,6 +126,7 @@ struct devlink_port_attrs { > >

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-14 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, January 14, 2021 9:48 AM > > On 2021/1/7 上午11:48, Parav Pandit wrote: > > > >> From: Michael S. Tsirkin > >> Sent: Tuesday, January 5, 2021 6:53 PM > >> > >> On Tue, Jan 05, 2021 at 12:30:15PM +

  1   2   3   4   5   6   >