Dear Christophe,
Am 11.04.21 um 18:23 schrieb Christophe Leroy:
Le 11/04/2021 à 13:09, Paul Menzel a écrit :
Related to * [CVE-2021-29154] Linux kernel incorrect computation of
branch displacements in BPF JIT compiler can be abused to execute
arbitrary code in Kernel mode* [1], on the
Dear Linux folks,
Related to * [CVE-2021-29154] Linux kernel incorrect computation of
branch displacements in BPF JIT compiler can be abused to execute
arbitrary code in Kernel mode* [1], on the POWER8 system IBM S822LC with
self-built Linux 5.12.0-rc5+, I am unable to disable `bpf_jit_enable
Dear Gustavo,
Thank you for working on that.
Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.
It would be nice to h
;& xdp_rxq_info_reg(&rx_ring->xdp_rxq,
adapter->netdev,
+ rx_ring->queue_index,
+ rx_ring->q_vector->napi.napi_id)
< 0)
Unrelated, but I always wonder, if there shouldn’t be more logging for
the error cases.
Dear Jakub, dear Greg,
Am 05.01.21 um 18:25 schrieb Greg KH:
On Tue, Jan 05, 2021 at 06:16:59PM +0100, Paul Menzel wrote:
Am 03.11.20 um 19:39 schrieb Jakub Kicinski:
On Tue, 3 Nov 2020 08:35:09 +0100 Paul Menzel wrote:
According to *Developer's Certificate of Origin 1.1* [3], it
Dear Jakub, dear Greg,
Am 03.11.20 um 19:39 schrieb Jakub Kicinski:
On Tue, 3 Nov 2020 08:35:09 +0100 Paul Menzel wrote:
According to *Developer's Certificate of Origin 1.1* [3], it’s my
understanding, that it is *not* required. The items (a), (b), and (c)
are connected by a
l_fdir_entry(adapter, input, input->sw_idx);
spin_unlock(&adapter->fdir_perfect_lock);
if ((uhtid != 0x800) && (adapter->jump_tables[uhtid]))
Reviewed-by: Paul Menzel
I wonder, in the non-error case, how `input` and `jump`
[Sorry, I did not know where and how to import the thread, and only got
the first message from Patchwork.]
Dear Linux folks,
Am 25.06.20 um 18:52 schrieb Wolfram Sang:
Missing this firmware is not fatal, my wifi card still works. Even more,
I couldn't find any documentation what it is or whe
: Guohan Lu
Signed-off-by: Paul Menzel
---
drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 3 +++
drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c
b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c
index
Dear Sven,
Am 11.11.20 um 11:10 schrieb Sven Auhagen:
On Wed, Nov 11, 2020 at 08:11:46AM +0100, Paul Menzel wrote:
Am 19.10.20 um 10:05 schrieb sven.auha...@voleatech.de:
From: Sven Auhagen
Add an extack error message when the RX buffer size is too small
for the frame size.
Suggested-by
Dear Sven,
Am 19.10.20 um 10:05 schrieb sven.auha...@voleatech.de:
From: Sven Auhagen
Add an extack error message when the RX buffer size is too small
for the frame size.
Suggested-by: Maciej Fijalkowski
Reviewed-by: Maciej Fijalkowski
Acked-by: Maciej Fijalkowski
Signed-off-by: Sven Auha
Dear Jakub,
Am 03.11.20 um 01:19 schrieb Jakub Kicinski:
On Tue, 3 Nov 2020 00:13:07 +0100 Paul Menzel wrote:
From: Jeffrey Townsend
The ops field might no be defined, so add a check.
This change should be first, otherwise AFAIU if someone builds the
kernel in between the commits (e.g
Dear Linux folks,
Am 03.11.20 um 00:13 schrieb Paul Menzel:
From: Jeffrey Townsend
The BCM5461S PHY is used in switches.
The patch is taken from Open Network Linux, and it was added there as
patch
packages/base/any/kernels/3.16+deb8/patches/driver-support-intel-igb-bcm5461X-phy.patch
Signed-off-by: Paul Menzel
---
drivers/net/ethernet/intel/igb/e1000_phy.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c
b/drivers/net/ethernet/intel/igb/e1000_phy.c
index 4e0b4ba09a00..4151e55a6d2a 100644
--- a/drivers/net
].
[1]:
https://github.com/opencomputeproject/OpenNetworkLinux/commit/f32316c63ce3a64de125b7429115c6d45e942bd1
[2]:
https://github.com/opencomputeproject/OpenNetworkLinux/commit/5ace6bcdb37cb8065dcd1d4404b3dcb6424f6331
Cc: Jeffrey Townsend
Cc: John W Linville
Signed-off-by: Paul Menzel
Dear Linux folks,
Looking a little bit at Open Network Linux, they carry some Linux
patches, but have not upstreamed them yet. This upstreams support for
the PHY BCM5461S. It’d be great, if you could help review it.
Kind regards,
Paul
Jeffrey Townsend (2):
ethernet: igb: Support PHY BCM546
Dear Tong,
Am 01.10.20 um 09:03 schrieb Paul Menzel:
Am 08.09.20 um 18:22 schrieb Tong Zhang:
length may be corrupted in rx_desc
How can that be?
and lead to panic, so check the sanity before passing it to skb_put
[ 167.667701] skbuff: skb_over_panic: text:b1e32cc1 len:60224
Dear Tong,
Thank you for your patch.
Am 08.09.20 um 18:22 schrieb Tong Zhang:
length may be corrupted in rx_desc
How can that be?
and lead to panic, so check the sanity before passing it to skb_put
[ 167.667701] skbuff: skb_over_panic: text:b1e32cc1 len:60224
put:60224 head:
Dear Kai-Heng,
Thank you for patch version 3.
Am 24.09.20 um 18:45 schrieb Kai-Heng Feng:
We are seeing the following error after S3 resume:
[ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
[ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete
[ 704.902817] e1000e 00
Dear Kai-Heng,
Thank you for sending version 2.
Am 24.09.20 um 17:09 schrieb Kai-Heng Feng:
We are seeing the following error after S3 resume:
I’d be great if you added the system and used hardware, you are seeing
this with.
[ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
[
Dear Andrew,
Am 23.09.20 um 21:28 schrieb Andrew Lunn:
How much does this increase the resume time?
Define resume time? Until you get the display manager unlock screen?
Or do you need working networking?
Until network is functional again. Currently, the speed negotiation
alone takes three(
Dear Kai-Heng,
Am 23.09.20 um 16:46 schrieb Kai-Heng Feng:
On Sep 23, 2020, at 21:28, Paul Menzel wrote:
Am 23.09.20 um 09:47 schrieb Kai-Heng Feng:
We are seeing the following error after S3 resume:
[ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
[ 704.844232] e1000e
Dear Kai-Heng,
Am 23.09.20 um 09:47 schrieb Kai-Heng Feng:
We are seeing the following error after S3 resume:
[ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020
[ 704.844232] e1000e :00:1f.6 eno1: MDI Write did not complete
[ 704.902817] e1000e :00:1f.6 eno1: Setting page 0x
Dear Björn,
Am 08.09.20 um 13:12 schrieb Björn Töpel:
On 2020-09-08 12:12, Paul Menzel wrote:
Am 07.09.20 um 17:02 schrieb Björn Töpel:
From: Björn Töpel
Start using XSK_NAPI_WEIGHT as NAPI poll budget for the AF_XDP Rx
zero-copy path.
Could you please add the description from the
Dear Björn,
Am 07.09.20 um 17:02 schrieb Björn Töpel:
From: Björn Töpel
Start using XSK_NAPI_WEIGHT as NAPI poll budget for the AF_XDP Rx
zero-copy path.
Could you please add the description from the patch series cover letter
to this commit too? To my knowledge, the message in the cover le
Dear Linux folks,
On the Dell XPS 9360, testing Linux 5.8-rc4 from the Ubuntu Linux Kernel
Mainline PPA [1], when running
sudo ./sleepgraph.py -config config/suspend.cfg -multi 50 15
Linux logged the messages below *once* during suspend with the Dell
DA200 USB-C port replicator(?) attac
Dear Aaron,
Thank you for your patch.
(Rant: Some more fallout from the other patch, which nobody reverted.)
Am 16.06.20 um 12:05 schrieb Aaron Ma:
After commit "e1000e: disable s0ix entry and exit flows for ME systems",
some ThinkPads always failed to disable ulp by ME.
Please add the (sho
Dear Stefan,
On 03.09.19 08:08, Stefan Assmann wrote:
In the case of an invalid min tx rate being requested
i40e_ndo_set_vf_bw() immediately returns -EINVAL instead of releasing
__I40E_VIRTCHNL_OP_PENDING first.
What problem does this cause?
Signed-off-by: Stefan Assmann
---
drivers/net/
Dear Linux folks,
On 01.02.19 22:34, Paul Menzel wrote:
[attaching Linux messages, lspci and lsusb output]
On 01.02.19 22:20, Paul Menzel wrote:
When trying to pair a Dell Latitude E7250 running Debian Sid/unstable
with Linux 4.20 and GNOME 3.30 with an LG TV, after starting the
pairing
Dear Linux folks,
When trying to pair a Dell Latitude E7250 running Debian Sid/unstable
with Linux 4.20 and GNOME 3.30 with an LG TV, after starting the pairing
process the TV is listed. in Bluetooth dialog of GNOME setting.
The TV displays the instructions below.
Complete the next three s
Dear Björn,
On 01/21/19 17:33, bjorn.to...@gmail.com wrote:
> From: Björn Töpel
>
> GCC will generate jump tables for switch-statements with more than 5
> case statements. An entry into the jump table is an indirect call,
> which means that for CONFIG_RETPOLINE builds, this is rather
> expensiv
Dear Björn,
On 08/24/18 16:00, Jesper Dangaard Brouer wrote:
> On Fri, 24 Aug 2018 13:21:59 +0200
> Björn Töpel wrote:
>
>> When XDP is enabled, the driver will report incorrect
>> statistics. Received frames will reported as transmitted frames.
>>
>> This commits fixes the i40e implementation
ies */
#define I40E_MAX_ITR 0x0FF0 /* reg uses 2 usec resolution */
@@ -428,6 +430,7 @@ struct i40e_ring {
*/
struct i40e_channel *ch;
+ struct xdp_rxq_info xdp_rxq;
} ____cacheline_internodealigned_in_smp;
static inline bool ring_uses_build_skb(struct i40e_ring *ring)
Reviewed-by: Paul Menzel
Kind regards,
Paul
Dear Intel folks,
Changing our login setup, we noticed sometimes the RPC time-out
`do_ypcall: clnt_call: RPC: Timed out` when calling `getspnam()` on
exactly one type of machines, Dell OptiPlex 990, with the ethernet
device 82579LM.
Please find DMI info fetched with `dmicode -s …`, where th
Dear Pavel,
On 12/10/17 09:39, Pavel Machek wrote:
In v4.15-rc2+, network manager can not see my ethernet card, and
manual attempts to ifconfig it up did not really help, either.
Card is:
02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit
Ethernet Controller
Dmesg says:
dmes
Dear Matthew,
On 08/23/17 17:59, Matthew Tan wrote:
Calls to udelay are not preemtable by userspace so userspace
applications experience a large (~200us) latency when running on core
0. Instead usleep_range can be used to be more friendly to userspace
since it is preemtable.
Dear David,
On 2017-06-02 20:37, David Miller wrote:
From: Cong Wang
Date: Fri, 2 Jun 2017 10:51:39 -0700
On Thu, Jun 1, 2017 at 10:32 AM, Paul Menzel
wrote:
On 06/01/17 18:19, David Miller wrote:
Neither of us have anything to do with the 4.4 -stable series. We
only
manage stable
Dear David,
On 06/01/17 18:19, David Miller wrote:
Neither of us have anything to do with the 4.4 -stable series. We only
manage stable backport submissions for the most recent two releases.
Thank you for the prompt response. Should the netdev FAQ be updated then
to contain that information
Dear David, dear Eric,
We noticed, that we manually apply commit 52bd2d62ce67 (net: better
skb->sender_cpu and skb->napi_id cohabitation), present since v4.5-rc1,
to our Linux 4.4 images.
Would it be useful to have it included in the 4.4 series?
Kind regards,
Paul
Dear Benjamin,
Thank you for your fix.
On 04/21/17 23:20, Benjamin Poirier wrote:
Some statistics passed to ethtool are garbage because e1000e_get_stats64()
doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
memory to userspace and confuses users.
Could you please give s
Dear Linux folks,
The ASRock E350M1 has a Realtek ethernet controller.
It takes almost three seconds for the link to become ready. This is
noticeable after resume from suspend, where the user wants to continue
working but first has to wait for the network.
This test is done with Linux 4.10.
``
On 11/14/16 18:28, David Miller wrote:
From: Paul Menzel
Date: Mon, 14 Nov 2016 09:25:47 +0100
On 11/13/16 06:01, Baoquan He wrote:
This is v2 post.
In commit 3e1be7a ("bnx2: Reset device during driver initialization"),
firmware requesting code was moved from open stage to probe
Dear Baoquan,
On 11/13/16 06:01, Baoquan He wrote:
This is v2 post.
In commit 3e1be7a ("bnx2: Reset device during driver initialization"),
firmware requesting code was moved from open stage to probe stage.
The reason is in kdump kernel hardware iommu need device be reset in
driver probe stage,
inclusion into the stable Linux kernel.
Acked-by: Paul Menzel
Thanks,
Paul
Dear Baoquan,
On 10/31/16 11:09, Baoquan He wrote:
On 10/26/16 at 12:31pm, Paul Menzel wrote:
Baoquan, could you please fix this regression. My suggestion is, that you
add the old code back, but check if the firmware has been loaded. If it
hasn’t, load it again.
That way, people can update
Dear Baoquan,
Am Samstag, den 29.10.2016, 10:55 +0800 schrieb Baoquan He:
> On 10/27/16 at 03:21pm, Paul Menzel wrote:
> > > > Baoquan, could you please fix this regression. My suggestion is, that
> > > > you
> > > > add the old code back, but check
Dear Baoquan,
On 10/26/16 14:00, Baoquan He wrote:
On 10/26/16 at 12:31pm, Paul Menzel wrote:
dev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG |
@@ -8607,6 +8608,7 @@ bnx2_init_one(struct pci_dev *pdev, const struct
pci_device_id *ent)
return 0;
er
Dear Baoquan, Linux folks,
I am sorry for Thunderbird’s autowrapping messing up the message formatting.
On 10/25/16 16:33, Paul Menzel wrote:
A server with the Broadcom devices below, fails to load the drivers
because of missing firmware.
$ lspci -nn
[…]
01:00.0 Ethernet controller [0200
Dear Rick,
On 10/25/16 17:24, Rick Jones wrote:
On 10/25/2016 07:33 AM, Paul Menzel wrote:
A server with the Broadcom devices below, fails to load the drivers
because of missing firmware.
I have run into the same sort of issue from time to time when going to a
newer kernel. A newer
Dear Linux folks,
A server with the Broadcom devices below, fails to load the drivers
because of missing firmware.
> $ lspci -nn
> […]
01:00.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme II BCM5709
Gigabit Ethernet [14e4:1639] (rev 20)
01:00.1 Ethernet controller [0200]: Broa
Dear Linux folks,
Running the Firmware Test Suite (fwts) [1] on an ASRock E350M1, it
suggests that ASPM should be enabled.
The module r8169 disables ASPM since the commit below.
commit ba04c7c93bbcb48ce880cf75b6e9dffcd79d4c7b
Author: Stanislaw Gruszka
Date: Tue Feb 22 02:00:11 2011 +
51 matches
Mail list logo
