Re: [PATCH 1/2] slab, slub, slob: add slab_flags_t

2017-10-21 Thread Pekka Enberg
On 21/10/2017 13.02, Alexey Dobriyan wrote: Add sparse-checked slab_flags_t for struct kmem_cache::flags (SLAB_POISON, etc). SLAB is bloated temporarily by switching to "unsigned long", but only temporarily. Signed-off-by: Alexey Dobriyan Acked-by: Pekka Enberg

Re: [PATCH 2/2] slab, slub, slob: convert slab_flags_t to 32-bit

2017-10-21 Thread Pekka Enberg
by: Alexey Dobriyan Acked-by: Pekka Enberg

Re: [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2

2008-02-02 Thread Pekka Enberg
Hi, On Feb 2, 2008 8:25 PM, Ondrej Zary <[EMAIL PROTECTED]> wrote: > +//static __be16 el3_phys_addr[EL3_MAX_CARDS][3]; [snip] > +//#if defined(CONFIG_MCA) || defined(CONFIG_EISA) [snip] > +// while (el3_probe(el3_cards) == 0) { > +// if (irq[el3_cards] > 1) > +//

Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

2007-12-10 Thread Pekka Enberg
Hi Richard, On Dec 10, 2007 9:29 PM, Richard Knutsson <[EMAIL PROTECTED]> wrote: > Remove local definition of TRUE/FALSE. This is already fixed in Francois' tree: http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commitdiff;h=2af61e99e3d1c959840ea007ff56b15db794fb99

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Pekka Enberg
Hi Michael, On Monday 05 November 2007 13:23:50 Pekka Enberg wrote: > > Is CONFIG_DEBUG_SLAB enabled? Usually these kind of random corruptions > > are caused by someone passing a bad pointer to kfree() or > > kmem_cache_free(). On 11/5/07, Michael Buesch <[EMAIL PROT

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Pekka Enberg
Hi Michael, On Sat, 2007-11-03 at 21:06 +0100, Michael Buesch wrote: > Who is responsible for slab btw? > I mean, someone should be interested in getting this bug fixed. :) > When using slab I see random corruptions. I think related to rmmod, but > I'm not sure. I don't see this with slub. Is CON

Re: [PATCH 08/40] mm: kmem_cache_objsize

2007-05-04 Thread Pekka Enberg
Christoph Lameter wrote: On Fri, 4 May 2007, Pekka Enberg wrote: Again, slab has no way of actually estimating how many pages you need for a given number of objects. So we end up calculating some upper bound which doesn't belong in mm/slab.c. I am perfectly okay with: It can give a

Re: [PATCH 08/40] mm: kmem_cache_objsize

2007-05-04 Thread Pekka Enberg
Christoph Lameter wrote: SLAB can calculate exactly how many pages are needed. The per cpu and per node stuff is setup at boot and does not change. We are talking about the worst case scenario here. True in case of an off slab we have additional overhead that would also have to go into worst cas

Re: [PATCH 08/40] mm: kmem_cache_objsize

2007-05-04 Thread Pekka Enberg
On Fri, 2007-05-04 at 11:30 -0700, Christoph Lameter wrote: > Hmmm... Maybe lets have > > unsigned kmem_estimate_pages(struct kmem_cache *slab_cache, int objects) > > which would calculate the worst case memory scenario for allocation the > number of indicated objects? On Fri, 4 May 2007, Pete

Re: [PATCH 08/40] mm: kmem_cache_objsize

2007-05-04 Thread Pekka Enberg
Christoph Lameter wrote: Hmmm... Maybe lets have unsigned kmem_estimate_pages(struct kmem_cache *slab_cache, int objects) which would calculate the worst case memory scenario for allocation the number of indicated objects? IIRC this looks more or less what Peter had initially. I don't like t

Re: [PATCH 08/40] mm: kmem_cache_objsize

2007-05-04 Thread Pekka Enberg
On 5/4/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote: Expost buffer_size in order to allow fair estimates on the actual space used/needed. [snip] #ifdef CONFIG_SLAB_FAIR -static inline int slab_alloc_rank(gfp_t flags) +static __always_inline int slab_alloc_rank(gfp_t flags) { return

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka Enberg
On 3/12/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [patch 4/4] [TULIP] Rev tulip version

2007-03-12 Thread Pekka Enberg
Hi, On 3/12/07, Valerie Henson <[EMAIL PROTECTED]> wrote: --- tulip-2.6-mm-linux.orig/drivers/net/tulip/tulip_core.c +++ tulip-2.6-mm-linux/drivers/net/tulip/tulip_core.c @@ -17,11 +17,11 @@ #define DRV_NAME "tulip" #ifdef CONFIG_TULIP_NAPI -#define DRV_VERSION"1.1.14-NAPI" /* Keep

Re: [PATCH 08/29] mm: kmem_cache_objs_to_pages()

2007-02-22 Thread Pekka Enberg
On 2/22/07, Pekka Enberg <[EMAIL PROTECTED]> wrote: So you are only interested in rough estimation of how much many pages you need for a given amount of objects? Why not use ksize() for that then? Uhm, I obviously meant, why not expose obj_size() instead. - To unsubscribe from this list

Re: [PATCH 08/29] mm: kmem_cache_objs_to_pages()

2007-02-22 Thread Pekka Enberg
Hi Peter, On Wed, 2007-02-21 at 17:47 +0200, Pekka Enberg wrote: > So how does this work? You ask the slab allocator how many pages you > need for a given number of objects and then those pages are available > to it via the page allocator? Can other users also dip into those > rese

Re: [PATCH 08/29] mm: kmem_cache_objs_to_pages()

2007-02-21 Thread Pekka Enberg
Hi Peter, On 2/21/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote: Provide a method to calculate the number of pages needed to store a given number of slab objects (upper bound when considering possible partial and free slabs). So how does this work? You ask the slab allocator how many pages you

Re: [PATCH 02/29] mm: slab allocation fairness

2007-02-21 Thread Pekka Enberg
On 2/21/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote: [AIM9 results go here] Yes please. I would really like to know what we gain by making the slab even more complex. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [PATCH 1/7] ip1000: update maintainer information

2006-08-17 Thread Pekka Enberg
Hi Jesse, On 8/17/06, Jesse Huang <[EMAIL PROTECTED]> wrote: From: Jesse Huang <[EMAIL PROTECTED]> update maintainer information Change Logs: update maintainer information The patches are missing signed-off-by so please resend. I am starting my vacation on friday so I suggest you send th

Re: [RFC 1/4] kevent: core files.

2006-07-09 Thread Pekka Enberg
On 7/9/06, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: +struct kevent *kevent_alloc(gfp_t mask) +{ + struct kevent *k; + + if (kevent_cache) + k = kmem_cache_alloc(kevent_cache, mask); + else + k = kzalloc(sizeof(struct kevent), mask); + + retur

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-21 Thread Pekka Enberg
Hi David, On 5/21/06, David Vrabel <[EMAIL PROTECTED]> wrote: Did anyone manage to get a response from IC Plus regarding the required Signed-off-by line? The current IP1000A driver maintainer at IC Plus is [EMAIL PROTECTED] I have no received confirmation if he can sign off or not yet.

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Pekka Enberg
Pekka J Enberg <[EMAIL PROTECTED]> : > [...] > > maintain the tree, I can send you my patches so you can recreate the full > > history. The first steps were produced by quilt on the original > > out-of-tree driver, though, so they're probably not helpful. On Thu, 2006-05-04 at 01:35 +0200, Franc

Re: [PATCH 2/3] ipg: leaks in ipg_probe

2006-05-02 Thread Pekka Enberg
Pekka J Enberg <[EMAIL PROTECTED]> : > [...] > > Is this tested with hardware? On Tue, 2006-05-02 at 20:33 +0200, Francois Romieu wrote: > No. On Tue, 2006-05-02 at 20:33 +0200, Francois Romieu wrote: > > Alignment of the start address looks bogus for sure, but any idea > > why they had it in the

Re: IP1000 gigabit nic driver

2006-05-01 Thread Pekka Enberg
t 2.5 MHz (the maximum according to the datasheet) instead of 500 Hz. (David) The patch is 128 KB in size, so I am not including it in this mail. You can find the patch here: http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch Signed-off-by: David Vrabel <[EMAIL PROTECTED]>

Re: IP1000 gigabit nic driver

2006-05-01 Thread Pekka Enberg
On Mon, 2006-05-01 at 00:40 +0100, David Vrabel wrote: > Still pending. Also: > > - something (PHY reset/auto negotiation?) takes 2-3 seconds and >appears to be done with interrupts disabled. Are you seeing this at module initialization? Does Sysrq-t show anything useful?

Re: IP1000 gigabit nic driver

2006-05-01 Thread Pekka Enberg
don't know if I broke anything. The patch is 128 KB in size, so I am not including it in this mail. You can find the patch here: http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch Signed-off-by: David Vrabel <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED

Re: IP1000 gigabit nic driver

2006-04-30 Thread Pekka Enberg
On Sat, 2006-04-29 at 14:21 +0200, David Gómez wrote: > > I already had it modified, just needed to create the patch... Anyway, > > have you submitted it to netdev? On Sat, 2006-04-29 at 23:35 +0300, Pekka Enberg wrote: > No, I haven't. I don't have the hardware, s

Re: IP1000 gigabit nic driver

2006-04-29 Thread Pekka Enberg
Hi David, On Sat, 2006-04-29 at 14:21 +0200, David Gómez wrote: > I already had it modified, just needed to create the patch... Anyway, > have you submitted it to netdev? No, I haven't. I don't have the hardware, so I can't test the driver. Furthermore, there's plenty of stuff to fix before it's

Re: IP1000 gigabit nic driver

2006-04-29 Thread Pekka Enberg
On Fri, 28 Apr 2006, David Gómezz wrote: > > Ok, i could take care of that, and it's a good way of getting my hands > > dirty with kernel programming ;). David, if it's ok to you i'll do the > > cleanup thing. On Fri, 2006-04-28 at 14:59 +0300, Pekka J Enberg wrote: > Here are some suggestions for

Re: IP1000 gigabit nic driver

2006-04-28 Thread Pekka Enberg
On 4/28/06, David Gómez <[EMAIL PROTECTED]> wrote: > I could help. What things do you think need to be fixed before > submitting the driver? Needs some serious coding style cleanup and conversion to proper 2.6 APIs for starters. - To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [RFT/PATCH] 3c509: use proper suspend/resume API

2006-02-15 Thread Pekka Enberg
On Wed, Feb 15, 2006 at 01:23:19PM +0200, Pekka J Enberg wrote: > > Hmm. Either I am totally confused or we don't even attempt suspend/resume > > for eisa and mca bus devices. Care to try this patch? On Wed, 2006-02-15 at 12:40 +, Russell King wrote: > Please don't use struct device_driver su

[RFT/PATCH] 3c509: use proper suspend/resume API

2006-02-14 Thread Pekka Enberg
Hi, I am looking for someone with 3c509 netword card that can do suspend/resume to test this patch. Pekka Subject: 3c509: use proper suspend/resume API From: Pekka Enberg <[EMAIL PROTECTED]> This patch converts 3c509 driver to use proper suspend/resume API inst