[PATCH 7/8] ipg: naming convention fixes

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> This changes some camel-case names to follow proper kernel naming convention. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/i

[PATCH 5/8] ipg: remove commented out code

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 34 ++ drivers/net/ipg.h |4 +---

[PATCH 4/8] ipg: remove driver version

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> The driver is in mainline now so there's no need to maintain a separate version number. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- dri

[PATCH 2/8] ipg: remove boolean macros

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/ipg.h | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-

[PATCH 8/8] ipg: fix checkpatch reported errors

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 48 +--- drivers/net/ipg.h

[PATCH 3/8] ipg: remove IPG_DEV_KFREE_SKB macro

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 28 ++-- drivers/net/ipg.h |2 -- 2 files

[PATCH 1/8] ipg: remove old contact information

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Remove old comment as up-to-date contact information is in MAINTAINERS. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/ipg.h |

[PATCH 6/8] ipg: remove some internal comments

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> This removes some now useless comments that were added when the driver was developed out-of-tree. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]

Re: [PATCH 08/40] mm: kmem_cache_objsize

2007-05-05 Thread Pekka J Enberg
On Fri, 4 May 2007, Christoph Lameter wrote: > He is not able to calculate it just using the object size since he does > not know where the slab put the slab management structure. And in case of > SLUB there is no slab management structure... Which means he would have to > special case based on

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka J Enberg
On 3/9/07, David Miller <[EMAIL PROTECTED]> wrote: > The whole cahce-multipath subsystem has to have it's guts revamped for > proper error handling. (Untested patch follows.) From: Amit Choudhary <[EMAIL PROTECTED]> Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file ne

[RFC/PATCH] ipg: add jumbo frame support kconfig option

2008-02-26 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Convert the internal JUMBO_FRAME #ifdef to CONFIG_IP1000_JUMBO_FRAME proper and fix compilation errors. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROT

[RFC/PATCH] ipg: add jumbo frame support kconfig option

2008-02-26 Thread Pekka J Enberg
[ Sorry for the duplicate. I typoed Francois' email address. ] From: Pekka Enberg <[EMAIL PROTECTED]> Convert the internal JUMBO_FRAME #ifdef to CONFIG_IP1000_JUMBO_FRAME proper and fix compilation errors. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Hu

Re: [PATCH 1/3] ipg: removal of unreachable code

2006-05-01 Thread Pekka J Enberg
On Tue, 2 May 2006, Francois Romieu wrote: > map/unmap is done in ipg_{probe/remove} Applied. Thanks! Pekka - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.

Re: [PATCH 2/3] ipg: leaks in ipg_probe

2006-05-01 Thread Pekka J Enberg
On Tue, 2 May 2006, Francois Romieu wrote: > The error paths are badly broken. > > Bonus: > - remove duplicate initialization of sp; > - remove useless NULL initialization of dev; > - USE_IO_OPS is not used (and the driver does not seem to care about > posted writes, rejoice). > > Signed-off-by

Re: [PATCH 3/3] ipg: plug leaks in the error path of ipg_nic_open

2006-05-01 Thread Pekka J Enberg
On Tue, 2 May 2006, Francois Romieu wrote: > Added ipg_{rx/tx}_clear() to factor out some code. > > Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Applied. Thanks! Pekka - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-02 Thread Pekka J Enberg
Hi Francois, On Tue, 2 May 2006, Francois Romieu wrote: > Btw the whole serie is available in branch 'netdev-ipg' at: > git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git > > The interim steps may be useful if testing reveals something wrong > (especially if it happens in a few weeks/mont

Re: IP1000 gigabit nic driver

2006-05-03 Thread Pekka J Enberg
On Wed, 3 May 2006, Andrew Morton wrote: > Please remember that to merge this we'll need a signed-off-by from the > original developers. (That's not very gplish, but such is life). OK. Lets see if we can track one of them developers down. I see Craig Rich's email (only email found in the origina

Re: [PATCH] ipg: removing more dead code

2006-05-03 Thread Pekka J Enberg
Hi David, On Wed, 3 May 2006, David Gómezz wrote: > I'll test it tomorrow ASAP. For now, here is another patch removing > more dead code. This code is never reached (NOTGRACE is not defined) > and the *fiber_detect functions are subsequently never used. No need to resend this one, but in future,

Re: Sign-off for the IP1000A driver before inclusion

2006-05-23 Thread Pekka J Enberg
On Wed, 24 May 2006, jesse\(??\)\) wrote: > We had read this document, but we can't find any blank at which we can sign. > Could you tell us where we can sign it off. You sign it off in the patch submission. It's enough that you agree on it and let us know a sign off line: Signed-off-by: John D

Re: Sign-off for the IP1000A driver before inclusion

2006-05-29 Thread Pekka J Enberg
On Tue, 30 May 2006, jesse\(??\)~H~H\) wrote: > I had did some modification of ipg.h and ipg.c. Please see attach file. > 20060521-2.6.17-rc4-git-ip1000-test.patch__icplus_modify.zip Please send them as regular patches. Please Documentation/SubmittingPatches and the following URL for details: h

Re: Sign-off for the IP1000A driver before inclusion

2006-05-30 Thread Pekka J Enberg
On Mon, 29 May 2006, Andrew Morton wrote: > It takes people quite a few iterations to get patch preparation worked out. > > Pekka, if you have time, perhaps you can extract the patches for us? Jesse, I wasn't able to work out the ipg_config_autoneg() changes, but the rest of them are at: http

Re: Sign-off for the IP1000A driver before inclusion

2006-05-30 Thread Pekka J Enberg
Hi Jesse, On Tue, 30 May 2006, jesse\(??\)~H~H\) wrote: > Sorry for that. I try to generate the patch file. But I only can use > "diff -uN" to generate it. The "diff --git" is not work. I still try to > generate it. I assume you're using Francois' git tree, right? What you need to do is: - Ch

Re: [RFT/PATCH] 3c509: use proper suspend/resume API

2006-02-15 Thread Pekka J Enberg
On Wed, 15 Feb 2006, Andrew Morton wrote: > I have a 3c509, and I'm not afraid to use it! > > Problem is, it doesn't resume correctly either with or without the patch: > it needs rmmod+modprobe to get it going again. (Which is better than the > aic7xxx driver, which has a coronary and panics the

Re: [RFT/PATCH] 3c509: use proper suspend/resume API

2006-02-15 Thread Pekka J Enberg
Hi Andrew, On Wed, 15 Feb 2006, Andrew Morton wrote: > Problem is, it doesn't resume correctly either with or without the patch: > it needs rmmod+modprobe to get it going again. (Which is better than the > aic7xxx driver, which has a coronary and panics the kernel on post-resume > reboot). Hmm.

Re: IP1000 gigabit nic driver

2006-04-28 Thread Pekka J Enberg
On Apr 28 at 01:58:04, Pekka Enberg wrote: > > Needs some serious coding style cleanup and conversion to proper 2.6 > > APIs for starters. On Fri, 28 Apr 2006, David Gómezz wrote: > Ok, i could take care of that, and it's a good way of getting my hands > dirty with kernel programming ;). David, if

Re: IP1000 gigabit nic driver

2006-04-28 Thread Pekka J Enberg
Hi David, On Fri, 28 Apr 2006, David Gómezz wrote: > Ok, i could take care of that, and it's a good way of getting my hands > dirty with kernel programming ;). David, if it's ok to you i'll do the > cleanup thing. Here are some suggestions for coding style cleanups: - Use Lindet for initial fo