Re: [PATCH v3] ip6_tunnel: Correct tos value in collect_md mode

2017-06-18 Thread Peter Dawson
On Sat, 17 Jun 2017 11:38:05 +0800 Haishuang Yan <yanhaishu...@cmss.chinamobile.com> wrote: > Same as ip_gre, geneve and vxlan, use key->tos as traffic class value. > > CC: Peter Dawson <peted...@gmail.com> > Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix s

Re: [PATCH v2] ip6_tunnel: Correct tos value in collect_md mode

2017-06-14 Thread Peter Dawson
On Thu, 15 Jun 2017 10:30:29 +0800 Haishuang Yan <yanhaishu...@cmss.chinamobile.com> wrote: > Same as ip_gre, geneve and vxlan, use key->tos as tos value. > > CC: Peter Dawson <peted...@gmail.com> > Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting o

Re: [PATCH] ip6_tunnel: Correct tos value in collect_md mode

2017-06-13 Thread Peter Dawson
On Wed, 14 Jun 2017 10:54:31 +0800 严海双 wrote: > > Changes since v2: > > * mask key->tos with RT_TOS() suggested by Daniel Can you help me understand the rationale for this change? Is there are bug introduced by dsfield = ip6_tclass(key->label); ? The

Re: [PATCH net] ip6_tunnel: fix traffic class routing for tunnels

2017-06-02 Thread Peter Dawson
olicy is applied to the tunneled packets. Acked-by: Peter Dawson <peter.a.daw...@boeing.com>

[PATCH net,v2] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
t handling of the DSCP portion of the flowlabel in ip6_tunnel and ip6_gre. Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") Signed-off-by: Peter Dawson <peter.a.daw...@boeing.com> --- net/ipv6/ip6_gre.c| 13 +++-- net/ipv6/ip6_tunnel.c | 2

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
ulted in the DSCP value always being set to 0. Commit 90427ef5d2a4 caused the regression by masking out the flowlabel which exposed the incorrect the handling of the DSCP portion of the flowlabel in ip6_tunnel and ip6_gre. Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") Signed-off-by: Peter Dawson <peter.a.daw...@boeing.com>

Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-25 Thread Peter Dawson
On Thu, 25 May 2017 12:11:17 -0400 (EDT) David Miller wrote: > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661 > > This is not the correct way to use the Fixes: tag. > > You should specify the commit that introduced the regression > between 4.9.x and 4.10.x,

[PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-22 Thread Peter Dawson
was incorrect and resulted in the DSCP value always being set to 0. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661 Signed-off-by: Peter Dawson <peter.a.daw...@boeing.com> --- net/ipv6/ip6_gre.c| 13 +++-- net/ipv6/ip6_tunnel.c | 21 + 2 files chang

Re: [PATCH] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

2017-05-17 Thread Peter Dawson
nk. Please run checkpatch.pl, look at the > results and resubmit. Thanks. I've run checkpatch.pl over this updated file with no errors. Regards Peter From f12adb265f683d53ae071725e657dab17d26ed8d Mon Sep 17 00:00:00 2001 From: Peter Dawson <peter.a.daw...@boeing.com> Date: Thu, 18 May 201