Re: [PATCH mlx5-next v1 1/4] net/mlx5: Declare more strictly devlink encap mode

f-by: Leon Romanovsky > --- Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH rdma-next 3/3] RDMA/mlx5: Enable decap and packet reformat on FDB

-by: Maor Gottlieb > Signed-off-by: Leon Romanovsky Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH mlx5-next 1/3] net/mlx5: Expose eswitch encap mode

Hi, > From: Maor Gottlieb > Add API to get the current Eswitch encap mode. > It will be used in downstream patches to check if > flow table can be created with encap support or not. > Signed-off-by: Maor Gottlieb > Signed-off-by: Leon Romanovsky Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH rdma-next 2/3] RDMA/mlx5: Consider eswitch encap mode

: Enable decap and packet reformat on flow > tables') > Signed-off-by: Maor Gottlieb > Signed-off-by: Leon Romanovsky Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH] devlink: fix libc and kernel headers collision

the kernel header alone to avoid kernel and userspace headers > collision of definitions. Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH iproute2 1/1] man: Document COLORFGBG environment variable

Hi Stephen, > > Default colors are not contrast enough on dark backround > > and this functionality, which uses more suitable colors > > is hidden in the code. > > Signed-off-by: Petr Vorel > COLORFGBG is a semi-standard thing used by many programs. > Maybe

[PATCH iproute2 1/1] man: Document COLORFGBG environment variable

Default colors are not contrast enough on dark backround and this functionality, which uses more suitable colors is hidden in the code. Signed-off-by: Petr Vorel --- man/man8/ip.8 | 17 + 1 file changed, 17 insertions(+) diff --git a/man/man8/ip.8 b/man/man8/ip.8 index 84ade110

Re: [PATCH net] sock: return uapi errno in sock_setsockopt() for SO_ZEROCOPY

serspace sees the known number, replace > > ENOTSUPP(524) with EOPNOTSUPP(95). > > Fixes: 76851d1212c1 ("sock: add SOCK_ZEROCOPY sockopt") > > Signed-off-by: Alexey Kodanev > > Reported-by: Petr Vorel > This code has been there since 4.14. I think it's too late

[PATCH 1/1] doc: Mention MSG_ZEROCOPY implementation for UDP

MSG_ZEROCOPY implementation for UDP was merged in v5.0, 6e360f733113 ("Merge branch 'udp-msg_zerocopy'"). Signed-off-by: Petr Vorel --- Documentation/networking/msg_zerocopy.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking

Re: [PATCH iproute2] configure: fix typo in check_xt_old_internal_h

Hi Dmitry, > On Tue, 8 Jan 2019 01:37:15 +0300 > "Dmitry V. Levin" wrote: > > Fixes: 377a09902a57 ("configure: Minor code cleanup") > > Signed-off-by: Dmitry V. Levin > > --- > Applied Sorry for silly error and thanks for a fix. Kind regards, Petr

Re: [PATCH iproute2 1/1] testsuite: Fix colorize

Hi Stephen, > On Tue, 18 Dec 2018 20:29:04 +0100 > Petr Vorel wrote: > > bash and dash require for escape sequence to use 'echo -e' or printf > > (but working on zsh). Choosing printf as it's implementation is IMHO > > more portable than echo implementatio

[PATCH iproute2 1/1] testsuite: Fix colorize

r.c as it's not problematic for C code (working when run ip on various shells). Fixes: 7e2f71b4 ("testsuite: colorize test result output") Signed-off-by: Petr Vorel --- testsuite/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testsuite/Makefile b/tes

Re: [PATCH iproute2 v3 4/4] testsuite: remove gre kmods if the test loads them

Hi Luca, > Signed-off-by: Luca Boccassi > Reviewed-by: Petr Vorel Tested-by: Petr Vorel > --- > v2: applied suggestions from Petr to simplify the modules parsing/unloading > v3: ditto, added reviewed-by tag Kind regards, Petr

Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

Hi Luca, Reviewed-by: Petr Vorel LGTM, but I'd suggest 2 small changes (see bellow). > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > TUNNEL_NAME="tunnel_test_ip" I'd put KMODS here: KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre" The reason is mainte

Re: [PATCH iproute2 v2 3/4] testsuite: delete dummy interface after default route test

Hi Luca, > Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel > --- > v2: fixed copypasta in log message Kind regards, Petr

[PATCH RESENT iproute2 7/7] examples: Remove cbq.init-v0.7.3

This script is obsolete. Signed-off-by: Petr Vorel --- examples/cbq.init-v0.7.3 | 983 --- 1 file changed, 983 deletions(-) delete mode 100644 examples/cbq.init-v0.7.3 diff --git a/examples/cbq.init-v0.7.3 b/examples/cbq.init-v0.7.3 deleted file mode 100644

[PATCH RESENT iproute2 2/7] tests: Use /bin/sh shebang

Bashisms for both tests were removed in ecd44e68 ("tests: Remove bashisms (s/source/.)"), so no need to use bash shebang. + remove trailing whitespace. Signed-off-by: Petr Vorel --- testsuite/tests/tc/cls-testbed.t | 4 ++-- testsuite/tests/tc/dsmark.t | 2 +- 2 files

[PATCH RESENT iproute2 1/7] man: rtpr: Rename s/bash/shell/

ip/rtpr mentioned in man as bash script is actually posix shell script (doesn't require to use bash). Signed-off-by: Petr Vorel --- man/man8/rtpr.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/rtpr.8 b/man/man8/rtpr.8 index 1b04a821..87f291ab 100644 ---

[PATCH RESENT iproute2 3/7] configure: Remove unused function check_prog()

Signed-off-by: Petr Vorel --- configure | 6 -- 1 file changed, 6 deletions(-) diff --git a/configure b/configure index 5df6082b..614355dd 100755 --- a/configure +++ b/configure @@ -11,12 +11,6 @@ CONFIG=config.mk TMPDIR=$(mktemp -d config.XX) trap 'status=$?; rm -rf $TMPDIR;

[PATCH RESENT iproute2 5/7] configure: Minor code cleanup

Signed-off-by: Petr Vorel --- configure | 71 --- 1 file changed, 20 insertions(+), 51 deletions(-) diff --git a/configure b/configure index c88247d8..b85eb58b 100755 --- a/configure +++ b/configure @@ -32,9 +32,7 @@ int main(int argc, char

[PATCH RESENT iproute2 6/7] examples: Remove dhcp-client-script

This script is obsolete. Signed-off-by: Petr Vorel --- examples/dhcp-client-script | 446 1 file changed, 446 deletions(-) delete mode 100644 examples/dhcp-client-script diff --git a/examples/dhcp-client-script b/examples/dhcp-client-script deleted file

[PATCH RESENT iproute2 4/7] configure: Remove non-posix shell expansion

+ change shebang to /bin/sh Signed-off-by: Petr Vorel --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 614355dd..c88247d8 100755 --- a/configure +++ b/configure @@ -1,4 +1,4 @@ -#! /bin/bash +#!/bin/sh # SPDX-License-Identifier

Re: [PATCH iproute2 4/4] testsuite: remove gre kmods if the test loads them

of the test. This should avoid causing problems if > a user is already using GRE for other purposes. > Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel > --- > testsuite/tests/ip/tunnel/add_tunnel.t | 24 > 1 file changed, 24 insertions(+) > dif

Re: [PATCH iproute2 3/4] tests: delete dummy interface after default route test

Hi Luca, > Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel > --- > testsuite/tests/ip/route/add_default_route.t | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/testsuite/tests/ip/route/add_default_route.t > b/testsuite/tests/ip/route/add_default_route.

Re: [PATCH iproute2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg

#x27;s $(TESTS) rule so > that the tool correctly gets compiled before any test runs. > Fixes: 3537633dcf44 ("testsuite: Generate generate_nlmsg when needed") > Cc: petr.vo...@gmail.com > Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel Tested-by: Petr Vorel Again, thanks for fix. Kind regards, Petr

Re: [PATCH iproute2 1/4] Makefile: have check target depend on all

iproute2 > make -C tools > Makefile:3: ../../config.mk: No such file or directory > make[2]: *** No rule to make target '../../config.mk'. Stop. > Fixes: 8804a8c0d387 ("Makefile: Add check target") > Cc: petr.vo...@gmail.com > Signed-off-by: Luca Boccassi

Re: iproute2: fix build on glibc < 2.21 / uClibc

Subject: [iproute] utils.h: provide fallback CLOCK_TAI definition In-Reply-To: <20181027153102.32302-1-pe...@korsgaard.com> To: Stephen Hemminger , Vinicius Costa Gomes Cc: netdev@vger.kernel.org, Peter Korsgaard From: Petr Vorel List-Id: > q_{etf,taprio}.c uses CLOCK_TAI, wh

Re: [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg

Hi Stephen, > Applied, it seem to have gotten lost somewhere between my laptop and the repo. Thanks a lot for merging :). There is a patchset "Minor shell code cleanup", which has state Accepted, but not in git https://patchwork.ozlabs.org/project/netdev/list/?series=67063&state=* Did they got lo

Re: [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg

emove LDLIBS entirely (as > required -lmnl flag was specified in 5dc2204c ("testsuite: add libmnl"). > Fixes: 8804a8c0 ("Makefile: Add check target") > Signed-off-by: Petr Vorel > --- > Hi Stephen, > I'm sorry for this regression. > Kind regards

[PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg

t;). Fixes: 8804a8c0 ("Makefile: Add check target") Signed-off-by: Petr Vorel --- Hi Stephen, I'm sorry for this regression. Kind regards, Petr --- testsuite/tools/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testsuite/tools/Makefile b/testsuite/too

[PATCH iproute2 5/7] configure: Code cleanup

Signed-off-by: Petr Vorel --- configure | 65 +++ 1 file changed, 18 insertions(+), 47 deletions(-) diff --git a/configure b/configure index 8f4a7f1e..86c4cf58 100755 --- a/configure +++ b/configure @@ -32,9 +32,7 @@ int main(int argc, char

[PATCH iproute2 2/7] tests: Use /bin/sh shebang

Bashisms for both tests were removed in ecd44e68 ("tests: Remove bashisms (s/source/.)"), so no need to use bash shebang. + remove trailing whitespace. Signed-off-by: Petr Vorel --- testsuite/tests/tc/cls-testbed.t | 4 ++-- testsuite/tests/tc/dsmark.t | 2 +- 2 files

[PATCH iproute2 4/7] configure: Remove non-posix shell expansion

+ change shebang to /bin/sh Signed-off-by: Petr Vorel --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 34325f99..8f4a7f1e 100755 --- a/configure +++ b/configure @@ -1,4 +1,4 @@ -#! /bin/bash +#!/bin/sh # SPDX-License-Identifier

[PATCH iproute2 1/7] man: rtpr: Rename s/bash/shell/

ip/rtpr mentioned in man as bash script is actually posix shell script (doesn't require to use bash). Signed-off-by: Petr Vorel --- man/man8/rtpr.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/rtpr.8 b/man/man8/rtpr.8 index 1b04a821..87f291ab 100644 ---

[PATCH iproute2 6/7] examples: Remove dhcp-client-script

This script is obsolete. Signed-off-by: Petr Vorel --- examples/dhcp-client-script | 446 1 file changed, 446 deletions(-) delete mode 100644 examples/dhcp-client-script diff --git a/examples/dhcp-client-script b/examples/dhcp-client-script deleted file

[PATCH iproute2 7/7] examples: Remove cbq.init-v0.7.3

This script is obsolete. Signed-off-by: Petr Vorel --- examples/cbq.init-v0.7.3 | 983 --- 1 file changed, 983 deletions(-) delete mode 100644 examples/cbq.init-v0.7.3 diff --git a/examples/cbq.init-v0.7.3 b/examples/cbq.init-v0.7.3 deleted file mode 100644

[PATCH iproute2 0/7] Minor shell code cleanup

Hi, this patchset does minor cleanup in shell scripts: * remove bashisms * use /bin/sh shebang * remove obsolete code from examples * remove unused code Kind regards, Petr Petr Vorel (7): man: rtpr: Rename s/bash/shell/ tests: Use /bin/sh shebang configure: Remove unused function

[PATCH iproute2 3/7] configure: Remove unused function check_prog()

Signed-off-by: Petr Vorel --- configure | 6 -- 1 file changed, 6 deletions(-) diff --git a/configure b/configure index 5ef5cd4c..34325f99 100755 --- a/configure +++ b/configure @@ -11,12 +11,6 @@ CONFIG=config.mk TMPDIR=$(mktemp -d config.XX) trap 'status=$?; rm -rf $TMPDIR;

[PATCH iproute2 1/1] Makefile: Add check target

Signed-off-by: Petr Vorel --- Makefile | 4 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 25de3893..b7488add 100644 --- a/Makefile +++ b/Makefile @@ -77,6 +77,7 @@ help: @echo " clean - remove products of build" @echo &

[PATCH iproute2 v2 0/3] testsuite: make alltests fixes

Hi, here are simply fixes to restore 'make alltests'. Currently it does not run. Kind regards, Petr Petr Vorel (3): testsuite: Fix missing generate_nlmsg testsuite: Generate generate_nlmsg when needed testsuite: Warn about empty $(IPVERS) testsuite/Makefile | 21 ++

[PATCH iproute2 v2 3/3] testsuite: Warn about empty $(IPVERS)

alltests target requires having symlink created by configure target (default target). Without that there is no test being run. Signed-off-by: Petr Vorel --- testsuite/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/testsuite/Makefile b/testsuite/Makefile index 1c2467f5..b3aebec1

[PATCH iproute2 v2 2/3] testsuite: Generate generate_nlmsg when needed

Commit 886f2c43 added generate_nlmsg.c. Running alltests target, which uses the binary required to run 'make -C tools' before. Fixes: 886f2c43 testsuite: Generate nlmsg blob at runtime Signed-off-by: Petr Vorel --- testsuite/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH iproute2 v2 1/3] testsuite: Fix missing generate_nlmsg

Commit ad23e152 caused generate_nlmsg to be always missing: $ make alltests make: ./tools/generate_nlmsg: Command not found Create testclean: to remove only results directory. Fixes: ad23e152 testsuite: remove all temp files and implement make clean Signed-off-by: Petr Vorel --- testsuite

Re: [PATCH iproute2] ip maddr: fix filtering by device

me in ma.name. > > Fixes: 530903dd9003 ("ip: fix igmp parsing when iface is long") > > Signed-off-by: Michal Kubecek > Acked-by: Phil Sutter Acked-by: Petr Vorel Thanks for fixing, Michal. Petr

Re: [PATCH] tests: Remove bashisms (s/source/.)

Hi Mark, > > --- a/testsuite/tests/ip/route/add_default_route.t > > +++ b/testsuite/tests/ip/route/add_default_route.t > > @@ -1,6 +1,6 @@ > > -#!/bin/sh > > +#!/bin/bash > Funny - ^^^ choosing bash explicitly while > removing the bashism? Eh, this is really silly, sorry. I've sent a patc

[PATCH iproute2 1/1] tests: Revert back /bin/sh in shebang

This was added by mistake in commit ecd44e68 ("tests: Remove bashisms (s/source/.)") Signed-off-by: Petr Vorel --- testsuite/tests/ip/route/add_default_route.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuit

[PATCH iproute2 v2 2/4] color: Fix another ip segfault when using --color switch

ds. Thus removing it and restoring "magic" offset + 7. Reproduce with: $ ip -c a Signed-off-by: Petr Vorel --- include/color.h | 1 - lib/color.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/color.h b/include/color.h index 1cd6f7d2..c183ef79 1006

[PATCH iproute2 v2 4/4] color: Rename enum

COLOR_NONE is more descriptive than COLOR_CLEAR. Signed-off-by: Petr Vorel --- include/color.h | 2 +- include/json_print.h | 2 +- lib/color.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/color.h b/include/color.h index c183ef79..7fd685d0

[PATCH iproute2 v2 3/4] color: Cleanup code to remove "magic" offset + 7

Signed-off-by: Petr Vorel --- lib/color.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/color.c b/lib/color.c index 05afcb21..497f5e1b 100644 --- a/lib/color.c +++ b/lib/color.c @@ -45,8 +45,8 @@ static const char * const color_codes[] = { NULL

[PATCH iproute2 v2 1/4] color: Fix ip segfault when using --color switch

;15;0" is used to ask for color set suitable for dark background. Signed-off-by: Petr Vorel --- include/json_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/json_print.h b/include/json_print.h index b6ce1f9f..596af35a 100644 --- a/include/json_print.h +

[PATCH iproute2 v2 0/4] Fix ip segfault when using --color switch

Hi Stephen, I cleanup code not to use magic offsets. I kept it in separate commits, as it's clearer what happened. Petr Vorel (4): color: Fix ip segfault when using --color switch color: Fix another ip segfault when using --color switch color: Cleanup code to remove "magic&q

[PATCH] tests: Remove bashisms (s/source/.)

Signed-off-by: Petr Vorel --- testsuite/tests/ip/link/new_link.t| 2 +- testsuite/tests/ip/link/show_dev_wo_vf_rate.t | 2 +- testsuite/tests/ip/netns/set_nsid.t | 2 +- testsuite/tests/ip/netns/set_nsid_batch.t | 2 +- testsuite/tests/ip/route/add_default_route.t | 4

[PATCH iproute2 1/1] color: Fix ip segfault in color_fprintf() when using --color switch

t; is used to ask for color set suitable for light background, COLORFGBG="15;0" is used to ask for color set suitable for dark background. Signed-off-by: Petr Vorel --- include/json_print.h | 2 +- lib/color.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH net] r8152: fix the list rx_done may be used without initialization

Hi Hayes, > The list rx_done would be initialized when the linking on occurs. > Therefore, if a napi is scheduled without any linking on before, > the following kernel panic would happen. > BUG: unable to handle kernel NULL pointer dereference at 008 > IP: [] r8152_poll+0x

Re: [PATCH 1/1] r8152: fix NULL pointer dereference in r8152_poll

> > > Unfortunately this doesn't work. Code in r8152.c doesn't use > > > local_bh_enable()/local_bh_disable(). I tried to lock it with > > > spin_lock_bh()/spin_unlock_bh() and with mutex_lock()/mutex_unlock() > > > but neither work. > > The local_bh_disable() / local_bh_enable() definitely is the

Re: [PATCH 1/1] r8152: fix NULL pointer dereference in r8152_poll

Hi Eric, > > The proper work around is to enclose the napi_schedule() in a > > local_bh_enable()/local_bh_disable() pair. > Something like : > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -3703,8 +3703,10 @@ static int rtl8152_resume(struct usb_interface *intf) >

[PATCH 1/1] r8152: fix NULL pointer dereference in r8152_poll

89b4cf067 PUD 898ff2067 PMD 0 Oops: 0002 [#1] PREEMPT SMP Signed-off-by: Petr Vorel --- NOTE: This is just a workaround, I suppose, there is better way how to fix that (which allows keeping scheduling the napi for rx after napi_enable()). --- drivers/net/usb/r8152.c | 2 -- 1 file changed, 2

[iproute PATCH v3 1/1] color: use "light" colors for dark background

COLORFGBG environment variable is used to detect dark background. Idea and a bit of code is borrowed from Vim, thanks. Signed-off-by: Petr Vorel --- Changes v2->v3: remove unnecessary cast. --- include/color.h | 1 + lib/color.c | 45 - 2 fi

[iproute PATCH v2 1/1] color: use "light" colors for dark background

COLORFGBG environment variable is used to detect dark background. Idea and a bit of code is borrowed from Vim, thanks. Signed-off-by: Petr Vorel --- Changes v1->V2: * Rename function and enum values * Add missing bold white enum + it's code. --- include/color.h | 1 + lib/color.c

Re: [PATCH 1/1] color: use "light" colors for dark background

Hi, > Yea, I admit, the original color palette is kind of horrendous. I > wouldn't say the current colors are suitable for a light background > either. > I propose you just replace the current colors with their bold > variants, and leave the background hue guessing out all together. That > would

Re: [PATCH 1/1] color: use "light" colors for dark background

Hi, > This really needs to be standardized with some convention. So that ls, grep, > git > all behave the same and done by some standard library. > The current method is hack that keeps on growing. It would be easier, if the code could be adapted by some broadly used library, than start new pr

[PATCH 1/1] color: use "light" colors for dark background

COLORFGBG environment variable is used to detect dark background. Idea and a bit of code is borrowed from Vim, thanks. Signed-off-by: Petr Vorel --- Colors are nice, but the ones chosen aren't suitable for dark background. COLORFGBG environment variable is used in some libraries and sof

Re: [PATCH 1/1] ip: fix igmp parsing when iface is long

Hi, > Entries with long vhost names in /proc/net/igmp have no whitespace > between name and colon, so sscanf() adds it to vhost and > 'ip maddr show iface' doesn't include inet result. Bug was also reported to bugzilla (https://bugzilla.kernel.org/show_bug.cgi?id=192741), with updated comment in

[PATCH 1/1] ip: fix igmp parsing when iface is long

Entries with long vhost names in /proc/net/igmp have no whitespace between name and colon, so sscanf() adds it to vhost and 'ip maddr show iface' doesn't include inet result. Signed-off-by: Petr Vorel --- ip/ipmaddr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)