Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 2017-11-09 20:08, Florian Fainelli wrote: On 11/09/2017 09:24 AM, Andrew Lunn wrote: The registers writing code is where? switchdev driver? All I care about is that all the switch specific code should be in one place. The switch specific code is in the switch specific driver. Take a

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 2017-11-09 19:24, Andrew Lunn wrote: The registers writing code is where? switchdev driver? All I care about is that all the switch specific code should be in one place. The switch specific code is in the switch specific driver. Take a look under drivers/net/dsa for the switches which are

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 2017-11-09 17:38, Andrew Lunn wrote: >>Unless switchdev could be expanded to support other functions beyond >>VLAN, >>like port rate control, ACL, HW NAT (no switchdev L3 offload doesn't fit >>this), etc. > >Switchdev allows offloading of TC. So port rate control would be >implemented via TC.

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 2017-11-09 15:24, Andrew Lunn wrote: Although it could be a good thing to bring this to mainline, I'm kind of pessimistic about supporting such switches in DSA/switchdev. IMO swconfig does a better job for now. I think the important point here is "... for now" ... as always, probably

Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver

On 2017-11-06 01:19, Linus Walleij wrote: This adds a driver core for the Realtek SMI chips and a subdriver for the RTL8366RB. I just added this chip simply because it is all I can test. The code is a massaged variant of the code that has been sitting out-of-tree in OpenWRT for years in the

Re: [PATCH net-next 00/10] korina cleanups/optimizations

On 2017-10-22 23:57, Roman Yeryomin wrote: On 2017-10-16 00:05, David Miller wrote: From: Roman Yeryomin <ro...@advem.lv> Date: Sun, 15 Oct 2017 19:46:02 +0300 On 2017-10-15 19:38, Florian Fainelli wrote: On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin <ro...@advem.lv>

RE: [PATCH net-next 00/10] korina cleanups/optimizations

On 2017-10-16 15:59, David Laight wrote: From: Roman Yeryomin Sent: 15 October 2017 17:22 TX optimizations have led to ~15% performance increase (35->40Mbps) in local tx usecase (tested with iperf v3.2). Indicate which patches give the improvement. IIRC some just changed the source with

Re: [PATCH net-next 00/10] korina cleanups/optimizations

On 2017-10-16 00:05, David Miller wrote: From: Roman Yeryomin <ro...@advem.lv> Date: Sun, 15 Oct 2017 19:46:02 +0300 On 2017-10-15 19:38, Florian Fainelli wrote: On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin <ro...@advem.lv> wrote: TX optimizations have led to ~15% performa

Re: [PATCH net-next 00/10] korina cleanups/optimizations

On 2017-10-15 19:38, Florian Fainelli wrote: On October 15, 2017 9:22:26 AM PDT, Roman Yeryomin <ro...@advem.lv> wrote: TX optimizations have led to ~15% performance increase (35->40Mbps) in local tx usecase (tested with iperf v3.2). Could you avoid empty commit messages and write a

[PATCH net-next 10/10] net: korina: bump version

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 8fa60d1fe022..fc8e80487507 100644 --- a/drivers/net/ethernet/korina.c

[PATCH net-next 07/10] net: korina: move tx to napi context

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 79 +++ 1 file changed, 20 insertions(+), 59 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index a076b0c49e6e..f606f1e01af1

[PATCH net-next 09/10] net: korina: use dma api instead of dma_cache_* functions

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 44 ++- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 9520fa1e35a2..8fa60d1fe022

[PATCH net-next 08/10] net: korina: optimize tx_full condition

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index f606f1e01af1..9520fa1e35a2 100644 --- a/drive

[PATCH net-next 01/10] net: korina: optimize korina_send_packet logic

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 76 ++- 1 file changed, 24 insertions(+), 52 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 7cecd9dbc111..84b2654e2d06

[PATCH net-next 02/10] net: korina: reorder functions

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 317 +- 1 file changed, 158 insertions(+), 159 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 84b2654e2d06..5545f8

[PATCH net-next 05/10] net: korina: remove unused korina_private members

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 64ae32af7539..59d4554c43c9 100644 --- a/drivers/net/ethernet/korina.c +++ b/drive

[PATCH net-next 03/10] net: korina: introduce and use interrupt disable/enable helpers

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 83 +-- 1 file changed, 48 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 5545f86aac4a..04c1a3f38a79

[PATCH net-next 00/10] korina cleanups/optimizations

TX optimizations have led to ~15% performance increase (35->40Mbps) in local tx usecase (tested with iperf v3.2). Roman Yeryomin (10): net: korina: optimize korina_send_packet logic net: korina: reorder functions net: korina: introduce and use interrupt disable/enable helpers net: kor

[PATCH net-next 06/10] net: korina: optimize tx descriptor flags processing

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 59d4554c43c9..a076b0c49e6e 100644 --- a/drive

[PATCH net-next 04/10] net: korina: optimize tx/rx interrupt handlers

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 04c1a3f38a79..64ae32af7539 100644 --- a/d

Re: [PATCH net-next v2 0/7] korina: performance fixes and cleanup

On 18 September 2017 at 16:02, Roman Yeryomin <leroi.li...@gmail.com> wrote: > On 17 September 2017 at 23:09, Florian Fainelli <f.faine...@gmail.com> wrote: >> >> >> On 09/17/2017 10:23 AM, Roman Yeryomin wrote: >>> Changes from v1: >>>

Re: [PATCH net-next v2 0/7] korina: performance fixes and cleanup

On 17 September 2017 at 23:09, Florian Fainelli <f.faine...@gmail.com> wrote: > > > On 09/17/2017 10:23 AM, Roman Yeryomin wrote: >> Changes from v1: >> - use GRO instead of increasing ring size >> - use NAPI_POLL_WEIGHT instead of defining own NAPI_WEIGHT

[PATCH net-next v2 7/7] net: korina: bump version

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index d58aa4bfcb58..7cecd9dbc111 100644 --- a/drivers/net/ethernet/korina.c

[PATCH net-next v2 4/7] net: korina: use GRO

Performance gain when receiving locally is 55->95Mbps and 50->65Mbps for NAT. Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/ko

[PATCH net-next v2 5/7] net: korina: whitespace cleanup

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 58 +++ 1 file changed, 31 insertions(+), 27 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 5f36e1703378..c26f0d84ba6b

[PATCH net-next v2 6/7] net: korina: update authors

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index c26f0d84ba6b..d58aa4bfcb58 100644 --- a/drivers/net/ethernet/korina.c +++ b/drive

[PATCH net-next v2 3/7] net: korina: use NAPI_POLL_WEIGHT

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index e5466e19994a..c210add9b654 100644 --- a/drivers/net/ethernet/korina.c

[PATCH net-next v2 2/7] net: korina: optimize rx descriptor flags processing

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 87 ++- 1 file changed, 44 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 98d686ed69a9..e5466e19994a

[PATCH net-next v2 1/7] net: korina: don't use overflow and underflow interrupts

. Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 83 +-- 1 file changed, 1 insertion(+), 82 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 3c0a6451273d..98d686ed69a9

[PATCH net-next v2 0/7] korina: performance fixes and cleanup

Changes from v1: - use GRO instead of increasing ring size - use NAPI_POLL_WEIGHT instead of defining own NAPI_WEIGHT - optimize rx descriptor flags processing Roman Yeryomin (7): net: korina: don't use overflow and underflow interrupts net: korina: optimize rx descriptor flags processing

Re: [net, 6/6] net: korina: version bump

On 17 January 2017 at 21:19, Roman Yeryomin <leroi.li...@gmail.com> wrote: > On 17 January 2017 at 20:55, Felix Fietkau <n...@nbd.name> wrote: >> On 2017-01-17 18:33, Roman Yeryomin wrote: >>> Signed-off-by: Roman Yeryomin <ro...@advem.lv> >>> --- >&

Re: [net, 3/6] net: korina: increase tx/rx ring sizes

On 17 January 2017 at 21:20, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Tue, 2017-01-17 at 20:27 +0200, Roman Yeryomin wrote: >> On 17 January 2017 at 19:58, David Miller <da...@davemloft.net> wrote: >> > From: Roman Yeryomin <leroi.li...@gmail.com>

Re: [net, 6/6] net: korina: version bump

On 17 January 2017 at 20:55, Felix Fietkau <n...@nbd.name> wrote: > On 2017-01-17 18:33, Roman Yeryomin wrote: >> Signed-off-by: Roman Yeryomin <ro...@advem.lv> >> --- >> drivers/net/ethernet/korina.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 dele

Re: [net, 3/6] net: korina: increase tx/rx ring sizes

On 17 January 2017 at 19:58, David Miller <da...@davemloft.net> wrote: > From: Roman Yeryomin <leroi.li...@gmail.com> > Date: Tue, 17 Jan 2017 19:32:36 +0200 > >> Having larger ring sizes almost eliminates rx fifo overflow, thus improving >> performance.

Re: [net, 2/6] net: korina: define NAPI_WEIGHT

On 17 January 2017 at 19:40, David Miller <da...@davemloft.net> wrote: > From: Roman Yeryomin <leroi.li...@gmail.com> > Date: Tue, 17 Jan 2017 19:32:22 +0200 > >> @@ -77,6 +77,8 @@ >> >> #define MII_CLOCK 125/* no more than 2

[net, 6/6] net: korina: version bump

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 83c994f..c8fed01 100644 --- a/drivers/net/ethernet/korina.c +++ b/d

[net, 3/6] net: korina: increase tx/rx ring sizes

Having larger ring sizes almost eliminates rx fifo overflow, thus improving performance. This patch reduces rx overflow occurence by approximately 1000 times (from ~25k down to ~25 times per 3M frames) Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 4 +

[net, 5/6] net: korina: update authors

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index afa440c..83c994f 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/et

[net, 4/6] net: korina: whitespace styling cleanup

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 54 +++ 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 02f2364..afa440c

[net, 2/6] net: korina: define NAPI_WEIGHT

Signed-off-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 9bc375d..45bd617 100644 --- a/drivers/net/ethernet/korina.c +++ b/drive

[net, 1/6] net: korina: don't use overflow and underflow interrupts

-by: Roman Yeryomin <ro...@advem.lv> --- drivers/net/ethernet/korina.c | 83 +-- 1 file changed, 1 insertion(+), 82 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 8037426..9bc375d 100644 --- a/drivers/net/et

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

On 16 May 2016 at 19:04, Dave Taht <dave.t...@gmail.com> wrote: > On Mon, May 16, 2016 at 1:14 AM, Roman Yeryomin <leroi.li...@gmail.com> wrote: >> On 16 May 2016 at 01:34, Roman Yeryomin <leroi.li...@gmail.com> wrote: >>> On 6 May 2016 at 22:43, Dave Taht <

Re: [Make-wifi-fast] OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

On 16 May 2016 at 11:12, David Lang <da...@lang.hm> wrote: > On Mon, 16 May 2016, Roman Yeryomin wrote: > >> On 6 May 2016 at 22:43, Dave Taht <dave.t...@gmail.com> wrote: >>> >>> On Fri, May 6, 2016 at 11:56 AM, Roman Yeryomin <leroi.li...@gmail.com

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

On 16 May 2016 at 01:34, Roman Yeryomin <leroi.li...@gmail.com> wrote: > On 6 May 2016 at 22:43, Dave Taht <dave.t...@gmail.com> wrote: >> On Fri, May 6, 2016 at 11:56 AM, Roman Yeryomin <leroi.li...@gmail.com> >> wrote: >>> On 6 May 2016 at 21:43, Ro

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

On 16 May 2016 at 02:07, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Mon, 2016-05-16 at 01:34 +0300, Roman Yeryomin wrote: > >> qdisc fq_codel 8003: parent :3 limit 1024p flows 16 quantum 1514 >> target 80.0ms ce_threshold 32us interval 100.0ms ecn >> Sen

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

On 7 May 2016 at 12:57, Kevin Darbyshire-Bryant wrote: > > > On 06/05/16 10:42, Jesper Dangaard Brouer wrote: >> Hi Felix, >> >> This is an important fix for OpenWRT, please read! >> >> OpenWRT changed the default fq_codel sch->limit from 10240 to 1024, >> without

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

On 6 May 2016 at 22:43, Dave Taht <dave.t...@gmail.com> wrote: > On Fri, May 6, 2016 at 11:56 AM, Roman Yeryomin <leroi.li...@gmail.com> wrote: >> On 6 May 2016 at 21:43, Roman Yeryomin <leroi.li...@gmail.com> wrote: >>> On 6 May 2016 at 15:47, Jesper Danga

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

On 6 May 2016 at 21:43, Roman Yeryomin <leroi.li...@gmail.com> wrote: > On 6 May 2016 at 15:47, Jesper Dangaard Brouer <bro...@redhat.com> wrote: >> >> I've created a OpenWRT ticket[1] on this issue, as it seems that someone[2] >> closed Felix'es OpenWRT email acc

Re: OpenWRT wrong adjustment of fq_codel defaults (Was: [Codel] fq_codel_drop vs a udp flood)

r packet, but >> instead can amortize this. >> >> To Eric, should we recommend OpenWRT to adjust default (max) 64 bulk >> drop, given we also recommend bucket size to be 128 ? (thus the amount >> of memory to scan is less, but their CPU is also much smaller). >> &g