On 2/11/21, 4:18 PM, "Ronak Doshi" wrote:
>From: Todd Sabin
>
>Linux network stack uses an allocation page cache for skbs. The
> purpose is to reduce the number of page allocations that it needs to
>make, and it works by allocating a group of pages, and
was originally.
This patch fixes that by giving each vmxnet3 device a per-rx-queue page
cache.
Signed-off-by: Todd Sabin
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 30 --
drivers/net/vmxnet3/vmxnet3_int.h | 2 ++
include/linux/skbuff.h
ould subvert SVM/TDX guarantees.
Signed-off-by: Petr Vandrovec
Signed-off-by: Ronak Doshi
---
Changes in v2:
- Use kcalloc_node()
- Remove log for memory allocation failure
Changes in v3:
- Do not pass __GFP_ZERO to kcalloc
Changes in v4:
- Modified description to not have subject line
Change
ould subvert SVM/TDX guarantees.
Signed-off-by: Petr Vandrovec
Signed-off-by: Ronak Doshi
---
Changes in v2:
- Use kcalloc_node()
- Remove log for memory allocation failure
Changes in v3:
- Do not pass __GFP_ZERO to kcalloc
Changes in v4:
- Modified description to not have subject line
---
dri
k-of-Mon-20210104/022829.html
that malicious vmxnet3 device could subvert SVM/TDX guarantees.
Signed-off-by: Petr Vandrovec
Signed-off-by: Ronak Doshi
---
Changes in v2:
- Use kcalloc_node()
- Remove log for memory allocation failure
Changes in v3:
- Do not pass __GFP_ZERO to kcalloc
---
drivers
k-of-Mon-20210104/022829.html
that malicious vmxnet3 device could subvert SVM/TDX guarantees.
Signed-off-by: Petr Vandrovec
Signed-off-by: Ronak Doshi
---
Changes in v2:
- Use kcalloc_node()
- Remove log for memory allocation failure
---
drivers/net/vmxnet3/vmxnet3_drv.c
On 1/21/21, 5:07 PM, "Jakub Kicinski" wrote:
> On Tue, 19 Jan 2021 18:19:40 -0800 Ronak Doshi wrote:
> > From: Petr Vandrovec
> >
> > vmxnet3: Remove buf_info from device accessible structures
>
>Something happened to the posting, looks like the sub
mail/intel-wired-lan/Week-of-Mon-20210104/022829.html
that malicious vmxnet3 device could subvert SVM/TDX guarantees.
Signed-off-by: Petr Vandrovec
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 45 ---
drivers/net/vmxnet3/vmxnet3_int.h | 2 -
mail/intel-wired-lan/Week-of-Mon-20210104/022829.html
that malicious vmxnet3 device could subvert SVM/TDX guarantees.
Signed-off-by: Petr Vandrovec
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 45 ---
drivers/net/vmxnet3/vmxnet3_int.h | 2 -
filtering appropriate features for non-udp tunnels.
Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload support")
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 5 ++---
drivers/net/vmxnet3/vmxnet3_ethtool.c | 28
inner
tcp header.
Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload support")
Signed-off-by: Ronak Doshi
Acked-by: Guolin Yang
---
Changes in v2:
- Undo changes to driver version
- Fixed commit message
drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
1 file changed
reference for inner
tcp header.
Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload
support")
Signed-off-by: Ronak Doshi
Acked-by: Guolin Yang
---
drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
drivers/net/vmxnet3/vmxnet3_int.h | 4 ++--
2 files changed, 4 insertions(+)
It makes sense to allow changes to get/set rx flow hash callback only
when rss is enabled. This patch restricts get_rss_hash_opts and
set_rss_hash_opts methods to allow querying and configuring different
Rx flow hash configurations only when rss is enabled
Signed-off-by: Ronak Doshi
---
drivers
Fixes: dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload support")
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 31 +++
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
b/dri
On 5/28/20, 2:43 PM, "David Miller" wrote:
>It's really awful to kill so much of the system because of a flipped bit
>in a descriptor.
>
>Please fix this as well as address Michal's feedback.
>
>Thanks.
Thanks for the review. Sent version 4 patches.
Thanks
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver,
the driver can configure emulation to run at vmxnet3 version 4, provided
the emulation advertises support for version 4.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++-
drivers/net/vmxnet3
set_rss_hash_opts
methods to allow querying and configuring different Rx flow hash
configurations.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_defs.h| 12 ++
drivers/net/vmxnet3/vmxnet3_drv.c | 39 ++
drivers/net/vmxnet3/vmxnet3_ethtool.c | 219
segment the inner packet, compute the inner
checksum for each segment and encapsulate each segment before
transmitting the packet via the vNIC. This results in significant
performance penalty.
This patch will enhance vmxnet3 to support Geneve/VXLAN TSO as well as
checksum offload.
Signed-off-by: Ronak
vmxnet3 is currently at version 3 and this patch initiates the
preparation to accommodate changes for version 4. Introduced utility
macros for vmxnet3 version 4 comparison and update Copyright
information.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/Makefile | 2 +-
drivers/net
ced BUG_ON() with WARN_ON_ONCE()
Changes in v2 -> v3:
- fixed get_rss_hash_opts to return correct values for udp rss
Changes in v2:
- Fixed compilation issue due to missing closed brace
- added fallthrough comment
Ronak Doshi (4):
vmxnet3: prepare for version 4 changes
vmxnet3: add s
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver,
the driver can configure emulation to run at vmxnet3 version 4, provided
the emulation advertises support for version 4.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++-
drivers/net/vmxnet3
segment the inner packet, compute the inner
checksum for each segment and encapsulate each segment before
transmitting the packet via the vNIC. This results in significant
performance penalty.
This patch will enhance vmxnet3 to support Geneve/VXLAN TSO as well as
checksum offload.
Signed-off-by: Ronak
set_rss_hash_opts
methods to allow querying and configuring different Rx flow hash
configurations.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_defs.h| 12 ++
drivers/net/vmxnet3/vmxnet3_drv.c | 39 ++
drivers/net/vmxnet3/vmxnet3_ethtool.c | 219
xed get_rss_hash_opts to return correct values for udp rss
Changes in v2:
- Fixed compilation issue due to missing closed brace
- added fallthrough comment
Ronak Doshi (4):
vmxnet3: prepare for version 4 changes
vmxnet3: add support to get/set rx flow hash
vmxnet3: add geneve and vxlan tun
vmxnet3 is currently at version 3 and this patch initiates the
preparation to accommodate changes for version 4. Introduced utility
macros for vmxnet3 version 4 comparison and update Copyright
information.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/Makefile | 2 +-
drivers/net
On 5/28/20, 12:35 PM, "Jakub Kicinski" wrote:
>On Thu, 28 May 2020 11:36:14 -0700 Ronak Doshi wrote:
>> @@ -1168,13 +1220,21 @@ vmxnet3_rx_csum(struct vmxnet3_adapter *adapter,
>> (le32_to_cpu(gdesc->dword[3]) &
>>
On 5/28/20, 1:15 PM, "Michal Kubecek" wrote:
>This means that for both TCP and UDP, you have cases where get handler
>will return value which will cause an error if it's fed back to set
>handler. And for UDP, accepted values for set are L3 and L3 | L4 but get
>handler returns 0 o
On 5/28/20, 12:21 PM, "Michal Kubecek" wrote:
>On Thu, May 28, 2020 at 11:36:13AM -0700, Ronak Doshi wrote:
>> With vmxnet3 version 4, the emulation supports multiqueue(RSS) for
>> UDP and ESP traffic. A guest can enable/disable RSS for UDP/ESP over
&g
set_rss_hash_opts
methods to allow querying and configuring different Rx flow hash
configurations.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_defs.h| 12 ++
drivers/net/vmxnet3/vmxnet3_drv.c | 39 ++
drivers/net/vmxnet3/vmxnet3_ethtool.c | 224
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver,
the driver can configure emulation to run at vmxnet3 version 4, provided
the emulation advertises support for version 4.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++-
drivers/net/vmxnet3
vmxnet3 is currently at version 3 and this patch initiates the
preparation to accommodate changes for version 4. Introduced utility
macros for vmxnet3 version 4 comparison and update Copyright
information.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/Makefile | 2 +-
drivers/net
issue due to missing closed brace
- added fallthrough comment
Ronak Doshi (4):
vmxnet3: prepare for version 4 changes
vmxnet3: add support to get/set rx flow hash
vmxnet3: add geneve and vxlan tunnel offload support
vmxnet3: update to version 4
drivers/net/vmxnet3/Makefile
segment the inner packet, compute the inner
checksum for each segment and encapsulate each segment before
transmitting the packet via the vNIC. This results in significant
performance penalty.
This patch will enhance vmxnet3 to support Geneve/VXLAN TSO as well as
checksum offload.
Signed-off-by: Ronak
avoids segmenting and calculating checksum
for each segment and hence gives performance boost.
Patch 4:
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver,
with this patch, the driver can configure emulation to run at vmxnet3
version 4.
Ronak Doshi (4):
vmxnet3: prepare for
set_rss_hash_opts
methods to allow querying and configuring different Rx flow hash
configurations.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_defs.h| 12 ++
drivers/net/vmxnet3/vmxnet3_drv.c | 39 ++
drivers/net/vmxnet3/vmxnet3_ethtool.c | 223
segment the inner packet, compute the inner
checksum for each segment and encapsulate each segment before
transmitting the packet via the vNIC. This results in significant
performance penalty.
This patch will enhance vmxnet3 to support Geneve/VXLAN TSO as well as
checksum offload.
Signed-off-by: Ronak
vmxnet3 is currently at version 3 and this patch initiates the
preparation to accommodate changes for version 4. Introduced utility
macros for vmxnet3 version 4 comparison and update Copyright
information.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/Makefile | 2 +-
drivers/net
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver,
the driver can configure emulation to run at vmxnet3 version 4, provided
the emulation advertises support for version 4.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++-
drivers/net/vmxnet3
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver,
the driver can configure emulation to run at vmxnet3 version 4, provided
the emulation advertises support for version 4.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++-
drivers/net/vmxnet3
set_rss_hash_opts
methods to allow querying and configuring different Rx flow hash
configurations.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/vmxnet3_defs.h| 12 ++
drivers/net/vmxnet3/vmxnet3_drv.c | 39 ++
drivers/net/vmxnet3/vmxnet3_ethtool.c | 223
segment the inner packet, compute the inner
checksum for each segment and encapsulate each segment before
transmitting the packet via the vNIC. This results in significant
performance penalty.
This patch will enhance vmxnet3 to support Geneve/VXLAN TSO as well as
checksum offload.
Signed-off-by: Ronak
avoids segmenting and calculating checksum
for each segment and hence gives performance boost.
Patch 4:
With all vmxnet3 version 4 changes incorporated in the vmxnet3 driver,
with this patch, the driver can configure emulation to run at vmxnet3
version 4.
Ronak Doshi (4):
vmxnet3: prepare for
vmxnet3 is currently at version 3 and this patch initiates the
preparation to accommodate changes for version 4. Introduced utility
macros for vmxnet3 version 4 comparison and update Copyright
information.
Signed-off-by: Ronak Doshi
---
drivers/net/vmxnet3/Makefile | 2 +-
drivers/net
Currently, when rx csum is disabled, vmxnet3 driver does not turn
off lro, which can cause performance issues if user does not turn off
lro explicitly. This patch adds fix_features support which is used to
turn off LRO whenever RXCSUM is disabled.
Signed-off-by: Ronak Doshi
Acked-by: Rishi Mehta
On Tue, 5 Jun 2018, Paolo Abeni wrote:
> Hi,
>
> I'm sorry for the long delay in my answer, I've been travelling.
>
> On Fri, 2018-06-01 at 11:10 -0700, Ronak Doshi wrote:
> > On Thu, 31 May 2018, Neil Horman wrote:
> > > What packet types will rcd
On Thu, 31 May 2018, Neil Horman wrote:
> On Thu, May 31, 2018 at 11:02:34AM -0700, Ronak Doshi wrote:
> >
> > On Wed, 30 May 2018, Paolo Abeni wrote:
> >
> > > Hi,
> > >
> > > On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote:
> >
On Wed, 30 May 2018, Paolo Abeni wrote:
> Hi,
>
> On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote:
> > Yes, that code is not correct, we should fix that code
>
> Did you have any chance to address the issue and/or to give a more in-
> deepth look to the change proposed in my initial emai
fixes this issue by taking sizeof(vlan_ethhdr) into account
if vlan tag is present and correctly references the ip hdr.
Signed-off-by: Ronak Doshi
Acked-by: Guolin Yang
Acked-by: Louis Luo
---
drivers/net/vmxnet3/vmxnet3_drv.c | 17 +
drivers/net/vmxnet3/vmxnet3_int.h | 4
Shrikrishna Khare would no longer maintain the vmxnet3 driver. Taking
over the role of vmxnet3 maintainer.
Signed-off-by: Ronak Doshi
Signed-off-by: Shrikrishna Khare
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
NETIF_F_LRO to check if lro is enabled.
Fixes: 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)")
Reported-by: Rachel Lunnon
Signed-off-by: Ronak Doshi
Acked-by: Shrikrishna Khare
---
Changes in v2:
- Added "Fixes:" tag for the commit which introduced
under heavy load or
(b) workload inside VM is of low packet rate.
This race results in xmit hangs when network coalescing is disabled. This
change creates a local copy of txNumDeferred and uses it to perform ring
arithmetic.
Reported-by: Noriho Tanaka
Signed-off-by: Ronak Doshi
Acked-by
NETIF_F_LRO to check if lro is enabled.
Reported-by: Rachel Lunnon
Signed-off-by: Ronak Doshi
Acked-by: Shrikrishna Khare
---
drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
drivers/net/vmxnet3/vmxnet3_int.h | 5 ++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vmxnet
under heavy load or
(b) workload inside VM is of low packet rate.
This race results in xmit hangs when network coalescing is disabled. This
change creates a local copy of txNumDeferred and uses it to perform ring
arithmetic.
Reported-by: Noriho Tanaka
Signed-off-by: Ronak Doshi
Acked-by
53 matches
Mail list logo
