[net-next 14/15] net/mlx5: DR, Add support for force-loopback QP

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik When supported by the device, SW steering RoCE RC QP that is used to write/read to/from ICM will be created with force-loopback attribute. Such QP doesn't require GID index upon creation. Signed-off-by: Erez Shitrit Signed-off-by: Yevgeny Kliteynik Signed-off-by:

[net-next 15/15] net/mlx5: DR, Add support for isolate_vl_tc QP

2021-04-19 Thread Saeed Mahameed
cases, we set this QP to use isolated VL. The VL number is reserved by FW and is not exposed to the driver. Support for this QP on isolated VL exists only when both force-loopback and isolate_vl_tc capabilities are set. Signed-off-by: Alex Vesker Signed-off-by: Yevgeny Kliteynik Signed-off-by:

[net-next 12/15] net/mlx5: DR, Set flex parser for TNL_MPLS dynamically

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Query the flex_parser id that's intended for TNL_MPLS and use an appropriate flex parser for MPLS over UDP/GRE. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_cmd.c

[net-next 11/15] net/mlx5: DR, Add support for matching on geneve TLV option

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Enable matching on tunnel geneve TLV option using the flex parser. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_cmd.c | 4 +++ .../mellanox/mlx5/core/steering/dr_matcher.c

[net-next 13/15] net/mlx5: DR, Add support for matching tunnel GTP-U

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Enable matching on tunnel GTP-U and GTP-U first extension header using dynamic flex parser. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_cmd.c | 16 +++ .../mellanox/mlx5

[net-next 10/15] net/mlx5: DR, Set STEv0 ICMP flex parser dynamically

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Set the flex parser ID dynamicly for ICMP instead of relying on hardcoded values. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_matcher.c | 12 ++--- .../mellanox/mlx5/core

[net-next 09/15] net/mlx5: DR, Add support for dynamic flex parser

2021-04-19 Thread Saeed Mahameed
which allows using a correct flex parser that was programmed to the required protocol. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_matcher.c | 50 ++ .../mellanox/mlx5/core/steering/dr_rule.c

[net-next 08/15] net/mlx5: DR, Remove protocol-specific flex_parser_3 definitions

2021-04-19 Thread Saeed Mahameed
From: Muhammad Sammar Remove MPLS specific fields from flex parser 3 layout. Flex parser can be used for multiple protocols and should not be hardcoded to a specific type. Signed-off-by: Muhammad Sammar Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5

[net-next 07/15] net/mlx5: mlx5_ifc updates for flex parser

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Added the required definitions for supporting more protocols by flex parsers (GTP-U, Geneve TLV options), and for using the right flex parser that was configured for this protocol. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- include/linux/mlx5

[net-next 04/15] net/mlx5: DR, Rename an argument in dr_rdma_segments

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik Rename the argument to better reflect that the meaning is not number of records, but wheather or not we should ring the dorbell. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/steering/dr_send.c| 8

[net-next 05/15] net/mlx5: DR, Fix SQ/RQ in doorbell bitmask

2021-04-19 Thread Saeed Mahameed
From: Yevgeny Kliteynik QP doorbell size is 16 bits. Fixing sw steering's QP doorbel bitmask, which had 20 bits. Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[net-next 06/15] net/mlx5: E-Switch, Improve error messages in term table creation

2021-04-19 Thread Saeed Mahameed
Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/eswitch_offloads_termtbl.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c b/drivers/net/ethernet/mellanox/mlx5/core

[net-next 03/15] net/mlx5e: RX, Add checks for calculated Striding RQ attributes

2021-04-19 Thread Saeed Mahameed
the HW spec and SW assumptions/requirements. This is not a fix, no particular issue exists today. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en/params.c | 86 --- .../ethernet/mellanox/mlx5/core/en/params.h | 20

[pull request][net-next 00/15] mlx5 updates 2021-04-19

2021-04-19 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series provides updates for mlx5, mostly around mlx5 software steering For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit

[net-next 01/15] net/mlx5e: Fix lost changes during code movements

2021-04-19 Thread Saeed Mahameed
net/mlx5e: Move params logic into its dedicated file") Fixes: b3a131c2a160 ("net/mlx5e: Move params logic into its dedicated file") Signed-off-by: Tariq Toukan Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 5 +++--

[net-next 02/15] net/mlx5e: Fix possible non-initialized struct usage

2021-04-19 Thread Saeed Mahameed
registered. Also, change mlx5e_get_devlink_port() behavior and return NULL in case port is not registered to replicate devlink's wrapper when ndo is not implemented. Signed-off-by: Vladyslav Tarasiuk Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c

Re: [PATCH net] net/mlx5e: Fix uninitialised struct field moder.comps

2021-04-19 Thread Saeed Mahameed
On Mon, 2021-04-19 at 20:17 +0800, wangyunjian wrote: > From: Yunjian Wang > > The 'comps' struct field in 'moder' is not being initialized > in mlx5e_get_def_rx_moderation(). So initialize 'moder' to > zero to avoid the issue. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 3

[net-next 11/14] net/mlx5: Add register layout to support extended link state

2021-04-16 Thread Saeed Mahameed
From: Moshe Tal Add needed structure layouts and defines for pddr register (Port Diagnostics Database Register) and the troublshooting page. This will be used to get extended link state from the monitor opcode bits. Signed-off-by: Moshe Tal Signed-off-by: Saeed Mahameed --- include/linux

[net-next 13/14] net/mlx5: Add helper to initialize 1PPS

2021-04-16 Thread Saeed Mahameed
From: Aya Levin Wrap 1PPS initialization in a helper for a cleaner init flow. Signed-off-by: Aya Levin Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/lib/clock.c | 25 +-- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet

[net-next 14/14] net/mlx5: Enhance diagnostics info for TX/RX reporters

2021-04-16 Thread Saeed Mahameed
From: Aya Levin Add ts_format to 'Common Config' section of the TX/RX devlink reporters diagnostics info. Possible values for ts_format: 'RT' or 'FRC' which stands for: Real Time and Free Running Counters correspondingly. Signed-off-by: Aya Levin Signed-off-by: Sa

[net-next 12/14] net/mlx5e: Add ethtool extended link state

2021-04-16 Thread Saeed Mahameed
ned-off-by: Moshe Tal Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en_ethtool.c | 171 ++ 1 file changed, 171 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index ef

[net-next 09/14] net/mlx5e: Cleanup safe switch channels API by passing params

2021-04-16 Thread Saeed Mahameed
ical. Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 8 +- .../ethernet/mellanox/mlx5/core/en_dcbnl.c| 15 ++- .../ethernet/mellanox/mlx5/core/en_ethtool.c | 98 +- .../net/ethernet/mellanox/mlx5/core/e

[net-next 10/14] net/mlx5: Allocate FC bulk structs with kvzalloc() instead of kzalloc()

2021-04-16 Thread Saeed Mahameed
From: Maor Dickman The bulk size is larger than 16K so use kvzalloc(). The bulk bitmask upper size limit is 16K so use kvcalloc(). Signed-off-by: Maor Dickman Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/fs_counters.c| 16 1 file changed, 8

[net-next 07/14] net/mlx5e: Use mlx5e_safe_switch_channels when channels are closed

2021-04-16 Thread Saeed Mahameed
ctored and simplified, where more complex flows are used to change configuration on the fly, without recreating the channels (the logic is rewritten in a more robust way, with a reset required by default and a list of exceptions). Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --

[net-next 05/14] net/mlx5e: kTLS, Add resiliency to RX resync failures

2021-04-16 Thread Saeed Mahameed
possible failure that demands driver handling is ICOSQ being full. By relying on the NAPI mechanism, we make sure that the entries in list will be handled when ICOSQ completions arrive and make some room available. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet

[net-next 04/14] net/mlx5e: TX, Inline function mlx5e_tls_handle_tx_wqe()

2021-04-16 Thread Saeed Mahameed
unused function parameter. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h | 2 +- .../net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c | 6 -- .../net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.h | 8

[net-next 06/14] net/mlx5e: Allow mlx5e_safe_switch_channels to work with channels closed

2021-04-16 Thread Saeed Mahameed
mlx5e_safe_switch_channels to work when the channels are closed. In this case it will assign the new parameters and run the preactivate hook. Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_main.c | 40 +-- 1 file changed, 27 insertions

[net-next 08/14] net/mlx5e: Refactor on-the-fly configuration changes

2021-04-16 Thread Saeed Mahameed
it's allowed to skip it. The logic of switching channel parameters is now completely encapsulated into mlx5e_safe_switch_channels(). Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- .../ethernet/mellanox/mlx5/core

[net-next 03/14] net/mlx5e: TX, Inline TLS skb check

2021-04-16 Thread Saeed Mahameed
: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h | 5 +++-- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c | 3 --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.h | 6 ++ 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers

[net-next 02/14] net/mlx5e: Cleanup unused function parameter

2021-04-16 Thread Saeed Mahameed
From: Tariq Toukan Socket parameter is not used in accel_rule_init(), remove it. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net

[net-next 01/14] net/mlx5e: Remove non-essential TLS SQ state bit

2021-04-16 Thread Saeed Mahameed
From: Tariq Toukan Maintaining an SQ state bit to indicate TLS support has no real need, a simple and fast test [1] for the SKB is almost equally good. [1] !skb->sk || !tls_is_sk_tx_device_offloaded(skb->sk) Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/et

[pull request][net-next 00/14] mlx5 updates 2021-04-16

2021-04-16 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series provides some updates to mlx5e driver. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 392c36e5be1dee19ffce8c8ba8f07f90f5aa3f7c: Merge

Re: [RFC net-next 4/6] ethtool: add interface to read standard MAC stats

2021-04-15 Thread Saeed Mahameed
On Thu, 2021-04-15 at 16:05 -0700, Jakub Kicinski wrote: > On Thu, 15 Apr 2021 15:46:52 -0700 Saeed Mahameed wrote: > > > > best practice here is to centralize all the data structures and > > > > information definitions in one place, you define the stat id, > > >

Re: [PATCH net-next v2 0/6] ethtool: add standard FEC statistics

2021-04-15 Thread Saeed Mahameed
tats >   sfc: ef10: implement ethtool::get_fec_stats >   mlx5: implement ethtool::get_fec_stats For the series: Reviewed-by: Saeed Mahameed

Re: [RFC net-next 4/6] ethtool: add interface to read standard MAC stats

2021-04-15 Thread Saeed Mahameed
On Thu, 2021-04-15 at 08:38 -0700, Jakub Kicinski wrote: > On Wed, 14 Apr 2021 23:12:52 -0700 Saeed Mahameed wrote: > > On Wed, 2021-04-14 at 13:23 -0700, Jakub Kicinski wrote: > > > Most of the MAC statistics are included in > > > struct rtnl_link_stats64, but some

Re: [PATCH net-next 3/6] ethtool: add FEC statistics

2021-04-15 Thread Saeed Mahameed
On Thu, 2021-04-15 at 08:21 -0700, Jakub Kicinski wrote: > On Wed, 14 Apr 2021 23:25:43 -0700 Saeed Mahameed wrote: > > On Tue, 2021-04-13 at 20:44 -0700, Jakub Kicinski wrote: > > > ethtool_link_ksettings *); > > > +   void(*get_fec_st

Re: [PATCH net-next 6/6] mlx5: implement ethtool::get_fec_stats

2021-04-14 Thread Saeed Mahameed
PCAM_FEATURE(mdev, ppcnt_statistical_group)) > +   return; > + > +   MLX5_SET(ppcnt_reg, in, local_port, 1); > +   MLX5_SET(ppcnt_reg, in, grp, > MLX5_PHYSICAL_LAYER_STATISTICAL_GROUP); > +   mlx5_core_access_reg(mdev, in, sz, ppcnt_phy_statistical, > +    sz, MLX5_REG_PPCNT, 0, 0); > + other than that the FW might fail us here, LGTM. Acked-by: Saeed Mahameed

Re: [PATCH net-next 3/6] ethtool: add FEC statistics

2021-04-14 Thread Saeed Mahameed
On Tue, 2021-04-13 at 20:44 -0700, Jakub Kicinski wrote: > ethtool_link_ksettings *); > +   void(*get_fec_stats)(struct net_device *dev, > +    struct ethtool_fec_stats > *fec_stats); why void ? some drivers need to access the FW and it could be an old FW/device

Re: [RFC net-next 4/6] ethtool: add interface to read standard MAC stats

2021-04-14 Thread Saeed Mahameed
On Wed, 2021-04-14 at 13:23 -0700, Jakub Kicinski wrote: > Most of the MAC statistics are included in > struct rtnl_link_stats64, but some fields > are aggregated. Besides it's good to expose > these clearly hardware stats separately. > > Signed-off-by: Jakub Kicinski > --- >  include/linux/ethto

Re: [RFC net-next 0/6] ethtool: add uAPI for reading standard stats

2021-04-14 Thread Saeed Mahameed
On Wed, 2021-04-14 at 13:23 -0700, Jakub Kicinski wrote: > This series adds a new ethtool command to read well defined > device statistics. There is nothing clever here, just a netlink > API for dumping statistics defined by standards and RFCs which > today end up in ethtool -S under infinite varia

[PATCH net 3/3] net/mlx5: Fix checksum issue of VXLAN and IPsec crypto offload

2021-04-14 Thread Saeed Mahameed
a path") Signed-off-by: Raed Salem Signed-off-by: Huy Nguyen Cc: Steffen Klassert Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_accel/ipsec_rxtx.c | 65 ++- .../mellanox/mlx5/core/en_accel/ipsec_rxtx.h | 21 +- 2 files changed, 69 insertions(+), 17 deleti

[PATCH net 2/3] net/xfrm: Add inner_ipproto into sec_path

2021-04-14 Thread Saeed Mahameed
From: Huy Nguyen The inner_ipproto saves the inner IP protocol of the plain text packet. This allows vendor's IPsec feature making offload decision at skb's features_check and configuring hardware at ndo_start_xmit. For example, ConnectX6-DX IPsec device needs the plaintext's IP protocol to supp

[PATCH net 1/3] net/mlx5: Optimize mlx5e_feature_checks for non IPsec packet

2021-04-14 Thread Saeed Mahameed
path") Signed-off-by: Raed Salem Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_accel/ipsec_rxtx.h | 15 +-- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 8 +--- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/d

[PATCH net 0/3] Fix ipsec offlaods with vxlan tunnel

2021-04-14 Thread Saeed Mahameed
From: Saeed Mahameed This small series fixes ipsec TX offloads with vxlan overlay on top of the offloaded ipsec packet, the driver (mlx5) was lacking such information and the skb->encapsulation bit wasn't enough as indication to reach the vxlan inner headers, as a solution we mark the t

[net 2/3] net/mlx5e: Fix setting of RS FEC mode

2021-04-14 Thread Saeed Mahameed
From: Aya Levin Change register setting from bit number to bit mask. Fixes: b5ede32d3329 ("net/mlx5e: Add support for FEC modes based on 50G per lane links") Signed-off-by: Aya Levin Reviewed-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/ml

[net 3/3] net/mlx5e: fix ingress_ifindex check in mlx5e_flower_parse_meta

2021-04-14 Thread Saeed Mahameed
_meta support") Signed-off-by: wenxu Acked-by: Pablo Neira Ayuso Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_

[pull request][net 0/3] mlx5 fixes 2021-04-14

2021-04-14 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series provides 3 small fixes to mlx5 driver. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 2afeec08ab5c86ae21952151f726bfe184f6b23d: xen-netback: Check for hotplug-status existence

[net 1/3] net/mlx5: Fix setting of devlink traps in switchdev mode

2021-04-14 Thread Saeed Mahameed
crashes upon setting a trap. Fixes: 241dc159391f ("net/mlx5: Notify on trap action by blocking event") Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Reviewed-by: Roi Dayan Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/dev

Re: [PATCH] net/mlx5e: fix ingress_ifindex check in mlx5e_flower_parse_meta

2021-04-14 Thread Saeed Mahameed
On Fri, 2021-04-09 at 13:33 +0800, we...@ucloud.cn wrote: > From: wenxu > > In the nft_offload there is the mate flow_dissector with no > ingress_ifindex but with ingress_iftype that only be used > in the software. So if the mask of ingress_ifindex in meta is > 0, this meta check should be bypass

[net-next V2 16/16] net/mlx5e: Fix RQ creation flow for queues which doesn't support XDP

2021-04-14 Thread Saeed Mahameed
From: Aya Levin Allow to create an RQ which is not registered as an XDP RQ. For example: the trap-RQ doesn't register as an XDP RQ. Fixes: 869c5f926247 ("net/mlx5e: Generalize open RQ") Signed-off-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mel

[net-next V2 15/16] net/mlx5: Replace spaces with tab at the start of a line

2021-04-14 Thread Saeed Mahameed
From: Wenpeng Liang There should be no spaces at the start of the line. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[net-next V2 14/16] net/mlx5: Remove return statement exist at the end of void function

2021-04-14 Thread Saeed Mahameed
From: Wenpeng Liang void function return statements are not generally useful. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 2 -- drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 1 - drivers

[net-next V2 13/16] net/mlx5: Add a blank line after declarations

2021-04-14 Thread Saeed Mahameed
From: Wenpeng Liang There should be a blank lines after declarations. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c| 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 1 + 2 files

[net-next V2 12/16] net/mlx5: Fix bit-wise and with zero

2021-04-14 Thread Saeed Mahameed
ot;) Fixes: 7dfee4b1d79e ("net/mlx5: IPsec, Refactor SA handle creation and destruction") Signed-off-by: Colin Ian King Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[net-next V2 11/16] net/mlx5: DR, Alloc cmd buffer with kvzalloc() instead of kzalloc()

2021-04-14 Thread Saeed Mahameed
From: Roi Dayan The cmd size is 8K so use kvzalloc(). Signed-off-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 6 +++--- 2 files changed, 5 insertions(+), 5

[net-next V2 01/16] net/mlx5: E-Switch, let user to enable disable metadata

2021-04-14 Thread Saeed Mahameed
: cmode runtime value true $ devlink dev param set pci/:06:00.0 \ name esw_port_metadata value false cmode runtime $ devlink dev eswitch set pci/:06:00.0 mode switchdev Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed

[pull request][net-next V2 00/16] mlx5 updates 2021-04-13

2021-04-14 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This patchset includes some updates and cleanup to mlx5 driver. For more information please see tag log below. v1->v2: update 1st patch commit message and mlx5 documentation to include performance numbers and applicability of the metadata settings. Ple

[net-next V2 06/16] net/mlx5: E-Switch, Move legacy code to a individual file

2021-04-14 Thread Saeed Mahameed
infrastructure code, move the legacy code to its own legacy.c file. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +- .../ethernet/mellanox/mlx5/core/esw/legacy.c | 509 + .../ethernet/mellanox/mlx5/core/esw

[net-next V2 09/16] net/mlx5: SF, Reuse stored hardware function id

2021-04-14 Thread Saeed Mahameed
From: Parav Pandit SF's hardware function id is already stored in mlx5_sf. Reuse it, instead of querying the hw table. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 5 ++--- 1 file changed, 2 insertions(+), 3 dele

[net-next V2 10/16] net/mlx5: DR, Use variably sized data structures for different actions

2021-04-14 Thread Saeed Mahameed
becomes a generic action header. Then actions are dynamically allocated with needed memory, the data for each action is stored right after the header. Signed-off-by: Jianbo Liu Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_action.c | 242 ++ .../mellanox/mlx5

[net-next V2 04/16] net/mlx5: E-Switch Make cleanup sequence mirror of init

2021-04-14 Thread Saeed Mahameed
From: Parav Pandit Make cleanup sequence mirror of init sequence for cleaning up reps and freeing vports. Also when reps initialization fails, there is no need to perform reps cleanup. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core

[net-next V2 05/16] net/mlx5: E-Switch, Convert a macro to a helper routine

2021-04-14 Thread Saeed Mahameed
From: Parav Pandit Convert ESW_ALLOWED macro to a helper routine so that it can be used in other eswitch files. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/eswitch.c | 32 +-- .../net/ethernet/mellanox/mlx5/core/eswitch.h

[net-next V2 02/16] net/mlx5: E-Switch, Skip querying SF enabled bits

2021-04-14 Thread Saeed Mahameed
From: Parav Pandit With vhca events, SF state is queried through the VHCA events. Device no longer expects SF bitmap in the query eswitch functions command. Hence, remove it to simplify the code. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox

[net-next V2 03/16] net/mlx5: E-Switch, Make vport number u16

2021-04-14 Thread Saeed Mahameed
From: Parav Pandit Vport number is 16-bit field in hardware. Make it u16. Move location of vport in the structure so that it reduces a hole in the structure. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2

[net-next V2 08/16] net/mlx5: SF, Use device pointer directly

2021-04-14 Thread Saeed Mahameed
From: Parav Pandit At many places in the code, device pointer is directly available. Make use of it, instead of accessing it from the table. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/sf/hw_table.c| 16 1 file changed, 8

[net-next V2 07/16] net/mlx5: E-Switch, Initialize eswitch acls ns when eswitch is enabled

2021-04-14 Thread Saeed Mahameed
s not dependent on eswitch, make namespace init and cleanup routines as helper routines to be invoked only when eswitch is needed. With this change, ingress and egress ACL namespaces are created only when eswitch legacy/offloads mode is enabled. Signed-off-by: Parav Pandit Signed-off-by:

Re: [net-next 01/16] net/mlx5: E-Switch, let user to enable disable metadata

2021-04-13 Thread Saeed Mahameed
On Tue, 2021-04-13 at 13:21 -0700, Jakub Kicinski wrote: > On Tue, 13 Apr 2021 12:29:51 -0700 Saeed Mahameed wrote: > > Currently each packet inserted in eswitch is tagged with a internal > > metadata to indicate source vport. Metadata tagging is not always > > needed. Metadat

[net-next 16/16] net/mlx5e: Fix RQ creation flow for queues which doesn't support XDP

2021-04-13 Thread Saeed Mahameed
From: Aya Levin Allow to create an RQ which is not registered as an XDP RQ. For example: the trap-RQ doesn't register as an XDP RQ. Fixes: 869c5f926247 ("net/mlx5e: Generalize open RQ") Signed-off-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mel

[net-next 08/16] net/mlx5: SF, Use device pointer directly

2021-04-13 Thread Saeed Mahameed
From: Parav Pandit At many places in the code, device pointer is directly available. Make use of it, instead of accessing it from the table. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/sf/hw_table.c| 16 1 file changed, 8

[net-next 15/16] net/mlx5: Replace spaces with tab at the start of a line

2021-04-13 Thread Saeed Mahameed
From: Wenpeng Liang There should be no spaces at the start of the line. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[net-next 13/16] net/mlx5: Add a blank line after declarations

2021-04-13 Thread Saeed Mahameed
From: Wenpeng Liang There should be a blank lines after declarations. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c| 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 1 + 2 files

[net-next 09/16] net/mlx5: SF, Reuse stored hardware function id

2021-04-13 Thread Saeed Mahameed
From: Parav Pandit SF's hardware function id is already stored in mlx5_sf. Reuse it, instead of querying the hw table. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/sf/devlink.c | 5 ++--- 1 file changed, 2 insertions(+), 3 dele

[net-next 10/16] net/mlx5: DR, Use variably sized data structures for different actions

2021-04-13 Thread Saeed Mahameed
becomes a generic action header. Then actions are dynamically allocated with needed memory, the data for each action is stored right after the header. Signed-off-by: Jianbo Liu Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/steering/dr_action.c | 242 ++ .../mellanox/mlx5

[net-next 14/16] net/mlx5: Remove return statement exist at the end of void function

2021-04-13 Thread Saeed Mahameed
From: Wenpeng Liang void function return statements are not generally useful. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 2 -- drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 1 - drivers

[net-next 12/16] net/mlx5: Fix bit-wise and with zero

2021-04-13 Thread Saeed Mahameed
ot;) Fixes: 7dfee4b1d79e ("net/mlx5: IPsec, Refactor SA handle creation and destruction") Signed-off-by: Colin Ian King Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[net-next 11/16] net/mlx5: DR, Alloc cmd buffer with kvzalloc() instead of kzalloc()

2021-04-13 Thread Saeed Mahameed
From: Roi Dayan The cmd size is 8K so use kvzalloc(). Signed-off-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 6 +++--- 2 files changed, 5 insertions(+), 5

[net-next 07/16] net/mlx5: E-Switch, Initialize eswitch acls ns when eswitch is enabled

2021-04-13 Thread Saeed Mahameed
s not dependent on eswitch, make namespace init and cleanup routines as helper routines to be invoked only when eswitch is needed. With this change, ingress and egress ACL namespaces are created only when eswitch legacy/offloads mode is enabled. Signed-off-by: Parav Pandit Signed-off-by:

[net-next 06/16] net/mlx5: E-Switch, Move legacy code to a individual file

2021-04-13 Thread Saeed Mahameed
infrastructure code, move the legacy code to its own legacy.c file. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +- .../ethernet/mellanox/mlx5/core/esw/legacy.c | 509 + .../ethernet/mellanox/mlx5/core/esw

[net-next 03/16] net/mlx5: E-Switch, Make vport number u16

2021-04-13 Thread Saeed Mahameed
From: Parav Pandit Vport number is 16-bit field in hardware. Make it u16. Move location of vport in the structure so that it reduces a hole in the structure. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2

[net-next 05/16] net/mlx5: E-Switch, Convert a macro to a helper routine

2021-04-13 Thread Saeed Mahameed
From: Parav Pandit Convert ESW_ALLOWED macro to a helper routine so that it can be used in other eswitch files. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/eswitch.c | 32 +-- .../net/ethernet/mellanox/mlx5/core/eswitch.h

[net-next 04/16] net/mlx5: E-Switch Make cleanup sequence mirror of init

2021-04-13 Thread Saeed Mahameed
From: Parav Pandit Make cleanup sequence mirror of init sequence for cleaning up reps and freeing vports. Also when reps initialization fails, there is no need to perform reps cleanup. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core

[net-next 02/16] net/mlx5: E-Switch, Skip querying SF enabled bits

2021-04-13 Thread Saeed Mahameed
From: Parav Pandit With vhca events, SF state is queried through the VHCA events. Device no longer expects SF bitmap in the query eswitch functions command. Hence, remove it to simplify the code. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox

[net-next 01/16] net/mlx5: E-Switch, let user to enable disable metadata

2021-04-13 Thread Saeed Mahameed
Reviewed-by: Roi Dayan Reviewed-by: Vu Pham Signed-off-by: Saeed Mahameed --- .../device_drivers/ethernet/mellanox/mlx5.rst | 23 +++ .../net/ethernet/mellanox/mlx5/core/devlink.c | 62 +++ .../net/ethernet/mellanox/mlx5/core/devlink.h | 1 + .../net/ethernet/mellanox/mlx5/core

[pull request][net-next 00/16] mlx5 updates 2021-04-13

2021-04-13 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This patchset includes some updates and cleanup to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit

[pull-request][net-next][rdma-next] mlx5-next 2021-04-09

2021-04-09 Thread Saeed Mahameed
t to be more generic net/mlx5: Add IFC bits needed for single FDB mode Mikhael Goikhman (1): net/mlx5: Remove unused mlx5_core_health member recover_work Saeed Mahameed (1): net/mlx5: Cleanup prototype warning Tariq Toukan (1): net/mlx5: Use order-0 allocations for E

[net-next 11/13] net/mlx5e: TC, Refactor tc update skb function

2021-04-06 Thread Saeed Mahameed
From: Chris Mi As a pre-step to process sampled packet in this function. Signed-off-by: Chris Mi Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en/rep/tc.c | 59 +++ 1 file changed, 33 insertions(+), 26 deletions(-) diff --git a/drivers/net/ethernet

[net-next 07/13] net/mlx5e: TC, Parse sample action

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Parse TC sample action and save sample parameters in flow attribute data structure. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en/tc_priv.h | 1 + .../net/ethernet/mellanox/mlx5

[net-next 08/13] net/mlx5e: TC, Add sampler termination table API

2021-04-06 Thread Saeed Mahameed
Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/Kconfig | 12 +++ .../net/ethernet/mellanox/mlx5/core/Makefile | 1 + .../net/ethernet/mellanox/mlx5/core/en_rep.h | 1 + .../net/ethernet/mellanox/mlx5/core/en_tc.c | 11 +++ .../ethernet

[net-next 06/13] net/mlx5: Instantiate separate mapping objects for FDB and NIC tables

2021-04-06 Thread Saeed Mahameed
when creating the chains object. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/Makefile | 5 ++- .../net/ethernet/mellanox/mlx5/core/en/fs.h | 1 + .../ethernet/mellanox/mlx5/core/en/rep/tc.c

[net-next 09/13] net/mlx5e: TC, Add sampler object API

2021-04-06 Thread Saeed Mahameed
-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/esw/sample.c | 131 ++ 1 file changed, 131 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/sample.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/sample.c index 9bd996e8d28a..37e33670bb24 100644

[net-next 10/13] net/mlx5e: TC, Add sampler restore handle API

2021-04-06 Thread Saeed Mahameed
to userspace. Aggregate the modify header action, restore rule and object ID to a sample restore handle. Re-use identical sample restore handle for the same object ID. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox

[net-next 13/13] net/mlx5e: TC, Add support to offload sample action

2021-04-06 Thread Saeed Mahameed
: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_tc.c | 30 +++ .../ethernet/mellanox/mlx5/core/esw/sample.c | 235 ++ .../ethernet/mellanox/mlx5/core/esw/sample.h | 18 ++ .../net/ethernet/mellanox/mlx5/core

[net-next 05/13] net/mlx5: Map register values to restore objects

2021-04-06 Thread Saeed Mahameed
usive contexts such as chain id and sample group id. Use the mapping object to associate an index with a restore object as a prestep for supporting additional restore types. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox

[net-next 12/13] net/mlx5e: TC, Handle sampled packets

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Mark the sampled packets with a sample restore object. Send sampled packets using the psample api. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 14

[net-next 02/13] net/mlx5: E-switch, Rename functions to follow naming convention.

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Public api starts with mlx5 and remove mlx5 for non-public api. Signed-off-by: Chris Mi Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/esw/vporttbl.c | 4 +-- .../net/ethernet/mellanox/mlx5/core/eswitch.h | 4 +-- .../mellanox/mlx5/core/eswitch_offloads.c

[net-next 03/13] net/mlx5: E-switch, Generalize per vport table API

2021-04-06 Thread Saeed Mahameed
: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/esw/vporttbl.c| 15 --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 7 +++ .../mellanox/mlx5/core/eswitch_offloads.c | 14 ++ 3

[net-next 04/13] net/mlx5: E-switch, Set per vport table default group number

2021-04-06 Thread Saeed Mahameed
hlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/esw/vporttbl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/vporttbl.c b/drivers/net/ethernet/mellanox/mlx5/cor

[net-next 01/13] net/mlx5: E-switch, Move vport table functions to a new file

2021-04-06 Thread Saeed Mahameed
and the sample features. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +- .../mellanox/mlx5/core/esw/vporttbl.c | 136 +++ .../net/ethernet/mellanox/mlx5/core/eswitch.h

[pull request][net-next 00/13] mlx5 updates 2021-04-06

2021-04-06 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series From Chris adds the support for TC psample offloads to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit

[net 4/5] net/mlx5: Fix PBMC register mapping

2021-04-06 Thread Saeed Mahameed
he Shemesh Signed-off-by: Saeed Mahameed --- include/linux/mlx5/mlx5_ifc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 9940070cda8f..9c68b2da14c6 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/

  1   2   3   4   5   6   7   8   9   10   >