Re: [net-next 07/15] net/mlx5: mlx5_ifc updates for flex parser

2021-04-19 Thread Samudrala, Sridhar
On 4/19/2021 8:20 PM, Saeed Mahameed wrote: From: Yevgeny Kliteynik Added the required definitions for supporting more protocols by flex parsers (GTP-U, Geneve TLV options), and for using the right flex parser that was configured for this protocol. Are you planning to support adding flow rules

Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering

2021-04-09 Thread Samudrala, Sridhar
On 4/9/2021 11:37 AM, Jakub Kicinski wrote: On Fri, 9 Apr 2021 20:01:14 +0300 Vadym Kochan wrote: On Fri, Apr 09, 2021 at 09:51:13AM -0700, Samudrala, Sridhar wrote: On 4/9/2021 9:22 AM, Oleksandr Mazur wrote: I'd like to discuss a possibility of handling devlink port parameters with de

Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering

2021-04-09 Thread Samudrala, Sridhar
On 4/9/2021 9:22 AM, Oleksandr Mazur wrote: I'd like to discuss a possibility of handling devlink port parameters with devlink port pointer supplied. Current design makes it impossible to distinguish which port's parameter should get altered (set) or retrieved (get) whenever there's a single par

Re: [PATCH net 1/4] virtchnl: Fix layout of RSS structures

2021-03-28 Thread Samudrala, Sridhar
On 3/27/2021 2:53 AM, Geert Uytterhoeven wrote: Hi Samudrala, On Fri, Mar 26, 2021 at 11:45 PM Samudrala, Sridhar wrote: On 3/26/2021 1:06 AM, Geert Uytterhoeven wrote: On Thu, Mar 25, 2021 at 11:29 PM Tony Nguyen wrote: From: Norbert Ciosek Remove padding from RSS structures. Previous

Re: [net-next V9 14/14] net/mlx5: Add devlink subfunction port documentation

2021-01-23 Thread Samudrala, Sridhar
On 1/21/2021 4:11 PM, Jason Gunthorpe wrote: On Thu, Jan 21, 2021 at 12:59:55PM -0800, Samudrala, Sridhar wrote: + mlx5_core.sf.4 + (subfunction auxiliary device

Re: [net-next V9 14/14] net/mlx5: Add devlink subfunction port documentation

2021-01-21 Thread Samudrala, Sridhar
On 1/21/2021 12:52 AM, Saeed Mahameed wrote: From: Parav Pandit Add documentation for subfunction management using devlink port. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../device_drivers/ethernet/mellanox/mlx5.rst | 210 ++ 1 file changed, 210 insert

Re: [net-next V9 04/14] devlink: Support get and set state of port function

2021-01-21 Thread Samudrala, Sridhar
On 1/21/2021 12:52 AM, Saeed Mahameed wrote: From: Parav Pandit devlink port function can be in active or inactive state. Allow users to get and set port function's state. When the port function it activated, its operational state may change after a while when the device is created and driver

Re: [net-next V9 03/14] devlink: Support add and delete devlink port

2021-01-21 Thread Samudrala, Sridhar
On 1/21/2021 12:52 AM, Saeed Mahameed wrote: From: Parav Pandit Extended devlink interface for the user to add and delete a port. Extend devlink to connect user requests to driver to add/delete a port in the device. Driver routines are invoked without holding devlink instance lock. This enable

Re: [PATCH net-next v2 00/14] Add mlx5 subfunction support

2020-12-10 Thread Samudrala, Sridhar
On 12/8/2020 11:29 PM, sa...@kernel.org wrote: From: Parav Pandit Hi Dave, Jakub, Jason, This series form Parav was the theme of this mlx5 release cycle, we've been waiting anxiously for the auxbus infrastructure to make it into the kernel, and now as the auxbus is in and all the stars are ali

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-20 Thread Samudrala, Sridhar
On 11/20/2020 9:58 AM, Alexander Duyck wrote: On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski wrote: On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: On 11/18/20 7:14 PM, Jakub Kicinski wrote: On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: On Tue, Nov 17, 2020 at 09:11:20A

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Samudrala, Sridhar
On 11/18/2020 5:17 PM, David Ahern wrote: On 11/18/20 5:41 PM, Jacob Keller wrote: On 11/18/2020 11:22 AM, Parav Pandit wrote: From: David Ahern Sent: Wednesday, November 18, 2020 11:33 PM With Connectx-4 Lx for example the netdev can have at most 63 queues leaving 96 cpu servers a b

Re: [PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Samudrala, Sridhar
On 9/17/2020 9:41 PM, Parav Pandit wrote: Hi David, From: David Ahern Sent: Friday, September 18, 2020 9:08 AM On 9/17/20 9:29 PM, Parav Pandit wrote: Examples: Create a PCI PF and PCI SF port. $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ devlink port add netdevsim

Re: [Intel-wired-lan] [PATCH net-next] i40e: allow VMDQs to be used with AF_XDP zero-copy

2020-09-11 Thread Samudrala, Sridhar
On 9/11/2020 6:10 AM, Maciej Fijalkowski wrote: On Fri, Sep 11, 2020 at 02:29:50PM +0200, Magnus Karlsson wrote: On Fri, Sep 11, 2020 at 2:11 PM Maciej Fijalkowski wrote: On Fri, Sep 11, 2020 at 02:08:26PM +0200, Magnus Karlsson wrote: From: Magnus Karlsson Allow VMDQs to be used with A

Re: [PATCH v2] fs/epoll: Enable non-blocking busypoll when epoll timeout is 0

2020-07-06 Thread Samudrala, Sridhar
On 7/6/2020 1:36 PM, Alexander Duyck wrote: On Wed, Jun 24, 2020 at 4:03 PM Sridhar Samudrala wrote: This patch triggers non-blocking busy poll when busy_poll is enabled, epoll is called with a timeout of 0 and is associated with a napi_id. This enables an app thread to go through napi poll

Re: [PATCH v2] fs/epoll: Enable non-blocking busypoll when epoll timeout is 0

2020-07-06 Thread Samudrala, Sridhar
Resending. Dave, Eric, Can we get this in via net-next as this is targeted for networking use case using epoll/busypoll. Thanks Sridhar On 6/24/2020 12:30 PM, Sridhar Samudrala wrote: This patch triggers non-blocking busy poll when busy_poll is enabled, epoll is called with a timeout of 0 a

Re: ADQ - comparison to aRFS, clarifications on NAPI ID, binding with busy-polling

2020-06-30 Thread Samudrala, Sridhar
On 6/26/2020 5:48 AM, Maxim Mikityanskiy wrote: Thanks a lot for your reply! It was really helpful. I have a few comments, please see below. On 2020-06-24 23:21, Samudrala, Sridhar wrote: On 6/17/2020 6:15 AM, Maxim Mikityanskiy wrote: Hi, I discovered Intel ADQ feature [1] that allows

Re: ADQ - comparison to aRFS, clarifications on NAPI ID, binding with busy-polling

2020-06-24 Thread Samudrala, Sridhar
On 6/17/2020 6:15 AM, Maxim Mikityanskiy wrote: Hi, I discovered Intel ADQ feature [1] that allows to boost performance by picking dedicated queues for application traffic. We did some research, and I got some level of understanding how it works, but I have some questions, and I hope you c

Re: [PATCH] fs/epoll: Enable non-blocking busypoll with epoll timeout of 0

2020-06-24 Thread Samudrala, Sridhar
On 6/24/2020 9:49 AM, Eric Dumazet wrote: On 6/24/20 9:32 AM, Samudrala, Sridhar wrote: Adding Dave, Eric for review and see if we can get this in via net-next as this is mainly useful for networking workloads doing busypoll. Thanks Sridhar On 6/19/2020 11:13 AM, Sridhar Samudrala wrote

Re: [PATCH] fs/epoll: Enable non-blocking busypoll with epoll timeout of 0

2020-06-24 Thread Samudrala, Sridhar
Adding Dave, Eric for review and see if we can get this in via net-next as this is mainly useful for networking workloads doing busypoll. Thanks Sridhar On 6/19/2020 11:13 AM, Sridhar Samudrala wrote: This patch triggers non-blocking busy poll when busy_poll is enabled and epoll is called with

Re: [PATCH net-next v2 1/3] i40e: optimize AF_XDP Tx completion path

2020-06-23 Thread Samudrala, Sridhar
On 6/23/2020 2:44 AM, Magnus Karlsson wrote: Improve the performance of the AF_XDP zero-copy Tx completion path. When there are no XDP buffers being sent using XDP_TX or XDP_REDIRECT, we do not have go through the SW ring to clean up any entries since the AF_XDP path does not use these. In the

Re: [Intel-wired-lan] [PATCH net-next 1/2] i40e: optimize AF_XDP Tx completion path

2020-06-22 Thread Samudrala, Sridhar
On 6/22/2020 6:21 AM, Magnus Karlsson wrote: Improve the performance of the AF_XDP zero-copy Tx completion path. When there are no XDP buffers being sent using XDP_TX or XDP_REDIRECT, we do not have go through the SW ring to clean up any entries since the AF_XDP path does not use these. In the

Re: [RFC v2] current devlink extension plan for NICs

2020-05-03 Thread Samudrala, Sridhar
On 5/1/2020 2:14 AM, Jiri Pirko wrote: Hi all. First, I would like to apologize for very long email. But I think it would be beneficial to the see the whole picture, where we are going. Currently we are working internally on several features with need of extension of the current devlink infr

Re: [Intel-wired-lan] FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-22 Thread Samudrala, Sridhar
On 10/21/2019 3:34 PM, Alexei Starovoitov wrote: On Mon, Oct 21, 2019 at 1:10 PM Samudrala, Sridhar wrote: On 10/20/2019 10:12 AM, Björn Töpel wrote: On Sun, 20 Oct 2019 at 12:15, Toke Høiland-Jørgensen wrote: Alexei Starovoitov writes: On Fri, Oct 18, 2019 at 05:45:26PM -0700

Re: [Intel-wired-lan] FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-21 Thread Samudrala, Sridhar
On 10/20/2019 10:12 AM, Björn Töpel wrote: On Sun, 20 Oct 2019 at 12:15, Toke Høiland-Jørgensen wrote: Alexei Starovoitov writes: On Fri, Oct 18, 2019 at 05:45:26PM -0700, Samudrala, Sridhar wrote: On 10/18/2019 5:14 PM, Alexei Starovoitov wrote: On Fri, Oct 18, 2019 at 11:40:07AM -0700

Re: FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-18 Thread Samudrala, Sridhar
On 10/18/2019 5:14 PM, Alexei Starovoitov wrote: On Fri, Oct 18, 2019 at 11:40:07AM -0700, Samudrala, Sridhar wrote: Perf report for "AF_XDP default rxdrop" with patched kernel - mitigations ON == Samples: 44

Re: FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-18 Thread Samudrala, Sridhar
On 10/9/2019 6:06 PM, Alexei Starovoitov wrote: Will update the patchset with the right performance data and address feedback from Bjorn. Hope you are not totally against direct XDP approach as it does provide value when an AF_XDP socket is bound to a queue and a HW filter can direct packets

Re: [PATCH v3 3/3] i40e: Add UDP segmentation offload support

2019-10-11 Thread Samudrala, Sridhar
On 10/11/2019 10:56 AM, Alexander Duyck wrote: On Fri, 2019-10-11 at 10:39 -0700, Samudrala, Sridhar wrote: On 10/11/2019 9:53 AM, Josh Hunt wrote: Based on a series from Alexander Duyck this change adds UDP segmentation offload support to the i40e driver. CC: Alexander Duyck CC: Willem

Re: [PATCH v3 3/3] i40e: Add UDP segmentation offload support

2019-10-11 Thread Samudrala, Sridhar
On 10/11/2019 9:53 AM, Josh Hunt wrote: Based on a series from Alexander Duyck this change adds UDP segmentation offload support to the i40e driver. CC: Alexander Duyck CC: Willem de Bruijn Signed-off-by: Josh Hunt --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 + drivers/net/ethe

Re: [PATCH 3/3] i40e: Add UDP segmentation offload support

2019-10-09 Thread Samudrala, Sridhar
On 10/9/2019 3:06 PM, Josh Hunt wrote: Based on a series from Alexander Duyck this change adds UDP segmentation offload support to the i40e driver. CC: Alexander Duyck CC: Willem de Bruijn Signed-off-by: Josh Hunt --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 + drivers/net/ether

Re: FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-09 Thread Samudrala, Sridhar
On 10/9/2019 10:17 AM, Alexei Starovoitov wrote: On Wed, Oct 9, 2019 at 9:53 AM Samudrala, Sridhar wrote: + +u32 bpf_direct_xsk(const struct bpf_prog *prog, struct xdp_buff *xdp) +{ + struct xdp_sock *xsk; + + xsk = xdp_get_xsk_from_qid(xdp->rxq->dev, xdp->rxq->

Re: FW: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-09 Thread Samudrala, Sridhar
+ +u32 bpf_direct_xsk(const struct bpf_prog *prog, struct xdp_buff *xdp) +{ + struct xdp_sock *xsk; + + xsk = xdp_get_xsk_from_qid(xdp->rxq->dev, xdp->rxq->queue_index); + if (xsk) { + struct bpf_redirect_info *ri = + this_cpu_ptr(&bpf_redirect_info); + +

Re: [PATCH bpf-next 2/4] xsk: allow AF_XDP sockets to receive packets directly from a queue

2019-10-09 Thread Samudrala, Sridhar
On 10/8/2019 1:05 AM, Björn Töpel wrote: On 2019-10-08 08:16, Sridhar Samudrala wrote: Introduce a flag that can be specified during the bind() call of an AF_XDP socket to receive packets directly from a queue when there is no XDP program attached to the device. This is enabled by introducing

Re: [PATCH bpf-next 0/4] Enable direct receive on AF_XDP sockets

2019-10-09 Thread Samudrala, Sridhar
On 10/8/2019 1:05 AM, Björn Töpel wrote: On 2019-10-08 08:16, Sridhar Samudrala wrote: This is a rework of the following patch series https://lore.kernel.org/netdev/1565840783-8269-1-git-send-email-sridhar.samudr...@intel.com/#r that tried to enable direct receive by bypassing XDP program att

Re: [PATCH bpf-next 0/4] Enable direct receive on AF_XDP sockets

2019-10-08 Thread Samudrala, Sridhar
On 10/8/2019 5:49 PM, Jakub Kicinski wrote: On Mon, 7 Oct 2019 23:16:51 -0700, Sridhar Samudrala wrote: This is a rework of the following patch series https://lore.kernel.org/netdev/1565840783-8269-1-git-send-email-sridhar.samudr...@intel.com/#r that tried to enable direct receive by bypassi

Re: [PATCH bpf-next 0/5] Add support for SKIP_BPF flag for AF_XDP sockets

2019-08-15 Thread Samudrala, Sridhar
On 8/15/2019 12:28 PM, Jakub Kicinski wrote: On Wed, 14 Aug 2019 20:46:18 -0700, Sridhar Samudrala wrote: This patch series introduces XDP_SKIP_BPF flag that can be specified during the bind() call of an AF_XDP socket to skip calling the BPF program in the receive path and pass the buffer dir

Re: [PATCH bpf-next 0/5] Add support for SKIP_BPF flag for AF_XDP sockets

2019-08-15 Thread Samudrala, Sridhar
On 8/15/2019 10:11 AM, Toke Høiland-Jørgensen wrote: "Samudrala, Sridhar" writes: On 8/15/2019 4:12 AM, Toke Høiland-Jørgensen wrote: Sridhar Samudrala writes: This patch series introduces XDP_SKIP_BPF flag that can be specified during the bind() call of an AF_XDP sock

Re: [PATCH bpf-next 0/5] Add support for SKIP_BPF flag for AF_XDP sockets

2019-08-15 Thread Samudrala, Sridhar
On 8/15/2019 5:51 AM, Björn Töpel wrote: On 2019-08-15 05:46, Sridhar Samudrala wrote: This patch series introduces XDP_SKIP_BPF flag that can be specified during the bind() call of an AF_XDP socket to skip calling the BPF program in the receive path and pass the buffer directly to the socket.

Re: [PATCH bpf-next 0/5] Add support for SKIP_BPF flag for AF_XDP sockets

2019-08-15 Thread Samudrala, Sridhar
On 8/15/2019 4:12 AM, Toke Høiland-Jørgensen wrote: Sridhar Samudrala writes: This patch series introduces XDP_SKIP_BPF flag that can be specified during the bind() call of an AF_XDP socket to skip calling the BPF program in the receive path and pass the buffer directly to the socket. When

Re: [RFC bpf-next 0/7] busy poll support for AF_XDP sockets

2019-05-16 Thread Samudrala, Sridhar
On 5/16/2019 5:37 AM, Magnus Karlsson wrote: After a number of surprises and issues in the driver here are now the first set of results. 64 byte packets at 40Gbit/s line rate. All results in Mpps. Note that I just used my local system and kernel build for these numbers so they are not performanc

Re: [RFC bpf-next 0/7] busy poll support for AF_XDP sockets

2019-05-13 Thread Samudrala, Sridhar
On 5/13/2019 1:42 PM, Jonathan Lemon wrote: Tossing in my .02 cents: I anticipate that most users of AF_XDP will want packet processing for a given RX queue occurring on a single core - otherwise we end up with cache delays. The usual model is one thread, one socket, one core, but this isn't e

Re: [RFC bpf-next 5/7] net: add busy-poll support for XDP sockets

2019-05-02 Thread Samudrala, Sridhar
On 5/2/2019 1:39 AM, Magnus Karlsson wrote: This patch adds busy-poll support for XDP sockets (AF_XDP). With busy-poll, the driver is executed in process context by calling the poll() syscall. The main advantage with this is that all processing occurs on a single core. This eliminates the core

Re: [RFC bpf-next 4/7] netdevice: introduce busy-poll setsockopt for AF_XDP

2019-05-02 Thread Samudrala, Sridhar
On 5/2/2019 1:39 AM, Magnus Karlsson wrote: This patch introduces a new setsockopt that enables busy-poll for XDP sockets. It is called XDP_BUSY_POLL_BATCH_SIZE and takes batch size as an argument. A value between 1 and NAPI_WEIGHT (64) will turn it on, 0 will turn it off and any other value w

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-14 Thread Samudrala, Sridhar
On 3/14/2019 6:28 PM, Parav Pandit wrote: -Original Message- From: Jakub Kicinski Sent: Thursday, March 14, 2019 6:39 PM To: Parav Pandit Cc: Jiri Pirko ; da...@davemloft.net; netdev@vger.kernel.org; oss-driv...@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow sub

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Samudrala, Sridhar
On 3/13/2019 12:37 AM, Jiri Pirko wrote: Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudr...@intel.com wrote: On 3/12/2019 7:02 AM, Jiri Pirko wrote: I originally planned to implement sriov orchestration api in devlink too. Interesting, would you mind elaborating? I have to think a

Re: Three questions about busy poll

2019-02-22 Thread Samudrala, Sridhar
On 2/15/2019 11:18 AM, Cong Wang wrote: On Thu, Feb 14, 2019 at 4:43 PM Samudrala, Sridhar wrote: On 2/14/2019 12:15 PM, Cong Wang wrote: Hello, While looking into the busy polling in Linux kernel, three questions come into my mind: 1. In the document[1], it claims sysctl.net.busy_poll

Re: phys_port_id in switchdev mode?

2018-09-05 Thread Samudrala, Sridhar
On 9/4/2018 3:20 AM, Jakub Kicinski wrote: On Mon, 3 Sep 2018 12:40:22 +0300, Or Gerlitz wrote: On Tue, Aug 28, 2018 at 9:05 PM, Jakub Kicinski wrote: Hi! Hi Jakub and sorry for the late reply, this crazigly hot summer refuses to die, Note I replied couple of minutes ago but it didn't get to

Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-04 Thread Samudrala, Sridhar
On 9/3/2018 7:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] There should check the

Re: [PATCH net-next] failover: remove set but not used variable 'primary_dev'

2018-08-31 Thread Samudrala, Sridhar
On 8/30/2018 8:46 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] Actually this gcc op

Re: virtio_net failover and initramfs

2018-08-17 Thread Samudrala, Sridhar
On 8/17/2018 2:56 AM, Harald Hoyer wrote: On 17.08.2018 11:51, Harald Hoyer wrote: On 16.08.2018 00:17, Siwei Liu wrote: On Wed, Aug 15, 2018 at 12:05 PM, Samudrala, Sridhar wrote: On 8/14/2018 5:03 PM, Siwei Liu wrote: Are we sure all userspace apps skip and ignore slave interfaces by just

Re: virtio_net failover and initramfs (was: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework)

2018-08-15 Thread Samudrala, Sridhar
On 8/14/2018 5:03 PM, Siwei Liu wrote: Are we sure all userspace apps skip and ignore slave interfaces by just looking at "IFLA_MASTER" attribute? When STANDBY is enabled on virtio-net, a failover master interface will appear, which automatically enslaves the virtio device. But it is found out t

Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw

2018-06-29 Thread Samudrala, Sridhar
On 6/29/2018 6:05 AM, Jiri Pirko wrote: Fri, Jun 29, 2018 at 02:54:36PM CEST, dsah...@gmail.com wrote: On 6/29/18 6:48 AM, Jiri Pirko wrote: Fri, Jun 29, 2018 at 02:12:21PM CEST, j...@mojatatu.com wrote: On 29/06/18 04:39 AM, Jiri Pirko wrote: Fri, Jun 29, 2018 at 12:25:53AM CEST, xiyou.wangc

Re: [patch net-next 0/9] net: sched: introduce chain templates support with offloading to mlxsw

2018-06-27 Thread Samudrala, Sridhar
On 6/27/2018 12:50 AM, Jiri Pirko wrote: Tue, Jun 26, 2018 at 11:18:58PM CEST, jakub.kicin...@netronome.com wrote: On Tue, 26 Jun 2018 09:12:17 +0200, Jiri Pirko wrote: Tue, Jun 26, 2018 at 09:00:45AM CEST, jakub.kicin...@netronome.com wrote: On Mon, Jun 25, 2018 at 11:43 PM, Jiri Pirko wrote

Re: [patch net-next v2 0/9] net: sched: introduce chain templates support with offloading to mlxsw

2018-06-26 Thread Samudrala, Sridhar
On 6/26/2018 11:05 PM, Jiri Pirko wrote: Wed, Jun 27, 2018 at 02:04:31AM CEST, xiyou.wangc...@gmail.com wrote: On Tue, Jun 26, 2018 at 1:01 AM Jiri Pirko wrote: Create dummy device with clsact first: # ip link add type dummy # tc qdisc add dev dummy0 clsact There is no template assigned by

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Samudrala, Sridhar
On 6/22/2018 5:17 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 4:40 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at

Re: [PATCH net] failover: eliminate callback hell

2018-06-11 Thread Samudrala, Sridhar
On 6/11/2018 12:34 PM, Samudrala, Sridhar wrote: On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote: On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:    * Set permanent and current address of net_failover device to match the primary. We copy the dev_addr of standby dev

Re: [PATCH net] failover: eliminate callback hell

2018-06-11 Thread Samudrala, Sridhar
On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote: On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: * Set permanent and current address of net_failover device to match the primary. * Carrier should be marked off before registering device the net_failover device

Re: [PATCH net] failover: eliminate callback hell

2018-06-06 Thread Samudrala, Sridhar
On 6/6/2018 2:24 PM, Stephen Hemminger wrote: On Wed, 6 Jun 2018 15:30:27 +0300 "Michael S. Tsirkin" wrote: On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote: Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote: The net failover should be a simple library, not

Re: [net-next PATCH v3 3/5] net: Enable Tx queue selection based on Rx queues

2018-06-06 Thread Samudrala, Sridhar
On 6/6/2018 11:56 AM, Willem de Bruijn wrote: On Tue, Jun 5, 2018 at 4:38 AM, Amritha Nambiar wrote: This patch adds support to pick Tx queue based on the Rx queue(s) map configuration set by the admin through the sysfs attribute for each Tx queue. If the user configuration for receive queue(

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 11:00 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:39:12 -0700 "Samudrala, Sridhar" wrote: On 6/5/2018 8:51 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 16:52:22 -0700 "Samudrala, Sridhar" wrote: On 6/5/2018 2:52 PM, Stephen Hemminger wrote:

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 8:51 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 16:52:22 -0700 "Samudrala, Sridhar" wrote: On 6/5/2018 2:52 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: See: https://patchwork.ozlabs.org/patch/85

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 2:52 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: See: https://patchwork.ozlabs.org/patch/851711/ Let me try to summarize that: You wanted to speed up the delayed link up. You had an idea to additionally take link

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Samudrala, Sridhar
On 6/4/2018 8:42 PM, Stephen Hemminger wrote: The net failover should be a simple library, not a virtual object with function callbacks (see callback hell). The code is simpler is smaller both for the netvsc and virtio use case. I quickly tried this patch and it breaks virtio-net in standby mod

Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()

2018-05-31 Thread Samudrala, Sridhar
On 5/31/2018 5:01 AM, Dan Carpenter wrote: This has an '&' vs '|' typo so it starts with vlan_features set to none. Also a u32 type isn't large enough to hold all the feature bits, it should be netdev_features_t. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: Dan Car

Re: [PATCH 2/2 net-next] net_failover: fix error code in net_failover_create()

2018-05-31 Thread Samudrala, Sridhar
On 5/31/2018 5:04 AM, Dan Carpenter wrote: We forgot to set the error code on this path. This function is supposed to return error pointers, so with this bug it accidentally returns NULL and the caller doesn't check for that. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-30 Thread Samudrala, Sridhar
On 5/30/2018 3:53 PM, Jakub Kicinski wrote: On Wed, 30 May 2018 14:23:06 -0700, Samudrala, Sridhar wrote: On 5/29/2018 11:33 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 23:08:11 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 20:19:54

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-30 Thread Samudrala, Sridhar
On 5/29/2018 11:33 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 23:08:11 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 10:56 PM, Jakub Kicinski wrote: On Tue, 29 May 2018 20:19:54 -0700, Michael Chan wrote: On Tue, May 29, 2018 at 1:46 PM, Samudrala, Sridhar wrote: Isn't ndo_set_v

Re: [PATCH net-next 1/3] net: Add support to configure SR-IOV VF minimum and maximum queues.

2018-05-29 Thread Samudrala, Sridhar
On 5/29/2018 1:18 AM, Michael Chan wrote: VF Queue resources are always limited and there is currently no infrastructure to allow the admin. on the host to add or reduce queue resources for any particular VF. With ever increasing number of VFs being supported, it is desirable to allow the admin.

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-26 Thread Samudrala, Sridhar
'On 5/26/2018 12:51 AM, Jiri Pirko wrote: Sat, May 26, 2018 at 09:22:18AM CEST, sridhar.samudr...@intel.com wrote: On 5/25/2018 4:28 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" wrote: On 5/25/2018 3:34 PM, Stephen Hemminger wrote:

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-26 Thread Samudrala, Sridhar
On 5/25/2018 4:28 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" wrote: On 5/25/2018 3:34 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hype

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-25 Thread Samudrala, Sridhar
On 5/25/2018 3:34 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hyperv/Kconfig @@ -2,5 +2,6 @@ config HYPERV_NET tristate "Microsoft Hyper-V virtual network driver" depends on HYPERV

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

2018-05-25 Thread Samudrala, Sridhar
On 5/25/2018 3:38 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 03ed492c4e14..0f4ba52b641d 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1421,6 +142

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-24 Thread Samudrala, Sridhar
On 5/24/2018 10:04 AM, Or Gerlitz wrote: On Thu, May 24, 2018 at 5:22 AM, Jakub Kicinski wrote: Hi! This series from John adds bond offload to the nfp driver. Patch 5 exposes the hash type for NETDEV_LAG_TX_TYPE_HASH to make sure nfp hashing matches that of the software LAG. This may be unn

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-23 Thread Samudrala, Sridhar
On 5/22/2018 11:27 PM, Jiri Pirko wrote: Tue, May 22, 2018 at 10:54:29PM CEST, sridhar.samudr...@intel.com wrote: On 5/22/2018 9:12 AM, Jiri Pirko wrote: Fixing the subj, sorry about that. Tue, May 22, 2018 at 05:46:21PM CEST, m...@redhat.com wrote: On Tue, May 22, 2018 at 05:36:14PM +0200,

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Samudrala, Sridhar
On 5/22/2018 9:12 AM, Jiri Pirko wrote: Fixing the subj, sorry about that. Tue, May 22, 2018 at 05:46:21PM CEST, m...@redhat.com wrote: On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudr...@intel.com wrote: On 5/22/2018 2:08 AM,

Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-22 Thread Samudrala, Sridhar
On 5/22/2018 2:08 AM, Jiri Pirko wrote: Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar S

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-11 Thread Samudrala, Sridhar
On 5/7/2018 3:39 PM, Randy Dunlap wrote: Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: Signed-off-by: Sridhar Samudrala --- MAINTAINERS|7 + include/linux/netdevice.h | 16 + include/net/net_failover.h | 52 +++ net/Kconfig| 10 + net/cor

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-11 Thread Samudrala, Sridhar
On 5/7/2018 4:46 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapat

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Samudrala, Sridhar
On 5/7/2018 4:53 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: +static struct net_device *net_failover_get_bymac(u8 *mac, +struct net_failover_ops **ops) +{ + struct net_device *failover_dev; +

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

2018-05-07 Thread Samudrala, Sridhar
On 5/7/2018 4:59 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: + if (netif_running(failover_dev)) { + err = dev_open(slave_dev); + if (err && (err != -EBUSY)) { + netdev_err(failover_dev, "Openin

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

2018-05-02 Thread Samudrala, Sridhar
On 5/2/2018 1:30 PM, Michael S. Tsirkin wrote: On Wed, May 02, 2018 at 10:51:12AM -0700, Samudrala, Sridhar wrote: On 5/2/2018 9:15 AM, Jiri Pirko wrote: Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

2018-05-02 Thread Samudrala, Sridhar
On 5/2/2018 9:15 AM, Jiri Pirko wrote: Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: [...] + + err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, +

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-05-02 Thread Samudrala, Sridhar
On 5/2/2018 12:50 AM, Jiri Pirko wrote: Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not supp

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-05-01 Thread Samudrala, Sridhar
On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not supported That I did expect to work. I would expect this would change the mac of the master and both standby and pri

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-30 Thread Samudrala, Sridhar
On 4/30/2018 12:12 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 05:00:33AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when

Re: [PATCH net-next v9 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

2018-04-30 Thread Samudrala, Sridhar
On 4/30/2018 12:03 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 04:47:03AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 12:50 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:57PM CEST,sridhar.samudr...@intel.com wrote: This feature bit can be used by hypervisor to indicate virtio_net

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

2018-04-29 Thread Samudrala, Sridhar
On 4/28/2018 2:06 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their da

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-29 Thread Samudrala, Sridhar
On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF withou

Re: [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-27 Thread Samudrala, Sridhar
On 4/27/2018 10:45 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:56PM CEST, sridhar.samudr...@intel.com wrote: v9: Select NET_FAILOVER automatically when VIRTIO_NET/HYPERV_NET are enabled. (stephen) Tested live migration with virtio-net/AVF(i40evf) configured in failover mode while running i

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-26 Thread Samudrala, Sridhar
On 4/26/2018 5:09 PM, Michael S. Tsirkin wrote: On Thu, Apr 26, 2018 at 03:33:26PM -0700, Stephen Hemminger wrote: On Thu, 26 Apr 2018 05:30:05 +0300 "Michael S. Tsirkin" wrote: On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: On Wed, 25 Apr 2018 16:59:28 -0700 Sridhar Sam

Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

2018-04-23 Thread Samudrala, Sridhar
On 4/22/2018 10:06 AM, Michael S. Tsirkin wrote: On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: +#if IS_ENABLED(CONFIG_NET_FAILOVER) + +int failover_create(struct net_device *standby_dev, + struct failover **pfailover); Should we rename all these structs ne

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-20 Thread Samudrala, Sridhar
On 4/20/2018 8:28 AM, Stephen Hemminger wrote: On Thu, 19 Apr 2018 18:42:04 -0700 Sridhar Samudrala wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala Do what you want to other devices but leave netvsc alon

Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

2018-04-20 Thread Samudrala, Sridhar
On 4/19/2018 7:44 PM, Michael S. Tsirkin wrote: On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 10:07 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of al

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-18 Thread Samudrala, Sridhar
On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as illustrated in the reply below, cloud service providers require transparent live migration. Specifically, the main targe

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 1:32 PM, Jiri Pirko wrote: You still use "active"/"backup" names which is highly misleading as it has completely different meaning that in bond for example. I noted that in my previous review already. Please change it. I guess the issue is with only the 'active'  name. 'backup' shou

Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 2:25 AM, Jiri Pirko wrote: Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-18 Thread Samudrala, Sridhar
On 4/18/2018 6:51 AM, Willem de Bruijn wrote: On Wed, Apr 18, 2018 at 9:47 AM, Sowmini Varadhan wrote: On (04/18/18 06:35), Eric Dumazet wrote: There is no change at all. This will only be used as a mechanism to send X packets of same size. So instead of X system calls , one system call. On

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-17 Thread Samudrala, Sridhar
On 4/17/2018 2:07 PM, Willem de Bruijn wrote: On Tue, Apr 17, 2018 at 4:48 PM, Sowmini Varadhan wrote: On (04/17/18 16:23), Willem de Bruijn wrote: Assuming IPv4 with an MTU of 1500 and the maximum segment size of 1472, the receiver will see three datagrams with MSS of 1472B, 528B and 512B.

Re: SRIOV switchdev mode BoF minutes

2018-04-17 Thread Samudrala, Sridhar
On 4/17/2018 7:47 AM, Andy Gospodarek wrote: On Tue, Apr 17, 2018 at 04:58:05PM +0300, Or Gerlitz wrote: On Tue, Apr 17, 2018 at 4:30 PM, Andy Gospodarek wrote: On Mon, Apr 16, 2018 at 07:08:39PM -0700, Samudrala, Sridhar wrote: On 4/16/2018 5:39 AM, Andy Gospodarek wrote: On Sun, Apr 15

  1   2   >