Re: drivers/net/chelsio/sge.c: two array overflows

2006-03-17 Thread Scott Bardone
: The Coverity checker spotted the following two array overflows in drivers/net/chelsio/sge.c (in both cases, the arrays contain 3 elements): Am Freitag, 17. März 2006 01:21 schrieb Jeff Garzik: Scott Bardone wrote: Adrian, This is a bug. The array should contain 2 elements. Attached

Re: drivers/net/chelsio/sge.c: two array overflows

2006-03-14 Thread Scott Bardone
I had meant to say the array contains 3 elements but should only access index 2. Sorry for the confusion. -Scott Ingo Oeser wrote: Hi Scott, You wrote: This is a bug. The array should contain 2 elements. Sure? It either contains 3 elements or your patch is not fixing the issue. Please

Re: drivers/net/chelsio/sge.c: two array overflows

2006-03-13 Thread Scott Bardone
Adrian, This is a bug. The array should contain 2 elements. Attached is a patch which fixes it. Thanks. Signed-off-by: Scott Bardone [EMAIL PROTECTED] Adrian Bunk wrote: The Coverity checker spotted the following two array overflows in drivers/net/chelsio/sge.c (in both cases, the arrays

Re: [RFC: 2.6 patch] chelsio/espi.c:tricn_init(): remove dead code

2006-03-09 Thread Scott Bardone
This patch is correct, these two variables are unused in this driver. Thanks for catching this! Signed-off-by: Scott Bardone [EMAIL PROTECTED] Adrian Bunk wrote: The Coverity checker spotted these two unused variables. Please check whether this patch is correct or whether they should

[PATCH] TCP Offload (TOE) - Chelsio

2005-08-12 Thread Scott Bardone
'. - use RCU, need to look at this. - use inline function instead of TOEDEV macro, requires some work. Comments: - static was removed from functions '__tcp_inherit_port' '__tcp_v4_hash' because these are called outside of tcp_ipv4.c from the TOM driver. Signed-off-by: Scott Bardone [EMAIL PROTECTED

[ANNOUNCE] Chelsio 10Gb TOE (TCP Offload Engine)

2005-08-02 Thread Scott Bardone
Chelsio Communications would like to announce the availability of its TCP offload (TOE) support for Linux under the GPL. This is code developed by us over the past couple of years and has been in production for over a year. The code, architecture description, and some papers comparing TOE