Re: [PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy

2020-07-20 Thread Sekhar Nori
Hi Santosh, On 7/15/20 2:24 PM, Grygorii Strashko wrote: > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. > > The above board have phy-mode = "rgmii-id" and it is worked before because > KSZ9031 PHY st

Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers

2019-02-18 Thread Sekhar Nori
Hi Vinod, On 19/02/19 10:32 AM, Vinod Koul wrote: > Hello Dave, > > On 18-02-19, 16:28, David Miller wrote: >> From: Vinod Koul >> Date: Mon, 18 Feb 2019 15:48:52 +0530 >> >>> Some helpers were inlined, but makes more sense to allow compiler >>> to do the right optiomazations instead, so remove

Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

2019-01-11 Thread Sekhar Nori
Sekhar to Cc, maybe he has some contacts to ask. I dont have any direct contacts, but I will ask internally. > >> If the feedback takes time it may be better to apply the soft reset as >> fix and replace it later in case we have a less intrusive option. > > Yes please let's fix the regression first and then patch > more later as needed. +1 I justed tested AM437x GP EVM with 10 times cable plug-unplug and this fixes the regression. Tested-by: Sekhar Nori Thanks, Sekhar

Re: Regression in v4.20 with net phy soft reset changes

2019-01-10 Thread Sekhar Nori
Hi Tony, On 10/01/19 3:06 AM, Tony Lindgren wrote: > Hi, > > * Heiner Kallweit [190109 19:28]: >> On 09.01.2019 20:06, Tony Lindgren wrote: >>> Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused >>> a regression where suspend resume cycle fails to bring up Ethernet on at >>>

Re: [PATCH v2 00/25] at24: remove

2018-12-06 Thread Sekhar Nori
On 13/11/18 7:31 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Now that nvmem has gained support for defining cells from board files and > looking them up from relevant drivers[1], it's time for a respin of the > previous series[2] that aims at removing struct at24_platform_data

Re: [PATCH v2 net-next] drivers: net: davinci_mdio: prevent spurious timeout

2018-05-09 Thread Sekhar Nori
On Wednesday 09 May 2018 07:00 PM, Andrew Lunn wrote: > On Wed, May 09, 2018 at 04:30:24PM +0530, Sekhar Nori wrote: >> A well timed kernel preemption in the time_after() loop >> in wait_for_idle() can result in a spurious timeout >> error to be returned. >> >> F

[PATCH v3 next-next] drivers: net: davinci_mdio: prevent spurious timeout

2018-05-09 Thread Sekhar Nori
A well timed kernel preemption in the time_after() loop in wait_for_idle() can result in a spurious timeout error to be returned. Fix it by using readl_poll_timeout() which takes care of this issue. Reviewed-by: Andrew Lunn Signed-off-by: Sekhar Nori --- v3: simplify return path based on

[PATCH v2 net-next] drivers: net: davinci_mdio: prevent spurious timeout

2018-05-09 Thread Sekhar Nori
A well timed kernel preemption in the time_after() loop in wait_for_idle() can result in a spurious timeout error to be returned. Fix it by using readl_poll_timeout() which takes care of this issue. Signed-off-by: Sekhar Nori --- v2: use readl_poll_timeout() per suggestion from Andrew. The

Re: [PATCH net-next] drivers: net: davinci_mdio: prevent sprious timeout

2018-05-09 Thread Sekhar Nori
On Tuesday 08 May 2018 06:18 PM, Andrew Lunn wrote: > On Tue, May 08, 2018 at 01:56:38PM +0530, Sekhar Nori wrote: >> A well timed kernel preemption in the time_after() loop >> in wait_for_idle() can result in a spurious timeout >> error to be returned. >> >>

[PATCH net-next] drivers: net: davinci_mdio: prevent sprious timeout

2018-05-08 Thread Sekhar Nori
A well timed kernel preemption in the time_after() loop in wait_for_idle() can result in a spurious timeout error to be returned. Fix it by checking for status of hardware before returning timeout error. Signed-off-by: Sekhar Nori --- The issue has not been personally observed by me, but has

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-20 Thread Sekhar Nori
On Thursday 19 October 2017 08:25 PM, Marc Kleine-Budde wrote: > On 10/19/2017 03:54 PM, Franklin S Cooper Jr wrote: >> On 10/19/2017 06:32 AM, Marc Kleine-Budde wrote: >>> On 10/19/2017 01:09 PM, Sekhar Nori wrote: >>>> On Thursday 19 October 2017 02:43 PM, Marc Klei

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-19 Thread Sekhar Nori
On Thursday 19 October 2017 02:43 PM, Marc Kleine-Budde wrote: > On 10/19/2017 07:07 AM, Sekhar Nori wrote: >>>>> Sounds reasonable. What's the status of this series? >>>> >>>> I have had some offline discussions with Franklin on this, and I am no

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Sekhar Nori
On Wednesday 18 October 2017 07:47 PM, Franklin S Cooper Jr wrote: > > > On 10/18/2017 08:24 AM, Sekhar Nori wrote: >> Hi Marc, >> >> On Wednesday 18 October 2017 06:14 PM, Marc Kleine-Budde wrote: >>> On 09/21/2017 02:48 AM, Franklin S Cooper Jr wrote: &

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-10-18 Thread Sekhar Nori
>>>> Hi Wenyou, >>>> >>>> On 09/17/2017 10:47 PM, Yang, Wenyou wrote: >>>>> >>>>> On 2017/9/14 13:06, Sekhar Nori wrote: >>>>>> On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: >>>>>>

Re: [v2,1/3] can: m_can: Make hclk optional

2017-09-21 Thread Sekhar Nori
On Thursday 21 September 2017 06:01 AM, Franklin S Cooper Jr wrote: > > > On 08/24/2017 03:00 AM, Sekhar Nori wrote: >> + some OMAP folks and Linux OMAP list >> >> On Tuesday 25 July 2017 04:21 AM, Franklin Cooper wrote: >>> Hclk is the MCAN's interfa

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-13 Thread Sekhar Nori
On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: > > > On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: >> During test transmitting using CAN-FD at high bitrates (4 Mbps) only >> resulted in errors. Scoping the signals I noticed that only a single bit >> was being transmitt

Re: Fwd: DA850-evm MAC Address is random

2017-09-07 Thread Sekhar Nori
On Thursday 07 September 2017 03:11 AM, Adam Ford wrote: > On Mon, Sep 4, 2017 at 11:42 PM, Sekhar Nori wrote: >> Hi Adam, >> >> On Wednesday 30 August 2017 11:08 AM, Sekhar Nori wrote: >>>> I wonder if U-Boot isn't pushing something to Linux because it doe

Re: Fwd: DA850-evm MAC Address is random

2017-09-04 Thread Sekhar Nori
Hi Adam, On Wednesday 30 August 2017 11:08 AM, Sekhar Nori wrote: >> I wonder if U-Boot isn't pushing something to Linux because it doesn't >> appear to be running some of the da850 specific code even when I run >> linux-next. Can you tell me what verision of U-Boot

[PATCH] net: ti: cpsw-common: dont print error if ti_cm_get_macid() fails

2017-08-30 Thread Sekhar Nori
severity of message to "information", so it does not spam logs when 'quiet' boot is desired. Signed-off-by: Sekhar Nori --- drivers/net/ethernet/ti/cpsw-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/

Re: Fwd: DA850-evm MAC Address is random

2017-08-29 Thread Sekhar Nori
On Wednesday 30 August 2017 06:19 AM, Adam Ford wrote: > On Tue, Aug 29, 2017 at 10:20 AM, Adam Ford wrote: >> On Tue, Aug 29, 2017 at 10:16 AM, Sekhar Nori wrote: >>> On Tuesday 29 August 2017 05:32 PM, Adam Ford wrote: >>>> On Tue, Aug 29, 2017 at 6:42 AM, Sekhar

Re: Fwd: DA850-evm MAC Address is random

2017-08-29 Thread Sekhar Nori
On Tuesday 29 August 2017 05:32 PM, Adam Ford wrote: > On Tue, Aug 29, 2017 at 6:42 AM, Sekhar Nori wrote: >> On Tuesday 29 August 2017 03:53 PM, Adam Ford wrote: >>> On Tue, Aug 29, 2017 at 3:23 AM, Sekhar Nori wrote: >>>> On Tuesday 29 August 2017 02:42 AM, Ton

Re: Fwd: DA850-evm MAC Address is random

2017-08-29 Thread Sekhar Nori
On Tuesday 29 August 2017 03:53 PM, Adam Ford wrote: > On Tue, Aug 29, 2017 at 3:23 AM, Sekhar Nori wrote: >> On Tuesday 29 August 2017 02:42 AM, Tony Lindgren wrote: >>> * Adam Ford [170828 13:33]: >>>> On Mon, Aug 28, 2017 at 1:54 PM, Grygorii Strashko

Re: Fwd: DA850-evm MAC Address is random

2017-08-29 Thread Sekhar Nori
On Tuesday 29 August 2017 02:42 AM, Tony Lindgren wrote: > * Adam Ford [170828 13:33]: >> On Mon, Aug 28, 2017 at 1:54 PM, Grygorii Strashko >> wrote: >>> Cc: Sekhar >>> >>> On 08/28/2017 10:32 AM, Adam Ford wrote: The davinvi_emac MAC address seems to attempt a call to ti_cm_get_m

Re: [v2,3/3] can: m_can: Add PM Runtime

2017-08-24 Thread Sekhar Nori
+ OMAP mailing list On Tuesday 25 July 2017 04:21 AM, Franklin Cooper wrote: > Add support for PM Runtime which is the new way to handle managing clocks. > However, to avoid breaking SoCs not using PM_RUNTIME leave the old clk > management approach in place. Since hclk is the interface clock, I t

Re: [v2,1/3] can: m_can: Make hclk optional

2017-08-24 Thread Sekhar Nori
+ some OMAP folks and Linux OMAP list On Tuesday 25 July 2017 04:21 AM, Franklin Cooper wrote: > Hclk is the MCAN's interface clock. However, for OMAP based devices such as > DRA7 SoC family the interface clock is handled by hwmod. Therefore, this > interface clock is managed by hwmod driver via p

Re: [PATCH 0/2] net: phy: dp83867: workaround incorrect RX_CTRL pin strap

2017-07-04 Thread Sekhar Nori
Hi Andrew, On Tuesday 04 July 2017 08:17 PM, Andrew Lunn wrote: > On Tue, Jul 04, 2017 at 04:23:22PM +0530, Sekhar Nori wrote: >> Hi, >> >> This patch series adds workaround for incorrect RX_CTRL pin strap >> setting that can be found on some TI boards. > > H

[PATCH 2/2] net: phy: dp83867: add workaround for incorrect RX_CTRL pin strap

2017-07-04 Thread Sekhar Nori
-off-by: Murali Karicheri [nsek...@ti.com: rebase to mainline, code simplification] Signed-off-by: Sekhar Nori --- drivers/net/phy/dp83867.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index b57f20e552ba..c1ab976cc800

[PATCH 1/2] dt-bindings: phy: dp83867: provide a workaround for incorrect RX_CTRL pin strap

2017-07-04 Thread Sekhar Nori
/lit/ds/snls484e/snls484e.pdf Signed-off-by: Murali Karicheri [nsek...@ti.com: rebase to mainline, split documentation into separate patch] Signed-off-by: Sekhar Nori --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation

[PATCH 0/2] net: phy: dp83867: workaround incorrect RX_CTRL pin strap

2017-07-04 Thread Sekhar Nori
Hi, This patch series adds workaround for incorrect RX_CTRL pin strap setting that can be found on some TI boards. This is required to be complaint to PHY datamanual specification. Murali Karicheri (2): dt-bindings: phy: dp83867: provide a workaround for incorrect RX_CTRL pin strap net:

[PATCH] MAINTAINERS: update entry for TI's CPSW driver

2017-04-19 Thread Sekhar Nori
er is actually misleading since get_maintainer.pl script stops suggesting that Dave Miller be copied. Signed-off-by: Sekhar Nori --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 860dacbb5be3..c6d89f004e25 100644 --- a/MAINTAINERS +++ b/MAINTA

[PATCH] net: ethernet: ti: cpsw: fix race condition during open()

2017-04-03 Thread Sekhar Nori
of {of_}phy_connect() and do a one-time write to slave->phy. Reviewed-by: Grygorii Strashko Reported-by: Yan Liu Signed-off-by: Sekhar Nori --- drivers/net/ethernet/ti/cpsw.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/

Re: [PATCH 2/2] ARM: dts: am335x-icev2: Add CPSW ethernet0 and ethernet1

2017-03-13 Thread Sekhar Nori
On Tuesday 14 March 2017 12:54 AM, Grygorii Strashko wrote: > > > On 03/13/2017 08:42 AM, Roger Quadros wrote: >> Enable the 2 ethernet ports as CPSW ports in dual-mac mode >> >> Signed-off-by: Roger Quadros >> [nsek...@ti.com: use AM33XX_IOPAD()] >> Sign

Re: next-20170110 build: 1 failures 4 warnings (next-20170110)

2017-01-11 Thread Sekhar Nori
On Wednesday 11 January 2017 01:51 AM, Stephen Rothwell wrote: > Hi Mark, > > On Tue, 10 Jan 2017 18:16:07 + Mark Brown wrote: >> >> On Tue, Jan 10, 2017 at 07:21:32AM +, Build bot for Mark Brown wrote: >> >> Today's -next fails to build an arm allmodconfig due to: >> >>> arm-allmodco

Re: [net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control

2016-07-20 Thread Sekhar Nori
Nishanth, On Wednesday 20 July 2016 09:03 PM, Nishanth Menon wrote: > On 07/20/2016 09:56 AM, Mugunthan V N wrote: >> Add documention of ti,impedance-control which can be used to >> correct MAC impedance mismatch using phy extended registers. >> >> Signed-off-by: Mugunthan V N >> --- >> Documen

Re: [net-next PATCH 1/3] drivers: net: cpsw: add am335x errata workarround for interrutps

2015-08-24 Thread Sekhar Nori
Hi Mugunthan, On Wednesday 12 August 2015 03:22 PM, Mugunthan V N wrote: > +static const struct of_device_id cpsw_of_mtable[] = { > + { .compatible = "ti,cpsw", .data = &cpsw_devtype[CPSW], }, > + { .compatible = "ti,am335x-cpsw", .data = &cpsw_devtype[AM335X_CPSW], }, > + { .compatib