On Sat, Dec 02, 2017 at 12:06:12PM +0100, Sean Nyekjær wrote:
> Hi
>
> >> I'm not sure at all, but could you try to apply
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d63785c6b94b5d2f095f90755825f90eea791f5
> >> and see if the problem is resolved ?>
> > I wil
On Mon, Nov 13, 2017 at 11:54:14PM +0900, David Miller wrote:
> From: Simon Guinot
> Date: Mon, 13 Nov 2017 15:51:15 +0100
>
> > IIUC the driver stops the queue if a threshold of 316 Tx descriptors is
> > reached (default and worst value).
>
> That's a lot of
descriptors.
Fixes: 2a90f7e1d5d0 ("net: mvneta: add xmit_more support")
Cc: sta...@vger.kernel.org # 4.11+
Signed-off-by: Simon Guinot
---
drivers/net/ethernet/marvell/mvneta.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
Changes for v2:
- Use do {} while instea
On Sat, Nov 11, 2017 at 06:45:04PM +0900, David Miller wrote:
> From: Simon Guinot
> Date: Wed, 8 Nov 2017 17:58:35 +0100
>
> > @@ -2413,8 +2416,7 @@ static int mvneta_tx(struct sk_buff *skb, struct
> > net_device *dev)
> > if (txq->c
Hi Sven and Andreas,
Please, can you try with this patch ?
Thanks.
Simon
On Wed, Nov 08, 2017 at 05:58:35PM +0100, Simon Guinot wrote:
> The mvneta controller provides a 8-bit register to update the pending
> Tx descriptor counter. Then, a maximum of 255 Tx descriptors can be
> adde
descriptors.
Fixes: 2a90f7e1d5d0 ("net: mvneta: add xmit_more support")
Cc: sta...@vger.kernel.org # 4.11+
Signed-off-by: Simon Guinot
---
drivers/net/ethernet/marvell/mvneta.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/marvell/m
On Tue, Oct 31, 2017 at 03:27:40PM +0100, Thomas Petazzoni wrote:
> Hello,
Hi Thomas,
>
> Let's add Simon Guinot in the loop.
>
> On Tue, 31 Oct 2017 15:23:22 +0100, Sven Müller wrote:
> > After quite a long time of trying to reproduce the issue without any
> >
On Fri, Nov 18, 2016 at 12:20:07PM +0100, Simon Guinot wrote:
> On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote:
> > On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote:
> > > On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote:
> > > >
On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote:
> On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote:
> > On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote:
> > > On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote:
> > > > Hi Amir,
>
On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote:
> On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote:
> > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote:
> > > This driver enables Thunderbolt Networking on non-Apple platforms
> > > running Lin
191 ("net: mvneta: fix refilling for Rx DMA buffers")
> ---
> drivers/net/ethernet/marvell/mvneta.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Acked-by: Simon Guinot
Thanks,
Simon
> diff --git a/drivers/net/ethernet/marvell/mvneta.c
> b/drive
ith small
> latency.
>
> Along with existing tx_done processing by coalescing interrupts this
> commit enables triggering HR timer each time the packets are sent.
> Time threshold can also be configured, using ethtool.
>
> Signed-off-by: Marcin Wojtas
> Signed-off-by: S
fixes the issue by ensuring that the right Rx buffers are
DMA-unmapped.
Reported-by: Oren Laskin
Signed-off-by: Simon Guinot
Fixes: a84e32894191 ("net: mvneta: fix refilling for Rx DMA buffers")
Cc: # v3.8+
---
drivers/net/ethernet/marvell/mvneta.c | 4 +++-
1 file changed, 3 inser
ize for the inconvenience.
Anyway, I am about to send a patch fixing the issue. Please, can you
test it ?
Thanks in advance,
Simon
> On Tue, Jul 21, 2015 at 12:30 AM, David Miller wrote:
>
> > From: Simon Guinot
> > Date: Sun, 19 Jul 2015 13:00:53 +0200
> >
> > >
d replicated the problem with wget and found it.
>
> Oren
>
> On Mon, Sep 14, 2015 at 3:13 PM, Simon Guinot
> wrote:
> > Hi Oren,
> >
> > On Mon, Sep 14, 2015 at 01:22:12PM -0700, Oren Laskin wrote:
> >> I had to undo this change on my Amada 370 based board. I
ave to
wget the same file (size 30MB) in a loop and to check its md5sum ?
That's it ? And how long should I wait for the error ?
Thanks,
Simon
>
> Thanks,
>
> Oren
>
> On Tue, Jul 21, 2015 at 12:30 AM, David Miller wrote:
>
> > From: Simon Guinot
> &
of building
SKB with the associated Rx buffer. In case of a memory allocation
failure, data is dropped and the original DMA buffer is put back into
the Rx ring.
Signed-off-by: Simon Guinot
Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
unit")
Cc: # v3.8+
On Wed, Jul 15, 2015 at 03:52:56PM -0700, David Miller wrote:
> From: Simon Guinot
> Date: Mon, 13 Jul 2015 00:04:57 +0200
>
> > On some Armada 370-based NAS, I have experimented kernel bugs and
> > crashes when the mvneta Ethernet driver fails to refill Rx DMA buffers
>
controller. Moreover note that there is no
point in using different values for this counters because both the
mvneta driver and the Ethernet controller are unable to handle holes in
the Rx descriptors queues.
Signed-off-by: Simon Guinot
Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 3
This patch updates the Ethernet DT nodes for Armada XP SoCs with the
compatible string "marvell,armada-xp-neta".
Signed-off-by: Simon Guinot
Fixes: 77916519cba3 ("arm: mvebu: Armada XP MV78230 has only three Ethernet
interfaces")
Cc: # v3.8+
Acked-by: Gregory CLEMENT
--
value greater than 1600 bytes.
Signed-off-by: Simon Guinot
Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
unit")
Cc: # v3.8+
---
drivers/net/ethernet/marvell/mvneta.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff
to each commits.
Changes since v3:
- Fix patch 3 name: replace prefix "ARM: mvebu:" with "net: mvneta:".
Regards,
Simon
Simon Guinot (3):
net: mvneta: introduce compatible string "marvell,armada-xp-neta"
ARM: mvebu: update Ethernet compatible string for Armada XP
ned-off-by: Simon Guinot
Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
unit")
Cc: # v3.8+
Acked-by: Gregory CLEMENT
---
Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 2 +-
drivers/net/ethernet/marvell/mvneta.c
to each commits.
Regards,
Simon
Simon Guinot (3):
net: mvneta: introduce compatible string "marvell,armada-xp-neta"
ARM: mvebu: update Ethernet compatible string for Armada XP
ARM: mvebu: disable IP checksum with jumbo frames for Armada 370
.../bindings/net/marvell-armada-370-neta.tx
value greater than 1600 bytes.
Signed-off-by: Simon Guinot
Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
unit")
Cc: # v3.8+
---
drivers/net/ethernet/marvell/mvneta.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff
This patch updates the Ethernet DT nodes for Armada XP SoCs with the
compatible string "marvell,armada-xp-neta".
Signed-off-by: Simon Guinot
Fixes: 77916519cba3 ("arm: mvebu: Armada XP MV78230 has only three Ethernet
interfaces")
Cc: # v3.8+
Acked-by: Gregory CLEMENT
--
ned-off-by: Simon Guinot
Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network
unit")
Cc: # v3.8+
Acked-by: Gregory CLEMENT
---
Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 2 +-
drivers/net/ethernet/marvell/mvneta.c
On Fri, Jun 19, 2015 at 02:32:53PM +0200, Simon Guinot wrote:
> On Wed, Jun 17, 2015 at 05:01:12PM +, Jason Cooper wrote:
> > Hi Gregory,
> >
> > On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory CLEMENT wrote:
> > > On 17/06/2015 17:12, Gregory CLEMENT wrot
On Wed, Jun 17, 2015 at 05:01:12PM +, Jason Cooper wrote:
> Hi Gregory,
>
> On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory CLEMENT wrote:
> > On 17/06/2015 17:12, Gregory CLEMENT wrote:
> > > On 17/06/2015 15:19, Simon Guinot wrote:
> > >> The mvneta d
On Wed, Jun 17, 2015 at 05:24:58PM +0200, Thomas Petazzoni wrote:
> Dear Simon Guinot,
>
> On Wed, 17 Jun 2015 15:19:19 +0200, Simon Guinot wrote:
>
> > This patch series fixes the Ethernet jumbo frames support for the SoCs
> > Armada 370, 380 and 385. Unlike Armada XP,
This patch updates the Ethernet DT nodes for Armada XP SoCs with the
compatible string "marvell,armada-xp-neta".
Signed-off-by: Simon Guinot
Cc: # v3.8+
---
arch/arm/boot/dts/armada-370-xp.dtsi | 2 --
arch/arm/boot/dts/armada-370.dtsi| 8
arch/arm/boot/dts
8 and onwards.
Changes since v1:
- Use a new compatible string for the Ethernet IP found in Armada XP
SoCs (instead of using an optional property).
- Fix the issue for the Armada 380 and 385 SoCs as well.
Regards,
Simon
Simon Guinot (3):
net: mvneta: introduce compatible string "marvell
value greater than 1600 bytes.
Signed-off-by: Simon Guinot
Cc: # v3.8+
---
drivers/net/ethernet/marvell/mvneta.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet/marvell/mvneta.c
ned-off-by: Simon Guinot
Cc: # v3.8+
---
Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 2 +-
drivers/net/ethernet/marvell/mvneta.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/marvell-
On Mon, Jun 15, 2015 at 04:49:52PM +0200, Thomas Petazzoni wrote:
> Dear Simon Guinot,
>
> On Mon, 15 Jun 2015 16:27:22 +0200, Simon Guinot wrote:
> > This patch introduces the tx_csum_limit DT property. This allows to
> > configure the maximum frame size for which the E
The Ethernet controller found in Armada 370 SoCs don't support TCP/IP
checksumming with frames largest than 1600 Bytes.
This patch sets accordingly the tx_csum_limit property in Ethernet nodes
for Armada 370.
Signed-off-by: Simon Guinot
Cc: # v3.8+
---
arch/arm/boot/dts/armada-370.dts
.
Signed-off-by: Simon Guinot
Cc: # v3.8+
---
.../bindings/net/marvell-armada-370-neta.txt | 3 +++
drivers/net/ethernet/marvell/mvneta.c | 25 +-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/marvell-armada
wards.
Regards,
Simon
Simon Guinot (2):
net: mvneta: introduce tx_csum_limit property
ARM: mvebu: disable IP checksum with jumbo frames for Armada 370
.../bindings/net/marvell-armada-370-neta.txt | 3 +++
arch/arm/boot/dts/armada-370.dtsi | 8 +++
drivers/net/ethernet/ma
38 matches
Mail list logo
