Re: [PATCH 7/8 net] bnxt_tc: update indirect block support

2020-05-19 Thread Sriharsha Basavapatna
On Wed, May 13, 2020 at 10:12 PM Pablo Neira Ayuso wrote: > > Register ndo callback via flow_indr_dev_register() and > flow_indr_dev_unregister(). > > Signed-off-by: Pablo Neira Ayuso > --- > drivers/net/ethernet/broadcom/bnxt/bnxt.h| 1 - > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 51

[PATCH net] be2net: VxLAN offload should be re-enabled when only 1 UDP port is left

2017-04-17 Thread Sriharsha Basavapatna
abled. Remove this restriction by tracking the ports added and re-enabling offload when ports get deleted and only 1 port is left. Signed-off-by: Sriharsha Basavapatna Reviewed-by: Sathya Perla --- drivers/net/ethernet/emulex/benet/be.h | 12 ++- drivers/net/ethernet/emulex/benet/be_main.c

Re: [PATCH net v2] be2net: fix initial MAC setting

2017-01-31 Thread Sriharsha Basavapatna
.. > > # ip link set eth8 up > be2net :01:04.0 eth8: Link is Up > > Initialization is now OK. > > v2 - Corrected the comment and condition check suggested by Suresh & Harsha > > Fixes: 34393529163a ("be2net: fix MAC addr setting on privileged BE3

Re: [PATCH net] be2net: fix initial MAC setting

2017-01-27 Thread Sriharsha Basavapatna
8: Link is Up > > Initialization is now OK. > > Fixes: 34393529163a ("be2net: fix MAC addr setting on privileged BE3 VFs") > Cc: Sathya Perla > Cc: Ajit Khaparde > Cc: Sriharsha Basavapatna > Cc: Somnath Kotur > Signed-off-by: Ivan Vecera > --- > dr

Re: [PATCH net] be2net: Increase skb headroom size to 256 bytes

2016-12-21 Thread Sriharsha Basavapatna
On Wed, Dec 21, 2016 at 1:00 AM, David Miller wrote: > > From: Suresh Reddy > Date: Tue, 20 Dec 2016 10:14:30 -0500 > > > From: Kalesh A P > > > > The driver currently allocates 128 bytes of skb headroom. > > This was found to be insufficient with some configurations > > like Geneve tunnels, whi

[PATCH net-next 5/5] be2net: Enable VF link state setting for BE3

2016-10-08 Thread Sriharsha Basavapatna
From: Suresh Reddy The VF link state setting feature now works on BE3 chips too from FW ver 11.1.192.0 onwards. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH net-next 1/5] be2net: Provide an alternate way to read pf_num for BEx chips

2016-10-08 Thread Sriharsha Basavapatna
field in the response of GET_CNTL_ATTRIBUTES command that can be read to get the same info for BEx adapters. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 5 + drivers/net/ethernet/emulex/benet/be_cmds.h | 6 +- 2 files changed, 10 insertions(

[PATCH net-next 0/5] be2net: patch-set

2016-10-08 Thread Sriharsha Basavapatna
-5 Enables VF link state setting for BE3 ** Sriharsha Basavapatna (4): be2net: Provide an alternate way to read pf_num for BEx chips be2net: NCSI FW section should be properly updated with ethtool for BE3 be2net: Update Copyright string in be_hw.h be2net: Fix TX stats for TSO

[PATCH net-next 2/5] be2net: NCSI FW section should be properly updated with ethtool for BE3

2016-10-08 Thread Sriharsha Basavapatna
. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c index 45d1742..7e9be9f4

[PATCH net-next 3/5] be2net: Update Copyright string in be_hw.h

2016-10-08 Thread Sriharsha Basavapatna
This patch updates the year and company name in the copyright string in be_hw.h. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_hw.h b/drivers/net

[PATCH net-next 4/5] be2net: Fix TX stats for TSO packets

2016-10-08 Thread Sriharsha Basavapatna
TX stats update does not take into account headers which get duplicated when the TSO packet is split into segments by HW. Fix this for both tunneled (vxlan) and non-tunneled TSO packets. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_main.c | 14 -- 1

[PATCH net-next 3/6] be2net: Add privilege level check for OPCODE_COMMON_GET_EXT_FAT_CAPABILITIES SLI cmd.

2016-09-07 Thread Sriharsha Basavapatna
po in CAPABILITIES. Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 13 +++-- drivers/net/ethernet/emulex/benet/be_cmds.h | 4 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/

[PATCH net-next 6/6] be2net: Update the driver version to 11.1.0.0

2016-09-07 Thread Sriharsha Basavapatna
Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h index 30a26aa..6cfa63a 100644 --- a/drivers/net/ethernet/emulex

[PATCH net-next 5/6] be2net: Fix mac address collision in some configurations

2016-09-07 Thread Sriharsha Basavapatna
-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 1 + drivers/net/ethernet/emulex/benet/be_main.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h index eecf24e..30a2

[PATCH net-next 2/6] be2net: Issue COMMON_RESET_FUNCTION cmd during driver unload

2016-09-07 Thread Sriharsha Basavapatna
l and assigned to a VM. Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 3b

[PATCH net-next 4/6] be2net: Avoid redundant addition of mac address in HW

2016-09-07 Thread Sriharsha Basavapatna
checking if the given mac address is present in uc_list while setting the device mac address and vice versa. Similarly skip deletion if the address is still in use in the other form. Signed-off-by: Suresh Reddy Signed-off-by: Sathya Perla Signed-off-by: Sriharsha Basavapatna --- drivers/net

[PATCH net-next 1/6] be2net: Support UE recovery in BEx/Skyhawk adapters

2016-09-07 Thread Sriharsha Basavapatna
the required delay. o With these changes, the existing error recovery code for Lancer also runs in the context of the new worker thread. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 68 ++- drivers/net/ethernet/emulex/benet/be_cmds.c| 53

[PATCH net-next 0/6] be2net: patch-set

2016-09-07 Thread Sriharsha Basavapatna
level check for OPCODE_COMMON_GET_EXT_FAT_CAPABILITIES SLI cmd. Sriharsha Basavapatna (2): be2net: Support UE recovery in BEx/Skyhawk adapters be2net: Update the driver version to 11.1.0.0 Suresh Reddy (2): be2net: Avoid redundant addition of mac address in HW be2net: Fix mac address

[PATCH v2 net-next 2/8] be2net: check for INSUFFICIENT_PRIVILEGES error

2016-02-02 Thread Sriharsha Basavapatna
s. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 3 ++- drivers/net/ethernet/emulex/benet/be_cmds.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/ne

[PATCH v2 net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs

2016-02-02 Thread Sriharsha Basavapatna
icient EQs, resulting in wasted queue resources. And the PF gets a smaller share of queues though it has more EQs. Fix this by capping the VF queue count at its EQ count. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 4 drivers/net/ethernet/emulex/benet/be_m

[PATCH v2 net-next 8/8] be2net: Fix interval calculation in interrupt moderation

2016-02-02 Thread Sriharsha Basavapatna
Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index d5286d3..9c1fc9d 100644 --- a/drivers/net

[PATCH v2 net-next 6/8] be2net: Fix Lancer error recovery

2016-02-02 Thread Sriharsha Basavapatna
: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_main.c | 51 +++-- 1 file changed, 34 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 62f6fbb..6eb3aba 100644 --- a

[PATCH v2 net-next 1/8] be2net: return error status from be_set_phys_id()

2016-02-02 Thread Sriharsha Basavapatna
From: Suresh Reddy be_set_phys_id() returns 0 to ethtool when the command fails in the FW. This patch fixes the set_phys_id() to return -EIO in case the FW cmd fails. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_ethtool.c | 23

[PATCH v2 net-next 7/8] be2net: Add retry in case of error recovery failure

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar Retry error recovery MAX_ERR_RECOVERY_RETRY_COUNT times in case of failure during error recovery. Signed-off-by: Padmanabh Ratnakar Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 5 + drivers/net/ethernet/emulex/benet

[PATCH v2 net-next 3/8] be2net: Fix be_vlan_rem_vid() to check vlan id being removed

2016-02-02 Thread Sriharsha Basavapatna
The driver decrements its vlan count without checking if it is really present in its list. This results in an invalid vlan count and impacts subsequent vlan add/rem ops. The function be_vlan_rem_vid() should be updated to fix this. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet

[PATCH v2 net-next 5/8] be2net: Don't run ethtool self-tests for VFs

2016-02-02 Thread Sriharsha Basavapatna
From: Somnath Kotur The CMD_SUBSYSTEM_LOWLEVEL cmds need DEV_CFG Privilege to run which VFs don't have by default. Self-tests need to be issued only for PFs. Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c

[PATCH v2 net-next 0/8] be2net patch-set

2016-02-02 Thread Sriharsha Basavapatna
ror recovery failure be2net: Fix interval calculation in interrupt moderation Somnath Kotur (1): be2net: Don't run ethtool self-tests for VFs Sriharsha Basavapatna (2): be2net: Fix be_vlan_rem_vid() to check vlan id being removed be2net: SRIOV Queue distribution should factor in EQ-

Re: [PATCH net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs

2016-02-02 Thread Sriharsha Basavapatna
On Tue, Feb 2, 2016 at 8:00 PM, Sergei Shtylyov wrote: > Hello. > > On 2/2/2016 1:20 PM, Sriharsha Basavapatna wrote: > >> The SRIOV resource distribution logic for RX/TX queue counts is not >> optimal >> when a small number of VFs are enabled. It does not take int

[PATCH net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs

2016-02-02 Thread Sriharsha Basavapatna
icient EQs, resulting in wasted queue resources. And the PF gets a smaller share of queues though it has more EQs. Fix this by capping the VF queue count at its EQ count. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 4 drivers/net/ethernet/emulex/benet/be_m

[PATCH net-next 0/8] be2net patch-set

2016-02-02 Thread Sriharsha Basavapatna
r VFs Sriharsha Basavapatna (2): be2net: Fix be_vlan_rem_vid() to check vlan id being removed be2net: SRIOV Queue distribution should factor in EQ-count of VFs Suresh Reddy (2): be2net: return error status from be_set_phys_id() be2net: check for INSUFFICIENT_PRIVILEGES error driver

[PATCH net-next 7/8] benet: Add retry in case of error recovery failure

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar Retry error recovery MAX_ERR_RECOVERY_RETRY_COUNT times in case of failure during error recovery. Signed-off-by: Padmanabh Ratnakar Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 5 + drivers/net/ethernet/emulex/benet

[PATCH net-next 5/8] be2net: Don't run ethtool self-tests for VFs

2016-02-02 Thread Sriharsha Basavapatna
From: Somnath Kotur The CMD_SUBSYSTEM_LOWLEVEL cmds need DEV_CFG Privilege to run which VFs don't have by default. Self-tests need to be issued only for PFs. Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c

[PATCH net-next 2/8] be2net: check for INSUFFICIENT_PRIVILEGES error

2016-02-02 Thread Sriharsha Basavapatna
s. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 3 ++- drivers/net/ethernet/emulex/benet/be_cmds.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/ne

[PATCH net-next 8/8] benet: Fix interval calculation in interrupt moderation

2016-02-02 Thread Sriharsha Basavapatna
Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index d5286d3..9c1fc9d 100644 --- a/drivers/net

[PATCH net-next 6/8] benet: Fix Lancer error recovery

2016-02-02 Thread Sriharsha Basavapatna
: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_main.c | 51 +++-- 1 file changed, 34 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 62f6fbb..6eb3aba 100644 --- a

[PATCH net-next 3/8] be2net: Fix be_vlan_rem_vid() to check vlan id being removed

2016-02-02 Thread Sriharsha Basavapatna
The driver decrements its vlan count without checking if it is really present in its list. This results in an invalid vlan count and impacts subsequent vlan add/rem ops. The function be_vlan_rem_vid() should be updated to fix this. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet

[PATCH net-next 1/8] be2net: return error status from be_set_phys_id()

2016-02-02 Thread Sriharsha Basavapatna
From: Suresh Reddy be_set_phys_id() returns 0 to ethtool when the command fails in the FW. This patch fixes the set_phys_id() to return -EIO in case the FW cmd fails. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_ethtool.c | 23

[PATCH net-next] be2net: Support vxlan offload stats in the driver

2015-07-29 Thread Sriharsha Basavapatna
This patch adds vxlan offload specific counters to ethtool stats. We provide tx/rx queue counters to show the number of vxlan offload pkts sent/received. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 2 ++ drivers/net/ethernet/emulex/benet

[PATCH net-next] be2net: support ndo_get_phys_port_id()

2015-07-21 Thread Sriharsha Basavapatna
From: Sriharsha Basavapatna Add be_get_phys_port_id() function to report physical port id. The port id should be unique across different be2net devices in the system. We use the chip serial number along with the physical port number for this. Signed-off-by: Sriharsha Basavapatna --- drivers

[PATCH net] be2net: Replace dma/pci_alloc_coherent() calls with dma_zalloc_coherent()

2015-06-05 Thread Sriharsha Basavapatna
backed by this memory. Reported-by: Joerg Roedel Tested-by: Joerg Roedel Signed-off-by: Sriharsha Basavapatna --- Hi Dave, This patch fixes a bug in be2net driver found by Joerg Roedel while testing his dma_alloc_coherent() changes on an AMD/IOMMU platform. The driver assumed memory returned by