[PATCH v3 iproute2-next 2/4] rdma: add helper rd_sendrecv_msg()

2019-04-03 Thread Steve Wise
This function sends the constructed netlink message and then receives the response. Change rd_recv_msg() to display any error messages. Change 'rdma dev set' to use rd_sendrecv_msg(). Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- rdma/dev.c | 2 +- rdma/rdma.h |

[PATCH v3 iproute2-next 1/4] Add .mailmap file

2019-04-03 Thread Steve Wise
.mailmap allows tracking multiple email addresses to the proper user name. Signed-off-by: Steve Wise Reviewed-by: Leon Romanovsky --- .mailmap | 8 1 file changed, 8 insertions(+) create mode 100644 .mailmap diff --git a/.mailmap b/.mailmap new file mode 100644 index

[PATCH v3 iproute2-next 0/4] Dynamic rdma link creation

2019-04-03 Thread Steve Wise
down the device index instead of the name, using the common rd services for validating the device name and fetching the index. Thanks, Steve. Steve Wise (4): Add .mailmap file rdma: add helper rd_sendrecv_msg() rdma: add 'link add/delete' commands rdma: man page update for l

[PATCH v3 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-04-03 Thread Steve Wise
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe netdev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise Reviewed-by: Leon Rom

[PATCH v3 iproute2-next 4/4] rdma: man page update for link add/delete

2019-04-03 Thread Steve Wise
Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 47 1 file changed, 47 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index bddf3474..b3b40

Re: [PATCH v2 iproute2-next 2/4] rdma: add helper rd_sendrecv_msg()

2019-04-03 Thread Steve Wise
On Sun, Mar 31, 2019 at 9:06 PM David Ahern wrote: > > On 3/26/19 1:18 PM, Steve Wise wrote: > > This function sends the constructed netlink message and then > > receives the response. > > > > Change rd_recv_msg() to display any error messages. > > > > Ch

Re: [PATCH v2 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-04-02 Thread Steve Wise
On Mon, Apr 1, 2019 at 1:37 AM Leon Romanovsky wrote: > > On Tue, Mar 26, 2019 at 02:18:29PM -0500, Steve Wise wrote: > > Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > > device to a netdev interface. > > >

[PATCH v2 iproute2-next 2/4] rdma: add helper rd_sendrecv_msg()

2019-03-26 Thread Steve Wise
This function sends the constructed netlink message and then receives the response. Change rd_recv_msg() to display any error messages. Change 'rdma dev set' to use rd_sendrecv_msg(). Signed-off-by: Steve Wise --- rdma/dev.c | 2 +- rdma/rdma.h | 2 ++ rdma/res.h | 1 + rd

[PATCH v2 iproute2-next 0/4] Dynamic rdma link creation

2019-03-26 Thread Steve Wise
evice, do avoid confused with the ib_device name. - got rid of the "type" parameter for link delete. Also pass down the device index instead of the name, using the common rd services for validating the device name and fetching the index. Thanks, Steve. Steve Wise

[PATCH v2 iproute2-next 1/4] Add .mailmap file

2019-03-26 Thread Steve Wise
.mailmap allows tracking multiple email addresses to the proper user name. Signed-off-by: Steve Wise --- .mailmap | 8 1 file changed, 8 insertions(+) create mode 100644 .mailmap diff --git a/.mailmap b/.mailmap new file mode 100644 index ..c012d3d0 --- /dev/null +++ b

[PATCH v2 iproute2-next 4/4] rdma: man page update for link add/delete

2019-03-26 Thread Steve Wise
Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 47 1 file changed, 47 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index bddf3474..b3b40

[PATCH v2 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-03-26 Thread Steve Wise
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe netdev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise --- rdma/link.c | 83

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-06 Thread Steve Wise
On 3/4/2019 8:13 AM, Steve Wise wrote: > Hey Leon, adding this to rd_recv_msg(): > > @@ -693,10 +693,28 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void > *data, unsigned int seq) > ret = mnl_cb_run(buf, ret, seq, portid, callback, data); >

RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-03-04 Thread Steve Wise
> > > > > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > > > >> This function sends the constructed netlink message and then > > > >> receives the response, displ

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-28 Thread Steve Wise
On 2/28/2019 1:56 PM, Leon Romanovsky wrote: > On Thu, Feb 28, 2019 at 01:41:20PM -0600, Steve Wise wrote: >> On 2/23/2019 3:26 AM, Leon Romanovsky wrote: >>> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >>>> This function sends the constr

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-28 Thread Steve Wise
On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >> This function sends the constructed netlink message and then >> receives the response, displaying any error text. >> >> Change 'rdma dev set' to us

RE: [PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-02-27 Thread Steve Wise
> -Original Message- > From: Steve Wise > Sent: Tuesday, February 26, 2019 11:25 AM > To: Leon Romanovsky > Cc: dsah...@gmail.com; step...@networkplumber.org; > netdev@vger.kernel.org; linux-r...@vger.kernel.org > Subject: Re: [PATCH v1 iproute2-next 3/4] rdma:

RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-27 Thread Steve Wise
> -Original Message- > From: Steve Wise > Sent: Tuesday, February 26, 2019 11:14 AM > To: Leon Romanovsky > Cc: dsah...@gmail.com; step...@networkplumber.org; > netdev@vger.kernel.org; linux-r...@vger.kernel.org > Subject: Re: [PATCH v1 iproute2-next

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/26/2019 1:16 PM, Leon Romanovsky wrote: > On Tue, Feb 26, 2019 at 11:19:12AM -0600, Steve Wise wrote: >> On 2/23/2019 3:31 AM, Leon Romanovsky wrote: >>> On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: >>>> On Thu, Feb 21, 2019 at 08:1

Re: [PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-02-26 Thread Steve Wise
On 2/23/2019 3:43 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:12AM -0800, Steve Wise wrote: >> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma >> device to a netdev interface. >> >> EG: >> >

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/23/2019 3:31 AM, Leon Romanovsky wrote: > On Sat, Feb 23, 2019 at 11:26:15AM +0200, Leon Romanovsky wrote: >> On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >>> This function sends the constructed netlink message and then >>> receives the response

Re: [PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h

2019-02-26 Thread Steve Wise
On 2/23/2019 3:28 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:07AM -0800, Steve Wise wrote: >> Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK / >> RDMA_NLDEV_CMD_DELLINK API. >> >> Signed-off-by: Steve Wise >> --- >>

Re: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-26 Thread Steve Wise
On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: >> This function sends the constructed netlink message and then >> receives the response, displaying any error text. >> >> Change 'rdma dev set' to us

RE: [PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter functions

2019-02-21 Thread Steve Wise
+++--- > rdma/utils.c| 26 ++ > 7 files changed, 112 insertions(+), 77 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 18/19] rdma: Perform single .doit call to query specific objects

2019-02-21 Thread Steve Wise
| 32 ++- > rdma/res.c | 34 +++- > rdma/res.h | 84 - > rdma/utils.c| 20 ++++ > 9 files changed, 239 insertions(+), 73 deletions(-) > Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 17/19] rdma: Unify netlink attribute checks prior to prints

2019-02-21 Thread Steve Wise
--- > rdma/res.h | 6 ++++-- > 7 files changed, 53 insertions(+), 51 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 16/19] rdma: Move QP code to separate function

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 16/19] rdma: Move QP code to separate > function > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- > rdma/res-qp.c | 253 +- > 1 file changed, 127 insertions(+), 126 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 15/19] rdma: Separate PD code

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 15/19] rdma: Separate PD code > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- > rdma/res-pd.c | 170 ++ > 1 file changed, 89 insertions(+), 81 deletions(-) commit text is wrong. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- > rdma/res-cq.c | 177 ++ > 1 file changed, 91 insertions(+), 86 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 14/19] rdma: Separate MR code

2019-02-21 Thread Steve Wise
s(-) The commit description is wrong. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 12/19] rdma: Simplify CM_ID print code

2019-02-21 Thread Steve Wise
-- > 1 file changed, 124 insertions(+), 122 deletions(-) Not sure why you refactored, but ok. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 11/19] rdma: Simplify code to reuse existing functions

2019-02-21 Thread Steve Wise
- > rdma/res-cmid.c | 4 ++-- > rdma/res-cq.c | 14 +++--- > rdma/res-mr.c | 2 +- > rdma/res-pd.c | 4 ++-- > rdma/res-qp.c | 14 +++--- > rdma/res.c | 34 ++ > rdma/res.h | 3 --- > 7 files changed, 13 insertions(+), 62 deletions(-) > Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 10/19] rdma: Properly mark RDMAtool license

2019-02-21 Thread Steve Wise
this type of license. > > Signed-off-by: Leon Romanovsky > --- > rdma/Makefile | 2 +- > rdma/dev.c| 7 +-- > rdma/link.c | 7 +-- > rdma/rdma.c | 7 +-- > rdma/rdma.h | 7 +-- > rdma/res.c| 7 +-- > rdma/utils.c | 7 +-- > 7 files changed, 7 insertions(+), 37 deletions(-) Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 09/19] rdma: Move resource PD logic to separate file

2019-02-21 Thread Steve Wise
les changed, 252 insertions(+), 237 deletions(-) > create mode 100644 rdma/res-qp.c Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID logic to separate file

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID > logic to separate file > > From: Leon Romanovsky > > Logically separate resource CM-ID logic to separate file, > in order to make CM-ID specific logic self-contained. > > Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 07/19] rdma: Move out resource CQ logic to separate file

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 07/19] rdma: Move out resource CQ logic > to separate file > > From: Leon Romanovsky > > Logically separate resource CQ logic to separate file, > in order to make CQ specific logic self-contained. > > Signed-off-by: Leon Romanovsky > --- Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 06/19] rdma: Refactor out resource MR logic to separate file

2019-02-21 Thread Steve Wise
f-by: Leon Romanovsky > --- Ah I guess you're moving them all into their own files. Ok. Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file

2019-02-21 Thread Steve Wise
y: Leon Romanovsky > --- Why does it need to be self contained? Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 04/19] rdma: Provide parent context index for all objects except CM_ID

2019-02-21 Thread Steve Wise
res_print_uint(rd, "pdn", pdn); > + > if (nla_line[RDMA_NLDEV_ATTR_RES_PID]) > free(comm); > > @@ -964,6 +991,7 @@ static int res_pd_parse_cb(const struct nlmsghdr > *nlh, void *data) > uint32_t local_dma_lkey = 0, unsafe_global_rkey = 0; > struct nlattr *nla_line[RDMA_NLDEV_ATTR_MAX] = {}; > char *comm = NULL; > + uint32_t ctxn = 0; > uint32_t pid = 0; > uint32_t pdn = 0; > uint64_t users; > @@ -997,7 +1025,13 @@ static int res_pd_parse_cb(const struct nlmsghdr > *nlh, void *data) > comm = get_task_name(pid); > } > > - if (rd_check_is_filtered(rd, "pid", pid)) > +if (rd_check_is_filtered(rd, "pid", pid)) Did this add some whitespace problem? Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 02/19] rdma: Remove duplicated print > code > > From: Leon Romanovsky > > There is no need to keep same print functions for > uint32_t and uint64_t, unify them into one function. > > Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for all visible objects

2019-02-21 Thread Steve Wise
n Hemminger > > Subject: [PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for all > visible objects > > From: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > --- Reviewed-by: Steve Wise

RE: [PATCH iproute2-next v1 01/19] rdma: update uapi headers

2019-02-21 Thread Steve Wise
sible entries > > Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

[PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-02-21 Thread Steve Wise
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe netdev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise --- rdma/link.c | 67

[PATCH v1 iproute2-next 4/4] rdma: man page update for link add/delete

2019-02-21 Thread Steve Wise
Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 47 +++ 1 file changed, 47 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index bddf34

[PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg()

2019-02-21 Thread Steve Wise
This function sends the constructed netlink message and then receives the response, displaying any error text. Change 'rdma dev set' to use it. Signed-off-by: Steve Wise --- rdma/dev.c | 2 +- rdma/rdma.h | 1 + rdma/utils.c | 21 + 3 files changed, 23 insert

[PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h

2019-02-21 Thread Steve Wise
Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK / RDMA_NLDEV_CMD_DELLINK API. Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 74 +++ 1 file changed, 58 insertions(+), 16 deletions(-) diff --git a/rdma/include/uapi/rdma

[PATCH v1 iproute2-next 0/4] Dynamic rdma link creation

2019-02-21 Thread Steve Wise
for the network device, do avoid confused with the ib_device name. - got rid of the "type" parameter for link delete. Also pass down the device index instead of the name, using the common rd services for validating the device name and fetching the index. Thanks, Steve. Steve W

RE: [rdma-rc PATCH 2/2] iw_cxgb4: cq/qp mask depends on bar2 pages in a host page

2019-02-14 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Raju Rangoju > Sent: Thursday, February 14, 2019 11:28 AM > To: Jason Gunthorpe > Cc: da...@davemloft.net; linux-r...@vger.kernel.org; > netdev@vger.kernel.org; sw...@opengridcomputing.com

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 4:25 PM, Jason Gunthorpe wrote: > On Wed, Nov 28, 2018 at 04:21:48PM -0600, Steve Wise wrote: > >>>> It does make sense to not require type.  The name must be unique so that >>>> should be enough.  I'll have to respin the kernel side though... &

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 4:17 PM, Jason Gunthorpe wrote: > On Wed, Nov 28, 2018 at 02:18:55PM -0600, Steve Wise wrote: >> >> On 11/28/2018 2:13 PM, Leon Romanovsky wrote: >>> On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: >>>> On 11/28/2018 2:04 PM, Leon Ro

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 2:13 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: >> >> On 11/28/2018 2:04 PM, Leon Romanovsky wrote: >>> On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: >>>> On 11/28/2018 12:26 PM, Leon

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 2:08 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 10:02:04PM +0200, Leon Romanovsky wrote: >> On Wed, Nov 28, 2018 at 01:34:14PM -0600, Steve Wise wrote: >>> ... >>> >>>>>> +rd

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: >> >> On 11/28/2018 12:26 PM, Leon Romanovsky wrote: >>> On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: >>>> Add new 'link' su

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
... >>> + rd_prepare_msg(rd, RDMA_NLDEV_CMD_NEWLINK, &seq, >>> + (NLM_F_REQUEST | NLM_F_ACK)); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, name); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_LINK_TYPE, type); >>> + mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_A

Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
On 11/28/2018 12:26 PM, Leon Romanovsky wrote: > On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: >> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma >> device to a netdev interface. >> >> EG: >>

[PATCH RFC iproute2-next 2/2] rdma: man page update for link add/delete

2018-11-28 Thread Steve Wise
Update the 'rdma link' man page with 'link add/delete' info. Signed-off-by: Steve Wise --- man/man8/rdma-link.8 | 51 +++ 1 file changed, 51 insertions(+) diff --git a/man/man8/rdma-link.8 b/man/man8/rdma-link.8 index 97dd8b

[PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands

2018-11-28 Thread Steve Wise
Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma device to a netdev interface. EG: rdma link add rxe_eth0 type rxe dev eth0 rdma link delete rxe_eth0 Signed-off-by: Steve Wise --- rdma/link.c | 106 +++

[PATCH RFC iproute2-next 0/2] Dynamic rdma link creation

2018-11-28 Thread Steve Wise
are still under review [1]. Please comment! Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg71469.html Steve Wise (2): rdma: add 'link add/delete' commands rdma: man page update for link add/delete man/man8/rdma-link.8 | 51 + r

RE: [PATCH iproute2-next] rdma: Refresh help section of resource information

2018-11-01 Thread Steve Wise
> -Original Message- > From: Leon Romanovsky > Sent: Thursday, November 1, 2018 3:35 AM > To: David Ahern > Cc: Leon Romanovsky ; netdev > ; RDMA mailing list ; > Stephen Hemminger ; Steve Wise > > Subject: [PATCH iproute2-next] rdma: Refresh help sectio

Re: [PATCH rdma-next 1/5] RDMA/core: Provide getter and setter to access IB device name

2018-09-20 Thread Steve Wise
On 9/20/2018 6:21 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Prepare IB device name field to rename operation by ensuring that all > accesses to it are protected with lock and users don't see part of name. > > The protection is done with global device_lock because it is used in >

Re: [PATCH] cxgb4: fix abort_req_rss6 struct

2018-09-10 Thread Steve Wise
(sorry for the late reply, I was out all last week) On 9/5/2018 5:55 PM, Jason Gunthorpe wrote: > On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: >> Remove the incorrect WR_HDR field which can cause a misinterpretation >> of this CPL by ULDs. > > What does th

[PATCH] cxgb4: fix abort_req_rss6 struct

2018-08-31 Thread Steve Wise
Remove the incorrect WR_HDR field which can cause a misinterpretation of this CPL by ULDs. Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") Signed-off-by: Steve Wise --- Dave, Doug, and Jason, I request this merge through the rdma repo since the only us

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-08-17 Thread Steve Wise
> > > > Hey Sagi, > > > > The patch works allowing connections for the various affinity mappings > below: > > > > One comp_vector per core across all cores, starting with numa-local cores: > > Thanks Steve, is this your "Tested by:" tag? Sure: Tested-by: Steve Wise

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-08-17 Thread Steve Wise
> On 8/16/2018 1:26 PM, Sagi Grimberg wrote: > > > >> Let me know if you want me to try this or any particular fix. > > > > Steve, can you test this one? > > Yes! I'll try it out tomorrow. > > Stevo > Hey Sagi, The patch works allowing connections for the various affinity mappings below: One

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-08-16 Thread Steve Wise
On 8/16/2018 1:26 PM, Sagi Grimberg wrote: > >> Let me know if you want me to try this or any particular fix. > > Steve, can you test this one? Yes!  I'll try it out tomorrow.  Stevo > -- > [PATCH rfc] block: fix rdma queue mapping > > nvme-rdma attempts to map queues based on irq vector aff

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-08-06 Thread Steve Wise
On 8/1/2018 9:27 AM, Max Gurtovoy wrote: > > > On 8/1/2018 8:12 AM, Sagi Grimberg wrote: >> Hi Max, > > Hi, > >> >>> Yes, since nvmf is the only user of this function. >>> Still waiting for comments on the suggested patch :) >>> >> >> Sorry for the late response (but I'm on vacation so I have >>

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-30 Thread Steve Wise
On 7/23/2018 11:53 AM, Max Gurtovoy wrote: > > > On 7/23/2018 7:49 PM, Jason Gunthorpe wrote: >> On Fri, Jul 20, 2018 at 04:25:32AM +0300, Max Gurtovoy wrote: >>> >> [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 > > queue 9 is not mapped (overlap). > please try th

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-24 Thread Steve Wise
On 7/24/2018 10:24 AM, Steve Wise wrote: > > On 7/19/2018 8:25 PM, Max Gurtovoy wrote: >>>>> [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 >>>> queue 9 is not mapped (overlap). >>>> please try the bellow: >>>> >>>

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-24 Thread Steve Wise
On 7/19/2018 8:25 PM, Max Gurtovoy wrote: > [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 >>> >>> queue 9 is not mapped (overlap). >>> please try the bellow: >>> >> >> This seems to work.  Here are three mapping cases:  each vector on its >> own cpu, each vector on 1 cpu wit

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-19 Thread Steve Wise
On 7/19/2018 9:50 AM, Max Gurtovoy wrote: > > > On 7/18/2018 10:29 PM, Steve Wise wrote: >> >>> >>> On 7/18/2018 2:38 PM, Sagi Grimberg wrote: >>>> >>>>>> IMO we must fulfil the user wish to connect to N queues and not >>&g

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-18 Thread Steve Wise
> > On 7/18/2018 2:38 PM, Sagi Grimberg wrote: > > > >>> IMO we must fulfil the user wish to connect to N queues and not reduce > >>> it because of affinity overlaps. So in order to push Leon's patch we > >>> must also fix the blk_mq_rdma_map_queues to do a best effort > mapping > >>> according t

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-18 Thread Steve Wise
> -Original Message- > From: Max Gurtovoy > Sent: Wednesday, July 18, 2018 9:14 AM > To: Sagi Grimberg ; Steve Wise > ; 'Leon Romanovsky' > Cc: 'Doug Ledford' ; 'Jason Gunthorpe' > ; 'RDMA mailing list' ; > 'Saee

RE: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-17 Thread Steve Wise
> On 7/16/2018 8:08 PM, Steve Wise wrote: > > Hey Max: > > > > > > Hey, > > > On 7/16/2018 11:46 AM, Max Gurtovoy wrote: > >> > >> > >> On 7/16/2018 5:59 PM, Sagi Grimberg wrote: > >>> > >>>> Hi, >

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-16 Thread Steve Wise
Hey Max: On 7/16/2018 11:46 AM, Max Gurtovoy wrote: > > > On 7/16/2018 5:59 PM, Sagi Grimberg wrote: >> >>> Hi, >>> I've tested this patch and seems problematic at this moment. >> >> Problematic how? what are you seeing? > > Connection failures and same error Steve saw: > > [Mon Jul 16 16:19:11 2

Re: iproute2 won't compile without AF_VSOCK

2018-06-19 Thread Steve Wise
On 6/19/2018 3:29 PM, David Ahern wrote: > On 6/19/18 2:27 PM, David Ahern wrote: >> On 6/19/18 9:47 AM, Stephen Hemminger wrote: >>> On Tue, 19 Jun 2018 10:17:45 -0500 >>> Steve Wise wrote: >>> >>>> Hey David, >>>> >>>>

iproute2 won't compile without AF_VSOCK

2018-06-19 Thread Steve Wise
Hey David, I'm trying to compile the latest iproute2 on an RHEL-7.3 distro, and it fails to compile because AF_VSOCK is not defined.  Should this functionality be a configure option to disable it on older distros? Thanks, Steve. misc     CC   ss.o ss.c:301:27: error: ‘AF_VSOCK’ undec

[PATCH v3 iproute2-next 3/3] rdma: update man pages

2018-05-16 Thread Steve Wise
Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/man8/rdma

[PATCH v3 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-16 Thread Steve Wise
2a8a5d00 rqt_size 256 in_use 128 size 130 Signed-off-by: Steve Wise --- rdma/rdma.c | 9 ++- rdma/rdma.h | 11 rdma/res.c | 30 +++-- rdma/utils.c | 196 +++ 4 files changed, 224 insertions(+), 22 deletions(-) diff -

[PATCH v3 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-16 Thread Steve Wise
Pull in the rdma_netlink.h changes from kernel commits: 25a0ad85156a ("RDMA/nldev: Add explicit pad attribute") da5c85078215 ("RDMA/nldev: add driver-specific resource tracking)" 0d52d803767e ("RDMA/uapi: Fix uapi breakage") Signed-off-by: Steve Wise --- rdma/in

[PATCH v3 iproute2-next 0/3] RDMA tool driver-specific resource tracking

2018-05-16 Thread Steve Wise
le unknown driver attributes when printing Changes since v0/rfc: - changed "provider" to "driver" based on kernel side changes - updated man pages - removed "RFC" tag Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64199.html Steve Wise (3): rdma:

RE: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Steve Wise
> -Original Message- > From: David Ahern > Sent: Tuesday, May 15, 2018 3:02 PM > To: Doug Ledford ; Steve Wise > ; l...@kernel.org > Cc: step...@networkplumber.org; netdev@vger.kernel.org; linux- > r...@vger.kernel.org > Subject: Re: [PATCH v2 iproute

RE: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Doug Ledford > Sent: Tuesday, May 15, 2018 2:53 PM > To: David Ahern ; Steve Wise > ; l...@kernel.org > Cc: step...@networkplumber.org; netdev@vger.kernel.org; linux- &

RE: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-15 Thread Steve Wise
> On Tue, 2018-05-15 at 13:37 -0600, David Ahern wrote: > > On 5/14/18 9:42 AM, Steve Wise wrote: > > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h > b/rdma/include/uapi/rdma/rdma_netlink.h > > > index 60416ed..40be0d8 100644 > > > --- a/rdma/inclu

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> > On Tue, May 15, 2018 at 12:35:34PM -0400, Doug Ledford wrote: > > On Mon, 2018-05-14 at 09:51 -0500, Steve Wise wrote: > > > > > > On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> On Tue, May 15, 2018 at 09:31:27AM -0500, Steve Wise wrote: > > > cap net admin is not high enough privledge to see unhashed kernel > > > pointers. CAP_RAW_IO? Or follow what printk does? > > > > > > > Do you mean CAP_NET_RAW? Here'

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> From: Jason Gunthorpe > On Tue, May 15, 2018 at 08:18:51AM -0500, Steve Wise wrote: > > > > > > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > > > > > > > On 5/14/2018 3:41 PM, Jason Gunthor

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > >> This enhancement allows printing rdma device-specific state,

RE: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-15 Thread Steve Wise
> > On Mon, May 14, 2018 at 05:04:26PM -0500, Steve Wise wrote: > > > > > > > > > On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > > > > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: > > > >> This enhancement allows printi

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Steve Wise
On 5/14/2018 3:41 PM, Jason Gunthorpe wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't >> need to

[PATCH v2 iproute2-next 3/3] rdma: update man pages

2018-05-14 Thread Steve Wise
Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/man8/rdma

[PATCH v2 iproute2-next 0/3] RDMA tool driver-specific resource tracking

2018-05-14 Thread Steve Wise
nce v0/rfc: - changed "provider" to "driver" based on kernel side changes - updated man pages - removed "RFC" tag Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64199.html Steve Wise (3): rdma: update rdma_netlink.h to get new driver attributes

[PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes

2018-05-14 Thread Steve Wise
Pull in the rdma_netlink.h changes from kernel commits: 25a0ad85156a ("RDMA/nldev: Add explicit pad attribute") da5c85078215 ("RDMA/nldev: add driver-specific resource tracking)" Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 26 ++

[PATCH v2 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Steve Wise
2a8a5d00 rqt_size 256 in_use 128 size 130 idx 43 wr_id 0x881057c03408 idx 40 wr_id 0x881057c033f0 Signed-off-by: Steve Wise --- rdma/rdma.c | 9 ++- rdma/rdma.h | 11 rdma/res.c | 30 +++-- rdma/utils.c | 196

Re: [PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

2018-05-14 Thread Steve Wise
On 5/13/2018 8:15 AM, Leon Romanovsky wrote: > On Mon, May 07, 2018 at 08:53:10AM -0700, Steve Wise wrote: >> Signed-off-by: Steve Wise >> --- >> rdma/include/uapi/rdma/rdma_netlink.h | 37 >> ++- >> 1 file changed, 36 inse

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-14 Thread Steve Wise
On 5/13/2018 8:24 AM, Leon Romanovsky wrote: > On Mon, May 07, 2018 at 08:53:16AM -0700, Steve Wise wrote: >> This enhancement allows printing rdma device-specific state, if provided >> by the kernel. This is done in a generic manner, so rdma tool doesn't > Double spac

Re: [PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-10 Thread Steve Wise
On 5/9/2018 11:08 PM, David Ahern wrote: > On 5/7/18 9:53 AM, Steve Wise wrote: >> @@ -152,7 +153,10 @@ int main(int argc, char **argv) >> pretty_output = true; >> break; >> case 'd': >&g

[PATCH v1 iproute2-next 3/3] rdma: update man pages

2018-05-07 Thread Steve Wise
Update the man pages for the resource attributes as well as the driver-specific attributes. Signed-off-by: Steve Wise --- man/man8/rdma-resource.8 | 29 ++--- man/man8/rdma.8 | 2 +- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/man8/rdma

[PATCH v1 iproute2-next 2/3] rdma: print driver resource attributes

2018-05-07 Thread Steve Wise
2a8a5d00 rqt_size 256 in_use 128 size 130 idx 43 wr_id 0x881057c03408 idx 40 wr_id 0x881057c033f0 Signed-off-by: Steve Wise --- rdma/rdma.c | 7 ++- rdma/rdma.h | 11 rdma/res.c | 30 +++-- rdma/utils.c | 194

[PATCH v1 iproute2-next 0/3] RDMA tool driver-specific resource tracking

2018-05-07 Thread Steve Wise
merged, I think. Changes since v0/rfc: - changed "provider" to "driver" based on kernel side changes - updated man pages - removed "RFC" tag Thanks, Steve. [1] https://www.spinics.net/lists/linux-rdma/msg64199.html Steve Wise (3): rdma: update rdma_netlink.h to

[PATCH v1 iproute2-next 1/3] rdma: update rdma_netlink.h to get driver attrs

2018-05-07 Thread Steve Wise
Signed-off-by: Steve Wise --- rdma/include/uapi/rdma/rdma_netlink.h | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h index 45474f1..40be0d8 100644 --- a/rdma

  1   2   3   4   5   6   >