Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

2018-03-29 Thread Steven Whitehouse
Hi, Can we solve the problem another way, by not taking refs on the glocks when we are iterating over them for the debugfs files? I assume that is the main issue here. We didn't used to take refs since the rcu locking was enough during the walk itself. We used to only keep track of the hash

Re: Question about SOCK_SEQPACKET

2017-05-05 Thread Steven Whitehouse
Hi, On 05/05/17 11:09, Sowmini Varadhan wrote: On (05/05/17 10:45), Steven Whitehouse wrote: I do wonder if the man page for recvmsg is wrong, or at least a bit confusing. SOCK_SEQPACKET is stream based not message based - it just happens to have EOR markers in the stream. There is no reason

Re: Question about SOCK_SEQPACKET

2017-05-05 Thread Steven Whitehouse
Hi, On 05/05/17 06:18, Sam Kumar wrote: Hello, I have recently had occasion to use SOCK_SEQPACKET sockets on Linux, and noticed some odd behavior. When using sendmsg and recvmsg with these sockets, it seems that the "end-of-record" flag (MSG_EOR) is not being propagated correctly. It depends

Re: [Cluster-devel] [PATCH 4/6] dlm: use sctp 1-to-1 API

2015-08-13 Thread Steven Whitehouse
Hi, On 12/08/15 17:42, Marcelo Ricardo Leitner wrote: Em 12-08-2015 12:33, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 12 August 2015 14:16 Em 12-08-2015 07:23, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 11 August 2015 23:22 DLM is using 1-to-many API but in a

Re: My 802.3ad is my bond

2008-01-24 Thread Steven Whitehouse
Hi, On Wed, 2008-01-23 at 09:13 -0800, Jay Vosburgh wrote: Steven Whitehouse [EMAIL PROTECTED] wrote: [...] This commit: ece95f7fefe3afae19e641e1b3f5e64b00d5b948 seems to have caused a problem with parsing bond arguments as now only the numeric arguments seem to work (in modprobe.conf

My 802.3ad is my bond

2008-01-23 Thread Steven Whitehouse
Hi, This commit: ece95f7fefe3afae19e641e1b3f5e64b00d5b948 seems to have caused a problem with parsing bond arguments as now only the numeric arguments seem to work (in modprobe.conf) and specifying 802.3ad fails. When I revert that patch in my local tree all seems ok. Also I notice that one of

Re: My 802.3ad is my bond

2008-01-23 Thread Steven Whitehouse
Hi, On Wed, 2008-01-23 at 09:13 -0800, Jay Vosburgh wrote: Steven Whitehouse [EMAIL PROTECTED] wrote: [...] This commit: ece95f7fefe3afae19e641e1b3f5e64b00d5b948 seems to have caused a problem with parsing bond arguments as now only the numeric arguments seem to work (in modprobe.conf

Re: dn_neigh_table vs pneigh_lookup/pneigh_delete

2007-12-20 Thread Steven Whitehouse
Hi, On Wed, Dec 19, 2007 at 05:11:34PM +0300, Pavel Emelyanov wrote: Hi The pneigh_lookup/delete silently concerns, that the key_len of the table is more that 4 bytes. Look: u32 hash_val = *(u32 *)(pkey + key_len - 4); The hash_val for the proxy neighbor entry is four last

Re: [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-29 Thread Steven Whitehouse
on, returning this 0 in any case. Is this made deliberately, or the patch below is correct? The patch looks good to me. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Acked-by: Steven Whitehouse [EMAIL PROTECTED] Steve. --- diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index

Re: [PATCH] decnet: addr module param can't be __initdata

2007-11-01 Thread Steven Whitehouse
Hi, Looks good, Feel free to add: Acked-by: Steven Whitehouse [EMAIL PROTECTED] Steve. On Thu, Nov 01, 2007 at 06:36:29PM +0300, Alexey Dobriyan wrote: sysfs keeps references to module parameters via /sys/module/*/parameters, so marking them as __initdata can't work. Steps to reproduce

DECnet routing rule resolution

2007-03-29 Thread Steven Whitehouse
Hi, One of the effects of the recent tidy up of the DECnet routing rules code is that we are no longer able to see the difference between reading a rule of type FR_ACT_UNREACHABLE returning -ENETUNREACH and simply running out of rules to look at, which also returns the same thing. The DECnet

Re: [PATCH 09/12] [DECNet]: Use rtnl registration interface

2007-03-22 Thread Steven Whitehouse
Hi, On Thu, Mar 22, 2007 at 02:00:04PM +0100, Thomas Graf wrote: Signed-off-by: Thomas Graf [EMAIL PROTECTED] Acked-by: Steven Whitehouse [EMAIL PROTECTED] for all the DECnet bits also the DECnet changes in the other patch I saw from you relating to the routing rules, Steve. - To unsubscribe

Re: [PATCH] net: decnet handle a failure in neigh_parms_alloc (take 2)

2007-01-25 Thread Steven Whitehouse
. Biederman [EMAIL PROTECTED] Acked-by: Steven Whitehouse [EMAIL PROTECTED] Also you should cc Patrick as he is now the maintainer, Steve. --- net/decnet/dn_dev.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c

Re: [PATCHSET] packet mark fib rules work

2006-11-09 Thread Steven Whitehouse
code from per protocol part into the generic part and adds support for inverting selectors. Acked-by: Steven Whitehouse [EMAIL PROTECTED] so far as all the DECnet bits go. One question though... will you be adding later (as your slide #5 and #11 from your netconf presentation appear to imply

[DECNET] Endian bug fixes

2006-11-06 Thread Steven Whitehouse
Hi, Here is a patch which fixes some endianess problems. Patrick: since you have both big little endian machines at your disposal, can you test to ensure this is ok? Thanks, Steve. From ed3de950e89f8b02302308a2bedd59123ff3b88e Mon Sep 17 00:00:00 2001 From: Steven Whitehouse [EMAIL PROTECTED

Re: [DECNET] Endian bug fixes

2006-11-06 Thread Steven Whitehouse
Hi, On Mon, 2006-11-06 at 10:32 +, Al Viro wrote: On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote: + opt-opt_optl = dn_htons((__u16)*ptr++); Lose that cast; it's only confusing the things... + memcpy(opt-opt_data, ptr, dn_ntohs(opt-opt_optl)); + skb_pull

Re: [DECNET] Endian bug fixes

2006-11-06 Thread Steven Whitehouse
Hi, On Mon, 2006-11-06 at 10:34 +, Al Viro wrote: On Mon, Nov 06, 2006 at 10:32:43AM +, Al Viro wrote: On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote: + opt-opt_optl = dn_htons((__u16)*ptr++); Lose that cast; it's only confusing the things... + memcpy

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Steven Whitehouse
Hi, On Tue, Oct 17, 2006 at 11:53:36PM -0700, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 18 Oct 2006 07:42:17 +0200 How many people are using DECNET and want to pay the price of this 20 bytes dnports structure ? Point taken :-) Eric, you also need to add a ||

[DECNET] Fix input routing bug

2006-10-18 Thread Steven Whitehouse
for a typo. Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Cc: Alan Kemmerer [EMAIL PROTECTED] diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c index dd0761e..810ab9c 100644 --- a/net/decnet/dn_route.c +++ b/net/decnet/dn_route.c

Re: [PATCH] [NET] reduce sizeof(struct flow)

2006-10-18 Thread Steven Whitehouse
Hi, Its not used at the moment[*], but would be required for any kind of flow tracking. The objnum field, could be folded into the objname field I guess on the basis that objnamel == 0 means objname[0] represents the objnum, but that doesn't really buy much. Well, as I privately said

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Steven Whitehouse
Hi, On Wed, Oct 11, 2006 at 11:05:04AM +0200, Michael S. Tsirkin wrote: Quoting r. David Miller [EMAIL PROTECTED]: Subject: Re: Dropping NETIF_F_SG since no checksum feature. From: Michael S. Tsirkin [EMAIL PROTECTED] Date: Wed, 11 Oct 2006 02:13:38 +0200 Maybe I can patch linux

Re: Dropping NETIF_F_SG since no checksum feature.

2006-10-11 Thread Steven Whitehouse
Hi, On Wed, Oct 11, 2006 at 05:01:03PM +0200, Michael S. Tsirkin wrote: Quoting Steven Whitehouse [EMAIL PROTECTED]: ssize_t tcp_sendpage(struct socket *sock, struct page *page, int offset, size_t size, int flags) { ssize_t res; struct sock *sk

Re: [DECNET]: Add support for fwmark masks in routing rules

2006-08-25 Thread Steven Whitehouse
PROTECTED] Acked-by: Steven Whitehouse [EMAIL PROTECTED] Looks good, Steve. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[DECNET] Fix to multiple tables routing

2006-08-11 Thread Steven Whitehouse
Here is a fix to Patrick McHardy's increase number of routing tables patch for DECnet. I did just test this and it appears to be working fine with this patch. Cc: Patrick McHardy [EMAIL PROTECTED] Cc: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] diff

Re: [DECNET] Fix to multiple tables routing

2006-08-11 Thread Steven Whitehouse
Hi, On Fri, Aug 11, 2006 at 05:22:17PM +0200, Patrick McHardy wrote: Steven Whitehouse wrote: Here is a fix to Patrick McHardy's increase number of routing tables patch for DECnet. I did just test this and it appears to be working fine with this patch. Cc: Patrick McHardy [EMAIL

[DECNET] Fix to decnet rules compare function

2006-08-11 Thread Steven Whitehouse
Here is a fix to the DECnet rules compare function where we used 32bit values rather than 16bit values. Spotted by Patrick McHardy. Cc: Patrick McHardy [EMAIL PROTECTED] Cc: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] diff --git a/net/decnet

Rules and groups

2006-08-09 Thread Steven Whitehouse
Hi, With your new protocol independent rules code, I see that there is an entry in struct fib_rules_ops for a netlink group for notification of rule changes. For whatever reason (historical I guess) DECnet has never had a nl group assigned for this, so I'm left with two choices when moving the

Re: Rules and groups

2006-08-09 Thread Steven Whitehouse
Hi, On Wed, Aug 09, 2006 at 01:01:25AM -0700, David Miller wrote: From: Steven Whitehouse [EMAIL PROTECTED] Date: Wed, 9 Aug 2006 09:01:39 +0100 Is there anything to stop me using RTNLGRP_NOP3 for that? (suitable renamed of course!) So far as I can see its never been assigned

[DECnet] Convert rwlock to spinlock

2006-08-09 Thread Steven Whitehouse
Hi, [This is also in the DECnet git tree] As per Stephen Hemminger's recent patch to ipv4/fib_semantics.c this is the same change but for DECnet. Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] --- net/decnet/dn_fib.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions

Re: [RFC DECNET 04/04]: Increase number of possible routing tables to 2^32

2006-07-03 Thread Steven Whitehouse
Hi, On Mon, Jul 03, 2006 at 09:53:05AM +0200, Patrick McHardy wrote: [DECNET]: Increase number of possible routing tables to 2^32 Increase the nubmer of possible routing tables to 2^32 by replacing the fixed sized array of tables by a hash table. Signed-off-by: Patrick McHardy [EMAIL

Re: MPLS extension for pktgen

2006-03-22 Thread Steven Whitehouse
Hi, On Tue, Mar 21, 2006 at 07:38:06PM +0100, Robert Olsson wrote: Steven Whitehouse writes: I've been looking into MPLS recently and so one of the first things that would be useful is a testbed to generate test traffic, and hence the attached patch to pktgen. If you have

Re: MPLS extension for pktgen

2006-03-22 Thread Steven Whitehouse
Hi, Here is the updated patch. If you are happy with this, then will you send it on to Dave, or should I do that? Steve. --- Signed-off-by: Steven Whitehouse [EMAIL PROTECTED] diff --git a/Documentation/networking

MPLS extension for pktgen

2006-03-21 Thread Steven Whitehouse
Nishanth Aravamudan [EMAIL PROTECTED] * 050103 + * + * MPLS support by Steven Whitehouse [EMAIL PROTECTED] + * */ #include linux/sys.h #include linux/types.h @@ -154,7 +157,7 @@ #include asm/div64.h /* do_div */ #include asm/timex.h -#define VERSION pktgen v2.66: Packet Generator