Re: [PATCH net-next] net/core: delete the no need variable description in devlink_resource_register() comment

2018-05-10 Thread Sun Lianwen
Hi On 05/10/2018 05:52 PM, Sergei Shtylyov wrote: > Hello! > > On 5/10/2018 6:28 AM, Sun Lianwen wrote: > >> The variable "top_hierarchy" and "reload_required" is not existence in > >    Don't exist, you mean? my statement

[PATCH net-next] net/core: delete the no need variable description in devlink_resource_register() comment

2018-05-09 Thread Sun Lianwen
The variable "top_hierarchy" and "reload_required" is not existence in devlink_resource_register() Signed-off-by: Sun Lianwen --- net/core/devlink.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index ad1317376798..c9596ea1d

[PATCH net-next] net/core: correct the variable name in dev_ioctl() comment

2018-05-09 Thread Sun Lianwen
The variable name is not "arg" but "ifr" in dev_ioctl() Signed-off-by: Sun Lianwen --- net/core/dev_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index a04e1e88bf3a..114e29053977 100644 --- a/net/co

Re: [PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Sun Lianwen
On 05/08/2018 12:51 PM, Randy Dunlap wrote: > On 05/07/2018 06:49 PM, Sun Lianwen wrote: >> There are follow comment errors: >> 1 The function name is wrong in p9_release_pages() comment. >> 2 The function name and variable name is wrong in p9_poll_workfn() comment. >

[PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Sun Lianwen
There is no variable initialized in struct virtio_chan. 6 The variable name is wrong in p9_virtio_zc_request() comment. Signed-off-by: Sun Lianwen Reviewed-by: Randy Dunlap --- net/9p/trans_common.c | 2 +- net/9p/trans_fd.c | 4 ++-- net/9p/trans_rdma.c | 4 +--- net/9p/trans_virtio.c | 5

[PATCH] net/9p: correct some comment errors in 9p file system code

2018-05-07 Thread Sun Lianwen
There is no variable initialized in struct virtio_chan. 6 The variable name is wrong in p9_virtio_zc_request() comment. Signed-off-by: Sun Lianwen --- net/9p/trans_common.c | 2 +- net/9p/trans_fd.c | 4 ++-- net/9p/trans_rdma.c | 4 +--- net/9p/trans_virtio.c | 5 ++--- 4 files changed, 6

[PATCH] net/9p: correct the variable name in v9fs_get_trans_by_name() comment

2018-05-04 Thread Sun Lianwen
The v9fs_get_trans_by_name(char *s) variable name is not "name" but "s". Signed-off-by: Sun Lianwen --- net/9p/mod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/9p/mod.c b/net/9p/mod.c index 6ab36aea7727..eb9777f05755 100644 --- a/net/9p/mod.

[PATCH net-next] vlan: correct the file path in vlan_dev_change_flags() comment

2018-05-04 Thread Sun Lianwen
The vlan_flags enum is defined in include/uapi/linux/if_vlan.h file. not in include/linux/if_vlan.h file. Signed-off-by: Sun Lianwen --- net/8021q/vlan_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 236452ebbd9e

[PATCH net-next] ip6_gre: correct the function name in ip6gre_tnl_addr_conflict() comment

2018-05-02 Thread Sun Lianwen
The function name is wrong in ip6gre_tnl_addr_conflict() comment, which use ip6_tnl_addr_conflict instead of ip6gre_tnl_addr_conflict. Signed-off-by: Sun Lianwen --- net/ipv6/ip6_gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c

[PATCH] change the comment of ip6gre_tnl_addr_conflict

2018-05-02 Thread Sun Lianwen
The comment of ip6gre_tnl_addr_conflict() is wrong. which use ip6_tnl_addr_conflict instead of ip6gre_tnl_addr_conflict. Signed-off-by: Sun Lianwen --- net/ipv6/ip6_gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index

[PATCH] change the comment of vti6_ioctl

2018-04-29 Thread Sun Lianwen
The comment of vti6_ioctl() is wrong. which use vti6_tnl_ioctl instead of vti6_ioctl. Signed-off-by: Sun Lianwen --- net/ipv6/ip6_vti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c index c214ffec02f0..deadc4c3703b 100644 --- a/net