Moderated list (Was: Re: [BUG] New Kernel Bugs)

2007-11-14 Thread Takashi Iwai
At Wed, 14 Nov 2007 04:01:31 -0800 (PST), David Miller wrote: > > From: David Miller <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 03:56:57 -0800 (PST) > > > The fact that it farts at me every time I post to this thread. > > See? I got another one and I have received at least 10 of the > followi

Re: Moderated list (Was: Re: [BUG] New Kernel Bugs)

2007-11-14 Thread Takashi Iwai
At Wed, 14 Nov 2007 13:21:30 +0100, Rene Herman wrote: > > On 14-11-07 09:25, Takashi Iwai wrote: > > > At Wed, 14 Nov 2007 04:01:31 -0800 (PST), > > David Miller wrote: > >> From: David Miller <[EMAIL PROTECTED]> > >> Date: Wed, 14 Nov 2007 03:56:57

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-15 Thread Takashi Iwai
At Thu, 15 Nov 2007 14:17:27 +0100, Olivier Galibert wrote: > > On Thu, Nov 15, 2007 at 06:59:34AM +0100, Rene Herman wrote: > > Totally unrelated indeed so why are spouting crap? If the kohab list has a > > problem take it up with them but keep ALSA out of it. alsa-devel has only > > ever moder

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

2016-06-20 Thread Takashi Iwai
On Mon, 20 Jun 2016 17:21:26 +0200, Richard Cochran wrote: > > On Mon, Jun 20, 2016 at 02:31:48PM +0200, Richard Cochran wrote: > > Where is this "audio_time" program of which you speak? > > Never mind, found it in alsa-lib. > > I still would appreciate an answer to my other questions, though...

Re: [alsa-devel] [very-RFC 0/8] TSN driver for the kernel

2016-06-20 Thread Takashi Iwai
On Tue, 21 Jun 2016 08:38:57 +0200, Richard Cochran wrote: > > On Tue, Jun 21, 2016 at 07:54:32AM +0200, Takashi Iwai wrote: > > > I still would appreciate an answer to my other questions, though... > > > > Currently HD-audio (both ASoC and legacy ones) are the onl

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

2015-09-29 Thread Takashi Iwai
On Tue, 29 Sep 2015 02:35:04 +0200, Pravin Shelar wrote: > > On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai wrote: > > [I resent this since the previous mail didn't go out properly, as it > > seems; apologies if you already read it, please disregard] > > > > Hi

S3 resume fails with r8169 (RTL8168evl/8111evl)

2015-09-01 Thread Takashi Iwai
Hi, we're facing a problem where the network can't be resumed after S3 with r8169 driver. The chip is with RTL_GIGA_MAC_VER_34, 8168evl/8111evl. The link is up and detected at S3 resume, but there is no proceed after that. NetworkManager gave up after timeout. During S3 resume, there is no int

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-20 Thread Takashi Iwai
ontains patches. > > It would be nice if we could tell request_firmware() if it is optional or > mandatory firmware. Or if it should just cache the status of a missing > firmware as well. OK, below is a quick hack to record the failed f/w files, too. Not sure whether this helps, though

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-20 Thread Takashi Iwai
At Wed, 20 May 2015 16:42:44 -0700, Laura Abbott wrote: > > On 05/20/2015 05:44 AM, Takashi Iwai wrote: > > At Wed, 20 May 2015 11:46:31 +0200, > > Marcel Holtmann wrote: > >> > >> Hi Oliver, > >> > >>>> The data is cached in RAM. Mo

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Takashi Iwai
At Thu, 21 May 2015 14:07:11 +0200, Marcel Holtmann wrote: > > Hi Takashi, > > >> The data is cached in RAM. More specifically, the former loaded > >> firmware files are reloaded and saved at suspend for each device > >> object. See fw_pm_notify() in firmware_class.c. > > > >>>

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Takashi Iwai
At Thu, 21 May 2015 10:18:08 -0400 (EDT), Alan Stern wrote: > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > Then avoiding the failed firmware is no solution, indeed. > > If it's a new probe, it should be never executed during resume. > > Can you expand

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Takashi Iwai
At Thu, 21 May 2015 11:26:17 -0400 (EDT), Alan Stern wrote: > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > At Thu, 21 May 2015 10:18:08 -0400 (EDT), > > Alan Stern wrote: > > > > > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > > >

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Takashi Iwai
At Thu, 21 May 2015 19:27:41 +0200, Arend van Spriel wrote: > > On 05/21/15 17:35, Takashi Iwai wrote: > > At Thu, 21 May 2015 11:26:17 -0400 (EDT), > > Alan Stern wrote: > >> > >> On Thu, 21 May 2015, Takashi Iwai wrote: > >> > >>> At Thu,

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Takashi Iwai
At Thu, 21 May 2015 13:37:56 -0400 (EDT), Alan Stern wrote: > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > At Thu, 21 May 2015 11:26:17 -0400 (EDT), > > Alan Stern wrote: > > > > > > On Thu, 21 May 2015, Takashi Iwai wrote: > > >

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Takashi Iwai
Cc: Haiyang Zhang > Cc: Hiral Patel > Cc: Suma Ramars > Cc: Brian Uchino > Cc: "James E.J. Bottomley" > Cc: Jaroslav Kysela > Cc: Takashi Iwai For the sound bits, Acked-by: Takashi Iwai thanks, Takashi > Cc: Andrew Morton > Suggested-by: David Miller >

Re: [alsa-devel] [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Takashi Iwai
| 6 +++--- > kernel/trace/trace_printk.c | 4 ++-- > lib/raid6/sse2.c | 14 +++--- > sound/soc/fsl/fsl_dma.c | 2 +- For sound bits, Acked-by: Takashi Iwai thanks, Takashi

[PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread Takashi Iwai
to a NULL dereference at the callers that expect non-NULL value. Fix it by returning the proper net_device object. Fixes: 916c5e1413be ("hv/netvsc: fix handling of fallback to single queue mode") Cc: Signed-off-by: Takashi Iwai --- drivers/net/hyperv/rndis_filter.c | 2 +- 1 file change

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread Takashi Iwai
On Tue, 14 Aug 2018 19:29:32 +0200, David Miller wrote: > > From: Takashi Iwai > Date: Tue, 14 Aug 2018 19:10:50 +0200 > > > The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback > > to single queue mode") tried to fix the fallback behavior

Re: [PATCH 20/22] sound: pci: avoid string overflow warnings

2017-07-14 Thread Takashi Iwai
On Fri, 14 Jul 2017 14:07:12 +0200, Arnd Bergmann wrote: > > With gcc-7, we get various warnings about a possible string overflow: > > sound/pci/rme9652/hdspm.c: In function 'snd_hdspm_create_alsa_devices': > sound/pci/rme9652/hdspm.c:2123:17: error: ' MIDIoverMADI' directive writing > 13 bytes

Re: [alsa-devel] [PATCH 04/11] sound/hal2: switch to dma_alloc_attrs

2017-06-16 Thread Takashi Iwai
latter case, Reviewed-by: Takashi Iwai thanks, Takashi > --- > sound/mips/hal2.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c > index 00fc9241d266..17a78a93e885 100644 > --- a/sou

Re: [alsa-devel] [PATCH 04/11] sound/hal2: switch to dma_alloc_attrs

2017-06-16 Thread Takashi Iwai
On Fri, 16 Jun 2017 10:51:47 +0200, Christoph Hellwig wrote: > > On Fri, Jun 16, 2017 at 10:49:56AM +0200, Takashi Iwai wrote: > > On Fri, 16 Jun 2017 09:17:09 +0200, > > Christoph Hellwig wrote: > > > > > > Use dma_alloc_attrs directly instead

[PATCH] sky2: Disable MSI on ASUS P6T

2019-07-23 Thread Takashi Iwai
entries instead. BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1142496 Reported-and-tested-by: Marcus Seyfarth Signed-off-by: Takashi Iwai --- drivers/net/ethernet/marvell/sky2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 16:46:21 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > On Tue, 12 Jan 2021 13:45:33 +0100, > > Kalle Valo wrote: > >> > >> Takashi Iwai writes: > >> > >> > On Tue, 12 Jan 2021 12:33:14 +

Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 16:48:56 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device > > memory") added a termination of name string just to be sure, and this > > seems causing a regression

Re: [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 16:50:54 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > The ucode TLV data may be read-only and should be treated as const > > pointers, but currently a few code forcibly cast to the writable > > pointer unnecessarily. This gave develope

Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void

2021-01-22 Thread Takashi Iwai
unconditionally anyhow. > > Signed-off-by: Uwe Kleine-König For the sound/* changes: Reviewed-by: Takashi Iwai BTW, how will we take the patches? Judging from the LOCs, sound/* are mostly affected, so I may merge them via sound.git tree, if other people have no objection. thanks, Takashi

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-28 Thread Takashi Iwai
e > accordingly. > > Signed-off-by: Uwe Kleine-König For the sound bit: Acked-by: Takashi Iwai thanks, Takashi > --- > arch/powerpc/include/asm/ps3.h | 4 ++-- > arch/powerpc/platforms/ps3/system-bus.c | 5 ++--- > drivers/block/ps3disk.c

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-11-28 Thread Takashi Iwai
On Thu, 26 Nov 2020 17:59:49 +0100, Uwe Kleine-König wrote: > > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. > > Sig

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-12-02 Thread Takashi Iwai
On Wed, 02 Dec 2020 13:14:06 +0100, Michael Ellerman wrote: > > Uwe Kleine-König writes: > > Hello Michael, > > > > On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: > >> On Thu, 26 Nov 2020 17:59:50 +0100, > >> Uwe Kleine-König wrote:

Re: [PATCH v2 0/3] isa: Make the remove callback for isa drivers return void

2021-01-25 Thread Takashi Iwai
er embedded in struct >radio_isa_driver). For this I introduced patch 2 and adapted patch 3 >a bit. An interdiff is below. > - Added Acks/Reviews by Guenter Roeck, William Breathitt Gray, Marc > Kleine-Budde, Wolfram Sang and Takashi Iwai > > The base-commit I specified (by h

Re: [alsa-devel] [PATCH 17/18] ALSA: hal2: pass struct device to DMA API functions

2019-02-01 Thread Takashi Iwai
> Signed-off-by: Christoph Hellwig Looks good to me: Reviewed-by: Takashi Iwai Shall I take this one through sound git tree or all through yours? thanks, Takashi

Re: [alsa-devel] [PATCH 18/18] ALSA: pass struct device to DMA API functions

2019-02-01 Thread Takashi Iwai
lso use GFP_KERNEL instead of GFP_USER as the gfp_t for the memory > allocation, as we should treat this allocation as a normal kernel one. > > Signed-off-by: Christoph Hellwig Reviewed-by: Takashi Iwai thanks, Takashi

Re: [alsa-devel] don't pass a NULL struct device to DMA API functions

2019-02-01 Thread Takashi Iwai
eal with separately. Actually there are a bunch of ISA sound drivers that still call allocators with NULL device. The patch below should address it, although it's only compile-tested. thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: isa: Avoid passing NULL to memory allo

Re: [alsa-devel] [PATCH 17/18] ALSA: hal2: pass struct device to DMA API functions

2019-02-01 Thread Takashi Iwai
On Fri, 01 Feb 2019 17:09:06 +0100, Christoph Hellwig wrote: > > On Fri, Feb 01, 2019 at 02:12:45PM +0100, Takashi Iwai wrote: > > Shall I take this one through sound git tree or all through yours? > > Feel free to merge the sound bits through your tree! Alright, merged both

Re: [alsa-devel] don't pass a NULL struct device to DMA API functions

2019-02-01 Thread Takashi Iwai
On Fri, 01 Feb 2019 17:09:57 +0100, Christoph Hellwig wrote: > > On Fri, Feb 01, 2019 at 02:16:08PM +0100, Takashi Iwai wrote: > > Actually there are a bunch of ISA sound drivers that still call > > allocators with NULL device. > > > > The patch below should

Re: 2.6.15-rc6: known regressions in the kernel Bugzilla

2005-12-22 Thread Takashi Iwai
At Wed, 21 Dec 2005 23:15:57 -0800, Greg KH wrote: > > On Thu, Dec 22, 2005 at 02:13:20AM +0100, Adrian Bunk wrote: > > The following bug in the kernel Bugzilla contains a regressions in > > 2.6.15-rc without a patch: > > - #5760 No sound with snd_intel8x0 & ALi M5455 chipset > > (kobject

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 12:33:14 +0100, Kalle Valo wrote: > > (adding luca) > > Michal Kubecek writes: > > > FYI, there is a regression in iwlwifi driver caused by commit > > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > > reported at > > > > https://bugzilla.kernel.org/show_

Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 13:45:33 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > On Tue, 12 Jan 2021 12:33:14 +0100, > > Kalle Valo wrote: > >> > >> (adding luca) > >> > >> Michal Kubecek writes: > >> &g

[PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data

2021-01-12 Thread Takashi Iwai
ly. This patch drops the code that caused the regression and keep the tlv data as is. Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733 Signed-off-

[PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const

2021-01-12 Thread Takashi Iwai
adds the const prefix to those cast pointers, so that such attempt can be caught more easily in future. Signed-off-by: Takashi Iwai --- .../net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 50 ++- .../net/wireless/intel/iwlwifi/iwl-dbg-tlv.h | 2 +- drivers/net/wireless/intel/iwlwifi

[PATCH 0/2] iwlwifi: Fix a crash at loading

2021-01-12 Thread Takashi Iwai
://bugzilla.suse.com/show_bug.cgi?id=1180344 [2] https://bugzilla.kernel.org/show_bug.cgi?id=210733 === Takashi Iwai (2): iwlwifi: dbg: Don't touch the tlv data iwlwifi: dbg: Mark ucode tlv data as const .../net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 57 +-- .../net/wireless/

Re: [PATCH 2/8] ALSA: pcm: use krealloc_array()

2020-10-27 Thread Takashi Iwai
On Tue, 27 Oct 2020 13:17:19 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: T

Re: [PATCH 0/3] Modernize tasklet callback API

2020-08-11 Thread Takashi Iwai
On Tue, 11 Aug 2020 23:33:13 +0200, Kees Cook wrote: > > On Mon, Aug 03, 2020 at 02:16:15PM +0530, Allen wrote: > > Here's the series re-based on top of 5.8 > > https://github.com/allenpais/tasklets/tree/V3 > > Great! > > > Let me know how you would want these to be reviewed. > > Was a Coccinel

Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-05-26 Thread Takashi Iwai
On Tue, 26 May 2020 15:15:26 +0200, Pierre-Louis Bossart wrote: > > > > On 5/24/20 1:35 AM, Greg KH wrote: > > On Sat, May 23, 2020 at 02:41:51PM -0500, Pierre-Louis Bossart wrote: > >> > >> > >> On 5/23/20 1:23 AM, Greg KH wrote: > >>> On Fri, May 22, 2020 at 09:29:57AM -0500, Pierre-Louis Boss

Re: BUG: unable to handle kernel paging request in dqput

2020-09-27 Thread Takashi Iwai
On Sat, 26 Sep 2020 22:48:15 +0200, syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:98477740 Merge branch 'rcu/urgent' of git://git.kernel.org.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1793087590 > kernel co