Re: [PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed reports

2018-06-14 Thread Tejaswi Tanikella
On Wed, Jun 13, 2018 at 04:44:37PM +0200, Andrew Lunn wrote: > While it has been asleep, it has also been dropping any multicast > traffic in the stream. So it does not really matter it has left the > group. You were not receiving the packets anyway. > > Thing about this from another angle. I

Re: [PATCH 2/2] ktime: helpers to convert between ktime and jiffies

2018-06-13 Thread Tejaswi Tanikella
On Tue, Jun 12, 2018 at 06:30:32PM +0200, Andrew Lunn wrote: > On Mon, Jun 11, 2018 at 05:22:28PM +0530, Tejaswi Tanikella wrote: > > Signed-off-by: Tejaswi Tanikella > > --- > > include/linux/ktime.h | 4 > > 1 file changed, 4 insertions(+) > > > &g

Re: [PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed reports

2018-06-13 Thread Tejaswi Tanikella
On Tue, Jun 12, 2018 at 06:28:18PM +0200, Andrew Lunn wrote: > On Mon, Jun 11, 2018 at 05:21:05PM +0530, Tejaswi Tanikella wrote: > > On receiving a IGMPv2/v3 query, based on max_delay set in the header a > > timer is started to send out a response after a random time withi

[PATCH net v3 2/2] ipv4: igmp: use alarmtimer to prevent delayed reports

2018-06-11 Thread Tejaswi Tanikella
will wake the system up from suspend to send out the IGMP report. Signed-off-by: Tejaswi Tanikella --- v2: use alarmtimer instead of wakelock. v3: add patches in the right order. --- If these changes are fine, I'll share similar patches for MLD and ARP. --- include/linux/igmp.h | 7 ++- net/ipv4

[PATCH net v3 1/2] ktime: helpers to convert between ktime and jiffies

2018-06-11 Thread Tejaswi Tanikella
Signed-off-by: Tejaswi Tanikella --- v2: use alarmtimer instead of wakelock. v3: add patches in the right order. --- include/linux/ktime.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/ktime.h b/include/linux/ktime.h index 5b9fddb..4881483 100644 --- a/include/linux

[PATCH 2/2] ktime: helpers to convert between ktime and jiffies

2018-06-11 Thread Tejaswi Tanikella
Signed-off-by: Tejaswi Tanikella --- include/linux/ktime.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/ktime.h b/include/linux/ktime.h index 5b9fddb..4881483 100644 --- a/include/linux/ktime.h +++ b/include/linux/ktime.h @@ -96,6 +96,10 @@ static inline ktime_t

[PATCH net 1/2] ipv4: igmp: use alarmtimer to prevent delayed reports

2018-06-11 Thread Tejaswi Tanikella
will wake the system up from suspend to send out the IGMP report. Signed-off-by: Tejaswi Tanikella --- v2: use alarmtimer instead of wakelock. --- If these changes are fine, I'll share similar patches for MLD and ARP. --- include/linux/igmp.h | 7 ++- net/ipv4/igmp.c | 27

Re: [PATCH net] ipv4: igmp: hold wakelock to prevent delayed reports

2018-06-06 Thread Tejaswi Tanikella
On Mon, Jun 04, 2018 at 11:06:40AM -0400, David Miller wrote: > From: Tejaswi Tanikella > Date: Fri, 1 Jun 2018 19:35:41 +0530 > > > On receiving a IGMPv2/v3 query, based on max_delay set in the header a > > timer is started to send out a response after a random time

Re: [PATCH net] ipv4: igmp: hold wakelock to prevent delayed reports

2018-06-04 Thread Tejaswi Tanikella
On Fri, Jun 01, 2018 at 07:45:16AM -0700, Florian Fainelli wrote: Thank you Florian for reviewing my patch. I had a few questions. > > > On 06/01/2018 07:05 AM, Tejaswi Tanikella wrote: > > On receiving a IGMPv2/v3 query, based on max_delay set in the header a > > timer i

[PATCH net] ipv4: igmp: hold wakelock to prevent delayed reports

2018-06-01 Thread Tejaswi Tanikella
to 10s, Reports were consistantly delayed if the timer is scheduled after 5 plus seconds. Hold wakelock while starting the timer to prevent moving into suspend state. Signed-off-by: Tejaswi Tanikella --- include/linux/igmp.h | 1 + net/ipv4/igmp.c | 20 ++-- 2 files changed

[PATCH v2 net] slip: Check if rstate is initialized before uncompressing

2018-04-11 Thread Tejaswi Tanikella
slhc.c:615 Adding a variable to indicate if the current rstate is initialized. If such a packet arrives, move to toss state. Signed-off-by: Tejaswi Tanikella <tejas...@codeaurora.org> --- drivers/net/slip/slhc.c | 5 + include/net/slhc_vj.h | 1 + 2 files changed, 6 insertions(+) d

[PATCH] slip: Check if rstate is initialized before uncompressing

2018-04-09 Thread Tejaswi Tanikella
slhc.c:615 Adding a variable to indicate if the current rstate is initialized. If such a packet arrives, move to toss state. Signed-off-by: Tejaswi Tanikella <tejas...@codeaurora.org> --- drivers/net/slip/slhc.c | 5 + include/net/slhc_vj.h | 1 + 2 files changed, 6 insertions(+) d