On 06/02/15 at 01:26pm, Eric W. Biederman wrote:
What we really want here is xfrm-lite. By lite I mean the tunnel
selection criteria is simple enough that it fits into the normal
routing table instead of having to do weird flow based magic that
is rarely needed.
I believe what we want are
On 06/02/15 at 02:28pm, Robert Shearman wrote:
Nesting attributes inside the RTA_ENCAP blob should be supported by the
patch series today. Something like this:
Sure. I'm not seeing such a construct for the MPLS case yet.
I'm happy to rebase my patches on top of your nexthop implementation.
It
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key
to allow routes to match on tunnel metadata. For now, the tunnel id
is added to flowi_tunnel which allows for routes to be bound to
specific virtual tunnels.
Signed-off-by: Thomas Graf tg...@suug.ch
---
include/net/flow.h
, it will only
have to allocate the metadata once and can simply increment the
reference counter for each packet that uses that instruction set.
Signed-off-by: Thomas Graf tg...@suug.ch
---
include/linux/skbuff.h| 1 +
include/net/ip_tunnels.h | 45
to extend/modify
these structures without affecting user ABI.
Signed-off-by: Thomas Graf tg...@suug.ch
---
include/net/ip_tunnels.h | 63 +
include/uapi/linux/openvswitch.h | 2 +-
net/openvswitch/actions.c| 2 +-
net/openvswitch/datapath.h | 5
(), vxlan_xmit_skb()
since they are no longer needed.
Signed-off-by: Thomas Graf tg...@suug.ch
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
drivers/net/vxlan.c| 23 +--
include/net/vxlan.h| 14 +-
net/openvswitch/Kconfig| 12 --
net/openvswitch/Makefile | 1
This allows to get rid of the get_name() vport ops later on.
Signed-off-by: Thomas Graf tg...@suug.ch
---
net/openvswitch/datapath.c | 4 ++--
net/openvswitch/vport-internal_dev.c | 1 -
net/openvswitch/vport-netdev.c | 6 --
net/openvswitch/vport-netdev.h | 1 -
net
This is the first step in representing all OVS vports as regular
struct net_devices. Move the net_device pointer into the vport
structure itself to get rid of struct vport_netdev.
Signed-off-by: Thomas Graf tg...@suug.ch
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
net/openvswitch
encapsulation for a large number of tunnel
endpoints and tunnel ids through a single net_device which improves
the scalability of current VXLAN tunnels.
Signed-off-by: Thomas Graf tg...@suug.ch
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
drivers/net/vxlan.c | 147
of tunnel
endpoints and virtual networks using a single tunnel net_device.
TODO:
- Geneve support
- IPv6 support
- Benchmarks
Pravin Shelar (1):
openvswitch: Use regular GRE net_device instead of vport
Thomas Graf (13):
ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic
ip_tunnel
This factors out the device configuration out of the RTNL newlink
API which allows for in-kernel creation of VXLAN net_devices.
Signed-off-by: Thomas Graf tg...@suug.ch
---
drivers/net/vxlan.c | 332
include/net/vxlan.h | 59 ++
2
Since ARP performs its own route lookup call, eventually
returned tunnel metadata must be attached manually.
Signed-off-by: Thomas Graf tg...@suug.ch
---
net/ipv4/arp.c | 8
1 file changed, 8 insertions(+)
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index 933a928..6cf0502 100644
This add the ability to select a routing table based on the tunnel
id which allows to maintain separate routing tables for each virtual
tunnel network.
ip rule add from all tunnel-id 100 lookup 100
ip rule add from all tunnel-id 200 lookup 200
Signed-off-by: Thomas Graf tg...@suug.ch
-off-by: Thomas Graf tg...@suug.ch
---
include/net/ip_fib.h | 3 +++
include/net/ip_tunnels.h | 1 -
include/net/route.h| 10
include/uapi/linux/rtnetlink.h | 16
net/ipv4/fib_frontend.c| 57 ++
net
With the removal of the special treating of OVS VXLAN vports, the
indirect call to vxlan_rcv() can be avoided and the VNI member
in vxlan_metadata can be removed.
Signed-off-by: Thomas Graf tg...@suug.ch
---
drivers/net/vxlan.c | 225 +---
include
From: Pravin Shelar pshe...@nicira.com
Removes all of the OVS specific GRE code and makes OVS use a
GRE net_device .
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
net/core/dev.c | 5 +-
net/ipv4/ip_gre.c | 161 -
.
Signed-off-by: Thomas Graf tg...@suug.ch
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
net/openvswitch/actions.c | 8 +-
net/openvswitch/datapath.c | 8 +++---
net/openvswitch/flow.h | 5
net/openvswitch/flow_netlink.c | 59
On 06/01/15 at 05:51pm, Robert Shearman wrote:
On 01/06/15 15:27, Thomas Graf wrote:
Introduces a new Netlink attribute RTA_TUNNEL which allows routes
to set tunnel transmit metadata and specify the tunnel endpoint or
tunnel id on a per route basis. The route must point to a tunnel
device
On 06/01/15 at 05:46pm, Robert Shearman wrote:
In order to be able to function as a Label Edge Router in an MPLS
network, it is necessary to be able to take IP packets and impose an
MPLS encap and forward them out. The traditional approach of setting
up an interface for each tunnel endpoint
On 05/15/15 at 08:06am, Herbert Xu wrote:
On Thu, May 14, 2015 at 07:37:56AM -0700, Eric Dumazet wrote:
This solves the corruption thanks Herbert.
Great.
But wasn't rhashtable meant to be faster ? ;)
Is it, that's news to me :)
Eric, can you share the scripts you used to test this?
On 05/06/15 at 11:58am, Nicolas Dichtel wrote:
More accurately, listen all netns that have a nsid assigned into the netns
where the netlink socket is opened.
For this purpose, a netlink socket option is added:
NETLINK_LISTEN_ALL_NSID. When this option is set on a netlink socket, this
socket
On 04/24/15 at 08:57am, Herbert Xu wrote:
It seems that I lost track somewhere along the line. I meant
to add an explicit limit on the overall number of entries since
that was what users like netlink expected but never got around
to doing it. Instead it seems that we're currently relying on
On 04/24/15 at 04:12pm, Herbert Xu wrote:
On Fri, Apr 24, 2015 at 09:06:08AM +0100, Thomas Graf wrote:
Which users are you talking about? Both Netlink and TIPC still
have an upper limit. nft sets are controlled by privileged users.
There is no limit in netlink apart from UINT_MAX AFAICS
.
This fixes the lost insertion issue and consequently allows my
code to display its error (and verify my fix for it.)
Signed-off-by: Johannes Berg johannes.b...@intel.com
Acked-by: Thomas Graf tg...@suug.ch
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
On 04/22/15 at 04:29pm, Cong Wang wrote:
On Wed, Apr 22, 2015 at 3:04 PM, Alexei Starovoitov a...@plumgrid.com wrote:
On 4/21/15 9:59 PM, Cong Wang wrote:
On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com
wrote:
ingress qdisc should return NET_XMIT_* values just
On 04/22/15 at 04:38pm, Cong Wang wrote:
On Wed, Apr 22, 2015 at 3:27 PM, Alexei Starovoitov a...@plumgrid.com wrote:
On 4/21/15 10:05 PM, Cong Wang wrote:
On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com
wrote:
introduce tc_classify_act() and qdisc_drop_bypass()
of rehashes
scheduled which lead to thousands of spinlocks to be taken
sequentially.
Instead, only allow either a series of resizes or a single rehash.
Drop any further rehashes and return -EBUSY.
Fixes: ccd57b1bd324 (rhashtable: Add immediate rehash during insertion)
Signed-off-by: Thomas Graf tg
likely to succeed. The insertion itself
will still fail to indicate pressure.
This fixes a bug where the table would never continue growing once the
utilization is above 100%.
Fixes: ccd57b1bd324 (rhashtable: Add immediate rehash during insertion)
Signed-off-by: Thomas Graf tg...@suug.ch
---
lib
Some rhashtable rehashing bugs found while testing with the
next rhashtable self-test queued up for the next devel cycle:
https://github.com/tgraf/net-next/commits/rht
v2:
- Moved schedule_work() call into rhashtable_insert_rehash()
Thomas Graf (2):
rhashtable: Schedule async resize when
On 04/21/15 at 10:10pm, David Miller wrote:
From: Herbert Xu herb...@gondor.apana.org.au
Date: Wed, 22 Apr 2015 08:36:34 +0800
On Tue, Apr 21, 2015 at 02:55:34PM +0200, Thomas Graf wrote:
When rhashtable_insert_rehash() fails with ENOMEM, this indicates that
we can't allocate
of rehashes
scheduled which lead to thousands of spinlocks to be taken
sequentially.
Instead, only allow either a series of resizes or a single rehash.
Drop any further rehashes and return -EBUSY.
Fixes: ccd57b1bd324 (rhashtable: Add immediate rehash during insertion)
Signed-off-by: Thomas Graf tg
Some rhashtable rehashing bugs found while testing with the
next rhashtable self-test queued up for the next devel cycle:
https://github.com/tgraf/net-next/commits/rht
Thomas Graf (2):
rhashtable: Schedule async resize when sync realloc fails
rhashtable: Do not schedule more than one rehash
likely to succeed. The insertion itself
will still fail to indicate pressure.
This fixes a bug where the table would never continue growing once the
utilization is above 100%.
Fixes: ccd57b1bd324 (rhashtable: Add immediate rehash during insertion)
Signed-off-by: Thomas Graf tg...@suug.ch
---
include
On 04/16/15 at 04:12pm, Herbert Xu wrote:
On Thu, Apr 16, 2015 at 05:02:15PM +1000, James Morris wrote:
They don't support namespaces, and maintaining the label is critical for
SELinux, at least, which mediates security for the system as a whole.
Thanks for the confirmation James, I
, the
netfilter mark must be preserved.
This patch rearranges skb_scrub_packet to preserve the mark field.
Fixes: ea23192e8e57 (tunnels: harmonize cleanup done on skb on rx path)
Signed-off-by: Herbert Xu herb...@gondor.apana.org.au
Acked-by: Thomas Graf tg...@suug.ch
We should also add a flag
Hello,
Before I continue to finish this work I'd like to get a few comments
on my implementation attempt.
The following patch implements the ETHTOOL_SSET and ETHTOOL_GSET
command via netlink. The individual commands are implemented as
separate functions and hooked into a table holding a
* Jeff Garzik [EMAIL PROTECTED] 2008-02-25 12:30
However, I would think it inconsistent to only do SSET/GSET. If others
are OK with this patch, are you open to implementing the full set of
ethtool operations?
Of course, I would also provide a documented userspace api within libnl.
--
To
-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.26/net/core/rtnetlink.c
===
--- net-2.6.26.orig/net/core/rtnetlink.c2008-02-22 01:50:53.0
+0100
+++ net-2.6.26/net/core/rtnetlink.c 2008-02-22 11:28:59.0
IFLA_LINK is no longer a write-only attribute on the kernel
side and must thus be validated. Same goes for the newly
introduced IFLA_LINKINFO.
Fixes undefined behaviour if either of the attributes are
not well formed.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.26/net/core
* Mark Seger [EMAIL PROTECTED] 2007-12-18 08:37
Anyhow, I just wanted to let people know that ALL tools that monitor
once a second on older counters will get the wrong numbers and tools
that correct for the wrong number by using fractional intervals (and I
suspect mine is the only one that
* Patrick McHardy [EMAIL PROTECTED] 2007-12-18 00:51
Chris Friesen wrote:
Patrick McHardy wrote:
From a kernel perspective there are only complete dumps, the
filtering is done by iproute. So the fact that it shows them
when querying specifically implies there is a bug in the
iproute
* Joerg Pommnitz [EMAIL PROTECTED] 2007-12-11 06:52
I think the leak comes from addr_msg_parser. The newly created address object
gets added to the cache with nl_cache_add wich takes a reference, so the
reference in addr_msg_parser should be dropped, e.g. the following patch
might be
RFC4303 introduces dummy packets with a nexthdr value of 59
to implement traffic confidentiality. Such packets need to
be dropped silently and the payload may not be attempted to
be parsed as it consists of random chunk.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.25/net/ipv4
RFC4303 introduces dummy packets with a nexthdr value of 59
to implement traffic confidentiality. Such packets need to
be dropped silently and the payload may not be attempted to
be parsed as it consists of random chunk.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.25/net/ipv6
* Dan Williams [EMAIL PROTECTED] 2007-10-23 10:10
Should I make NM disable ACKs for now until it gets fixed?
The reason libnl enables ACKs by default is to give the
application using it clear synchronisation points. For
change requests that means the interface function won't
return until the
+ provide us an output of strace with full buffers
send/received from netlink. Something like
strace -v -x -s 32768 nm
NM uses netlink in two places; libnl (from Thomas Graf) and some custom
code for listening for interface up/down events and wireless events.
It looks like that code comes
* Denis V. Lunev [EMAIL PROTECTED] 2007-10-23 17:09
I have reproduced the problem with one-line test.
./nl-route-get 192.168.1.1
The problem is with this message:
-- Debug: Sent Message:
-- BEGIN NETLINK MESSAGE
---
[HEADER] 16
* Denis V. Lunev [EMAIL PROTECTED] 2007-10-23 18:40
Revert to original netlink behavior. Do not reply with ACK if the
netlink dump has bees successfully started.
libnl has been broken by the cd40b7d3983c708aabe3d3008ec64ffce56d33b0
The following command reproduce the problem:
* Joe Perches [EMAIL PROTECTED] 2007-09-19 23:53
This removes the uses of NIPQUAD and HIPQUAD in
drivers/net and net
IPV4 Use:
DECLARE_IP_BUF(ipbuf);
__be32 addr;
print_ip(ipbuf, addr)
Signed-off-by: Joe Perches [EMAIL PROTECTED]
please pull from:
git pull
* Joe Perches [EMAIL PROTECTED] 2007-09-19 23:53
In the same vein as print_mac, the implementations
introduce declaration macros:
DECLARE_IP_BUF(var)
DECLARE_IPV6_BUF(var)
and functions:
print_ip
print_ipv6
print_ipv6_nofmt
IPV4 Use:
This change allows the generic attribute interface to be used within
the netfilter subsystem where this flag was initially introduced.
The byte-order flag is yet unused, it's intended use is to
allow automatic byte order convertions for all atomic types.
Signed-off-by: Thomas Graf [EMAIL
* Milan Kocian [EMAIL PROTECTED] 2007-09-12 16:50
However I still think that this notitfication is redundant. I tried to look
at XORP, bird, USAGI , quagga and to see RTM_DELLINK handling. And imho
nobody depends on RTM_DELLINK message from ipv6.
Send a patch to remove and we'll see if anyone
* Stephen Hemminger [EMAIL PROTECTED] 2007-09-06 16:10
Bug: http://bugzilla.kernel.org/show_bug.cgi?id=8876
Not all ips are shown by ip addr show command when IPs number assigned to an
interface is more than 60-80 (in fact it depends on broadcast/label etc
presence on each address).
The
* Herbert Xu [EMAIL PROTECTED] 2007-09-04 07:05
Thomas Graf [EMAIL PROTECTED] wrote:
I've been trying to reproduce this, what happens on my system
is that when the ISAKMP SA lifetime is exceeded the rekeying
fails and my connection dies. I can reproduce this back to
2.6.22
* David Miller [EMAIL PROTECTED] 2007-08-30 22:39
Every so often some piece of userland dies, and often it's
bad enough that my desktop session logs out.
I've been trying to find some clues and it seems to happen
about as often as openswan rekeys my VPN, so one suspect
area is the netlink
Fixes ancient ATM debug code to at least compile again.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/atm/signaling.c
===
--- net-2.6.24.orig/net/atm/signaling.c 2007-08-27 09:53:40.0 +0200
+++ net
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/drivers/net/82596.c
===
--- net-2.6.24.orig/drivers/net/82596.c 2007-08-27 14:43:16.0 +0200
+++ net-2.6.24/drivers/net/82596.c 2007-08-27 14:43:51.0
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_policy.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_policy.c 2007-08-24 13:11:17.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_policy.c 2007-08-24 13:11
* Masahide NAKAMURA [EMAIL PROTECTED] 2007-08-24 19:05
This is minor fix about sizeof argument using with kmemdup().
Thanks for catching this!
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
* Andrew Morton [EMAIL PROTECTED] 2007-08-21 22:54
Which used to be a BUG. It later oopsed via a null-pointer deref in
net_rx_action(), which is a much preferable result.
I fixed this already
Index: net-2.6.24/include/linux/netpoll.h
This patchset converts the xfrm netlink bits over to the type
safe netlink interface and does some cleanups.
xfrm_user.c | 1041
1 file changed, 433 insertions(+), 608 deletions(-)
-
To unsubscribe from this list: send the line
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-20 17:09:48.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 16:10
Uses nlmsg_parse() to parse the attributes. This actually changes
behaviour as unknown attributes (type MAXTYPE) no longer cause
an error. Instead unknown attributes will be ignored henceforth
to keep older kernels compatible with more recent userspace tools.
Signed-off-by: Thomas Graf [EMAIL
Moves all complex message size calculation into own inlined helper
functions and makes use of the type-safe netlink interface.
Using nlmsg_new() simplifies the calculation itself as it takes care
of the netlink header length by itself.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:10:34.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 16:12
These functions are only used once and are a lot easier to understand if
inlined directly into the function.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm
Adds alg_len() to calculate the properly padded length of an
algorithm attribute to simplify the code.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c
Increases readability a lot.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:10.0
+0200
+++ net-2.6.24/net/xfrm
-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:31:04.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:31:56.0
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:35:13.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:36
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:29.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:35
Also makes use of copy_sec_ctx() in another place and removes
duplicated code.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:15
This simplifies successful return codes from 0 to 0.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:13:57.0
+0200
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:12:20.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 16:13
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:36:59.0
+0200
+++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:37
Moves all of the SUB_POLICY ifdefs related to the attribute size
calculation into a function.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/net/xfrm/xfrm_user.c
===
--- net-2.6.24.orig/net/xfrm/xfrm_user.c
* Paul Moore [EMAIL PROTECTED] 2007-08-22 16:31
We're currently talking about several different ideas to solve the problem,
including leveraging the sk_buff.secmark field, and one of the ideas was to
add an additional field to the sk_buff structure. Knowing how well that idea
would go over
* Varun Chandramohan [EMAIL PROTECTED] 2007-08-20 13:46
The age field is filled with the current time at the time of creation of the
route. When the routes are dumped
then the age value stored in the route structure is subtracted from the
current time value and the difference is the age
* Varun Chandramohan [EMAIL PROTECTED] 2007-08-21 16:52
I know its a bit confusing but let me explain the reason. In my first
version patch i used fn_hash_insert() (place where alias is created)as
place to insert my current time in the age field.
This will eventually call fib_dump_info() for
The per cpu backlog napi struct can't do netpoll and has the
dev member set to NULL. Fixes an oops on boot when netpoll is
enabled.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6.24/include/linux/netpoll.h
===
--- net
* Felix Marti [EMAIL PROTECTED] 2007-08-20 12:02
These graphic adapters provide a wealth of features that you can take
advantage of to bring these amazing graphics to life. General purpose
CPUs cannot keep up. Chelsio offload devices do the same thing in the
realm of networking. - Will there
* Richard MUSIL [EMAIL PROTECTED] 2007-07-24 13:09
Thomas Graf wrote:
Please provide a new overall patch which is not based on your
initial patch so I can review your idea properly.
Here it goes (merging two previous patches). I have diffed
against v2.6.22, which I am using currently
* Waskiewicz Jr, Peter P [EMAIL PROTECTED] 2007-08-09 18:07
My big question is: Has anyone recently used the 802_3 protocol in tc
with u32 and actually gotten it to work? I can't see how the
u32_classify() code can look at the mac header, since it is using the
network header accessor to start
* Richard MUSIL [EMAIL PROTECTED] 2007-08-10 10:45
I have noticed that although ops for each family are the same (each
device is functionally same) I cannot use same genl_ops struct for
registration, because it uses internal member to link in list. Therefore
it is necessary to allocate new
* Waskiewicz Jr, Peter P [EMAIL PROTECTED] 2007-08-15 11:02
There is this very horrible way of using the u32 classifier
with a negative offset to look into the ethernet header.
Based on this, it sounds like u32 using protocol 802_3 is broken?
You might be expecting too much from u32. The
Introduces neigh_cleanup_and_release() to be used after a
neighbour has been removed from its neighbour table. Serves
as preparation to add event notifications.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/core/neighbour.c
. This allows to keep
track of neighbour states without periodically fetching the
complete neighbour table.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/core/neighbour.c
===
--- net-2.6.orig/net/core/neighbour.c 2007-07-22
replay label is unused otherwise.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/core/rtnetlink.c
===
--- net-2.6.orig/net/core/rtnetlink.c 2007-07-22 11:41:46.0 +0200
+++ net-2.6/net/core/rtnetlink.c
* Richard MUSIL [EMAIL PROTECTED] 2007-07-23 18:45
I have been giving it a second thought and came up with something more
complex. The idea is to have locking granularity at the level of
individual families.
I agree in general, it would make up a better solution.
However, your initial patch
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
===
--- net-2.6.orig/net/netlink/genetlink.c2007-07-23 21:54:35.0
+0200
+++ net-2.6/net/netlink/genetlink.c 2007-07-23 21:54
The current calculation of the maximum number of genetlink
multicast groups seems odd, fix it.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
===
--- net-2.6.orig/net/netlink/genetlink.c
family-mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
* Brian Haley [EMAIL PROTECTED] 2007-07-24 12:14
Thomas Graf wrote:
@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
void genl_unregister_mc_group(struct genl_family *family,
struct genl_multicast_group *grp)
{
-BUG_ON(grp-family != family
family-mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/netlink/genetlink.c
* Richard MUSIL [EMAIL PROTECTED] 2007-07-20 18:15
Patrick McHardy wrote:
Export the lock/unlock/.. functions. You'll also need a new version
similar to __rtnl_unlock.
Patrick, you might feel, I am not reading your lines, but in fact I do.
The problem is that I do not feel competent to
Introduces neigh_cleanup_and_release() to be used after a
neighbour has been removed from its neighbour table. Serves
as preparation to add event notifications.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/core/neighbour.c
. This allows to keep
track of neighbour states without periodically fetching the
complete neighbour table.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/core/neighbour.c
===
--- net-2.6.orig/net/core/neighbour.c 2007-07-22
replay label is unused otherwise.
Signed-off-by: Thomas Graf [EMAIL PROTECTED]
Index: net-2.6/net/core/rtnetlink.c
===
--- net-2.6.orig/net/core/rtnetlink.c 2007-07-22 11:41:46.0 +0200
+++ net-2.6/net/core/rtnetlink.c
* Miklos Szeredi [EMAIL PROTECTED] 2007-06-18 11:44
Garbage collection only ever happens, if the app is sending AF_UNIX
sockets over AF_UNIX sockets. Which is a rather rare case. And which
is basically why this bug went unnoticed for so long.
So my second patch only affects the performance
* Thomas Graf [EMAIL PROTECTED] 2007-06-18 12:32
* Miklos Szeredi [EMAIL PROTECTED] 2007-06-18 11:44
Garbage collection only ever happens, if the app is sending AF_UNIX
sockets over AF_UNIX sockets. Which is a rather rare case. And which
is basically why this bug went unnoticed for so
401 - 500 of 926 matches
Mail list logo
