Re: [RFC] add nl80211

2006-08-25 Thread Thomas Graf
* Johannes Berg [EMAIL PROTECTED] 2006-08-25 11:04 I completely reworked that now so it will: * create a nested NL80211_ATTR_INTERFACE_LIST with nested { * 1..N attributes, with nested { * ATTR_IFINDEX and * ATTR_IFNAME } } how does that sound? Maybe I should do the

Re: [NET_SCHED]: Add mask support to fwmark classifier

2006-08-25 Thread Thomas Graf
* Patrick McHardy [EMAIL PROTECTED] 2006-08-25 12:29 This patch adds support to mask the nfmark value before the lookup the the fw classifier. Unfortunately it has some drawbacks, so I'd be interested if anyone can think of a better way. The problem is that in order to avoid walking through

Re: [GIT PATCH] IPv6 Updates for net-2.6.19

2006-08-25 Thread Thomas Graf
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ [EMAIL PROTECTED] 2006-08-25 17:21 commit 10204d532f5f8bb379009ba0bee2113bafda72be Author: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Mon Aug 21 19:22:01 2006 +0900 [IPV6] ROUTE: Routing by FWMARK. Based on patch by Jean Lorchat [EMAIL

Re: [PATCH 0/3] [IPV6] Policy Routing Updates

2006-08-25 Thread Thomas Graf
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ [EMAIL PROTECTED] 2006-08-26 00:08 Hello. Here's some IPv6 policy rouging fixes on top of net-2.6.19 tree. [PATCH 1/3] [IPV6] ROUTE: Fix FWMARK support. [PATCH 2/3] [IPV6] ROUTE: Fix size of fib6_rule_policy. If we accept Patrick's IPv4 fwmask

Re: ProxyARP and IPSec

2006-08-24 Thread Thomas Graf
* David Miller [EMAIL PROTECTED] 2006-08-23 15:14 From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 23 Aug 2006 21:14:25 +0200 * H. Peter Anvin [EMAIL PROTECTED] 2006-08-22 17:31 Specifically, Linux will not ProxyARP for an address unless it has a route for it, *and* that route either

Re: [RFC] add nl80211

2006-08-24 Thread Thomas Graf
* Johannes Berg [EMAIL PROTECTED] 2006-08-22 15:52 +static struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] __read_mostly = { + [NL80211_ATTR_IFINDEX] = { .type = NLA_U32 }, + [NL80211_ATTR_WIPHY] = { .type = NLA_U32 }, + [NL80211_ATTR_FLAGS] = { .type = NLA_U32 }, +

Re: [RFC] add nl80211

2006-08-24 Thread Thomas Graf
* Johannes Berg [EMAIL PROTECTED] 2006-08-24 18:07 +static int nl80211_get_cmdlist(struct sk_buff *skb, struct genl_info *info) +{ + struct nl80211_registered_driver *drv; + struct sk_buff *msg; + void *hdr; + int err; + struct nlattr *start; + u8 *data; + +

Re: [RFC] make d80211 use nl80211

2006-08-24 Thread Thomas Graf
* Michael Buesch [EMAIL PROTECTED] 2006-08-24 19:09 On Thursday 24 August 2006 18:07, Johannes Berg wrote: + pkt = alloc_skb(framelen, GFP_KERNEL); if (!pkt) return -ENOMEM; + pktdata = skb_put(pkt, framelen); + memcpy(pktdata, frame, framelen); having two variables

Re: ProxyARP and IPSec

2006-08-23 Thread Thomas Graf
* H. Peter Anvin [EMAIL PROTECTED] 2006-08-22 17:31 Specifically, Linux will not ProxyARP for an address unless it has a route for it, *and* that route either has a DNAT marking or points to a different interface than the input interface: I can think of a very ugly way: Use netfilter to

[PATCH 2/2] [NETLINK]: Make use of NLA_STRING/NLA_NUL_STRING attribute validation

2006-08-22 Thread Thomas Graf
Converts existing NLA_STRING attributes to use the new validation features, saving a couple of temporary buffers. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/rtnetlink.c === --- net-2.6.19.git.orig

[PATCHSET] Validation for netlink string attributes

2006-08-22 Thread Thomas Graf
Validation of netlink string attributes was weak, forcing everyone to use nla_strlcpy() to copy the attribute into a temporary buffer. This patchset implements length validation checks for existing NLA_STRING attributes and adds a new type NLA_NUL_STRING for NUL terminated strings. - To

[PATCH 1/2] [NETLINK]: Improve string attribute validation

2006-08-22 Thread Thomas Graf
a maximum length of the string. Aims at easing the pain with using nla_strlcpy() on temporary buffers. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/netlink.h === --- net-2.6.19.git.orig/include/net/netlink.h

[RESEND 1/2] [NETLINK]: Improve string attribute validation

2006-08-22 Thread Thomas Graf
terminated is extended to provide means to specify a maximum length of the string. Aims at easing the pain with using nla_strlcpy() on temporary buffers. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/netlink.h

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-16 Thread Thomas Graf
* Herbert Xu [EMAIL PROTECTED] 2006-08-16 12:58 I'm not comfortable with that change since it implies the message originated from a user-space process. The netlink header pid is really akin to sadb_msg_pid from RFC 2367. IMHO it should always be zero if the kernel is the originator of the

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-16 Thread Thomas Graf
* Herbert Xu [EMAIL PROTECTED] 2006-08-16 21:12 On Wed, Aug 16, 2006 at 12:58:56PM +0200, Thomas Graf wrote: All route and tc notifications already use the pid so applications can decide whether the event was caused by them. A notification is a reply to a request so it doesn't even

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-16 Thread Thomas Graf
* Herbert Xu [EMAIL PROTECTED] 2006-08-16 21:57 On Wed, Aug 16, 2006 at 01:40:03PM +0200, Thomas Graf wrote: It was added to help quagga identify which route modifications are self caused. It's not possible to use rtm_protocol for this purpose as other applications can delete routes

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-16 Thread Thomas Graf
* jamal [EMAIL PROTECTED] 2006-08-16 08:04 current-pid i think is coming out to be a bad idea. Thomas' patches revert it out. Again this has everything to do with the original idea what maps to pid now changing to socketid. It probably developed from autobind using current-tid. - To

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-16 Thread Thomas Graf
* Herbert Xu [EMAIL PROTECTED] 2006-08-16 21:39 For a broadcast notification, the nlmsg_pid field is meaningless because the nlmsg_seq field is also meaningless. I'm not denying that it wouldn't be useful to have the originator's socket address in there. What I'm saying is that it's the

[PATCH 4/5] [IPv6] route: Convert FIB6 dumping to use new netlink api

2006-08-16 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/rtnetlink.c === --- net-2.6.19.git.orig/net/core/rtnetlink.c +++ net-2.6.19.git/net/core/rtnetlink.c @@ -188,22 +188,27 @@ void rtnl_set_sk_err(u32 group

[PATCH 2/5] [IPv6] route: Simplify ip6_ins_rt()

2006-08-16 Thread Thomas Graf
Provide a simple ip6_ins_rt() for the majority of users and an alternative for the exception via netlink. Avoids code obfuscation. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/ip6_route.h

[PATCH 3/5] [IPv6] route: FIB6 configuration using struct fib6_config

2006-08-16 Thread Thomas Graf
authorship information for notifications. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/ip6_fib.h === --- net-2.6.19.git.orig/include/net/ip6_fib.h +++ net-2.6.19.git/include/net/ip6_fib.h @@ -16,14 +16,35

[PATCHSET] IPv6 FIB configuration conversions

2006-08-16 Thread Thomas Graf
Same approach as for IPv4, simplifies the interface and makes it extendable without breaking the ioctl interface. Same memory corruption fixes in RTM_GETROUTE as for IPv4. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

[PATCH 5/5] [IPv6] route: Convert GETROUTE to use new netlink api

2006-08-16 Thread Thomas Graf
Fixes various unvalidated netlink attributes causing memory corruptions when left empty by userspace applications. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv6/route.c === --- net-2.6.19.git.orig/net

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-15 Thread Thomas Graf
* Hasso Tepper [EMAIL PROTECTED] 2006-08-15 15:08 Thomas Graf wrote: However, I changed IPv4 addresses to provide the pid and support NLM_F_ECHO and the same will follow for IPv6 address notifications which will mean that quagga sees a different set of IPv4 address notifications. Can

[PATCH 1/3] [IPv4]: FIB configuration using struct fib_config

2006-08-15 Thread Thomas Graf
will be used to carry the necessary netlink information to be used for notifications later on. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/ip_fib.h === --- net-2.6.19.git.orig/include/net/ip_fib.h

[PATCH 2/3] [IPv4]: Convert FIB dumping to use new netlink api

2006-08-15 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv4/fib_semantics.c === --- net-2.6.19.git.orig/net/ipv4/fib_semantics.c +++ net-2.6.19.git/net/ipv4/fib_semantics.c @@ -286,7 +286,7 @@ void rtmsg_fib(int event

[PATCHSET] IPv4 FIB configuration conversions

2006-08-15 Thread Thomas Graf
Replaces the rather ugly struct kern_rta + rtmsg with a new struct fib_config while converting everything to the new netlink api. Simplifies the FIB module interface quite a bit and allows changing internals while keeping a stable netlink interface. Gets rid of things like passing on

[PATCH 3/3] [IPv4]: Convert route get to new netlink api

2006-08-15 Thread Thomas Graf
Fixes various unvalidated netlink attributes causing memory corruptions when left empty by userspace applications. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/ip_fib.h === --- net-2.6.19.git.orig

[PATCH 01/16] [RTNETLINK]: Use rtnl_unicast() for rtnetlink unicasts

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/linux/rtnetlink.h === --- net-2.6.19.git.orig/include/linux/rtnetlink.h +++ net-2.6.19.git/include/linux/rtnetlink.h @@ -584,6 +584,7 @@ struct rtnetlink_link

[PATCHSET] rtnetlink notification rework

2006-08-14 Thread Thomas Graf
This patchset reworks rtnetlink notifications. Notification logic is fixed and gets hidden behind nlmsg_notify() and the rtnl socket is no longer directly accessed. All notification paths get appropriate error handling. NLM_F_ECHO support is added where it makes sense and no major surgery is

[PATCH 14/16] [WIRELESS]: Convert notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/wireless.c === --- net-2.6.19.git.orig/net/core/wireless.c +++ net-2.6.19.git/net/core/wireless.c @@ -85,6 +85,7 @@ #include linux/wireless.h

[PATCH 08/16] [IPv4] route: Convert route notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv4/fib_semantics.c === --- net-2.6.19.git.orig/net/ipv4/fib_semantics.c +++ net-2.6.19.git/net/ipv4/fib_semantics.c @@ -33,7 +33,6 @@ #include linux/if_arp.h

[PATCH 05/16] [NEIGH]: Convert neighbour notifications ot use rtnl_notify()

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2.6.19.git/net/core/neighbour.c @@ -2406,36 +2406,35 @@ static struct file_operations

[PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current-pid as netlink pid. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv6/addrconf.c === --- net-2.6.19.git.orig/net/ipv6/addrconf.c +++ net-2.6.19.git/net/ipv6/addrconf.c @@ -73,6

[PATCH 03/16] [RTNETLINK]: Add rtnetlink notification interface

2006-08-14 Thread Thomas Graf
Adds rtnl_notify() to send rtnetlink notification messages and rtnl_set_sk_err() to report notification errors as socket errors in order to indicate the need of a resync due to loss of events. nlmsg_report() is added to properly document the meaning of NLM_F_ECHO. Signed-off-by: Thomas Graf

[PATCH 16/16] [RTNETLINK]: Unexport rtnl socket

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/linux/rtnetlink.h === --- net-2.6.19.git.orig/include/linux/rtnetlink.h +++ net-2.6.19.git/include/linux/rtnetlink.h @@ -574,8 +574,6 @@ extern int

[PATCH 02/16] [NETLINK]: Add notification message sending interface

2006-08-14 Thread Thomas Graf
. nlmsg_multicast() is extended to take allocation flags to allow notification in atomic contexts. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/netlink.h === --- net-2.6.19.git.orig/include/net/netlink.h

[PATCH 13/16] [BRIDGE]: Convert notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current-pid as netlink pid. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/bridge/br_netlink.c === --- net-2.6.19.git.orig/net/bridge/br_netlink.c +++ net-2.6.19.git/net/bridge

[PATCH 12/16] [IPv6] prefix: Convert prefix notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current-pid as netlink pid. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv6/addrconf.c === --- net-2.6.19.git.orig/net/ipv6/addrconf.c +++ net-2.6.19.git/net/ipv6/addrconf.c

[PATCH 15/16] [NET] link: Convert notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/rtnetlink.c === --- net-2.6.19.git.orig/net/core/rtnetlink.c +++ net-2.6.19.git/net/core/rtnetlink.c @@ -630,20 +630,22 @@ static int rtnl_dump_all(struct

[PATCH 06/16] [DECNET]: Convert DECnet notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/decnet/dn_dev.c === --- net-2.6.19.git.orig/net/decnet/dn_dev.c +++ net-2.6.19.git/net/decnet/dn_dev.c @@ -746,20 +746,23 @@ rtattr_failure: static void

[PATCH 10/16] [IPv6] route: Convert route notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current-pid as netlink pid. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv6/route.c === --- net-2.6.19.git.orig/net/ipv6/route.c +++ net-2.6.19.git/net/ipv6/route.c @@ -35,7 +35,6

[PATCH 11/16] [IPv6] link: Convert link notifications to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Fixes a wrong use of current-pid as netlink pid. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv6/addrconf.c === --- net-2.6.19.git.orig/net/ipv6/addrconf.c +++ net-2.6.19.git/net/ipv6/addrconf.c

[PATCH 07/16] [IPv4] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Adds support for NLM_F_ECHO allowing applications to easly see which address have been deleted, added, or promoted. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv4/devinet.c === --- net-2.6.19.git.orig

[PATCH 04/16] [NET] fib_rules: Convert fib rule notification to use rtnl_notify()

2006-08-14 Thread Thomas Graf
Adds support for NLM_F_ECHO to simplify the process of identifying inserted rules with an auto generated priority. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/fib_rules.c === --- net-2.6.19.git.orig

Re: [RFC 5/7] neighbour: convert lookup to sequence lock

2006-08-14 Thread Thomas Graf
* Stephen Hemminger [EMAIL PROTECTED] 2006-08-14 14:20 --- net-2.6.19.orig/net/core/neighbour.c +++ net-2.6.19/net/core/neighbour.c @@ -1160,19 +1164,24 @@ int neigh_resolve_output(struct sk_buff if (!neigh_event_send(neigh, skb)) { int err; struct

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-14 Thread Thomas Graf
* jamal [EMAIL PROTECTED] 2006-08-14 19:43 On Mon, 2006-14-08 at 00:00 +0200, Thomas Graf wrote: plain text document attachment (rtnl_convert_ip6_addr) Fixes a wrong use of current-pid as netlink pid. If i am not mistaken: Some of these removals of current-pid will affect users

Re: [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()

2006-08-12 Thread Thomas Graf
* Alexey Kuznetsov [EMAIL PROTECTED] 2006-08-12 15:03 Actually, it was the idea. If requestor asked NLM_F_ECHO and subscribed to muticasts, it suppresses double notifications. If it did not ask NLM_F_ECHO, he is not interested in results, he knows what's going on without this. F.e. it was

Re: [NET 00/06]: Increase number of possible routing tables

2006-08-11 Thread Thomas Graf
* Michael Tokarev [EMAIL PROTECTED] 2006-08-11 10:56 And while we're at it... How about using table *names* instead of numbers in kernel too, a-la iptables? Once possible number of tables is large, and we're using hashes for tables now anyway, keeping a name inside the table structure wont

Re: [PATCH 3/4] [NETLINK]: Dont set socket error for failed event notifications

2006-08-11 Thread Thomas Graf
* David Miller [EMAIL PROTECTED] 2006-08-10 23:02 Thomas, there was a conflict which I did expect since I added all the 2.6.18 bug fixes into the tree. The conflict is for your netlink conversion of the iflink stuff. I had to fix the -stable tree IFLA_ADDRESS handling because

Re: [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()

2006-08-11 Thread Thomas Graf
* Alexey Kuznetsov [EMAIL PROTECTED] 2006-08-11 19:35 Well, tc was supposed to use it, but this did not happen and it remained deficient. Makes sense, especially for auto generated handles. I've been listening to the notifications on a separate socket for this purpose. It would make sense

Re: [PATCH 0/6] htb: cleanup

2006-08-10 Thread Thomas Graf
* David Miller [EMAIL PROTECTED] 2006-08-02 15:18 From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 2 Aug 2006 12:56:36 -0700 The HTB scheduler code is a mess, this patch set does some basic house cleaning. The first four should cause no code change, but the last two need more

Re: [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()

2006-08-10 Thread Thomas Graf
* Alexey Kuznetsov [EMAIL PROTECTED] 2006-08-10 19:51 This patch handles NLM_F_ECHO in netlink_rcv_skb() to handle it in a central point. Most subsystems currently interpret NLM_F_ECHO as to just unicast events to the originator of the change while the real meaning of the flag is to echo

Re: [PATCH 3/4] [NETLINK]: Dont set socket error for failed event notifications

2006-08-10 Thread Thomas Graf
* Patrick McHardy [EMAIL PROTECTED] 2006-08-10 20:09 Thomas Graf wrote: Setting a socket error on all sockets subscribed to a group if an event notificiation of said group fails due to memory pressure only confuses applications and is of no use. This patch removes it all together

Re: [PATCH 3/4] [NETLINK]: Dont set socket error for failed event notifications

2006-08-10 Thread Thomas Graf
* Patrick McHardy [EMAIL PROTECTED] 2006-08-10 21:08 The error code (-ENOMEM) gives it a pretty good idea what went wrong. Its true that it doesn't know which group was affected (that could be fixed), but at least it knows that something went wrong and it needs to resync. If that fails due to

Re: [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()

2006-08-10 Thread Thomas Graf
Hello * Alexey Kuznetsov [EMAIL PROTECTED] 2006-08-11 00:32 Nothing! NLM_F_ECHO _is_ listening for notifications without subscription to multicast groups and need to figure out what messages are yours. But beyond this NLM_F_ECHO is totally subset of this. Which still makes much more sense

Re: [PATCH][IPV6]: Make sure fib6_rule_lookup doesn't return NULL

2006-08-09 Thread Thomas Graf
* Ville Nuorvala [EMAIL PROTECTED] 2006-08-09 11:36 Of the three original route lookup functions (ip6_route_input, ip6_route_output and rt6_lookup), rt6_lookup was the only one that was allowed to produce a NULL entry. Of these three rt6_lookup was also the only one not actually being used for

Re: Rules and groups

2006-08-09 Thread Thomas Graf
* Steven Whitehouse [EMAIL PROTECTED] 2006-08-09 09:01 With your new protocol independent rules code, I see that there is an entry in struct fib_rules_ops for a netlink group for notification of rule changes. For whatever reason (historical I guess) DECnet has never had a nl group assigned for

Re: [PATCH][IPV6]: Make sure fib6_rule_lookup doesn't return NULL

2006-08-09 Thread Thomas Graf
* Ville Nuorvala [EMAIL PROTECTED] 2006-08-09 12:42 Ok, it might require quite big changes to the existing code, but if someone is willing to take a look at it I wouldn't be against it :-) I'll provide a patch soon. You know, I'm starting to think we could perhaps get rid of ip6_null_entry

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Thomas Graf
* Daniel Phillips [EMAIL PROTECTED] 2006-08-08 22:47 David Miller wrote: From: Daniel Phillips [EMAIL PROTECTED] Can you please characterize the conditions under which skb-dev changes after the alloc? Are there writings on this subtlety? The packet scheduler and classifier can redirect

Re: Rules and groups

2006-08-09 Thread Thomas Graf
* Steven Whitehouse [EMAIL PROTECTED] 2006-08-09 11:03 On Wed, Aug 09, 2006 at 01:01:25AM -0700, David Miller wrote: From: Steven Whitehouse [EMAIL PROTECTED] Date: Wed, 9 Aug 2006 09:01:39 +0100 Is there anything to stop me using RTNLGRP_NOP3 for that? (suitable renamed of course!)

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-09 Thread Thomas Graf
* Peter Zijlstra [EMAIL PROTECTED] 2006-08-09 16:07 I think Daniel was thinking of adding struct net_device * sk_buff::alloc_dev, I know I was after reading the first few mails. However if adding a field there is strict no-no /me takes a look at struct sk_buff Hmm, what does

[PATCHSET]: Clean up netlink NLM_F_ECHO and rtnl event notifications

2006-08-09 Thread Thomas Graf
Aims at cleaning up rtnetlink event notifications and implements real NLM_F_ECHO support. Please disregard my last IPv4 routing related patchset, I'll resubmit it based on this patchset. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()

2006-08-09 Thread Thomas Graf
events to the originator of the change while the real meaning of the flag is to echo the request. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/netlink/af_netlink.c === --- net-2.6.19.git.orig/net/netlink

[PATCH 3/4] [NETLINK]: Dont set socket error for failed event notifications

2006-08-09 Thread Thomas Graf
Setting a socket error on all sockets subscribed to a group if an event notificiation of said group fails due to memory pressure only confuses applications and is of no use. This patch removes it all together. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/bridge

[PATCH 4/4] [RTNETLINK]: Unexport global rtnl sock

2006-08-09 Thread Thomas Graf
All references to the rtnl sock are now done via wrapper functions, unexport it. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/linux/rtnetlink.h === --- net-2.6.19.git.orig/include/linux/rtnetlink.h

[RESEND 2/4] [RTNETLINK]: Use rtnl_multicast()/rtnl_unicast()

2006-08-09 Thread Thomas Graf
by themselves and properly feeds all calls to netlink_broadcast() with a pid of 0 to not exclude any sockets. Removes the obsoleted NLM_F_ECHO code. Some notifications are done in atomic contex, therefore nlmsg_multicast() had to be extended to take allocation flags. Signed-off-by: Thomas Graf [EMAIL

[PATCH 2/3] [IPv4]: Convert FIB dumping to use new netlink api

2006-08-08 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/ipv4/fib_semantics.c === --- net-2.6.19.git.orig/net/ipv4/fib_semantics.c +++ net-2.6.19.git/net/ipv4/fib_semantics.c @@ -286,7 +286,7 @@ void rtmsg_fib(int event

[PATCH 3/3] [IPv4]: Convert route get to new netlink api

2006-08-08 Thread Thomas Graf
Fixes various unvalidated netlink attributes causing memory corruptions when left empty by userspace applications. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/ip_fib.h === --- net-2.6.19.git.orig

[PATCHSET] IPv4 FIB configuration rework

2006-08-08 Thread Thomas Graf
Replaces the rather ugly struct kern_rta + rtmsg with a new struct fib_config while converting everything to the new netlink api. Simplifies the FIB module interface quite a bit and allows changing internals while keeping a stable netlink interface. Gets rid of things like passing on

[PATCH 1/3] [IPv4]: FIB configuration using struct fib_config

2006-08-08 Thread Thomas Graf
pid of the requesting process is stored in fib_config, it is no longer required to pass netlink_skb_parms all along just for event notification. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/net/ip_fib.h

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-08 Thread Thomas Graf
* Peter Zijlstra [EMAIL PROTECTED] 2006-08-08 21:33 +struct sk_buff *__netdev_alloc_skb(struct net_device *dev, + unsigned length, gfp_t gfp_mask) +{ + struct sk_buff *skb; + + if (dev (dev-flags IFF_MEMALLOC)) { + WARN_ON(gfp_mask (__GFP_NOMEMALLOC |

Re: [PATCH][IPV6]: Make sure fib6_rule_lookup doesn't return NULL

2006-08-08 Thread Thomas Graf
* Ville Nuorvala [EMAIL PROTECTED] 2006-08-09 01:05 [IPV6]: Make sure fib6_rule_lookup doesn't return NULL The callers of fib6_rule_lookup don't expect it to return NULL, therefore it must return ip6_null_entry whenever fib_rule_lookup fails. Signed-off-by: Ville

Re: [PATCH 1/3] [IPv4]: FIB configuration using struct fib_config

2006-08-08 Thread Thomas Graf
* Thomas Graf [EMAIL PROTECTED] 2006-08-08 00:00 Introduces struct fib_config replacing the ugly struct kern_rta prone to ordering issues. Avoids creating faked netlink messages for auto generated routes or requests via ioctl. A new interface net/nexthop.h is added to help navigate through

[PATCH 1/7] [NEIGH]: Convert neighbour deletion to new netlink api

2006-08-07 Thread Thomas Graf
Fixes: Return ENOENT if the neighbour is not found (was EINVAL) Return EAFNOSUPPORT if no table matches the specified address family. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/neighbour.c

[PATCHSET] Convert neighbour code to new netlink api

2006-08-07 Thread Thomas Graf
Pretty much straight forward, some minor fixes that go along with it. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/7] [NEIGH]: Convert neighbour addition to new netlink api

2006-08-07 Thread Thomas Graf
Fixes: Return EAFNOSUPPORT if no table matches the specified address family. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net

[PATCH 3/7] [NEIGH]: Convert neighbour dumping to new netlink api

2006-08-07 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2.6.19.git/net/core/neighbour.c @@ -1898,48 +1898,49 @@ out: return skb-len

[PATCH 4/7] [NEIGH]: Move netlink neighbour bits to linux/neighbour.h

2006-08-07 Thread Thomas Graf
, remove dependency on obsolete and buggy rta_buf. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/linux/neighbour.h === --- /dev/null +++ net-2.6.19.git/include/linux/neighbour.h @@ -0,0 +1,65 @@ +#ifndef

[PATCH 5/7] [NEIGH]: Convert neighbour table modification to new netlink api

2006-08-07 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2.6.19.git/net/core/neighbour.c @@ -1751,28 +1751,61 @@ static inline struct neigh_parms

[PATCH 6/7] [NEIGH]: Convert neighbour table dumping to new netlink api

2006-08-07 Thread Thomas Graf
Also fixes skipping of already dumped neighbours. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/net/core/neighbour.c === --- net-2.6.19.git.orig/net/core/neighbour.c +++ net-2.6.19.git/net/core/neighbour.c

[PATCH 7/7] [NEIGH]: Move netlink neighbour table bits to linux/neighbour.h

2006-08-07 Thread Thomas Graf
rtnetlink_rcv_msg() is not longer required to parse attributes for the neighbour tables layer, remove dependency on obsolete and buggy rta_buf. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/include/linux/neighbour.h

[SELinux]: selinux_socket_getpeersec_dgram() compile fix

2006-08-05 Thread Thomas Graf
Collision between [NetLabel]: SELinux support and [AF_UNIX]: Kernel memory leak fix for af_unix datagram getpeersec Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19.git/security/selinux/hooks.c === --- net-2.6.19

[PATCHSET] Multiple IPV6 Routing Tables Policy Routing

2006-08-04 Thread Thomas Graf
Hello, This patchset implements multiple IPv6 routing tables and policy routing. Even though the code is almost rewritten entirely the work is based on the MIPL patch found on mobile-ipv6.org which is being jointly developed by Helsinki University of Technology (HUT) and the USAGI/WIDE Project.

[PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency

2006-08-04 Thread Thomas Graf
(Ab)using rt6_lock wouldn't work anymore if rt6_lock is converted into a per table lock. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/net/ipv6/route.c === --- net-2.6.19.orig/net/ipv6/route.c +++ net-2.6.19/net

[PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-08-04 Thread Thomas Graf
Derived from net/ipv/fib_rules.c Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/include/linux/fib_rules.h === --- /dev/null +++ net-2.6.19/include/linux/fib_rules.h @@ -0,0 +1,60 @@ +#ifndef __LINUX_FIB_RULES_H

[PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-08-04 Thread Thomas Graf
Adds the framework to support multiple IPv6 routing tables. Currently all automatically generated routes are put into the same table. This could be changed at a later point after considering the produced locking overhead. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/include/net

[PATCH 5/5] [IPV4]: Use Protocol Independant Policy Routing Rules Framework

2006-08-04 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/include/net/ip_fib.h === --- net-2.6.19.orig/include/net/ip_fib.h +++ net-2.6.19/include/net/ip_fib.h @@ -18,6 +18,7 @@ #include net/flow.h #include linux/seq_file.h

[PATCH 4/5] [IPV6]: Policy Routing Rules

2006-08-04 Thread Thomas Graf
Adds support for policy routing rules including a new local table for routes with a local destination. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/net/ipv6/fib6_rules.c === --- /dev/null +++ net-2.6.19/net/ipv6

Re: [PATCHSET] Multiple IPV6 Routing Tables Policy Routing

2006-08-04 Thread Thomas Graf
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ [EMAIL PROTECTED] 2006-08-05 00:58 In article [EMAIL PROTECTED] (at Fri, 04 Aug 2006 12:23:08 +0200), Thomas Graf [EMAIL PROTECTED] says: This patchset implements multiple IPv6 routing tables and policy routing. Even though the code is almost rewritten

[PATCH 1/9] [NETLINK]: Extend netlink messaging interface

2006-08-04 Thread Thomas Graf
attribute in nested attributes Fixes nlmsg_new() to take allocation flags and consider size. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/include/net/netlink.h === --- net-2.6.19.orig/include/net/netlink.h +++ net-2.6.19

[PATCH 3/9] [IPV4]: Convert address addition to new netlink api

2006-08-04 Thread Thomas Graf
Adds rtm_to_ifaddr() transforming a netlink message to a struct in_ifaddr. Fixes various unvalidated netlink attributes causing memory corruptions when left empty by userspace applications. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/net/ipv4/devinet.c

[PATCH 7/9] [NET]: Convert link modification to new netlink api

2006-08-04 Thread Thomas Graf
on to atomic netlink operations without obsoleting some of the functionality. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/net/core/rtnetlink.c === --- net-2.6.19.orig/net/core/rtnetlink.c +++ net-2.6.19/net/core

[PATCH 4/9] [IPV4]: Convert address deletion to new netlink api

2006-08-04 Thread Thomas Graf
Fixes various unvalidated netlink attributes causing memory corruptions when left empty by userspace. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/net/ipv4/devinet.c === --- net-2.6.19.orig/net/ipv4/devinet.c

[PATCH 6/9] [IPv4]: Move interface address bits to linux/if_addr.h

2006-08-04 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/include/linux/if_addr.h === --- /dev/null +++ net-2.6.19/include/linux/if_addr.h @@ -0,0 +1,53 @@ +#ifndef __LINUX_IF_ADDR_H +#define __LINUX_IF_ADDR_H + +#include linux

[PATCH 9/9] [NET]: Move netlink interface bits to linux/if.h

2006-08-04 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/include/linux/if.h === --- net-2.6.19.orig/include/linux/if.h +++ net-2.6.19/include/linux/if.h @@ -212,5 +212,134 @@ struct ifconf #defineifc_buf

[PATCH 8/9] [NET]: Convert link dumping to new netlink api

2006-08-04 Thread Thomas Graf
troubles later on. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.19/net/core/rtnetlink.c === --- net-2.6.19.orig/net/core/rtnetlink.c +++ net-2.6.19/net/core/rtnetlink.c @@ -218,41 +218,73 @@ static void set_operstate

Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-31 Thread Thomas Graf
* Ville Nuorvala [EMAIL PROTECTED] 2006-07-31 17:46 Derived from net/ipv6/fib_rules.c do you mean net/ipv4/fib_rules.c or net/ipv6/fib6_rules.c? :-) Hehe, I meant net/ipv4/fib_rules.c :-) +struct fib_rule_hdr +{ + __u8family; + __u8dst_len; + __u8

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-31 Thread Thomas Graf
* Ville Nuorvala [EMAIL PROTECTED] 2006-07-31 16:55 When locating routes for redirects only the main table is searched for now. Since policy rules will not be reversible it is unclear whether it makes sense to change this. This is a good point. You are absolutely correct about the policy

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-31 Thread Thomas Graf
* Herbert Xu [EMAIL PROTECTED] 2006-08-01 00:01 Without a route cache, I think our only choice is to search through all tables. The same thing applies to PMTU updates as well. I think PMTU etc. should be moved out of the route into a some form of flow cache. It's currently using rt6_lookup()

<    3   4   5   6   7   8   9   10   >