[PATCH v4 1/2] net: 3com: typhoon: typhoon_init_one: fix incorrect return values

Reported-by: Pan Bian Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index 9fe3990..25f2e92

Re: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

On Tue, 2016-12-27 at 22:17:35 +0100, David Dillow wrote: >On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote: >> In some cases the return value of a failing function is not being used >> and the function typhoon_init_one() returns another negative error >> code ins

[PATCH v4 2/2] net: 3com: typhoon: typhoon_init_one: make return values more specific

In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 16 1 file changed, 8

[PATCH v3 1/2] drivers: net: ethernet: 3com: fix return value

Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index a0cacbe..c88b88a 100644 --- a/drivers/net

Re: Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

Hello. On Sat, 2016-12-24 at 20:06 +0100, Sergei Shtylyov wrote: >Hello! > >On 12/24/2016 03:02 PM, Thomas Preisner wrote: > >> In a few cases the err-variable is not set to a negative error code if a >> function call fails and thus 0 is returned instead. >> It m

[PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 16 1 file changed, 8

[PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index a0cacbe..c88b88a 100644 --- a/drivers/net

Re: [PATCH] drivers: net: ethernet: 3com: fix return value

On Sat, 2016-12-24 at 02:06 +0100, David Dillow wrote: >On Sat, 2016-12-24 at 00:00 +0100, Thomas Preisner wrote: >> diff --git a/drivers/net/ethernet/3com/typhoon.c >> b/drivers/net/ethernet/3com/typhoon.c >> index a0cacbe..9a3ab58 100644 >> --- a/drivers/net/ether

[PATCH v2 2/2] drivers: net: ethernet: 3com: fix return value

In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 16 1 file changed, 8

[PATCH] drivers: net: ethernet: 3com: fix return value

-off-by: Thomas Preisner Signed-off-by: Milan Stephan --- drivers/net/ethernet/3com/typhoon.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index a0cacbe..9a3ab58 100644 --- a/drivers/net/ethernet/3com/typhoon.c