[PATCH net-next 4/6] igc: enable auxiliary PHC functions for the i225

2021-04-16 Thread Tony Nguyen
ly a NIC can expose a single PTP device. Signed-off-by: Ederson de Souza Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc.h | 11 + drivers/net/ethernet/intel/igc/igc_defines.h | 63 + drivers/net/ethernet/intel/igc/igc_main.c

[PATCH net-next 6/6] igc: Expose LPI counters

2021-04-16 Thread Tony Nguyen
From: Sasha Neftin Expose EEE Tx and Rx low power idle counters via ethtool A EEE TX or RX LPI event occurs when the transmitter or the receiver enters EEE (IEEE802.3az) LPI state. ethtool --statistics Signed-off-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen

[PATCH net-next 0/6][pull request] 1GbE Intel Wired LAN Driver Updates 2021-04-16

2021-04-16 Thread Tony Nguyen
This series contains updates to igb and igc drivers. Ederson adjusts Tx buffer distributions in Qav mode to improve TSN-aware traffic for igb. He also enable PPS support and auxiliary PHC functions for igc. Grzegorz checks that the MTA register was properly written and retries if not for igb. Sa

[PATCH net-next 5/6] igc: Fix overwrites return value

2021-04-16 Thread Tony Nguyen
From: Sasha Neftin drivers/net/ethernet/intel/igc/igc_i225.c:235 igc_write_nvm_srwr() warn: loop overwrites return value 'ret_val' Reported-by: Dan Carpenter Signed-off-by: Sasha Neftin Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_

[PATCH net-next 3/6] igc: Enable internal i225 PPS

2021-04-16 Thread Tony Nguyen
. The PTP subsystem exposes the PPS events via ioctl and sysfs, and one can use the `testptp` tool (tools/testing/selftests/ptp) to check that the events are being generated. Signed-off-by: Ederson de Souza Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc

[PATCH net-next 1/6] igb: Redistribute memory for transmit packet buffers when in Qav mode

2021-04-16 Thread Tony Nguyen
: Tony Nguyen --- drivers/net/ethernet/intel/igb/e1000_defines.h | 8 drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/e1000_defines.h b/drivers/net/ethernet/intel/igb/e1000_defines.h index

[PATCH net-next 2/6] igb: Add double-check MTA_REGISTER for i210 and i211

2021-04-16 Thread Tony Nguyen
this patch there is possibility that multicast settings will be not always set correctly in hardware. Signed-off-by: Grzegorz Siwik Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igb/e1000_mac.c | 27 ++ 1 file changed, 27 insertions

[PATCH net-next 15/15] ice: reduce scope of variable

2021-04-14 Thread Tony Nguyen
From: Paul M Stillwell Jr The scope of this variable can be reduced so do that. Signed-off-by: Paul M Stillwell Jr Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH net-next 13/15] ice: suppress false cppcheck issues

2021-04-14 Thread Tony Nguyen
From: Bruce Allan Silence false errors, warnings and style issues reported by cppcheck. Signed-off-by: Bruce Allan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 3 +++ drivers/net/ethernet/intel/ice/ice_nvm.c | 1 + drivers

[PATCH net-next 11/15] ice: remove unused struct member

2021-04-14 Thread Tony Nguyen
printing the value of the field in a debug print, but don't store the value forever in a struct, potentially creating opportunities for callers to use the wrong struct member. Signed-off-by: Jesse Brandeburg Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/inte

[PATCH net-next 02/15] ice: Drop leading underscores in enum ice_pf_state

2021-04-14 Thread Tony Nguyen
From: Anirudh Venkataramanan Remove the leading underscores in enum ice_pf_state. This is not really communicating anything and is unnecessary. No functional change. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice

[PATCH net-next 06/15] ice: manage interrupts during poll exit

2021-04-14 Thread Tony Nguyen
lete a ping pong. Signed-off-by: Jesse Brandeburg Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 1 + drivers/net/ethernet/intel/ice/ice_txrx.c | 13 - 2 files changed, 13 insertions(+), 1 deletion(-) diff --g

[PATCH net-next 12/15] ice: Set vsi->vf_id as ICE_INVAL_VFID for non VF VSI types

2021-04-14 Thread Tony Nguyen
by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index 0443338f9eaf..eb6e352d3387 100644 --- a/drivers/net/ethernet/i

[PATCH net-next 14/15] ice: remove return variable

2021-04-14 Thread Tony Nguyen
From: Paul M Stillwell Jr We were saving the return value from ice_vsi_manage_rss_lut(), but the errors from that function are not critical so change it to return void and remove the code that saved the value. Signed-off-by: Paul M Stillwell Jr Tested-by: Tony Brelinski Signed-off-by: Tony

[PATCH net-next 04/15] ice: refactor interrupt moderation writes

2021-04-14 Thread Tony Nguyen
was doing both a store and a set in a helper function, which seems better done as separate tasks in the caller (and generally takes less lines of code even with a tiny bit of repetition). Signed-off-by: Jesse Brandeburg Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net

[PATCH net-next 08/15] ice: Reimplement module reads used by ethtool

2021-04-14 Thread Tony Nguyen
-by: Scott W Taylor Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 49 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice

[PATCH net-next 10/15] ice: use local for consistency

2021-04-14 Thread Tony Nguyen
From: Jesse Brandeburg Do a minor refactor on ice_vsi_rebuild to use a local variable to store vsi->type. Signed-off-by: Jesse Brandeburg Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_lib.c | 12 +++- 1 file changed, 7 insertions(+)

[PATCH net-next 01/15] ice: use kernel definitions for IANA protocol ports and ether-types

2021-04-14 Thread Tony Nguyen
Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 3 +++ drivers/net/ethernet/intel/ice/ice_dcb.c | 8 drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 2 +- drivers/net/ethernet/intel/ice/ice_type.h| 3 --- 4 files changed, 8 insertions(+), 8 deletions

[PATCH net-next 09/15] ice: print name in /proc/iomem

2021-04-14 Thread Tony Nguyen
+ 9c00-9dff : ice 9e00-9eff : :3b:00.1 9f00-9fff : :3b:00.0 a000-a000 : :3b:00.1 Signed-off-by: Jesse Brandeburg Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file chang

[PATCH net-next 05/15] ice: replace custom AIM algorithm with kernel's DIM library

2021-04-14 Thread Tony Nguyen
f using DIMLIB is that we meet or exceed our performance expectations set based on the old algorithm. Co-developed-by: Jesse Brandeburg Signed-off-by: Jesse Brandeburg Signed-off-by: Jacob Keller Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/Kconfig

[PATCH net-next 07/15] ice: refactor ITR data structures

2021-04-14 Thread Tony Nguyen
Signed-off-by: Jesse Brandeburg Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_base.c| 3 ++ drivers/net/ethernet/intel/ice/ice_ethtool.c | 15 +- drivers/net/ethernet/intel/ice/ice_lib.c | 7 - drivers/net/ethernet/intel/ice/

[PATCH net-next 03/15] ice: Add new VSI states to track netdev alloc/registration

2021-04-14 Thread Tony Nguyen
-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 2 ++ drivers/net/ethernet/intel/ice/ice_lib.c | 21 +++-- drivers/net/ethernet/intel/ice/ice_main.c | 5 + 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2021-04-14

2021-04-14 Thread Tony Nguyen
This series contains updates to ice driver only. Bruce changes and removes open coded values to instead use existing kernel defines and suppresses false cppcheck issues. Ani adds new VSI states to track netdev allocation and registration. He also removes leading underscores in the ice_pf_state en

[PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2021-04-14

2021-04-14 Thread Tony Nguyen
This series contains updates to ixgbe and ice drivers. Alex Duyck fixes a NULL pointer dereference for ixgbe. Yongxin Liu fixes an unbalanced enable/disable which was causing a call trace with suspend for ixgbe. Colin King fixes a potential infinite loop for ice. The following are changes since

[PATCH net 3/3] ice: Fix potential infinite loop when using u8 loop counter

2021-04-14 Thread Tony Nguyen
j the same type as cmp_dcbcfg->numapp. Addresses-Coverity: ("Infinite loop") Fixes: aeac8ce864d9 ("ice: Recognize 860 as iSCSI port in CEE mode") Signed-off-by: Colin Ian King Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_d

[PATCH net 2/3] ixgbe: fix unbalanced device enable/disable in suspend/resume

2021-04-14 Thread Tony Nguyen
b2558735 ("ixgbe: use generic power management") Signed-off-by: Yongxin Liu Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/

[PATCH net 1/3] ixgbe: Fix NULL pointer dereference in ethtool loopback test

2021-04-14 Thread Tony Nguyen
y: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 03d9aad516d4..45d2c8f37c01 10064

[PATCH net-next v2 2/3] net: intel: Remove unused function pointer typedef ixgbe_mc_addr_itr

2021-04-13 Thread Tony Nguyen
From: Chen Lin Remove the 'ixgbe_mc_addr_itr' typedef as it is not used. Signed-off-by: Chen Lin Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 4 drivers/net/ethernet/intel/ixgbevf/vf.h | 3 --- 2 files changed, 7

[PATCH net-next v2 1/3] ixgbe: Support external GBE SerDes PHY BCM54616s

2021-04-13 Thread Tony Nguyen
: Guohan Lu Signed-off-by: Paul Menzel Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 3 +++ drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b

[PATCH net-next v2 3/3] net: ethernet: intel: Fix a typo in the file ixgbe_dcb_nl.c

2021-04-13 Thread Tony Nguyen
From: Bhaskar Chowdhury s/Reprogam/Reprogram/ Signed-off-by: Bhaskar Chowdhury Reviewed-by: Jesse Brandeburg Acked-by: Randy Dunlap Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next v2 0/3][pull request] 10GbE Intel Wired LAN Driver Updates 2021-04-13

2021-04-13 Thread Tony Nguyen
This series contains updates to ixgbe and ixgbevf driver. Jostar Yang adds support for BCM54616s PHY for ixgbe. Chen Lin removes an unused function pointer for ixgbe and ixgbevf. Bhaskar Chowdhury fixes a typo in ixgbe. --- v2: - Dropped rx_error statistics patch The following are changes since

[PATCH net-next 3/4] net: intel: Remove unused function pointer typedef ixgbe_mc_addr_itr

2021-04-09 Thread Tony Nguyen
From: Chen Lin Remove the 'ixgbe_mc_addr_itr' typedef as it is not used. Signed-off-by: Chen Lin Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 4 drivers/net/ethernet/intel/ixgbevf/vf.h | 3 --- 2 files changed, 7

[PATCH net-next 4/4] net: ethernet: intel: Fix a typo in the file ixgbe_dcb_nl.c

2021-04-09 Thread Tony Nguyen
From: Bhaskar Chowdhury s/Reprogam/Reprogram/ Signed-off-by: Bhaskar Chowdhury Reviewed-by: Jesse Brandeburg Acked-by: Randy Dunlap Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next 2/4] ixgbe: aggregate of all receive errors through netdev's rx_errors

2021-04-09 Thread Tony Nguyen
marked as checksum invalid by hardware The above were added in order to align statistics with other products. Signed-off-by: Radoslaw Tyl Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 11 ++- 1 file changed, 10 insertions

[PATCH net-next 1/4] ixgbe: Support external GBE SerDes PHY BCM54616s

2021-04-09 Thread Tony Nguyen
: Guohan Lu Signed-off-by: Paul Menzel Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 3 +++ drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b

[PATCH net-next 0/4][pull request] 10GbE Intel Wired LAN Driver Updates 2021-04-09

2021-04-09 Thread Tony Nguyen
This series contains updates to ixgbe and ixgbevf driver. Jostar Yang adds support for BCM54616s PHY for ixgbe. Radoslaw aggregates additional Rx errors to be reported to netdev on ixgbe. Chen Lin removes an unused function pointer for ixgbe and ixgbevf. Bhaskar Chowdhury fixes a typo in ixgbe.

[PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-09 Thread Tony Nguyen
resulting in a more readable and efficient code since this function is called from the hot-path of the driver. Signed-off-by: Andre Guedes Signed-off-by: Vedang Patel Signed-off-by: Jithu Joseph Reviewed-by: Maciej Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/ne

[PATCH net-next 9/9] igc: Enable TX via AF_XDP zero-copy

2021-04-09 Thread Tony Nguyen
e approach implemented to support XDP_TX and XDP_REDIRECT actions. Signed-off-by: Andre Guedes Signed-off-by: Vedang Patel Signed-off-by: Jithu Joseph Reviewed-by: Maciej Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc.h | 3 + d

[PATCH net-next 7/9] igc: Replace IGC_TX_FLAGS_XDP flag by an enum

2021-04-09 Thread Tony Nguyen
aciej Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc.h | 8 ++-- drivers/net/ethernet/intel/igc/igc_main.c | 25 ++- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/inte

[PATCH net-next 6/9] igc: Introduce igc_unmap_tx_buffer() helper

2021-04-09 Thread Tony Nguyen
Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 49 +++ 1 file changed, 15 insertions(+), 34 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index

[PATCH net-next 3/9] igc: Refactor igc_clean_rx_ring()

2021-04-09 Thread Tony Nguyen
pool in igc_clean_rx_ring(). Signed-off-by: Andre Guedes Signed-off-by: Vedang Patel Signed-off-by: Jithu Joseph Reviewed-by: Maciej Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 23 ++- 1 file changed, 14

[PATCH net-next 5/9] igc: Introduce TX/RX stats helpers

2021-04-09 Thread Tony Nguyen
-off-by: Jithu Joseph Reviewed-by: Maciej Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 43 --- 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b

[PATCH net-next 4/9] igc: Refactor XDP rxq info registration

2021-04-09 Thread Tony Nguyen
-by: Andre Guedes Signed-off-by: Vedang Patel Signed-off-by: Jithu Joseph Reviewed-by: Maciej Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 16 ++ drivers/net/ethernet/intel/igc/igc_xdp.c | 27

[PATCH net-next 1/9] igc: Move igc_xdp_is_enabled()

2021-04-09 Thread Tony Nguyen
Fijalkowski Tested-by: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 5 - drivers/net/ethernet/intel/igc/igc_xdp.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net

[PATCH net-next 2/9] igc: Refactor __igc_xdp_run_prog()

2021-04-09 Thread Tony Nguyen
: Dvora Fuxbrumer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index eef2e195dd37

[PATCH net-next 0/9][pull request] 1GbE Intel Wired LAN Driver Updates 2021-04-09

2021-04-09 Thread Tony Nguyen
This series contains updates to igc driver only. Andre Guedes says: This series adds AF_XDP zero-copy feature to igc driver. The initial patches do some code refactoring, preparing the code base to land the AF_XDP zero-copy feature, avoiding code duplications. The last patches of the series are

[PATCH net 5/6] i40e: Fix sparse warning: missing error code 'err'

2021-04-08 Thread Tony Nguyen
e recovery mode support") Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/in

[PATCH net 6/6] ice: fix memory leak of aRFS after resuming from suspend

2021-04-08 Thread Tony Nguyen
] kthread+0x14c/0x170 [<ad2cf1cd>] ret_from_fork+0x1f/0x30 Fixes: 769c500dcc1e ("ice: Add advanced power mgmt for WoL") Signed-off-by: Yongxin Liu Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 1 + 1 file ch

[PATCH net 2/6] i40e: Fix sparse errors in i40e_txrx.c

2021-04-08 Thread Tony Nguyen
123830 ("i40e: split XDP_TX tail and XDP_REDIRECT map flushing") Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 12 +--- 1 file changed, 5 insertions(+)

[PATCH net 4/6] i40e: Fix sparse error: 'vsi->netdev' could be null

2021-04-08 Thread Tony Nguyen
we previously assumed 'vsi->netdev' could be null (see line 2323) Fixes: b603f9dc20af ("i40e: Log info when PF is entering and leaving Allmulti mode.") Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Dave Switzer Signed-off-by: Tony Nguy

[PATCH net 1/6] i40e: Fix parameters in aq_get_phy_register()

2021-04-08 Thread Tony Nguyen
;i40e: Extend PHY access with page change flag") Signed-off-by: Grzegorz Siwik Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_et

[PATCH net 3/6] i40e: Fix sparse error: uninitialized symbol 'ring'

2021-04-08 Thread Tony Nguyen
esc XDP command") Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/

[PATCH net 0/6][pull request] Intel Wired LAN Driver Updates 2021-04-08

2021-04-08 Thread Tony Nguyen
This series contains updates to i40e and ice drivers. Grzegorz fixes the ordering of parameters to i40e_aq_get_phy_register() which is causing incorrect information to be reported. Arkadiusz fixes various sparse issues reported on the i40e driver. Yongxin Liu fixes a memory leak with aRFS follow

[PATCH net-next 15/15] ice: Remove unnecessary blank line

2021-04-08 Thread Tony Nguyen
/ice_main.c:455: + +} Signed-off-by: Tony Nguyen Tested-by: Tony Brelinski --- drivers/net/ethernet/intel/ice/ice_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index 5ab35c1d6121..30935aaa8935 100644 --

[PATCH net-next 10/15] ice: Limit forced overrides based on FW version

2021-04-08 Thread Tony Nguyen
ation structure, the module compliance enforcement is already correctly set by firmware, so the extra code block is redundant. Signed-off-by: Jeb Cramer Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_common.c | 14 ++ 1 file chang

[PATCH net-next 11/15] ice: Remove unnecessary variable

2021-04-08 Thread Tony Nguyen
From: Anirudh Venkataramanan In ice_init_phy_user_cfg, vsi is used only to get to hw. Remove this and just use pi->hw Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 7 +-- 1 file changed

[PATCH net-next 14/15] ice: Remove unnecessary checks in add/kill_vid ndo ops

2021-04-08 Thread Tony Nguyen
is an unnecessary check. The second check is unnecessary because the PF VSI is never put into a port VLAN. Remove these checks. Signed-off-by: Brett Creeley Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 12 1 file changed, 12

[PATCH net-next 13/15] ice: Remove rx_gro_dropped stat

2021-04-08 Thread Tony Nguyen
Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 1 - drivers/net/ethernet/intel/ice/ice_ethtool.c | 1 - drivers/net/ethernet/intel/ice/ice_main.c| 4 +--- drivers/net/ethernet/intel/ice/ice_txrx.h| 1 - 4 files changed, 1 insertion(+), 6 deletions(-) di

[PATCH net-next 12/15] ice: Use local variable instead of pointer derefs

2021-04-08 Thread Tony Nguyen
From: Anirudh Venkataramanan Replace multiple instances of vsi->back and pi->phy with equivalent local variables Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 27 ++-

[PATCH net-next 09/15] ice: Use default configuration mode for PHY configuration

2021-04-08 Thread Tony Nguyen
k function for Report Default Configuration support and update accordingly. Also change adv_phy_type_[lo|hi] to advert_phy_type[lo|hi] for clarity. Co-developed-by: Mateusz Pacuszka Signed-off-by: Mateusz Pacuszka Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: T

[PATCH net-next 08/15] ice: Replace some memsets and memcpys with assignment

2021-04-08 Thread Tony Nguyen
From: Anirudh Venkataramanan In ice_set_link_ksettings, use assignment instead of memset/memcpy where possible Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 10 +++--- 1 file changed, 3

[PATCH net-next 07/15] ice: Fix error return codes in ice_set_link_ksettings

2021-04-08 Thread Tony Nguyen
From: Anirudh Venkataramanan Return more appropriate error codes so that the right error message is communicated to the user by ethtool. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 14

[PATCH net-next 05/15] ice: Remove unnecessary checker loop

2021-04-08 Thread Tony Nguyen
From: Anirudh Venkataramanan The loop checking for PF VSI doesn't make any sense. The VSI type backing the netdev passed to ice_set_link_ksettings will always be of type ICE_PF_VSI. Remove it. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony N

[PATCH net-next 03/15] ice: Align macro names to the specification

2021-04-08 Thread Tony Nguyen
n Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 10 +- drivers/net/ethernet/intel/ice/ice_common.c | 13 +++-- drivers/net/ethernet/intel/ice/ice_ethtool.c| 12 ++-- drivers/net/ethernet/intel/ice/ice

[PATCH net-next 06/15] ice: Rename a couple of variables

2021-04-08 Thread Tony Nguyen
From: Anirudh Venkataramanan In ice_set_link_ksettings, change 'abilities' to 'phy_caps' and 'p' to 'pi'. This is more consistent with similar usages elsewhere in the driver. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by

[PATCH net-next 04/15] ice: Ignore EMODE return for opcode 0x0605

2021-04-08 Thread Tony Nguyen
-boo. Clean it up. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 17 ++-- drivers/net/ethernet/intel/ice/ice_lib.c | 37 ++ drivers/net/ethernet/intel/ice/ice_lib.h | 2

[PATCH net-next 02/15] ice: Modify recursive way of adding nodes

2021-04-08 Thread Tony Nguyen
present on that layer. In some cases it can consume more stack. Signed-off-by: Victor Raj Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_sched.c | 130 - 1 file changed, 77 insertions(+), 53 deletions(-) diff --git a/drivers/net

[PATCH net-next 01/15] ice: Re-send some AQ commands, as result of EBUSY AQ error

2021-04-08 Thread Tony Nguyen
the result of EBUSY, instead of returning error to the caller right away. Signed-off-by: Chinh T Cao Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_common.c | 81 ++- drivers/net/ethernet/intel/ice/ice_common.h | 3 + drivers/net

[PATCH net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2021-04-08

2021-04-08 Thread Tony Nguyen
unnecessary checks in add/kill_vid ndo ops Chinh T Cao (1): ice: Re-send some AQ commands, as result of EBUSY AQ error Jeb Cramer (1): ice: Limit forced overrides based on FW version Tony Nguyen (1): ice: Remove unnecessary blank line Victor Raj (1): ice: Modify recursive way of adding nodes

[PATCH net 3/3] i40e: Fix display statistics for veb_tc

2021-04-01 Thread Tony Nguyen
Reviewed-by: Aleksandr Loktionov Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- .../net/ethernet/intel/i40e/i40e_ethtool.c| 52 --- 1 file changed, 46 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/inte

[PATCH net 2/3] i40e: fix receiving of single packets in xsk zero-copy mode

2021-04-01 Thread Tony Nguyen
eported-by: Sreedevi Joshi Signed-off-by: Magnus Karlsson Acked-by: Maciej Fijalkowski Tested-by: Kiran Bhandare Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40

[PATCH net 1/3] i40e: Fix inconsistent indenting

2021-04-01 Thread Tony Nguyen
ed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net

[PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2021-04-01

2021-04-01 Thread Tony Nguyen
This series contains updates to i40e driver only. Arkadiusz fixes warnings for inconsistent indentation. Magnus fixes an issue on xsk receive where single packets over time are batched rather than received immediately. Eryk corrects warnings and reporting of veb-stats. The following are changes

[PATCH net-next 12/15] ice: Refactor ice_set/get_rss into LUT and key specific functions

2021-03-31 Thread Tony Nguyen
and ice_set/get_rss_key functions. Also, consolidate all calls for setting/getting the RSS LUT and RSS Key to use ice_set/get_rss_lut() and ice_set/get_rss_key(). Signed-off-by: Brett Creeley Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h

[PATCH net-next 15/15] ice: Correct comment block style

2021-03-31 Thread Tony Nguyen
, use /* Comment... FILE: drivers/net/ethernet/intel/ice/ice_adminq_cmd.h:1428: +/* + * Send to PF command (indirect 0x0801) ID is only used by PF Signed-off-by: Tony Nguyen Tested-by: Tony Brelinski --- drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 3 +-- 1 file changed, 1 insertion(

[PATCH net-next 11/15] ice: Refactor get/set RSS LUT to use struct parameter

2021-03-31 Thread Tony Nguyen
the arguments ever need to be updated in the future. Also, reduce duplicate code that was checking for an invalid vsi_handle and lut parameter by moving the checks to the lower level __ice_aq_get_set_rss_lut(). Signed-off-by: Brett Creeley Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen

[PATCH net-next 13/15] ice: Consolidate VSI state and flags

2021-03-31 Thread Tony Nguyen
state, it makes more sense to represent VSI state with its own enum. So derive a new enum ice_vsi_state from ice_vsi_flags and ice_state and use it. Also rename enum ice_state to ice_pf_state for clarity. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: T

[PATCH net-next 14/15] ice: cleanup style issues

2021-03-31 Thread Tony Nguyen
From: Bruce Allan A few style issues reported by checkpatch have snuck into the code; resolve the style issues. COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses Signed-off-by: Bruce Allan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net

[PATCH net-next 08/15] ice: correct memory allocation call

2021-03-31 Thread Tony Nguyen
From: Bruce Allan Use *malloc() instead of *calloc() when allocating only a single object as opposed to an array of objects. Signed-off-by: Bruce Allan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_switch.c | 2 +- 1 file changed, 1 insertion

[PATCH net-next 09/15] ice: rename ptype bitmap

2021-03-31 Thread Tony Nguyen
From: Qi Zhang Align all ptype bitmap to follow ice_ptypes_xxx prefix. Signed-off-by: Qi Zhang Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_flow.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net

[PATCH net-next 05/15] ice: change link misconfiguration message

2021-03-31 Thread Tony Nguyen
From: Paul Greenwalt Change link misconfiguration message since the configuration could be intended by the user. Signed-off-by: Paul Greenwalt Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH net-next 06/15] ice: remove unnecessary duplicated AQ command flag setting

2021-03-31 Thread Tony Nguyen
ndirect AQ commands, i.e. commands that provide an additional data buffer. Signed-off-by: Bruce Allan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet

[PATCH net-next 07/15] ice: Check for bail out condition early

2021-03-31 Thread Tony Nguyen
From: Anirudh Venkataramanan Check for bail out condition before calling ice_aq_sff_eeprom Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH net-next 01/15] ice: Add Support for XPS

2021-03-31 Thread Tony Nguyen
From: Benita Bose Enable and configure XPS. The driver code implemented sets up the Transmit Packet Steering Map, which in turn will be used by the kernel in queue selection during Tx. Signed-off-by: Benita Bose Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet

[PATCH net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2021-03-31

2021-03-31 Thread Tony Nguyen
Zhang (1): ice: rename ptype bitmap Tony Nguyen (1): ice: Correct comment block style drivers/net/ethernet/intel/ice/ice.h | 28 +- .../net/ethernet/intel/ice/ice_adminq_cmd.h | 4 +- drivers/net/ethernet/intel/ice/ice_arfs.c | 6 +- drivers/net/ethernet/intel/ice/ice_ba

[PATCH net-next 10/15] ice: Change ice_vsi_setup_q_map() to not depend on RSS

2021-03-31 Thread Tony Nguyen
ently allows for up to 256 Rx queues per TC. Signed-off-by: Brett Creeley Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 1 + drivers/net/ethernet/intel/ice/ice_lib.c | 50 2 files changed, 17 insertions(+), 34 dele

[PATCH net-next 04/15] ice: handle increasing Tx or Rx ring sizes

2021-03-31 Thread Tony Nguyen
ul M Stillwell Jr Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_lib.c | 123 -- drivers/net/ethernet/intel/ice/ice_txrx.h | 2 + 2 files changed, 92 insertions(+), 33 deletions(-) diff --git a/drivers/net/ethernet/intel/ice

[PATCH net-next 02/15] ice: Delay netdev registration

2021-03-31 Thread Tony Nguyen
Local testing didn't indicate any issues with this change. The state bit check in ice_open was put in as a stop-gap measure to prevent a premature interface up operation. This is no longer needed, so remove it. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-o

[PATCH net-next 03/15] ice: Update to use package info from ice segment

2021-03-31 Thread Tony Nguyen
to the firmware during the download package process. Signed-off-by: Dan Nowlin Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- .../net/ethernet/intel/ice/ice_adminq_cmd.h | 1 + .../net/ethernet/intel/ice/ice_flex_pipe.c| 40 ++- .../net/ethernet/intel/ice

[PATCH net 5/9] ice: fix memory allocation call

2021-03-29 Thread Tony Nguyen
From: Bruce Allan Fix the order of number of array members and member size parameters in a *calloc() call. Fixes: b3c3890489f6 ("ice: avoid unnecessary single-member variable-length structs") Signed-off-by: Bruce Allan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- d

[PATCH net 3/9] ice: Recognize 860 as iSCSI port in CEE mode

2021-03-29 Thread Tony Nguyen
ber at the AQ's caller layer. Rely on the dcbx-willing mode, desired QoS and remote QoS configuration to determine which port number that iSCSI will use. Fixes: 0ebd3ff13cca ("ice: Add code for DCB initialization part 2/4") Signed-off-by: Chinh T Cao Tested-by: Tony Brelinski S

[PATCH net 8/9] ice: Use port number instead of PF ID for WoL

2021-03-29 Thread Tony Nguyen
truct, but just needs a pointer to the hw instance. Fixes: 769c500dcc1e ("ice: Add advanced power mgmt for WoL") Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 2 +- drivers/net/eth

[PATCH net 7/9] ice: Fix for dereference of NULL pointer

2021-03-29 Thread Tony Nguyen
ned-off-by: Jacek BuĊ‚atek Co-developed-by: Haiyue Wang Signed-off-by: Haiyue Wang Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_switch.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net 4/9] ice: prevent ice_open and ice_stop during reset

2021-03-29 Thread Tony Nguyen
To prevent this additional checks in ice_open and ice_stop are introduced to make sure that OS is not allowed to alter VSI config while reset is in progress. Fixes: cdedef59deb0 ("ice: Configure VSIs for Tx/Rx") Signed-off-by: Krzysztof Goreczny Tested-by: Tony Brelinski Signed-of

[PATCH net 6/9] ice: remove DCBNL_DEVRESET bit from PF state

2021-03-29 Thread Tony Nguyen
actually blocking changes coming from the DCBNL interface, remove the bit from the PF state and don't block driver function based on DCBNL reset in progress. Fixes: b94b013eb626 ("ice: Implement DCBNL support") Signed-off-by: Dave Ertman Tested-by: Tony Brelinski Signed-off-by: Tony Nguye

[PATCH net 1/9] ice: Continue probe on link/PHY errors

2021-03-29 Thread Tony Nguyen
probe on link/PHY errors. Fixes: 1a3571b5938c ("ice: restore PHY settings on media insertion") Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 15 ++- 1 file changed, 6 insert

[PATCH net 0/9][pull request] Intel Wired LAN Driver Updates 2021-03-29

2021-03-29 Thread Tony Nguyen
This series contains updates to ice driver only. Ani does not fail on link/PHY errors during probe as this is not a fatal error to prevent the user from remedying the problem. He also corrects checking Wake on LAN support to be port number, not PF ID. Fabio increases the AdminQ timeout as some co

[PATCH net 2/9] ice: Increase control queue timeout

2021-03-29 Thread Tony Nguyen
From: Fabio Pricoco 250 msec timeout is insufficient for some AQ commands. Advice from FW team was to increase the timeout. Increase to 1 second. Fixes: 7ec59eeac804 ("ice: Add support for control queues") Signed-off-by: Fabio Pricoco Tested-by: Tony Brelinski Signed-off-by: T

[PATCH net 9/9] ice: Cleanup fltr list in case of allocation issues

2021-03-29 Thread Tony Nguyen
these cases. Fixes: 80d144c9ac82 ("ice: Refactor switch rule management structures and functions") Signed-off-by: Robert Malz Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_switch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[PATCH net-next 8/8] igc: Add support for XDP_REDIRECT action

2021-03-29 Thread Tony Nguyen
premature Rx buffer reuse") This patch has been tested with the sample apps "xdp_redirect_cpu" and "xdp_redirect_map" located in samples/bpf/. Signed-off-by: Andre Guedes Signed-off-by: Vedang Patel Signed-off-by: Jithu Joseph Reviewed-by: Maciej Fijalkowski Tested-by

  1   2   3   4   5   6   7   >