Please review below patch and provide your valuable feedback.
Regards
-Vijay
On 9/11/19, 1:05 PM, "Vijay Khemka" wrote:
HW checksum generation is not working for AST2500, specially with IPV6
over NCSI. All TCP packets with IPv6 get dropped. By disabling this
it works
mellanox OEM commands.
ncsi_rsp_handler_oem_mlx_gma: This handles get mac address response and
set it to device.
Signed-off-by: Vijay Khemka
---
net/ncsi/internal.h| 5 +
net/ncsi/ncsi-manage.c | 28 +++-
net/ncsi/ncsi-pkt.h| 9 +
net/ncsi/ncsi-rsp.c
Thanks David,
I will fix this and upload next version.
Regards
-Vijay
On 11/21/18, 4:55 PM, "David Miller" wrote:
From: Vijay Khemka
Date: Tue, 20 Nov 2018 12:35:16 -0800
> +static int ncsi_oem_gma_handler_mlx(struct ncsi_cmd_arg *nca)
> +{
> +
g with zero data length)
-> user space application
Error:
Error detected
-> ncsi_send_netlink_err ()
-> Netlink interface (err msg)
-> user space application
Signed-off-by: Justin Lee
Reviewed-by : Vijay Khemka
Hi Justin,
Please see minor comments below.
Regards
-Vijay
On 10/10/18, 9:01 AM, "justin.l...@dell.com" wrote:
The new command (NCSI_CMD_SEND_CMD) is added to allow user space application
to send NC-SI command to the network card.
Also, add a new attribute (NCSI_ATTR_DATA) for tran
On 10/4/18, 9:48 PM, "Samuel Mendoza-Jonas" wrote:
On Wed, 2018-10-03 at 16:32 -0700, Vijay Khemka wrote:
> This patch adds OEM commands and response handling. It also defines OEM
> command and response structure as per NCSI specification along with it
OEM commands
Signed-off-by: Vijay Khemka
---
net/ncsi/internal.h | 5 +
net/ncsi/ncsi-cmd.c | 30 +++---
net/ncsi/ncsi-pkt.h | 14 ++
net/ncsi/ncsi-rsp.c | 43 ++-
4 files changed, 88 insertions(+), 4 deletions
Hi Justin,
Please see comments below
-Vijay
> > > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
> > > index 7567ca63aae2..2f98533eba46 100644
> > > --- a/net/ncsi/ncsi-cmd.c
> > > +++ b/net/ncsi/ncsi-cmd.c
> > > @@ -211,6 +211,26 @@ static int ncsi_cmd_handler_snfc(s
Hi Justin,
Thanks for response. Please see my comments below.
-Vijay
> > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
> > index 7567ca63aae2..2f98533eba46 100644
> > --- a/net/ncsi/ncsi-cmd.c
> > +++ b/net/ncsi/ncsi-cmd.c
> > @@ -211,6 +211,26 @@ static int ncsi_cmd_h
On 9/28/18, 6:21 PM, "Linux-aspeed on behalf of Vijay Khemka"
wrote:
> On 9/28/18, 6:07 PM, "Vijay Khemka" wrote:
> This patch adds OEM commands and response handling. It also defines OEM
> command and response structure as per
> On 9/28/18, 6:07 PM, "Vijay Khemka" wrote:
> This patch adds OEM commands and response handling. It also defines OEM
> command and response structure as per NCSI specification along with its
> handlers.
>
> ncsi_cmd_handler_oem: This is a generic
OEM commands
Signed-off-by: Vijay Khemka
---
net/ncsi/internal.h | 4
net/ncsi/ncsi-cmd.c | 31 ---
net/ncsi/ncsi-pkt.h | 16
net/ncsi/ncsi-rsp.c | 44 +++-
4 files changed, 91 insertions(+), 4 deletions
>On 9/28/18, 11:16 AM, "justin.l...@dell.com" wrote:
> The new command (NCSI_CMD_SEND_CMD) is added to allow user space
application
> to send NC-SI command to the network card.
> Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and
response.
>
> The work fl
On 9/26/18, 8:44 PM, "Samuel Mendoza-Jonas" wrote:
>Hi Vijay,
>Having had a chance to take a closer look, there is probably room for
> both this patchset and Justin's potential changes to coexist; while
> Justin's is a more general solution for sending arbitrary commands, the
>
>Hi Vijay,
> Thanks for the patch; before I get too into a review though I'd like to
> loop in Justin (cc'd) who I know is also working on an OEM command patch.
> The changes here are very specific (eg. a command specific config option
> "CONFIG_NCSI_OEM_CMD_GET_MAC"), which is ok
Hi Joel,
Thanks, I am adding netdev mailing list here.
Yes, this command is supported for all Mellanox card. It is as per Mellanox
specification.
Regards
-Vijay
On 9/24/18, 5:30 PM, "Joel Stanley" wrote:
Hi Vijay,
On Tue, 25 Sep 2018 at 09:39, Vijay Khe
16 matches
Mail list logo
