Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-14 Thread Vikram Sethi
gt; >> ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); >> if (ret) { >> ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); >> if (ret) { >> dev_err(dev, "failed to set dma mask\n&quo

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Vikram Sethi
s own register block, but you still have to program it in concert with the > Emac. You can't really treat it separately. > > So I'm beginning to believe that Gilad's driver is actually correct as-is. > There are a few minor bug fixes, but in general it's correct.