On Mon, Oct 23, 2017 at 07:59:55PM +0200, Romain Perier wrote:
> From: Romain Perier
>
> The PCI pool API is deprecated. This commit replaces the PCI pool old
> API by the appropriate function with the DMA pool API.
Applied, thanks
--
~Vinod
drivers/dma/idma64.h| 2 +-
For this:
Acked-by: Vinod Koul
Thanks
--
~Vinod
On Fri, Aug 14, 2015 at 11:54:59AM +0300, Dan Carpenter wrote:
> The dma_mapping_error() function returns true or false. We should
> return -ENOMEM if it there is a dma mapping error.
Looks good to me, but should be sent to net folks now me :)
--
~Vinod
>
> Signed-off-by: Dan Carpenter
>
>
On Mon, Aug 29, 2016 at 12:26:04PM +0100, Russell King wrote:
> Add DMA filters for the sa11x0 DMA channels. This will allow us to
> migrate away from directly using the DMA filter function in drivers.
Acked-by: Vinod Koul
--
~Vinod
On Mon, Aug 29, 2016 at 12:26:20PM +0100, Russell King wrote:
> As we now have no users of sa11x0_dma_filter_fn() in the tree, we can
> unexport this function, and remove the now unused header file.
Acked-by: Vinod Koul
--
~Vinod
On Thu, Jun 08, 2017 at 03:25:28PM +0200, Christoph Hellwig wrote:
> DMA_ERROR_CODE is not a public API and will go away. Instead properly
> unwind based on the loop counter.
Acked-By: Vinod Koul
--
~Vinod
On Fri, Apr 20, 2018 at 03:28:28PM +0200, Geert Uytterhoeven wrote:
> Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS")
> is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy
> CONFIG_ARCH_SHMOBILE, hence use the former.
>
> Renesas SuperH SH-Mobile SoCs a
On 23-11-18, 15:24, Anshuman Khandual wrote:
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all);
> static bool dma_chan_is_local(struct dma_chan *chan, int cpu)
> {
> int node = dev_to_node(chan->device->dev);
> -
global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like
> 'invalid node' from various places redirecting them to a common definition.
>
> drivers/dma/dmaengine.c | 4 +++-
Acked-by: Vinod Koul
--
~Vinod
On 19-07-19, 10:53, xiaofeis wrote:
> Set phy device advertising to enable MAC flow control.
How about:
to Pause for enabling MAC flow control
>
> Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae
Please remove this
> Signed-off-by: Xiaofei Shen
> ---
> drivers/net/dsa/qca8k.c | 4 +++-
>
ys.
Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode")
Reported-by: Peter Ujfalusi
Reviewed-by: Niklas Cassel
Tested-by: Peter Ujfalusi
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 53 +++-
1 file changed, 42 inserti
c Gonzalez
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 8ff12938ab47..c6e7d800fd7a 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes.
While at it, as pointed by Dave, don't inline the helpers.
[1]: https://www.spinics.net/lists/netdev/msg550749.html
Changes in v4:
- fix log & comments nbased on Marc's feedback
Vinod Koul (2):
net: phy: at803x: do
From: Xiaofei Shen
When we create slave netdevice, the dev addr is inherited from master
but the master dev addr maybe NULL at that time, so inherit it again
while opening the slave.
Signed-off-by: Xiaofei Shen
Signed-off-by: Vinod Koul
---
net/dsa/slave.c | 4 +++-
1 file changed, 3
From: Xiaofei Shen
Before creating a slave netdevice, get the mac address from DTS and
apply in case it is valid.
Signed-off-by: Xiaofei Shen
Signed-off-by: Vinod Koul
---
include/net/dsa.h | 1 +
net/dsa/dsa2.c| 1 +
net/dsa/slave.c | 5 -
3 files changed, 6 insertions(+), 1
On 04-03-19, 11:46, xiaof...@codeaurora.org wrote:
> On 2019-02-22 22:26, Andrew Lunn wrote:
> > On Fri, Feb 22, 2019 at 06:28:15PM +0530, Vinod Koul wrote:
> > > From: Xiaofei Shen
> > >
> > > Before creating a slave netdevice, get the mac address from DTS
On 05-03-19, 16:16, xiaofeis wrote:
> Allow port network device's mac address to be retrieved from the
> device tree.
Reviewed-by: Vinod Koul
> Signed-off-by: xiaofeis
> ---
> Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 +
> 1 file changed, 5 insertio
On 29-01-21, 14:07, Steen Hegelund wrote:
> Provide a new ethernet phy configuration structure, that
> allow PHYs used for ethernet to be configured with
> speed, media type and clock information.
This lgtm, Kishon ?
>
> Signed-off-by: Lars Povlsen
> Signed-off-by: Steen Hegelund
> Reviewed-by
On 29-01-21, 14:07, Steen Hegelund wrote:
> Add the Microchip Sparx5 ethernet serdes PHY driver for the 6G, 10G and 25G
> interfaces available in the Sparx5 SoC.
>
> Signed-off-by: Bjarni Jonasson
> Signed-off-by: Steen Hegelund
> Reviewed-by: Andrew Lunn
> Reviewed-by: Alexandre Belloni
> ---
Hello Steen,
On 15-03-21, 16:04, Steen Hegelund wrote:
> Hi Kishon, Vinod, Andrew, Jacub, and David,
>
> I just wanted to know if you think that the Generic PHY subsystem might
> not be the right place for this Ethernet SerDes PHY driver after all.
>
> Originally I chose this subsystem for hist
On 18-02-21, 17:14, Steen Hegelund wrote:
> Adding the Sparx5 Serdes driver
>
> This series of patches provides the serdes driver for the Microchip Sparx5
> ethernet switch.
>
> The serdes driver supports the 10G and 25G serdes instances available in the
> Sparx5.
>
> The Sparx5 serdes support s
On 11-03-21, 16:33, Bjorn Andersson wrote:
> The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others
> needs
> platform-, and perhaps even board-, specific firmware. Add support for
> providing this in devicetree.
Reviewed-by: Vinod Koul
--
~Vinod
On 29-03-21, 16:13, Steen Hegelund wrote:
> Use direct register operations instead of a table of register
> information to lower the stack usage.
Applied, thanks
--
~Vinod
gs/phy/qcom-usb-ipq4019-phy.yaml| 2 ++
For phy changes:
Acked-By: Vinod Koul
--
~Vinod
: Xiaofei Shen
Tested-by: Xiaofei Shen
Signed-off-by: Sneh Shah
Signed-off-by: Vinod Koul
---
Changes in v2:
As discussed in [1] we move the stmmac driver inherting the mac address
from probe to open
[1]: https://lore.kernel.org/netdev/20190222125654.12478-1-vk...@kernel.org/
drivers/net
evicetree/bindings/ -name "*.yaml"`
> .../devicetree/bindings/dma/dma-common.yaml | 4 +-
> .../devicetree/bindings/dma/dma-router.yaml | 2 +-
> .../devicetree/bindings/dma/ingenic,dma.yaml | 2 +-
> .../bindings/dma/snps,dma-spear1340.yaml | 10 ++---
Acked-By: Vinod Koul
--
~Vinod
On 27-03-19, 11:59, xiaofeis wrote:
> Add flow_dissect for qca tagged packet to get the right hash.
Ideally this patch should have been tagged as V2. Anyhow the change
looks fine so:
Reviewed-by: Vinod Koul
> Signed-off-by: Xiaofei Shen
> ---
> net/dsa/tag_qca.c | 10
applies on top of pci/misc for v5.11
> ---
> drivers/dma/dw/pci.c | 2 +-
> drivers/dma/hsu/pci.c | 2 +-
Acked-By: Vinod Koul
--
~Vinod
On 05-01-21, 15:02, Thomas Bogendoerfer wrote:
> Signed-off-by: Thomas Bogendoerfer
Applied after fixing subsystem name, thanks
--
~Vinod
On 07-01-21, 17:40, Thomas Bogendoerfer wrote:
> On Wed, Jan 06, 2021 at 11:10:38AM -0800, Joe Perches wrote:
> > On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote:
> > > Signed-off-by: Thomas Bogendoerfer
> > []
> > > diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h
> > []
On 25-12-20, 15:52, Chunfeng Yun wrote:
> Convert phy-mtk-xsphy.txt to YAML schema mediatek,xsphy.yaml
Applied, thanks
--
~Vinod
On 25-12-20, 15:52, Chunfeng Yun wrote:
> Convert phy-mtk-tphy.txt to YAML schema mediatek,tphy.yaml
Applied, thanks
--
~Vinod
On 25-12-20, 15:52, Chunfeng Yun wrote:
> Convert phy-mtk-ufs.txt to YAML schema mediatek,ufs-phy.yaml
Applied, thanks
--
~Vinod
On 25-12-20, 15:52, Chunfeng Yun wrote:
> Convert HDMI PHY binding to YAML schema mediatek,hdmi-phy.yaml
Applied, thanks
--
~Vinod
On 25-12-20, 15:52, Chunfeng Yun wrote:
> Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml
Applied, thanks
--
~Vinod
On 14-01-21, 09:10, Andy Shevchenko wrote:
> On Thursday, January 14, 2021, Jakub Kicinski wrote:
>
> > On Tue, 12 Jan 2021 17:37:09 +0200 Andy Shevchenko wrote:
> > > We have currently three users of the PSEC_PER_SEC each of them defining
> > it
> > > individually. Instead, move it to time64.h t
On 13-07-20, 22:35, Lad Prabhakar wrote:
> Renesas RZ/G2H (R8A774E1) SoC also has the R-Car gen3 compatible
> DMA controllers, therefore document RZ/G2H specific bindings.
Applied, thanks
--
~Vinod
On 27-07-20, 15:34, Gustavo A. R. Silva wrote:
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 2c508ee672b9..9b69716172a4 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -1061,16 +1061,16 @@ static bool _start(struct pl330_thread *thrd)
>
> if (
lcomm ethqos")
Reported-by: Rahul Ankushrao Kawadgave
Signed-off-by: Vinod Koul
---
.../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
b/drivers/net/ethern
Hi Florian,
Thanks for a quick review,
On 08-01-19, 09:59, Florian Fainelli wrote:
> On 1/8/19 8:29 AM, Vinod Koul wrote:
> > + if (phydev->interface == PHY_INTERFACE_MODE_RGMII) {
> > + ret = at803x_disable_rx_delay(phydev);
> >
Hi Florian,
On 08-01-19, 10:00, Florian Fainelli wrote:
> On 1/8/19 8:29 AM, Vinod Koul wrote:
> > In RGMII mode we should not have any delay in phy, so disable
> > the delay.
>
> This seems to apply to the port's MAC itself, so the commit message
> should be ment
HI Rob,
On 11-01-19, 09:01, Rob Herring wrote:
> On Wed, Jan 02, 2019 at 02:47:25PM +0530, Vinod Koul wrote:
> > Some controllers require that phy delay should be disabled. So add
>
> If the MAC requires it, then the compatible string should imply this. If
> it depends on
On 15-01-19, 15:03, Rob Herring wrote:
> On Tue, Jan 08, 2019 at 09:59:22PM +0530, Vinod Koul wrote:
> > Add support for Qualcomm ethqos found in some SoCs like QCS404.
> >
> > Signed-off-by: Vinod Koul
> > ---
> > .../devicetree/bindings/net/qcom,dwmac.txt
Add support for Qualcomm ethqos found in some SoCs like QCS404.
Signed-off-by: Vinod Koul
---
.../devicetree/bindings/net/qcom,ethqos.txt | 64 +++
1 file changed, 64 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/qcom,ethqos.txt
diff --git a
y for disable the delay and disable delay for RGMII mode
in AT803x and QCA8K PHY drivers
Vinod Koul (5):
dt-bindings: net: Add Qualcomm ethqos binding
net: stmmac: Add driver for Qualcomm ethqos
MAINTAINER: Add entry for Qualcomm ETHQOS ethernet driver
net: phy: at803x: Disable phy dela
Add myself and Niklas as maintainers for this driver
Signed-off-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 32d76a90..b0af43cda327 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
For RGMII mode, phy delay should be disabled. Add this case along
with disable delay routines.
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
Ravi Kanth
Co-developed-by: Niklas Cassel
Signed-off-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 10 +
drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
.../stmicro/stmmac/dwmac-qcom-ethqos.c| 545 ++
3 files
In RGMII mode we should not have any delay in port MAC, so disable
the delay.
Signed-off-by: Vinod Koul
---
drivers/net/dsa/qca8k.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 7e97e620bd44
On 23-01-19, 06:19, Wei Yongjun wrote:
> In case of error, the function devm_clk_get() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().
Acked-by: Vinod Koul
This is a networking subsystem patch and you mi
On 01-02-19, 09:47, Christoph Hellwig wrote:
> The DMA API generally relies on a struct device to work properly, and
> only barely works without one for legacy reasons. Pass the easily
> available struct device from the platform_device to remedy this.
This looks good to me but fails to apply. Can
Add support for Qualcomm ethqos found in some SoCs like QCS404.
Signed-off-by: Vinod Koul
---
.../devicetree/bindings/net/qcom,dwmac.txt| 129 ++
1 file changed, 129 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/qcom,dwmac.txt
diff --git a
a DT property and disable the delay when this property is
present, this is done for two phys at803x and qca8k.
Vinod Koul (7):
dt-bindings: net: Add Qualcomm ethqos binding
net: stmmac: Add driver for Qualcomm ethqos
dt-bindings: net: stmmac: Add the bindings documentation for delays
MAINT
Rework at803x_config_init() function to check and program the tx and rx
delay enable separately. This will help in checking the delay to be
programmed based on other conditions as well.
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 12 +---
1 file changed, 9 insertions(+), 3
We should disable tx/rx delay in rgmii mode, but driver doesn't do so.
Hence add a device tree property to avoid breaking current users and
disable only when this property is set
Signed-off-by: Vinod Koul
---
drivers/net/dsa/qca8k.c | 27 ++-
1 file change
Some controllers require the tx and rx delays to be disabled. So check
the property and if present do not enable the delay and disable the
delay explicitly.
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 36
1 file changed, 36 insertions(+)
diff
Add myself and Nikals as maintainers for this driver
Signed-off-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f4855974f325..0e3f4d97efd7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Ravi Kanth
Co-developed-by: Niklas Cassel
Signed-off-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 10 +
drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
.../stmicro/stmmac/dwmac-qcom-ethqos.c| 545 ++
3 files
Some controllers require that phy delay should be disabled. So add
optional properties rx-disable-delay and tx-disable-delay for it.
Signed-off-by: Vinod Koul
---
Documentation/devicetree/bindings/net/stmmac.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree
On 02-01-19, 12:48, Sergei Shtylyov wrote:
> Hello!
>
> On 02.01.2019 12:17, Vinod Koul wrote:
>
> > Add myself and Nikals as maintainers for this driver
>
>Niklas?
Damn.. will update after getting other comments. Thanks for pointing
>
> > Signed-off-by:
On 02-01-19, 15:07, Andrew Lunn wrote:
> > + mdio {
> > + #address-cells = <0x1>;
> > + #size-cells = <0x0>;
> > + compatible = "snps,dwmac-mdio";
> > + phy1: phy@1 {
>
> phy@4 since reg = 0x4
Right, will fix this
--
~Vinod
Hi Andrew,
Thanks for the comments,
On 02-01-19, 14:40, Andrew Lunn wrote:
> On Wed, Jan 02, 2019 at 02:47:28PM +0530, Vinod Koul wrote:
> > Some controllers require the tx and rx delays to be disabled. So check
> > the property and if present do not enable the delay and disabl
For RGMII mode, phy delay should be disabled. Add this case along
with disable delay routines.
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index f9432d053a22
In RGMII mode we should not have any delay in phy, so disable
the delay.
Signed-off-by: Vinod Koul
---
drivers/net/dsa/qca8k.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 7e97e620bd44..a4b6cda38016
Add support for Qualcomm ethqos found in some SoCs like QCS404.
Signed-off-by: Vinod Koul
---
.../devicetree/bindings/net/qcom,dwmac.txt| 129 ++
1 file changed, 129 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/qcom,dwmac.txt
diff --git a
Ravi Kanth
Co-developed-by: Niklas Cassel
Signed-off-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 10 +
drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
.../stmicro/stmmac/dwmac-qcom-ethqos.c| 545 ++
3 files
x the two phy drivers tested with this.
Changes in v2:
- Fix the example in dt-binding
- Remove DT property for disable the delay and disable delay for RGMII mode
in AT803x and QCA8K PHY drivers
Vinod Koul (5):
dt-bindings: net: Add Qualcomm ethqos binding
net: stmmac: Add driver for Qua
Add myself and Niklas as maintainers for this driver
Signed-off-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 32d76a90..b0af43cda327 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Hi Peter,
On 12-02-19, 12:55, Peter Ujfalusi wrote:
> Vinod,
>
> On 21/01/2019 11.13, Vinod Koul wrote:
> > For RGMII mode, phy delay should be disabled. Add this case along
> > with disable delay routines.
>
> In next-20190211 I need to revert this patch to get c
Hi again,
On 12-02-19, 17:01, Vinod Koul wrote:
> Hi Peter,
>
> On 12-02-19, 12:55, Peter Ujfalusi wrote:
> > Vinod,
> >
> > On 21/01/2019 11.13, Vinod Koul wrote:
> > > For RGMII mode, phy delay should be disabled. Add this case along
> > >
e phy delay for RGMII mode")
Reported-by: Peter Ujfalusi
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 8ff12938ab47..7b54b
On 14-02-19, 08:38, David Miller wrote:
> From: Vinod Koul
> Date: Tue, 12 Feb 2019 19:49:22 +0530
>
> > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> > index 8ff12938ab47..7b54b54e3316 100644
> > --- a/drivers/net/phy/at803x.c
> &g
On 13-02-19, 09:02, Peter Ujfalusi wrote:
> Hi Vinod,
>
> On 12/02/2019 16.19, Vinod Koul wrote:
> > Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode
> > should not have delay in PHY whereas RGMII_ID and RGMII_RXID/RGMII_TXID
> > can have
ys.
Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode")
Reported-by: Peter Ujfalusi
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 47 ++--
1 file changed, 36 insertions(+), 11 deletions(-)
diff --git a/drivers/net/phy/at803x
Some helpers were inlined, but makes more sense to allow compiler
to do the right optiomazations instead, so remove inline for
at803x_disable_rx_delay() and at803x_disable_tx_delay()
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On 15-02-19, 16:23, Andrew Lunn wrote:
> On Fri, Feb 15, 2019 at 04:01:08PM +0100, Michal Vokáč wrote:
> > Hi,
> >
> > networking on my boards [1], which are currently in linux-next, suddently
> > stopped working. I tracked it down to this commit 5ecdd77c61c8 ("net: dsa:
> > qca8k: disable delay f
On 18-02-19, 12:54, Michal Vokáč wrote:
> On 18. 02. 19 11:45, Vinod Koul wrote:
> > On 15-02-19, 16:23, Andrew Lunn wrote:
> > > On Fri, Feb 15, 2019 at 04:01:08PM +0100, Michal Vokáč wrote:
> > > > Hi,
> > > >
> > > > networki
RGMII_ID specifies that we should have internal delay, so resurrect the
delay addition routine but under the RGMII_ID mode.
Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
Signed-off-by: Vinod Koul
---
drivers/net/dsa/qca8k.c | 12
1 file c
Hi Andrew,
On 18-02-19, 14:33, Andrew Lunn wrote:
> On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote:
> > RGMII_ID specifies that we should have internal delay, so resurrect the
> > delay addition routine but under the RGMII_ID mode.
> >
> > Fixes: 402
On 18-02-19, 14:36, Andrew Lunn wrote:
> On Mon, Feb 18, 2019 at 06:33:51PM +0530, Vinod Koul wrote:
> > + case PHY_INTERFACE_MODE_RGMII_ID:
> > + /* RGMII_ID needs internal delay. This is enabled through
> > +* PORT5_PAD_CTRL for all ports, rather
Hello Dave,
On 18-02-19, 16:28, David Miller wrote:
> From: Vinod Koul
> Date: Mon, 18 Feb 2019 15:48:52 +0530
>
> > Some helpers were inlined, but makes more sense to allow compiler
> > to do the right optiomazations instead, so remove inline for
> > at
On 19-02-19, 11:05, Sekhar Nori wrote:
> Hi Vinod,
>
> On 19/02/19 10:32 AM, Vinod Koul wrote:
> > Hello Dave,
> >
> > On 18-02-19, 16:28, David Miller wrote:
> >> From: Vinod Koul
> >> Date: Mon, 18 Feb 2019 15:48:52 +0530
> >>
> >
for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes.
While at it, as pointed by Dave, don't inline the helpers.
[1]: https://www.spinics.net/lists/netdev/msg550749.html
Vinod Koul (2):
net: phy: at803x: don't inline helpers
net: phy: at803x: disable delay only for RGMI
Some helpers were inlined, but makes more sense to allow compiler
to do the right optimizations instead, so remove inline for
at803x_disable_rx_delay() and at803x_disable_tx_delay()
Reviewed-by: Niklas Cassel
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 4 ++--
1 file changed, 2
ys.
Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode")
Reported-by: Peter Ujfalusi
Reviewed-by: Niklas Cassel
Tested-by: Peter Ujfalusi
Signed-off-by: Vinod Koul
---
drivers/net/phy/at803x.c | 47 ++--
1 file changed, 36 inserti
RGMII_ID specifies that we should have internal delay, so resurrect the
delay addition routine but under the RGMII_ID mode.
Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
Tested-by: Michal Vokáč
Signed-off-by: Vinod Koul
---
drivers/net/dsa/qc
On 20-02-19, 09:31, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>
> Fixes tag
>
> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
On 20-02-19, 20:59, Stefano Brivio wrote:
> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller wrote:
>
> > From: Jiri Pirko
> > Date: Wed, 20 Feb 2019 09:36:11 +0100
> >
> > > Would be good to have some robot checking "Fixes" sanity...
> >
> > I want to add a script to my trees that lo
88 matches
Mail list logo
