[PATCH] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-23 Thread clsoto
From: Carol L Soto If the caps.eqe_size is bigger than the struct mlx4_eqe then there is a potential for corrupting data at the master context. We can see the message "Master failed to generate an EQE for slave: X" when the event_eqe array wraps and we can see potential oops at the function mlx4

[PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-26 Thread clsoto
From: Carol L Soto If the caps.eqe_size is bigger than the struct mlx4_eqe then there is a potential for corrupting data at the master context. We can see the message "Master failed to generate an EQE for slave: X" when the event_eqe array wraps and we can see potential oops at the function mlx4_

[PATCH net-next] net/mlx5_core: Set log_uar_page_sz for non 4K page size architecture

2015-08-05 Thread clsoto
From: Carol L Soto failed to configure the page size for architectures with page size different than 4K. Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/driver

[PATCH net-next 2/2] net/mlx4_core: Fix unintialized variable used in error path

2015-08-27 Thread clsoto
From: Carol L Soto The uninitialized value name in mlx4_en_activate_cq was used in order to print an error message. Fixing it by replacing it with cq->vector. Signed-off-by: Matan Barak Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 5 ++--- 1 file changed, 2 ins

[PATCH net-next 1/2] net/mlx4_core: Capping number of requested MSIXs to MAX_MSIX

2015-08-27 Thread clsoto
From: Carol L Soto We currently manage IRQs in pool_bm which is a bit field of MAX_MSIX bits. Thus, allocating more than MAX_MSIX interrupts can't be managed in pool_bm. Fixing this by capping number of requested MSIXs to MAX_MSIX. Signed-off-by: Matan Barak Signed-off-by: Carol L Soto --- dr

[PATCH net-next] net/mlx4_en: Fix IPv6 csum calculation

2015-08-28 Thread clsoto
From: Carol L Soto Seeing this message with mlx4_eni with IPv6: hw csum failure Changing IPv6 csum calculation to be based on OFED 2.4 code. When calculate IPv6 csum based also on source and destination addresses. Signed-off-by: Muhammad Mahajna Signed-off-by: Carol L Soto --- drivers/net/et

[PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq

2015-09-29 Thread clsoto
From: Carol L Soto Test interrupts fails if not all completion vectors called request_irq. This case can happen if only mlx4_en loads and we have more completion vectors than rx rings. Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/eq.c | 4 1 file changed, 4 insertion

[PATCH 1/2 net] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq

2015-10-06 Thread clsoto
From: Carol L Soto Test interrupts fails if not all completion vectors called request_irq. This case can happen if only mlx4_en loads and we have more completion vectors than rx rings. Fixes: c66fa19c405a ('net/mlx4: Add EQ pool') Acked-by: Matan Barak Signed-off-by: Carol L Soto --- driver

[PATCH 2/2] Do not set shared_ports when nreq > MAX_MSIX

2015-10-06 Thread clsoto
From: Carol L Soto If we get MAX_MSIX interrupts would like to have each receive ring with his own msix interrupt line. Fixes: 9293267a3e2a ('net/mlx4_core: Capping number of requested MSIXs to MAX_MSIX') Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/main.c | 4 +--- 1 f

[PATCH net] net/mlx4: Remove shared_ports variable at mlx4_enable_msi_x

2015-10-07 Thread clsoto
From: Carol L Soto If we get MAX_MSIX interrupts would like to have each receive ring with his own msix interrupt line. Do not need the shared_ports variable at mlx4_enable_msix Fixes: 9293267a3e2a ('net/mlx4_core: Capping number of requested MSIXs to MAX_MSIX') Signed-off-by: Carol L Soto Ack

[PATCH net-next] net/mlx4_core: Add extra check for total vfs for SRIOV

2015-07-06 Thread clsoto
From: Carol Soto Add extra check for total vfs for SRIOV to check if that value is bigger than total vfs in pci SRIOV capabalities. Fix a check and print of the number of maximum vfs that hw can handle. Fix a check and print of the number of maximum vfs per port that driver can handle. Signe

[PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

2015-07-13 Thread clsoto
From: Carol L Soto Add function bond_remove_proc_entry at __bond_release_one to avoid stack trace at rmmod bonding. [68830.202239] remove_proc_entry: removing non-empty directory 'net/bonding', leaking at least 'bond0' [68830.202257] [ cut here ] [68830.202260] WARNING:

[PATCH net] net/mlx4: fix typo in mlx4_set_vf_mac

2015-06-01 Thread clsoto
fix typo in mlx4_set_vf_mac Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/cmd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlx4/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c @@ -2687,7 +2687,7 @@ int mlx4_set_vf_mac(s

[PATCH net] net/mlx4: double free of dev_vfs

2015-06-01 Thread clsoto
If user loads mlx4_core with num_vfs greater than supported then variable dev->dev_vfs is freed 2 times after unloading the driver. Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/main.c |1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/mellanox/mlx4/main.c

[PATCH net] net/mlx4: need to call close fw if alloc icm is called twice

2015-06-01 Thread clsoto
If mlx4_enable_sriov is called by adapter without this feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this path the function alloc icm is called twice without freeing the structures from the first time. Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/main.c |1 + 1 file c

[PATCH net-next 2/3] net/mlx4_core: need to call close fw if alloc icm is called twice

2015-06-02 Thread clsoto
From: Carol Soto If mlx4_enable_sriov is called by adapter without this feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this path the function alloc icm is called twice without freeing the structures from the first time. Acked-by: Or Gerlitz Signed-off-by: Carol L Soto --- drivers/net/ethernet

[PATCH net-next 1/3] net/mlx4_core: double free of dev_vfs

2015-06-02 Thread clsoto
From: Carol L Soto If user loads mlx4_core with num_vfs greater than supported then variable dev->dev_vfs is freed 2 times after unloading the driver. Acked-by: Or Gerlitz Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/main.c | 1 + 1 file changed, 1 insertion(+) diff --g

[PATCH net-next 3/3] net/mlx4_core: fix typo in mlx4_set_vf_mac

2015-06-02 Thread clsoto
From: Carol Soto fix typo in mlx4_set_vf_mac Acked-by: Or Gerlitz Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c i