Re: [patch 5/7] netxen: fix race in interrupt / napi

2008-01-14 Thread Dhananjay Phadke
Ok, I will respin the failed patches. Thanks, -Dhananjay On Sat, 12 Jan 2008, Jeff Garzik wrote: patch conflicted with commit 1706287f6eb58726a9a0e5cbbde87f49757615e3 Author: David S. Miller [EMAIL PROTECTED] Date: Mon Jan 7 20:51:29 2008 -0800 [NETXEN]: Fix -poll() done logic.

Re: [2.6 patch] drivers/net/netxen/: cleanups

2007-11-08 Thread Dhananjay Phadke
This looks good to me, I might chop off these #if 0 'ed functions in my next round of patches. Acked-by: Dhananjay Phadke [EMAIL PROTECTED] On 11/5/07, Adrian Bunk [EMAIL PROTECTED] wrote: This patch contains the following cleanups: - static functions in .c files shouldn't be marked inline

Re: NetXen driver causing slab corruption in -RT kernels

2007-09-19 Thread Dhananjay Phadke
That 00 0e 1e ... is netxen's mac address, so sounds like the NIC is dumping a frame in the skb already freed (and poisoned) by the stack. I suppose -RT kernels preempt the softirq, giving a chance for this race. The netxen driver doesn't seem to clear the mapped address of the skb in rx

[PATCH 3/3] netxen: ethtool fixes

2007-09-02 Thread Dhananjay Phadke
Resubmitting the patch. This patch improves ethtool support for printing correct ring statistics, segmentation offload status, etc. Signed-off by: Dhananjay Phadke [EMAIL PROTECTED] Index: netdev-2.6/drivers/net/netxen/netxen_nic.h

Re: [PATCH 3/3] netxen: ethtool fixes

2007-08-31 Thread Dhananjay Phadke
oops, ok regenerating patch 3 only. On Fri, 31 Aug 2007, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data) +{ + struct netxen_adapter *adapter = netdev_priv(dev); + adapter-rx_csum = 0; + return 0; +} Bug:

[PATCH] netxen: drop redudant spinlock

2007-07-27 Thread Dhananjay Phadke
Some leftover code that makes use of adapter-lock in tx_timeout function, which resets the interface under this lock. In close() when the workqueue is flushed, prints the warning about sleeping with interrupts disabled (when spinlock debug is enabled). The lock was required with private netxen

Re: [PATCH 0/2] netxen: bug fixes for multiport adapters

2007-07-24 Thread Dhananjay Phadke
Jeff, Any chance of these patches getting committed soon? Thanks, -Dhananjay Phadke On 7/21/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: These patches include fix for problem with 2nd port of multiport adapters on IBM blades. Also improves interrupt handling for multiport adapters avoiding

Re: [PATCH 1/1] netxen: Load firmware during probe, dma watchdog fix.

2007-07-24 Thread Dhananjay Phadke
on powerpc blades. This patch also fixes a bug that PCI resources are not freed if dma watchdog shutdown failed. The dma watchdog poll messages during module unload are also suppressed. Signed-off-by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED] Signed-off-by: Wen

Re: [PATCH 1/1] netxen: Load firmware during probe, dma watchdog fix.

2007-07-20 Thread Dhananjay Phadke
Please ignore this patch. There's one more patch in the series. I will send them together. Thanks, -Dhananjay - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Does the Netxen driver work?

2007-07-09 Thread Dhananjay Phadke
The MSI error wasn't fatal, so it was suppressed in recent fixes for 2.6.22-rc7. The driver in 2.6.21 had many bugs, but I ain't sure if recent fixes are going to be pulled in Fedora kernel. -Dhananjay Ben Greear wrote: Hello! I just got some Netxen 10Gbe CX4 adapters and put them into

Re: [PATCH] netxen: deinline and sparse fix

2007-07-06 Thread Dhananjay Phadke
Yes those functions are large enough to be de-inlined. I would like to shrink those to functions, by replacing the switch blocks with a simple macros, since the mask registers are contiguous. Will repost a patch based on your patch, after a bit of testing. Thanks, -Dhananjay Stephen Hemminger

RESEND [PATCH 0/3] NetXen: Bug fixes for multiport and blade adapters

2007-07-01 Thread dhananjay . phadke
Removed signal_pending checks during init, per Jeff's suggestion. drivers/net/netxen/netxen_nic.h | 180 +++--- drivers/net/netxen/netxen_nic_hdr.h |2 + drivers/net/netxen/netxen_nic_hw.c | 33 -- drivers/net/netxen/netxen_nic_init.c |

RESEND [PATCH 2/3] NetXen: Support per PCI-function interrupt mask registers

2007-07-01 Thread dhananjay . phadke
This patch updates the various access routines to access different control and status settings present in different register locations. This will fix problems related to working of different ports in multi Port card. Signed-off by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off by: Milan Bag

RESEND [PATCH 1/3] NetXen: Fix issue of MSI not working correctly

2007-07-01 Thread dhananjay . phadke
NetXen driver uses PCI function 0 to provide the functionality of MSI. The patch makes driver check the bus master bit for function 0 and enable it after the card initialization. Signed-off-by: Dhananjay Phadke[EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED] Signed-off-by: Wen Xiong

RESEND [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-07-01 Thread dhananjay . phadke
These changes allow driver close routine to be called during module unload, to clean-up buffers and other software resources, flush queues etc. Also, hardware is reset to pristine state. Signed-off-by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED] Signed-off

RESEND [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-07-01 Thread Dhananjay Phadke
Resending patch 3/3 only. These changes allow driver close routine to be called during module unload, to clean-up buffers and other software resources, flush queues etc. Also, hardware is reset to pristine state. Signed-off-by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL

Re: [PATCH 0/3] NetXen: Updates and bug fixes for NetXen 1/10G driver

2007-06-30 Thread Dhananjay Phadke
There's change of guard from NetXen side. I have reworked Mithlesh's original patches based on Michael's feedback. Will be sending out shortly. -- Dhananjay Phadke NetXen Inc. On 6/22/07, Mithlesh Thukral [EMAIL PROTECTED] wrote: Hi All, I will be sending updates for NetXen NIC 1/10 G

[PATCH 0/3] NetXen: Bug fixes for multiport and blade adapters

2007-06-30 Thread dhananjay . phadke
Sending reworked patches based on Michael's feedback (originally sent by Mithlesh Thukral). These patches address interrupt mask issues on multiport adapters, as well as stability issues on powerpc blades. -- Dhananjay Phadke NetXen Inc. drivers/net/netxen/netxen_nic.h | 176

[PATCH 1/3] NetXen: Fix issue of MSI not working correctly

2007-06-30 Thread dhananjay . phadke
NetXen driver uses PCI function 0 to provide the functionality of MSI. The patch makes driver check the bus master bit for function 0 and enable it after the card initialization. Signed-off-by: Dhananjay Phadke[EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED] Signed-off-by: Wen Xiong

[PATCH 2/3] NetXen: Support per PCI-function interrupt mask registers

2007-06-30 Thread dhananjay . phadke
This patch updates the various access routines to access different control and status settings present in different register locations. This will fix problems related to working of different ports in multi Port card. Signed-off by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off by: Milan Bag

[PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-06-30 Thread dhananjay . phadke
These changes allow driver close routine to be called during module unload, to clean-up buffers and other software resources, flush queues etc. Also, hardware is reset to pristine state. Signed-off-by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED] Signed-off

Re: [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-06-30 Thread Dhananjay Phadke
This stage is safe to bail out on signal. It's initializing about a hundred registers and trying to guaranty by retrying, so can get stretched too much on faulty h/w. -Dhananjay On 7/1/07, Jeff Garzik [EMAIL PROTECTED] wrote: While strictly this is true, I strongly urge the use of

RESEND [PATCH 0/3] NetXen: Bug fixes for multiport and blade adapters

2007-06-30 Thread dhananjay . phadke
Resending with changes suggested. -- Dhananjay Phadke NetXen Inc. drivers/net/netxen/netxen_nic.h | 177 +++--- drivers/net/netxen/netxen_nic_hdr.h |2 + drivers/net/netxen/netxen_nic_hw.c | 39 +-- drivers/net/netxen/netxen_nic_init.c

RESEND [PATCH 1/3] NetXen: Fix issue of MSI not working correctly

2007-06-30 Thread dhananjay . phadke
NetXen driver uses PCI function 0 to provide the functionality of MSI. The patch makes driver check the bus master bit for function 0 and enable it after the card initialization. Signed-off-by: Dhananjay Phadke[EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED] Signed-off-by: Wen Xiong

RESEND [PATCH 2/3] NetXen: Support per PCI-function interrupt mask registers

2007-06-30 Thread dhananjay . phadke
This patch updates the various access routines to access different control and status settings present in different register locations. This will fix problems related to working of different ports in multi Port card. Signed-off by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off by: Milan Bag

RESEND [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-06-30 Thread dhananjay . phadke
These changes allow driver close routine to be called during module unload, to clean-up buffers and other software resources, flush queues etc. Also, hardware is reset to pristine state. Signed-off-by: Dhananjay Phadke [EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED] Signed-off

Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address

2007-06-12 Thread Dhananjay Phadke
Mithlesh, You don't initialize max_mc_count anywhere. The multicast address pool can hold 16 addresses for ports {0,1} and 4 for ports {2,3}. You should have following line in the probe routine. adapter-max_mc_count = (adapter-portnum 1) ? 4 : 16; -- Dhananjay Phadke NetXen Inc. Mithlesh