Signed-off-by: Jianming Qiao
---
drivers/net/ethernet/broadcom/bcmsysport.c | 81
-
drivers/net/ethernet/broadcom/bcmsysport.h | 8
2 files changed, 68 insertions(+), 21 deletions(-)
diff --git a/drivers/ne
at 5:11 PM, kiki good wrote:
> Signed-off-by: Jianming Qiao
> ---
> drivers/net/ethernet/broadcom/bcmsysport.c | 81
> -
> drivers/net/ethernet/broadcom/bcmsysport.h | 8
> 2 files chan
about your thoughts ?
I will do the changes as you suggested for the rest parts.
Thanks
Jmqiao
On Sat, Jul 15, 2017 at 5:11 PM, kiki good wrote:
> Signed-off-by: Jianming Qiao
> ---
> drivers/net/ethernet/broadcom/bcmsyspo
Hi Florian:
I have created new patch based on you suggestion.
BTW: When using ndo_get_stats64, ndo_get_stats won't be called,
therefore, it is unnecessary to keep old bcm_sysport_get_stats64. The
exact logic could be found in dev_get_stats() at net/core/dev.c.
Why:
When using Broadcom Systemport
Hi David:
I am sorry for missing the commit log message;Since I did conversation
with Florian Fainelli about this patch in another email thread
"[PATCH] net: systemport: Support 64bit statistics", i incorrectly
thought it was unnecessary to add the commit log again when submitting
the revised patc
Hi Stephen:
Thanks for the suggestion of using per-cpu statistics. In this part of
code, there are two major reasons
not to use per-cpu variable for calculating Tx packets:
1. The update of ring->bytes and ring ->packets are protected with irq
version's spin lock in the current code logic. Althou
How about the changes below then ? of course, we need to remove
bcm_sysport_free_cb(cb) from bcm_sysport_tx_reclaim_one() as well.
u64_stats_update_begin(&stats64->syncp);
ring->bytes += len;
if (cb->skb)
{
ring->packets++;
+bcm_sysport_free_
