Hi,
On 11/01/2008, Jens Osterkamp <[EMAIL PROTECTED]> wrote:
> Hi Ishizaki,
>
> Linas has left the company and is no longer doing kernel related stuff,
> so I suggest, given Jeff is ok with that, that the two of us take over
> spidernet maintainership.
>
> Jens
>
&
the
dump, the mem is returned to general use.
The key point here, for ehea, is "the hypervisor
will reset he device state to something rational".
Preliminary patches are at
http://patchwork.ozlabs.org/linuxppc/patch?id=14884
and following.
--linas
-
To unsubscribe from this list: s
In certain rare cases, it can be nice to be able to check
if napi is enabled or not. Create an is_napi_enabled() call.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
---
Actually, I'm confused about whether I'd mailed this previously.
It might be a duplicate submission.
On Fri, Nov 09, 2007 at 06:02:34PM +0100, Ingo Oeser wrote:
> Linas Vepstas schrieb:
> > + * napi_enabled_p - return non-zero if napi enabled
> > + *
> > + * Mnemonic: _p stands for "predicate", returning a yes/no
> > + * answer to the question.
>
> Cal
On Thu, Nov 08, 2007 at 07:21:01PM -0600, Wen Xiong wrote:
> Hi Linas,
>
> I saw you have submitted several patches to support pci-express network
> adapters EEH. But looks only this patch fixed something in linux kernel
> code.
And its an old patch, submitted long ago ... I
On Wed, Nov 07, 2007 at 02:45:18PM -0800, Kok, Auke wrote:
> [adding netdev, jeff G to the Cc]
>
> Linas Vepstas wrote:
> > On Wed, Nov 07, 2007 at 01:50:17PM -0800, Kok, Auke wrote:
> >> Linas Vepstas wrote:
> >>> If a PCI bus error is encountered during d
Hi,
On Wed, Nov 07, 2007 at 03:43:59PM -0600, Linas Vepstas wrote:
>
> PCI error recovery usually involves the PCI adapter being reset.
> If the device is using MSI, the reset will cause the MSI state
> to be lost; the device driver needs to restore the MSI state.
>
> The pci
symbol, so
that it can be used in a modle.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
I am so sorry I wasn't able to send this 3 weeks ago, when
I first wrote the patch. There was simply no functional
hardware available to actually run this stuff :-(
Patches that use this
it has been setup by firmware.
>
> This should be sufficient for restoring the MSI state after a device
> reset, however we will need to revisit this for suspend to disk if that
> is ever implemented on pseries.
>
> Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]>
> --
On Tue, Oct 23, 2007 at 07:24:27AM +1000, Benjamin Herrenschmidt wrote:
>
> On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote:
> > On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote:
> > >
> > > On pseries there's a chance it will work for
On Fri, Oct 19, 2007 at 05:53:08PM -0700, David Miller wrote:
> From: [EMAIL PROTECTED] (Linas Vepstas)
> Date: Fri, 19 Oct 2007 19:46:10 -0500
>
> > FWIW, it looks like not all that many arches do this; the output
> > for grep -r address_hi * is pretty thin. Then, looki
n't get access to msi-capable
hardware until a few weeks ago; that's why this is coming up just now.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
pc laptops currently use msi-enabled devices,
as otherwise, this would have been flushed out.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
e MSI state during PCI error recovery.
> >
> > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
> > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]>
> > Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
>
> I'm not so sure about this.
>
> Perha
Hi,
On Fri, Oct 19, 2007 at 05:27:06PM -0700, David Miller wrote:
> From: [EMAIL PROTECTED] (Linas Vepstas)
> Date: Fri, 19 Oct 2007 19:04:21 -0500
>
> > I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see
> > that happening. viz. read_msi_msg() is
I know that no one ever suspends/resumes the big servers I work
on, sooo :-)
Actually, looking at arch/i386/kernel/io_apic.c, it looks like
the msi state is being saved only when CONFIG_SMP is set, so
it seems to me that the restore will fail on uni systems ...
are there any of those left?
--linas
t; is needed to restore the MSI state during PCI error recovery.
> > >
> > > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
> > > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]>
> > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
>
On Fri, Oct 19, 2007 at 02:36:56PM -0700, Matt Carlson wrote:
> This patch exports the pci_restore_msi_state() function. This function
> is needed to restore the MSI state during PCI error recovery.
>
> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
> Signed-off-by:
t; > will get missed (seeing how I just missed 2.6.23 ..)
>
> Yes, I know. David Miller hasn't opened up a 2.6.24 tree yet. We'll
> probably have a number of patches to be submitted for 2.6.24, and we'll
> add this one to the set. Thanks.
Did the patch make it in?
after above sequence, because it can't receive
> >interrupts.
> >
> >This patch changes spidernet interrupt handler that it compares
> >interrupt reason with SPIDER_NET_INTX_MASK_VALUE.
> >
> >Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
>
rent estimated
> > interval.
>
> This is one of many reasons why hardware interrupt mitigation
> is really needed for this.
When turning off interrupts, don't turn them *all* off.
Leave the queue-full interrupt always on.
--linas
-
To unsubscribe from this list: send the line &
00 jiffy)
is 83 packets a jiffy (for big packets, even more for small packets,
and more again for 10 gigabit cards). So polling once per jiffy is a
latency disaster.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message t
On Fri, Aug 24, 2007 at 09:04:56PM +0200, Bodo Eggert wrote:
> Linas Vepstas <[EMAIL PROTECTED]> wrote:
> > On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote:
> >> 3) On modern systems the incoming packets are processed very fast.
> >> Especiall
ance of the test case. Since the folks who came up with the
test case were adamant, I turned off the defferred interrupts.
While defferred interrupts are an "obvious" solution, I decided that
they weren't a good solution. (And I have no other solution to offer).
--linas
-
To unsub
nking that, if the system is under heavy load, then the interrupt
rate would fall, since (for less pathological network loads) more
packets would queue up before the poll was serviced. But I did not
actually measure the interrupt rate under heavy load ...
--linas
-
To unsubscribe from
_enable_interrupts(card);
at the end of spider_net_open(). Because of this, it seems like
Arnd's patch is no longer needed, right?
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
it seems this pach is no longer needed, right?
I'll pursue with Kou Ishizaki, who pointed out that
I'd missed your email.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 12, 2007 at 01:19:11AM +0200, Arnd Bergmann wrote:
> Index: linux-2.6/drivers/net/spider_net.c
Sorry, this one got lost in my mailbox. Will attend to it shortly.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EM
On Mon, Aug 13, 2007 at 10:07:25AM -0700, Joe Perches wrote:
> On Mon, 2007-08-13 at 10:45 -0500, Linas Vepstas wrote:
> > Note quite right. spider-pic is not part of spider_net.
>
> SPIDERNET NETWORK DRIVER for CELL
> P:Linas Vepstas
> M:[EMAIL PROTECTED]
> L:
INTAINERS
> @@ -4377,6 +4377,9 @@ P: Linas Vepstas
> M: [EMAIL PROTECTED]
> L: netdev@vger.kernel.org
> S: Supported
> +F: Documentation/networking/spider_net.txt
> +F: arch/powerpc/platforms/cell/spider-pic.c
> +F: drivers/net/spider_net*
Note quite right.
DMA allocation? Does it
improve only a certain type of traffic (large/small packets, etc.)
-- Example code? What's the API? How should my driver use it?
Right now, I can maybe find answers by doing lots of googling. I'd like
to have some quick way of getting a grip on this.
--linas
Add support for PCI Error Recovery for the tg3 ethernet
device driver. The general principles of operation are
described in Documentation/pci-error-recovery.txt
Other drivers having similar structure include e100,
e1000, ixgb, s2io, ipr, sym53c8xx_2, and lpfc
Signed-off-by: Linas Vepstas <[EM
On Fri, Jul 13, 2007 at 03:47:02PM -0700, David Miller wrote:
> From: [EMAIL PROTECTED] (Linas Vepstas)
> Date: Fri, 13 Jul 2007 15:05:15 -0500
>
> >
> > This is a patch (& bug report) for a crash in sysctl_set_parent()
> > in 2.6.22-git2.
> >
> >
gt; Actually come to think of it I am concerned that someone added a
> settable entry into /proc/sys/ it should at least be in /proc/sys/net/
> where it won't conflict with other uses of that directory. Especially
> as things like network devices have user controlled names.
Sigh. S
e line: + ctl_table devinet_root_dir[3];
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
I tried to audit some of the code to see where else there
might be similar badly-formed static declarations. This is hard,
as there's a lot of code. Most seems fine.
net/core/neighbour.c |4 ++
On Wed, Jul 11, 2007 at 04:57:38PM +0900, Ishizaki Kou wrote:
[...]
> I need more investigation. Please drop the patch.
OK.
--linas
p.s. I tested ifdown/ifup, and didn't see any problems.
Does your bug happen immediately, or does it take many attempts
to trigger it?
-
To unsubscr
calls netif_rx_complete() which
causes BUG_ON() because __LINK_STATE_RX_SCHED is not set.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Jeff, please apply for 2.6.23
Linas.
drivers/net/s
;diff -Nupr"? it adds some extra information
(the name of the subroutine) to the patch chunks; this makes
it easier to read.
QUILT_DIFF_OPTS="-Nupr"
in ~/.quiltrc if you use quilt.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bo
n/ifup. The device open/close
routines should reset all hardware state; this shouldn't make
any difference. (It doesn't for me, at least).
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 09, 2007 at 10:50:19AM +0900, Akira Tsukamoto wrote:
> Hi,
>
> On Fri, 6 Jul 2007 13:02:41 -0500, [EMAIL PROTECTED] (Linas Vepstas)
> mentioned:
> > of the spidernet device driver. Please note that the old
> > spidernet had absolutely disasterous performa
t be better to just add the hypervisor bits-n-pieces
to spidernet? That way, you get not only the various fixes, but
also the benefit of fairly regular testing...
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED
Replace literal with const; add bit definitions.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote:
> A follow-up patch needs to remove the above magic numbers (==numeric
> constants), replacing them with named consta
On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >--- linux-2.6.22-rc1.orig/drivers/net/spider_net.c 2007-06-11
> >10:02:34.0 -0500
> >+++ linux-2.6.22-rc1/drivers/net/spider_net.c2007-06-11
> >11:45:25.0
eeds, its petty easy to fill this thing
up multiple times per jiffy. The driver should continue to operate
either way, but the larger queue should keep it from being a busy
beaver.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jun 13, 2007 at 04:10:17PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >Avoid kernel crash in mm/slab.c due to double-free of pointer.
> >
> >If the ethernet interface is brought down while there is still
> >RX traffic in flight, the device shutdown rout
d be.
> >
>
> As I just stated, many of the patches in the "current" patch series have
>
> Linas Vepstas (11):
> s2io: add PCI error recovery support
> s2io: add PCI error recovery support
> spidernet: beautify error messages
> spide
On Tue, Jun 12, 2007 at 07:00:17PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote:
> >>On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote:
> >>>On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michae
Documentation for the spidernet driver.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Documentation/networking/spider_net.txt | 204
1 file changed, 204 insertions(+)
Index: linux-2.6.22-rc1/Documentation/networking/spider_n
The transmit frame tail bit is stranglely misnamed as
"no checksum". Fix the name to what it should be:
"transmit frame tail". No functional change,
just a name change.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |2 +-
drive
Put the enable and disable routines next to one-another,
as this makes verifying thier symmetry that much easier.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
Another way of minimizing the likelyhood of RX ram from overflowing
is to empty out the entire rx ring every chance we get. Change
the crazy watchdog timeout from 50 seconds to 3 seconds, while
we're here.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_n
When entering the netdev poll routine, empty out the RX
chain first, before cleaning up the TX chain. This should
help avoid RX buffer overflows.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Invalidate a pointer as its pci_unmap'ed; this is a bit of
paranoia to make sure hardware doesn't continue trying to
DMA to it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Ind
Crazy device problems are hard to debug, when one does not have
good trace info. This patch makes a major enhancement to the
device dump routine.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 78 ++-
Use dev_err() to print device error messages.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 64 ---
1 file changed, 34 insertions(+), 30 deletions(-)
Index: linux-2.6.22-rc1/drivers/net/spider
htool tx csum, and it
should use the standard ethtool_op_get_link.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
-
drivers/net/spider_net.c |4 ++--
drivers/net/spider_net_ethtool.c | 21 +++--
2 f
From: Florin Malita <[EMAIL PROTECTED]>
The stats update code in spider_net_pass_skb_up() is touching the skb
after it's been passed up to the stack. To avoid that, just update the
stats first.
Signed-off-by: Florin Malita <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas
sync_head_ptr() subroutine will
search the ring for the next full descr, and the driver will resume
operations there. Since this will leave "holes" in the ring, there
is also a spider_net_resync_tail_ptr() that will skip over such holes.
Signed-off-by: Li
At some point, the transmit descriptor chain end interrupt (TXDCEINT)
was turned on. This is a mistake; and it damages small packet
transmit performance, as it results in a huge storm of interrupts.
Turn it off.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider
Although the previous patch resolved issues with hangs when the
RX ram full interrupt is encountered, there are still situations
where lots of RX ramfull interrupts arrive, resulting in a noisy
log in syslog. There is no need for this.
Signed-off-by: Linas Vepstas <[EMAIL PROTEC
on't do it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Index: linux-2.6.22-rc1/drivers/net/spider_net.c
===
---
pointer.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |1 +
1 file changed, 1 insertion(+)
Index: linux-2.6.22-rc1/drivers/net/spider_net.c
===
--- linux-2.6.22-rc1.orig/drivers/net/spider
On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote:
> On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote:
> > On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael Ellerman wrote:
> > > On Thu, 2007-06-07 at 14:17 -0500, Linas Vepstas wrote:
> > > >
&
On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael Ellerman wrote:
> On Thu, 2007-06-07 at 14:17 -0500, Linas Vepstas wrote:
> > Jeff, please apply for the 2.6.23 kernel tree. The pach series
> > consists of two major bugfixes, and several bits of cleanup.
> >
> &
Documentation for the spidernet driver.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Documentation/networking/spider_net.txt | 204
1 file changed, 204 insertions(+)
Index: linux-2.6.22-rc1/Documentation/networking/spider_n
At some point, the transmit descriptor chain end interrupt (TXDCEINT)
was turned on. This is a mistake; and it damages small packet
transmit performance, as it results in a huge storm of interrupts.
Turn it off.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider
The transmit frame tail bit is stranglely misnamed as
"no checksum". Fix the name to what it should be:
"transmit frame tail". No functional change,
just a name change.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |2 +-
drive
A minor optimization on the RX side is that the hardware does
not need to be kicked if space did not open up in the RX ring.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Index: linux-
Altough the previous patch resolved issues with hangs when the
RX ram full interrupt is encountered, there are still situations
where lots of RX ramfull interrupts arrive, rsulting in a noisy
log in syslog. There is no need for this.
Signed-off-by: Linas Vepstas <[EMAIL PROTEC
sync_head_ptr() subroutine will
search the ring for the next full descr, and the driver will resume
operations there. Since this will leave "holes" in the ring, there
is also a spider_net_resync_tail_ptr() that will skip over such holes.
Signed-off-by: Li
The current error checking is flagging some perfectly normal, but
usually rare packets as being bad. Do not flag these packets.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
Index: linux-
Another way of minimizing the likelyhood of RX ram from overflowing
is to empty out the entire rx ring every chance we get. Change
the crazy watchdog timeout from 50 seconds to 3 seconds, while
we're here.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_n
When entering the netdev poll routine, empty out the RX
chain first, before cleaning up the TX chain. This should
help avoid RX buffer overflows.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Some versions of the spider have a firmware bug, where the
RX ring sequencer goes crazy when the RX RAM on the device
fills up. Appearently the only viable wrkaround is a soft
reset of the card.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c
Crazy device problems are hard to debug, when one does not have
good trace info. This patch makes a major enhancement to the
device dump routine.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 78 ++-
Subject: [PATCH 7/18] spidernet: Don't terminate the RX ring
There is no real reason to terminate the RX ring; it
doesn't make the operation any smooother, and it does
require an extra sync. So don't do it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/ne
If the ethernet interface is brought down while there is still
RX traffic in flight, the device shutdown routine can end up
trying to double-free an skb, leading to a crash in mm/slab.c
Avoid the double-free by nulling out the skb pointer.
Signed-off-by: Linas Vepstas <[EMAIL PROTEC
Invalidate a pointer as its pci_unmap'ed; this is a bit of
paranoia to make sure hardware doesn't continue trying to
DMA to it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Ind
Put the enable and disable routines next to one-another,
as this makes verifying thier symmetry that much easier.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
htool tx csum, and it
should use the standard ethtool_op_get_link.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
-
drivers/net/spider_net.c |4 ++--
drivers/net/spider_net_ethtool.c | 21 +++--
2 f
Use dev_err() to print device error messages.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 67 ---
drivers/net/spider_net.h |2 -
2 files changed, 36 insertions(+), 33 deletions(-)
Index: linux-2.6.
From: Florin Malita <[EMAIL PROTECTED]>
The stats update code in spider_net_pass_skb_up() is touching the skb
after it's been passed up to the stack. To avoid that, just update the
stats first.
Signed-off-by: Florin Malita <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas
causing a sever performance
degardation for small packets.
Minor updates include an expanded ring dump routine, and
documentation for some portions of the device driver.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTE
7;t need it's own get/set for ethtool tx csum, and it
> should use the standard ethtool_op_get_link.
Can you provide a signed-off-by line, please? I was hoping to submit
upstream today.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
7;t need it's own get/set for ethtool tx csum, and it
> should use the standard ethtool_op_get_link.
>
> NOT TESTED (no CELL hardware).
It seems to work. I've been distracted with other spidernet issues;
I will forward your patch upstream early next week.
--linas
-
On Thu, May 24, 2007 at 05:20:24PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >Don't run any of the MSI handlers if the channel is off;
> >also don't gather device statatistics. Also, netif_wake
> >not needed, per suggestions from
> >Sivakumar Subrama
Another way of minimizing the likelyhood of RX ram from overflowing
is to empty out the entire rx ring every chance we get. Change
the crazy watchdog timeout from 50 seconds to 3 seconds, while
we're here.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_n
When entering the netdev poll routine, empty out the RX
chain first, before cleaning up the TX chain. This should
help avoid RX buffer overflows.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Some versions of the spider have a firmware bug, where the
RX ring sequencer goes crazy when the RX RAM on the device
fills up. Appearently the only viable wrkaround is a soft
reset of the card.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c
Crazy device problems are hard to debug, when one does not have
good trace info. This patch makes a major enhancement to the
device dump routine.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 62 ---
There is no real reason to terminate the RX ring; it
doesn't make the operation any smooother, and it does
require an extra sync. So don't do it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 18 +-
1 file changed, 9
If the ethernet interface is brought down while there is still
RX traffic in flight, the device shutdown routine can end up
trying to double-free an skb, leading to a crash in mm/slab.c
Avoid the double-free by nulling out the skb pointer.
Signed-off-by: Linas Vepstas <[EMAIL PROTEC
Invalidate a pointer as its pci_unmap'ed; this is a bit of
paranoia to make sure hardware doesn't continue trying to
DMA to it.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
I
mething to the hardware.
All that I really acomplished here is a minor trick to
aid in debug printing when looking for something bad.
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Put the enable and disable routines next to one-another,
as this makes verifying thier symmetry that much easier.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
Make error messages print which interface they apply to.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
drivers/net/spider_net.c | 10 ++
drivers/net/spider_net.h |2 +-
2 files changed, 7 insertions(+), 5 deletions(-)
Index: netdev-2.6/drivers/net/spider
From: Florin Malita <[EMAIL PROTECTED]>
The stats update code in spider_net_pass_skb_up() is touching the skb
after it's been passed up to the stack. To avoid that, just update the
stats first.
Signed-off-by: Florin Malita <[EMAIL PROTECTED]>
Signed-off-by: Linas Vepstas
Don't run any of the MSI handlers if the channel is off;
also don't gather device statatistics. Also, netif_wake
not needed, per suggestions from
Sivakumar Subramani <[EMAIL PROTECTED]>.
Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]>
Cc: Ramkrishna Vepa <[EMAIL
t; >hasn't yet pulled from it?
>
> It only appeared in my tree on May 14. I tend to drop patches that are
> repeatedly revised, allowing the dust to settle.
OK, a new patch is coming. I did not want to pester you until after -rc1
came out, but perhaps that was the wrong strat
On Mon, May 21, 2007 at 02:48:47PM -0700, Andrew Morton wrote:
> On Mon, 21 May 2007 13:58:53 -0500
> [EMAIL PROTECTED] (Linas Vepstas) wrote:
> > This patch adds PCI error recovery support to the
>
> This is already in Jeff's development tree. Your new patch neither
>
1 - 100 of 316 matches
Mail list logo
