[PATCH RESEND v1] qed: Fix copy of uninitialized memory

2017-03-07 Thread Robert Foss
this memory is real. Detected by CoverityScan, CID#1399632 ("Uninitialized scalar variable") Signed-off-by: Robert Foss --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drive

[PATCH v1] qed: Fix copy of uninitialized memory

2017-03-01 Thread Robert Foss
this memory is real. Detected by CoverityScan, CID#1399632 ("Uninitialized scalar variable") Signed-off-by: Robert Foss --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drive

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-06 Thread Robert Foss
On 2016-09-06 12:41 PM, Grant Grundler wrote: On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote: On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: I'm not quite sure how the first From line was added, it should not have been. Grant Grundler is most definitely the author. Woul

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-01 Thread Robert Foss
On 2016-09-01 12:43 PM, Eric Dumazet wrote: On Mon, 2016-08-29 at 09:32 -0400, robert.f...@collabora.com wrote: From: Robert Foss From: Grant Grundler The miii_nway_restart() causes a PHY link change activity and ax88772_link_reset will be called. link_reset will set

Re: [PATCH v3 0/5] net/usb: asix driver improvements

2016-08-31 Thread Robert Foss
echo "Command failed" fi done iperf3 UDP: sudo iperf3 -c 192.168.0.28 -u -b 100M -t 0 On 2016-08-29 09:32 AM, robert.f...@collabora.com wrote: From: Robert Foss This is a resubmission of v3, since the netdev mailinlist was not sent the previous submission. T

[PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected

2016-08-29 Thread robert . foss
From: Robert Foss From: Vincent Palatin Check the answers from the USB stack and avoid re-sending multiple times the request if the device has disappeared. Signed-off-by: Vincent Palatin Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix_common.c | 56

[PATCH v3 0/5] net/usb: asix driver improvements

2016-08-29 Thread robert . foss
From: Robert Foss This is a resubmission of v3, since the netdev mailinlist was not sent the previous submission. This series improves power management of the asix driver. - Suspend/resume support is improved to save needed registers. - Device disconnection is improved. - Fixes AX88772x

[PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected

2016-08-29 Thread robert . foss
From: Vincent Palatin Check the answers from the USB stack and avoid re-sending multiple times the request if the device has disappeared. Signed-off-by: Vincent Palatin Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix_common.c | 56

[PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-08-29 Thread robert . foss
negotiation result. So do this first. Ignore the ret value since it's ignored in XXX_link_reset() functions. Signed-off-by: Grant Grundler Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix_devices.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --

[PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-08-29 Thread robert . foss
From: Robert Foss From: Grant Grundler The miii_nway_restart() causes a PHY link change activity and ax88772_link_reset will be called. link_reset will set AX_CMD_WRITE_MEDIUM_MODE register correctly. The asix_write_medium_mode in reset() fills in a default value to the register which may be

[PATCH v3 4/5] net: asix: see 802.3 spec for phy reset

2016-08-29 Thread robert . foss
From: Robert Foss From: Grant Grundler https://lkml.org/lkml/2014/11/11/947 Ben Hutchings is correct. IEEE 802.3 spec section "22.2.4.1.1 Reset" requires up to 500ms delay. Mitigate the "max" delay by polling the phy until BCM_RESET bit is clear. Signed-off-by: Grant Gru

[PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-08-29 Thread robert . foss
From: Robert Foss From: Allan Chou The change fixes AX88772x resume failure by - Restore incorrect AX88772A PHY registers when resetting - Need to stop MAC operation when suspending - Need to restart MII when restoring PHY Signed-off-by: Allan Chou Signed-off-by: Robert Foss Tested-by

[PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-08-29 Thread robert . foss
From: Allan Chou The change fixes AX88772x resume failure by - Restore incorrect AX88772A PHY registers when resetting - Need to stop MAC operation when suspending - Need to restart MII when restoring PHY Signed-off-by: Allan Chou Signed-off-by: Robert Foss Tested-by: Robert Foss

[PATCH v3 1/5] net: asix: Add in_pm parameter

2016-08-29 Thread robert . foss
function to ensure the PHY works correctly. Signed-off-by: Freddy Xin Signed-off-by: Robert Foss Tested-by: Robert Foss --- drivers/net/usb/asix.h | 40 +++-- drivers/net/usb/asix_common.c | 180 +++- drivers/net/usb/asix_devices.c | 373

[PATCH v3 4/5] net: asix: see 802.3 spec for phy reset

2016-08-29 Thread robert . foss
From: Grant Grundler https://lkml.org/lkml/2014/11/11/947 Ben Hutchings is correct. IEEE 802.3 spec section "22.2.4.1.1 Reset" requires up to 500ms delay. Mitigate the "max" delay by polling the phy until BCM_RESET bit is clear. Signed-off-by: Grant Grundler Signed

[PATCH v3 1/5] net: asix: Add in_pm parameter

2016-08-29 Thread robert . foss
From: Robert Foss From: Freddy Xin In order to R/W registers in suspend/resume functions, in_pm flags are added to some functions to determine whether the nopm version of usb functions is called. Save BMCR and ANAR PHY registers in suspend function and restore them in resume function. Reset

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Robert Foss
From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin as recorded in the following code reviews (and testing) that I was responsible for: https://chromium-review.googlesource.com/#/q/owner:%22G

[PATCH 1/3] net: asix: Add in_pm parameter

2016-07-25 Thread robert . foss
From: Grant Grundler In order to R/W registers in suspend/resume functions, in_pm flags are added to some functions to determine whether the nopm version of usb functions is called. Save BMCR and ANAR PHY registers in suspend function and restore them in resume function. Reset HW in resume func

[PATCH 2/3] net: asix: Avoid looping when the device is disconnected

2016-07-25 Thread robert . foss
From: Vincent Palatin Check the answers from the USB stack and avoid re-sending multiple times the request if the device has disappeared. Signed-off-by: Vincent Palatin --- drivers/net/usb/asix_common.c | 56 +- drivers/net/usb/asix_devices.c | 2 ++ 2

[PATCH 3/3] net: asix: Fix AX88772x resume failures

2016-07-25 Thread robert . foss
From: WK Tsai The change fixes AX88772x resume failure by - Restore incorrect AX88772A PHY registers when resetting - Need to stop MAC operation when suspending - Need to restart MII when restoring PHY Signed-off-by: WK Tsai --- drivers/net/usb/asix_devices.c | 47 +