Re: [PATCH net-next v7] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-11 Thread Samuel Mendoza-Jonas
ut () > -> Netlink interface (msg with zero data length) > -> user space application > > Error: > Error detected > -> ncsi_send_netlink_err () > -> Netlink interface (err msg) > -> user space application > > > Signed-off-by: Justin Lee > Reviewed-by: Samuel Mendoza-Jonas

Re: [RFC PATCH 2/2] net/ncsi: Configure multi-package, multi-channel modes with failover

2018-10-10 Thread Samuel Mendoza-Jonas
On Wed, 2018-10-10 at 22:36 +, justin.l...@dell.com wrote: > Hi Samuel, > > I am still testing your change and have some comments below. > > Thanks, > Justin > > > > This patch extends the ncsi-netlink interface with two new commands and > > three

Re: [PATCH net-next v5] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-10 Thread Samuel Mendoza-Jonas
On Wed, 2018-10-10 at 18:11 +, justin.l...@dell.com wrote: > + > + len = nla_len(info->attrs[NCSI_ATTR_DATA]); > + if (len < sizeof(struct ncsi_pkt_hdr)) { > + netdev_info(ndp->ndev.dev, "NCSI: no command to send %u\n", > + package_id); > +

Re: [PATCH net-next v3] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-09 Thread Samuel Mendoza-Jonas
ut () > -> Netlink interface (msg with zero data length) > -> user space application > > Error: > Error detected > -> ncsi_send_netlink_err () > -> Netlink interface (err msg) > -> user space application Hi Justin, I've built a

Re: [PATCH v3] net/ncsi: Add NCSI OEM command support

2018-10-04 Thread Samuel Mendoza-Jonas
handler for OEM > commands > ncsi_rsp_handler_oem: This is a generic response handler for OEM commands > > Signed-off-by: Vijay Khemka Reviewed-by: Samuel Mendoza-Jonas Technically this patch should also be marked [PATCH net-next] to target David's next tree. > --- > net/ncsi/inter

Re: [PATCH net v2] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-01 Thread Samuel Mendoza-Jonas
On Fri, 2018-09-28 at 18:15 +, justin.l...@dell.com wrote: > The new command (NCSI_CMD_SEND_CMD) is added to allow user space application > to send NC-SI command to the network card. > Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and > response. > > The work flow is

Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-01 Thread Samuel Mendoza-Jonas
handler for OEM > commands > ncsi_rsp_handler_oem: This is a generic response handler for OEM commands > > Signed-off-by: Vijay Khemka Hi Vijay - looks good to me, and should be a good common base for your and Justin's changes. Reviewed-by: Samuel Mendoza-Jonas > --- > net/ncsi

Re: [PATCH net] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-09-27 Thread Samuel Mendoza-Jonas
On Thu, 2018-09-27 at 21:08 +, justin.l...@dell.com wrote: > The new command (NCSI_CMD_SEND_CMD) is added to allow user space application > to send NC-SI command to the network card. > Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and > response. > > The work flow is

Re: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass

2018-09-26 Thread Samuel Mendoza-Jonas
On Thu, 2018-09-27 at 13:43 +1000, Samuel Mendoza-Jonas wrote: > On Mon, 2018-09-24 at 17:08 -0700, Vijay Khemka wrote: > > This patch adds OEM command to get mac address from NCSI device and and > > configure the same to the network card. > > > > ncsi_cmd_arg - Modifie

Re: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass

2018-09-25 Thread Samuel Mendoza-Jonas
o any one path Justin - could you weigh in here and give a description of your intended changes? Are you able to post your changes upstream so we can compare? Regards, Samuel > > On 9/24/18, 5:30 PM, "Joel Stanley" wrote: > > Hi Vijay, >

Re: [PATCH 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI

2018-06-18 Thread Samuel Mendoza-Jonas
On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote: > Sam has been handing the maintenance of NCSI for a number release cycles > now. > > Signed-off-by: Joel Stanley I'm exposed! Acked-by: Samuel Mendoza-Jonas > --- > MAINTAINERS | 5 + > 1 file changed, 5 in

Re: [PATCH 3/4] net/ncsi: Use netdev_dbg for debug messages

2018-06-18 Thread Samuel Mendoza-Jonas
> DEBUG is set or this specific netdev_dbg is enabled > via the dynamic debug control file. Right this is fine for these sort of messages; very noisy and not particularly critical. For this and the other logging updates: Acked-by: Samuel Mendoza-Jonas > > > Signed-off-by: Joel Stanley

[PATCH RESEND net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-16 Thread Samuel Mendoza-Jonas
639] == Reported-by: Joel Stanley <j...@jms.id.au> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/internal.h | 34 +++--- net/ncsi/ncsi-manage.c | 226 +--- net/ncsi/ncsi-netlink.c | 20 ++-- net/ncsi/ncsi-

[PATCH net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-08 Thread Samuel Mendoza-Jonas
639] == Reported-by: Joel Stanley <j...@jms.id.au> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/internal.h | 34 +++--- net/ncsi/ncsi-manage.c | 226 +--- net/ncsi/ncsi-netlink.c | 20 ++-- net/ncsi/ncsi-

[PATCH net-next v2] net/ncsi: Add generic netlink family

2018-03-04 Thread Samuel Mendoza-Jonas
, and NCSI_CMD_CLEAR_INTERFACE which clears any preferred setting. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v2: Add a separate NCSI_CMD_CLEAR_INTERFACE command instead of allowing missing attributes in NCSI_CMD_SET_INTERFACE. include/uapi/linux/ncsi.h | 115 + net/ncsi/Ma

Re: [PATCH net-next] net/ncsi: Add generic netlink family

2018-02-26 Thread Samuel Mendoza-Jonas
On Mon, 2018-02-26 at 11:31 -0500, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Fri, 23 Feb 2018 15:15:18 +1100 > > > + * @NCSI_CMD_SET_INTERFACE: set preferred package and channel combination. > > + * Requires NCSI_ATT

[PATCH net-next] net/ncsi: Add generic netlink family

2018-02-22 Thread Samuel Mendoza-Jonas
-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- include/uapi/linux/ncsi.h | 113 + net/ncsi/Makefile | 2 +- net/ncsi/internal.h | 3 + net/ncsi/ncsi-manage.c| 30 +++- net/ncsi/ncsi-netlink.c | 394 ++ net/ncs

Re: [RFC PATCH] net/ncsi: Add generic netlink family

2018-02-15 Thread Samuel Mendoza-Jonas
On Thu, 2018-02-15 at 14:50 +1030, Joel Stanley wrote: > Hey Sam, > > On Thu, Feb 15, 2018 at 2:00 PM, Samuel Mendoza-Jonas > <s...@mendozajonas.com> wrote: > > Add a generic netlink family for NCSI. This supports two commands; > > NCSI_CMD_PKG_INFO which r

[PATCH net-next] net/ncsi: Don't take any action on HNCDSC AEN

2017-12-14 Thread Samuel Mendoza-Jonas
. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-aen.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index 67e708e98ccf..e7b05de1e6d1 100644 --- a/net/ncsi/ncsi-aen.c

[GIT] [4.15] NFC update

2017-11-10 Thread Samuel Ortiz
Hi David, This is the NFC pull request for 4.15. We have: - A new netlink command for explicitly deactivating NFC targets - i2c constification for all NFC drivers - One NFC device allocation error path fix The following changes since commit 2798b80b385384d51a81832556ee9ad25d175f9b: Merge

[PATCH net-next 2/2] net/ncsi: Don't return error on normal response

2017-11-07 Thread Samuel Mendoza-Jonas
. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-rsp.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 58186c4102f0..efd933ff5570 100644 --- a/net/ncsi/ncsi

[PATCH net-next 1/2] net/ncsi: Improve general state logging

2017-11-07 Thread Samuel Mendoza-Jonas
The NCSI driver is mostly silent which becomes a headache when trying to determine what has occurred on the NCSI connection. This adds additional logging in a few key areas such as state transitions and calling out certain errors more visibly. Signed-off-by: Samuel Mendoza-Jonas &l

Re: [PATCH] NFC: fix device-allocation error return

2017-11-05 Thread Samuel Ortiz
/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks for the fix. Cheers, Samuel.

[PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length

2017-10-18 Thread Samuel Mendoza-Jonas
Correct the value of the HNCDSC AEN packet. Fixes: 7a82ecf4cfb85 "net/ncsi: NCSI AEN packet handler" Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-aen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-aen.c b/net

[PATCH net 3/5] net/ncsi: Disable HWA mode when no channels are found

2017-10-18 Thread Samuel Mendoza-Jonas
ed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-manage.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index b022deb39d31..0

[PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive

2017-10-18 Thread Samuel Mendoza-Jonas
0x164) [ 459.04] [<80033614>] (kthread) from [<8000a5e8>] (ret_from_fork+0x14/0x2c) This also updates the monitor instead of just returning if ncsi_xmit_cmd() fails to send the get-link-status command so that the monitor properly times out. Fixes: e6f44ed6d04d3 &quo

[PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout

2017-10-18 Thread Samuel Mendoza-Jonas
failing channel should be set to active in order for deinitialization and failover to be done. Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-manage.c | 8 +--- 1 file changed, 5 insertions(+)

[PATCH net 5/5] net/ncsi: Fix length of GVI response packet

2017-10-18 Thread Samuel Mendoza-Jonas
n <gws...@linux.vnet.ibm.com> Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-rsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 265b9a892d41..927dad4759d1 100644 --- a/net/ncsi/ncsi-rsp.c +++ b/n

[PATCH net] net/ncsi: Don't limit vids based on hot_channel

2017-10-10 Thread Samuel Mendoza-Jonas
only drop a new VLAN id if we are already tracking the maximum allowed by the NCSI specification. Per-channel limits are already handled by ncsi_add_filter(), but add a message to set_one_vid() to make it obvious that the channel can not support any more VLAN ids. Signed-off-by: Samuel Mendoza-Jonas

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-26 Thread Samuel Mendoza-Jonas
On Thu, 2017-09-21 at 18:11 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Fri, 22 Sep 2017 11:00:00 +1000 > > > If we haven't configured a channel yet (or are in the process of doing > > so) we won't have a hot_channe

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-21 Thread Samuel Mendoza-Jonas
On Wed, 2017-09-20 at 16:05 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Wed, 20 Sep 2017 14:12:51 +1000 > > > When handling new VLAN tags in NCSI we check the maximum allowed number > > of filters on the last active ("ho

[PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-19 Thread Samuel Mendoza-Jonas
is missing. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-manage.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 3fd3c39e6278..fc800f934beb 100644 --- a/net/nc

[PATCH net-next] net/ncsi: Define {add,kill}_vid callbacks for !CONFIG_NET_NCSI

2017-08-30 Thread Samuel Mendoza-Jonas
an_rx_kill_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] >>> undefined! >>> ERROR: "ncsi_vlan_rx_add_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] >>> undefined! Add definitions for !CONFIG_NET_NCSI to bring it into line with the rest of

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-29 Thread Samuel Mendoza-Jonas
On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Mon, 28 Aug 2017 16:18:40 +1000 > > > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. > > A fair amount of code alrea

[PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-28 Thread Samuel Mendoza-Jonas
changes when kicking updated channel Samuel Mendoza-Jonas (3): net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter ftgmac100: Support NCSI VLAN filtering when available drivers/net/ethernet/faraday/ftgmac100.c | 5 + include/net/ncsi.h | 2

[PATCH net-next v3 1/3] net/ncsi: Fix several packet definitions

2017-08-28 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi

[PATCH net-next v3 2/3] net/ncsi: Configure VLAN tag filter

2017-08-28 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v3: - Add comment describing change to ncsi_find_filter() - Catch NULL in clear_one_vid() from ncsi_get_filter() - S

[PATCH net-next v3 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-28 Thread Samuel Mendoza-Jonas
Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available. This allows the VLAN core to notify the NCSI driver when changes occur so that the remote NCSI channel can be properly configured to filter on the set VLAN tags. Signed-off-by: Samuel

Re: [PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

2017-08-13 Thread Samuel Mendoza-Jonas
On Mon, 2017-08-14 at 11:39 +0930, Joel Stanley wrote: > On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas > <s...@mendozajonas.com> wrote: > > Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI > > stack process new VLAN tags and configure

[PATCH net-next v2 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-13 Thread Samuel Mendoza-Jonas
Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available. This allows the VLAN core to notify the NCSI driver when changes occur so that the remote NCSI channel can be properly configured to filter on the set VLAN tags. Signed-off-by: Samuel

[PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

2017-08-13 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- include/net/ncsi.h | 2 + net/ncsi/internal.h| 11 ++ net/ncsi/ncsi-manage.c | 295 ++

[PATCH net-next v2 0/3] NCSI VLAN Filtering Support

2017-08-13 Thread Samuel Mendoza-Jonas
adds the appropriate flag and callbacks to the ftgmac100 driver to enable filtering as it's a large consumer of NCSI (and what I've been testing on). Samuel Mendoza-Jonas (3): net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter ftgmac100: Support NCSI VLAN filtering

[PATCH net-next v2 1/3] net/ncsi: Fix several packet definitions

2017-08-13 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi

Re: [PATCH 0/3] NCSI VLAN Filtering Support

2017-08-13 Thread Samuel Mendoza-Jonas
On Fri, 2017-08-11 at 14:48 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas <s...@mendozajonas.com> > Date: Fri, 11 Aug 2017 16:16:45 +1000 > > > This series (mainly patch 3) adds VLAN filtering to the NCSI implementation. > > A fair amount of code alrea

[PATCH 1/3] ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features

2017-08-11 Thread Samuel Mendoza-Jonas
This is required for the VLAN core to call the add/kill callback for VLAN IDs. 'ftgmac100' already supports VLAN tagging but this flag lets the network stack know that we want to be notified of VLAN tags being added or removed when we have NCSI support. Signed-off-by: Samuel Mendoza-Jonas &l

[PATCH 2/3] net/ncsi: Fix several packet definitions

2017-08-11 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index db7083bfd476..1fec9f

[PATCH 0/3] NCSI VLAN Filtering Support

2017-08-11 Thread Samuel Mendoza-Jonas
adds the appropriate flag to the ftgmac100 driver to enable filtering as it's a large consumer of NCSI (and what I've been testing on). Samuel Mendoza-Jonas (3): ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features net/ncsi: Fix several packet definitions net/ncsi: Configure VLAN tag filter

[PATCH 3/3] net/ncsi: Configure VLAN tag filter

2017-08-11 Thread Samuel Mendoza-Jonas
f VLAN tag filters is determined by the "Get Capabilities" response from the channel. Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> --- drivers/net/ethernet/faraday/ftgmac100.c | 2 + include/net/ncsi.h | 2 + net/ncsi/internal.h

[GIT] [4.13] NFC update

2017-06-30 Thread Samuel Ortiz
Hi David, This is the NFC pull request for 4.13. We have: - A conversion to unified device and GPIO APIs for the fdp, pn544, and st{21,-nci} drivers. - A fix for NFC device IDs allocation. - A fix for the nfcmrvl driver firmware download mechanism. - A trf7970a DT and GPIO cleanup and clock

Re: [PATCH] nfc: Add sockaddr length checks before accessing sa_family in bind handlers

2017-06-22 Thread Samuel Ortiz
nsertions(+), 2 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel.

Re: [PATCH] nfc: nci: remove unnecessary null check

2017-06-22 Thread Samuel Ortiz
Roeck <li...@roeck-us.net> > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > --- > net/nfc/nci/core.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel.

Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler

2017-06-22 Thread Samuel Ortiz
deletion(-) Applied, thanks. Cheers, Samuel.

Re: [PATCH] nfc: Fix the sockaddr length sanitization in llcp_sock_connect

2017-06-22 Thread Samuel Ortiz
uld result in the > disclosure of up to ~70 uninitialized bytes from the kernel stack to > user-mode clients capable of creating AFC_NFC sockets. > > Signed-off-by: Mateusz Jurczyk <mjurc...@google.com> > --- > net/nfc/llcp_sock.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel.

Re: [PATCH 0/2] NFC-digital: Adjustments for four function implementations

2017-06-22 Thread Samuel Ortiz
us Elfring (2): > Improve a size determination in four functions > Delete an error message for a failed memory allocation in digital_in_send() Both patches applied to nfc-next, thanks. Cheers, Samuel.

Re: [PATCH v2 03/11] tty: kbd: reduce stack size with KASAN

2017-06-16 Thread Samuel Thibault
> Of course kasan is the problem, but it really just does whatever we > asked it to do, and cannot do any better as long as we inline many > copies of tty_insert_flip_char() into kbd_keycode(). We didn't ask to inline put_queue into kbd_keycode. Samuel

Re: [PATCH v2 03/11] tty: kbd: reduce stack size with KASAN

2017-06-14 Thread Samuel Thibault
/or f_handler[value] into inlines again when it has already > determined the index to be constant. Cool :) But I don't see how it can see find it out constant. The only fn_handler[] caller is k_spec, using value as index. The only caller of f_handler[] is kbd_keycode, using type as index, and keysym&0xff as value. That is definitely not constant :) And it's only one caller, I don't see how that can bloat. Samuel

Re: [PATCH v2 03/11] tty: kbd: reduce stack size with KASAN

2017-06-14 Thread Samuel Thibault
ct vc_data *vc) This one is only referenced, not called, I don't see how that could pose problem. Samuel

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

2017-04-26 Thread Samuel Ortiz
e device-managed resources > NFC: nfcmrvl: use nfc-device for firmware download > NFC: nfcmrvl: fix firmware-management initialisation > NFC: nfcmrvl_uart: fix device-node leak during probe > NFC: nfcmrvl_usb: use interface as phy device > NFC: nfcmrvl: allow gpio 0 for reset signalling Applied, thanks. Cheers, Samuel.

[GIT] [4.12] NFC update

2017-04-20 Thread Samuel Ortiz
wilink driver Samuel Ortiz (1): MAINTAINERS: Remove Lauro and Aloisio from the NFC maintainers list Sudip Mukherjee (1): nfc: fdp: fix NULL pointer dereference Tobias Klauser (1): NFC: nfcmrvl: Include unaligned.h instead of access_ok.h .../devicetree/bindings/net/nfc/trf7970a.tx

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

2017-04-18 Thread Samuel Ortiz
NFC: nfcmrvl: fix firmware-management initialisation > > NFC: nfcmrvl_uart: fix device-node leak during probe > > NFC: nfcmrvl_usb: use interface as phy device > > NFC: nfcmrvl: allow gpio 0 for reset signalling > > Any chance of getting these into 4.12, Samuel? I have yo

Re: [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2017-04-05 Thread Samuel Ortiz
insertions(+), 11 deletions(-) Patches #1 and #2 applied to nfc-next. I'll wait for you to rework #3 before merging. Cheers, Samuel.

Re: [PATCH v1] NFC: netlink: Use error code from nfc_activate_target()

2017-04-05 Thread Samuel Ortiz
rning: variable ‘rc’ set but not used > [-Wunused-but-set-variable] > int rc; > ^~ > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > net/nfc/netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Cheers, Samuel.

Re: [PATCH v1] NFC: Add nfc_dbg() macro

2017-04-05 Thread Samuel Ortiz
Applied as well. Cheers, Samuel.

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-04-01 Thread Samuel Ortiz
+-- > 2 files changed, 16 insertions(+), 14 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel.

[GIT] [4.8] NFC update

2016-07-20 Thread Samuel Ortiz
Hi David, This is the first NFC pull request for 4.8. We have: - A fairly large NFC digital stack patchset: * RTOX fixes. * Proper DEP RWT support. * ACK and NACK PDUs handling fixes, in both initiator and target modes. * A few memory leak fixes. - A conversion of the nfcsim driver

Re: [PATCH] nfp: check idx is -ENOSPC before using it is an index

2016-07-11 Thread Samuel Ortiz
(struct nci_dev *ndev) > > if (info->ram_patch) { > release_firmware(info->ram_patch); > - info->otp_patch = NULL; > + info->ram_patch = NULL; > } > } This chunk is unrelated and also already applied to my nfc-next tree. Cheers, Samuel.

[PATCH net v2] openvswitch: fix conntrack netlink event delivery

2016-06-28 Thread Samuel Gauthier
in the non-commit case as well. Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action") CC: Joe Stringer <joestrin...@nicira.com> CC: Justin Pettit <jpet...@nicira.com> CC: Andy Zhou <az...@nicira.com> CC: Thomas Graf <tg...@suug.ch> Signed-off-by: Samuel Gauthier &

[PATCH net] openvswitch: fix conntrack netlink event delivery

2016-06-28 Thread Samuel Gauthier
, i.e not only in the commit case. Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action") CC: Joe Stringer <joestrin...@nicira.com> CC: Justin Pettit <jpet...@nicira.com> CC: Andy Zhou <az...@nicira.com> CC: Thomas Graf <tg...@suug.ch> Signed-off-by: Samuel G

[GIT] [4.6] NFC update

2016-05-11 Thread Samuel Ortiz
Hi David, This is the first NFC pull request for 4.7. With this one we mainly have: - Support for NXP's pn532 NFC chipset. The pn532 is based on the same microcontroller as the pn533, but it talks to the host through i2c instead of USB. By separating the pn533 driver into core and PHY

Re: [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-20 Thread Samuel Gauthier
2016-03-17 0:23 GMT+01:00 Jesse Gross <je...@kernel.org>: > On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier > <samuel.gauth...@6wind.com> wrote: >> This patchset adds a netlink api to refresh an existing flow in >> openvswitch. >> >> When a packet

[PATCH net-next 2/2] ovs: support to refresh a flow via netlink

2016-03-19 Thread Samuel Gauthier
' netlink message refreshes the flow used time to the current time. The value in OVS_FLOW_ATTR_USED attribute is not used in this case. Signed-off-by: Samuel Gauthier <samuel.gauth...@6wind.com> --- net/openvswitch/datapath.c | 2 ++ net/openvswitch/flow.c | 6 ++ net/openvswitch/

[PATCH net-next 1/2] ovs: split ovs_flow_stats_update into skb and stats

2016-03-19 Thread Samuel Gauthier
The function to update statistics takes a skbuff as parameter. It would be handy to have the statistics update part in one function, and the skbuff part in another one. The next commit will make use of the new ovs_flow_stats_update function. Signed-off-by: Samuel Gauthier <samuel.ga

[PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-18 Thread Samuel Gauthier
the behavior for all the flows, which is not always what you want. I tested this with a patch for the openvswitch tree of the ovs-dpctl mod-flow command, which adds a --refresh flag. I will submit the patch if this patchset is accepted. Samuel Gauthier (2): ovs: split ovs_flow_stats_update into skb

[GIT] [4.6] NFC update

2016-03-11 Thread Samuel Ortiz
Hi David, This is a very small one this time, with only 5 patches. There are a couple of big items that could not be merged/finished on time. We have: - 2 LLCP fixes for a race and a potential OOM. - 2 cleanups for the pn544 and microread drivers. - 1 Maintainer addition for the s3fwrn5 driver.

[PATCH v2 net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-10 Thread Samuel Gauthier
is used to validate the actions provided by the userland. This commit allows to use the ufid without having to provide the flow key, as it is already done in the netlink 'flow get' and 'flow del' path. The flow key remains mandatory when an action is provided. Signed-off-by: Samuel Gauthier

[PATCH net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-09 Thread Samuel Gauthier
allows to use the ufid without having to provide the flow key, as it is already done in the netlink 'flow get' and 'flow del' path. Signed-off-by: Samuel Gauthier <samuel.gauth...@6wind.com> --- net/openvswitch/datapath.c | 21 ++--- 1 file changed, 10 insertions(+), 11 del

Re: [PATCH v2 net] nfc: close a race condition in llcp_sock_getname()

2016-02-24 Thread Samuel Ortiz
lt;lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> > --- > net/nfc/llcp_sock.c | 6 ++ > 1 file changed, 6 insertions(+) Applied as well, thanks. Cheers, Samuel.

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

2016-02-24 Thread Samuel Ortiz
e.com> > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> > --- > net/nfc/llcp_commands.c | 4

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

2016-02-24 Thread Samuel Ortiz
licious users to OOM kernel on purpose. > > > > Reported-by: Dmitry Vyukov <dvyu...@google.com> > > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > > Cc: Samuel Ortiz <sa...@linu

[GIT] [4.5] NFC update

2015-12-31 Thread Samuel Ortiz
Hi David, This is the first NFC pull request for 4.5 and it brings: - A new driver for the STMicroelectronics ST95HF NFC chipset. The ST95HF is an NFC digital transceiver with an embedded analog front-end and as such relies on the Linux NFC digital implementation. This is the 3rd user of

[GIT] [4.4] NFC fixes

2015-11-08 Thread Samuel Ortiz
Hi David, This is the 1st NFC fixes pull request for 4.4. It includes bug fixes and one fix for a build failure, all of them introduced with the first NFC pull request for 4.4. We have: - Fix nfcmrvl SPI driver potential build error due to a broken Kconfig dependency. - A few fixes for the

[GIT] [4.4] NFC update

2015-10-28 Thread Samuel Ortiz
crash in nci_core_conn_create NFC: nci: add nci_get_conn_info_by_id function NFC: Add Intel Fields Peak NFC solution driver NFC: nci: non-static functions can not be inline Samuel Ortiz (2): NFC: nci: Use __nci_request for exported routines NFC: st-nci: Rename st-nci_se.c

Re: [PATCH 1/2] NFC: delete null dereference

2015-10-19 Thread Samuel Ortiz
ound using scripts/coccinelle/null/deref_null.cocci > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > > --- > net/nfc/netlink.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel. -- To unsubscribe from th

Re: [PATCH] nfc: netlink: avoid NULL pointer dereference on error

2015-10-19 Thread Samuel Ortiz
gt; > ./net/nfc/netlink.c:1175:21-24: ERROR: dev is NULL but dereferenced. > > Signed-off-by: Vincent Stehlé <vincent.ste...@laposte.net> > Cc: Thierry Escande <thierry.esca...@linux.intel.com> > Cc: Samuel Ortiz <sa...@linux.intel.com> > --- > net/nf

[GIT] [4.3] NFC update

2015-08-20 Thread Samuel Ortiz
Hi David, This is the NFC pull request for 4.3. With this one we have: - A new driver for Samsung's S3FWRN5 NFC chipset. In order to properly support this driver, a few NCI core routines needed to be exported. Future drivers like Intel's Fields Peak will benefit from this. - SPI support

[GIT] [4.2] 2nd NFC update

2015-06-18 Thread Samuel Ortiz
Hi David, This is a follow up fix for a typo that I introduced while cleaning the 1st 4.2 NFC pull request patches. The following changes since commit d0dcad8bd32a34aa85bcbd5d2033658cb3964377: NFC: nfcmrvl: set PB_BAIL_OUT at setup (2015-06-13 00:08:55 +0200) are available in the git

[GIT] [4.2] NFC update

2015-06-14 Thread Samuel Ortiz
support for enumerating through ACPI Samuel Ortiz (5): NFC: nxp-nci: Fix build warning NFC: nci: Handle proprietary response and notifications NFC: Introduce vendor commands structures NFC: netlink: Implement vendor command support NFC: nci: Export nci_req_complete Tomas

Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

2015-06-08 Thread Samuel Ortiz
;} else {...} exit: Signed-off-by: Joe Perches j...@perches.com --- net/nfc/nci/hci.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) Applied to nfc-next, thanks. Cheers, Samuel. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r

Re: [linux-nfc] [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: In order to communicate with the device during the setup phase

Re: [linux-nfc] [PATCH 1/8] NFC: NCI: Allow connection close with dev down

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: By calling __nci_request instead of nci_request allows the driver

[PATCH] [IrDA] LMP discovery timer not started by default

2008-01-22 Thread Samuel Ortiz
Hi Dave, By default, LMP sets up a 3 seconds timer for discovery. We don't need it until discovery is set to 1. This patch is against your latest net-2.6.25 tree. From: Ross Burton [EMAIL PROTECTED] Signed-off-by: Ross Burton [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED

[PATCH 3/4] [IrDA] Irport removal - part 1

2008-01-18 Thread samuel
From: Adrian Bunk [EMAIL PROTECTED] This patch removes IrPORT and the old dongle drivers (all off them have replacement drivers). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/Kconfig | 141 - drivers/net/irda/Makefile

[PATCH 2/4] [IrDA] Frame length validation

2008-01-18 Thread samuel
invalid - either an empty i:rsp or an IrCOMM i:rsp with an invalid clen. These corner cases are now checked. Signed-off-by: Robie Basak [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/ircomm/ircomm_core.c | 12 net/irda/irlap_event.c| 13

[PATCH 1/4] [IrDA] Resend frames on timeout

2008-01-18 Thread samuel
From: Robie Basak [EMAIL PROTECTED] When final timer expires, it might also mean that the i:cmd wasn't received properly. If we have rejected frames, we can try to resend them. Signed-off-by: Robie Basak [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/irlap_event.c

[PATCH 0/4] [IrDA] IrDA fixes for net-2.6.25

2008-01-18 Thread samuel
Hi Dave, Here goes a batch of 4 IrDA patches against your latest net-2.6.25 tree. Cheers, Samuel. -- -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [IrDA] af_irda memory leak fixes

2008-01-17 Thread Samuel Ortiz
Hi Dave, Here goes an IrDA patch against your latest net-2.6 tree. This patch fixes some af_irda memory leaks. It also checks for irias_new_obect() return value. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/af_irda.c | 30

[PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb

2007-12-16 Thread Samuel Ortiz
It seems to me that irda_usb_net_open() must set self-netopen under spinlock or disconnect() may fail to kill all URBs, if it is called while an interface is opened. From: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED

[PATCH 0/5] [IrDA] IrDA net-2.6 fixes

2007-12-16 Thread Samuel Ortiz
Hi Dave, Here goes a batch of 5 IrDA patches against your latest net-2.6 tree. Cheers, Samuel. -- -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 5/5] [IrDA] irda parameters warning fixes.

2007-12-16 Thread Samuel Ortiz
: warning: Using plain integer as NULL pointer From: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Cc: Andrew Morton [EMAIL PROTECTED] --- net/irda/parameters.c |6 +++--- 1 file changed, 3 insertions(+), 3

  1   2   3   >