On Tue, Dec 18, 2018 at 03:02:24PM -0800, Santosh Shilimkar wrote:
> On 12/18/2018 2:57 PM, David Miller wrote:
> > From: Shamir Rabinovitch
> > Date: Sun, 16 Dec 2018 09:01:07 +0200
> >
> > > From: shamir rabinovitch
> > >
> > > This patch s
From: shamir rabinovitch
redundant copy_from_user in rds_sendmsg system call expose rds
to issue where rds_rdma_extra_size walk the rds iovec and and
calculate the number pf pages (sgs) it need to add to the tail of
rds message and later rds_cmsg_rdma_args copy the rds iovec again
and re
From: shamir rabinovitch
per comment from Leon in rdma mailing list
https://lkml.org/lkml/2018/10/31/312 :
Please don't forget to remove user triggered WARN_ON.
https://lwn.net/Articles/769365/
"Greg Kroah-Hartman raised the problem of core kernel API code that will
use WARN_ON
From: shamir rabinovitch
This patch set fix google syzbot rds bug found in linux-next.
The first patch solve the syzbot issue.
The second patch fix issue mentioned by Leon Romanovsky that
drivers should not call WARN_ON as result from user input.
syzbot bug report can be foud here: https
+ }
> }
>
> int rds_ib_recv_path(struct rds_conn_path *cp)
> @@ -1029,6 +1031,7 @@ int rds_ib_recv_path(struct rds_conn_path *cp)
> if (rds_conn_up(conn)) {
> rds_ib_attempt_ack(ic);
> rds_ib_recv_refill(conn, 0, GFP_KERNEL);
> + rds_ib_stats_inc(s_ib_rx_refill_from_thread);
> }
>
> return ret;
> --
> 2.9.3
>
Reviewed-by: Shamir Rabinovitch
From: shamir rabinovitch
rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages.
This option cause the rds Makefile to add -DDEBUG to the rds gcc command
line.
When CONFIG_DYNAMIC_DEBUG is enabled, the "DEBUG" macro is used by
include/linux/dynamic_debug.h
Fix issue in 'rds_ib_cong_recv' when accessing unaligned memory
allocated by 'rds_page_remainder_alloc' using uint64_t pointer.
Signed-off-by: Shamir Rabinovitch
---
net/rds/page.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rds/page.c b/
When PAGE_SIZE > 4k single page can contain 2 RDS fragments. If
'rds_ib_cong_recv' ignore the RDS fragment offset in to the page it
then read the data fragment as far congestion map update and lead to
corruption of the RDS connection far congestion map.
Signed-off-by: Shamir Rabinovi
On Thu, Mar 31, 2016 at 04:02:46PM -0400, David Miller wrote:
> From: shamir rabinovitch
> Date: Thu, 31 Mar 2016 02:29:22 -0400
>
> > Issue can be seen on platforms that use 8K and above page size
> > while rds fragment size is 4K. On those platforms single page is
> &g
Sparc64 expect 64 bit types to be aligned to 8. This patch ensure that
memory allocated by 'rds_page_remainder_alloc' will be aligned to 8.
This patch fix issue found in 'rds_ib_cong_recv' when accessing
unaligned memory using uint64_t pointer.
Signed-off-by: Shamir Rabin
elow patch for Sparc64 platforms:
001f8f8 RDS: fix "Kernel unaligned access" on sparc64
Signed-off-by: Shamir Rabinovitch
Reviewed-by: Wengang Wang
Reviewed-by: Ajaykumar Hotchandani
Acked-by: Santosh Shilimkar
Tested-by: Anand Bibhuti
---
net/rds/ib_recv.c |2 +-
1 files changed
account lead to reading the data fragment
as congestion map fragment and hang of the rds transmit due to far
congestion map corruption.
Signed-off-by: shamir rabinovitch
Reviewed-by: Wengang Wang
Reviewed-by: Ajaykumar Hotchandani
Acked-by: Santosh Shilimkar
Tested-by: Anand Bibhuti
---
net/rds
On Thu, Mar 31, 2016 at 05:23:30PM +0300, Sergei Shtylyov wrote:
> On 3/31/2016 5:20 PM, Shamir Rabinovitch wrote:
>
> >>>Issue can be seen on platforms that use 8K and above page size
> >>>while rds fragment size is 4K. On those platforms single page is
>
On Thu, Mar 31, 2016 at 04:13:35PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 3/31/2016 3:50 AM, shamir rabinovitch wrote:
>
> >Issue can be seen on platforms that use 8K and above page size
> >while rds fragment size is 4K. On those platforms single page is
> &g
count lead to reading the data fragment
as congestion map fragment and hang of the rds transmit due to far
cong map corruption.
Reviewed-by: Wengang Wang
Reviewed-by: Ajaykumar Hotchandani
Acked-by: Santosh Shilimkar
Tested-by: Anand Bibhuti
Signed-off-by: shamir rabinovitch
---
net/rds/ib_r
15 matches
Mail list logo
