[PATCH 3/3] TCP: htcp - use measured rtt

2007-07-25 Thread shemminger
Change HTCP to use measured RTT rather than smooth RTT. Srtt is computed using the TCP receive timestamp options, so it is vulnerable to hostile receivers. To avoid any problems this might cause use the measured RTT instead. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/tcp_

[PATCH 1/3] TCP: congestion control API pass RTT in microseconds

2007-07-25 Thread shemminger
This patch changes the API for the callback that is done after an ACK is received. It solves a couple of issues: * Some congestion controls want higher resolution value of RTT (controlled by TCP_CONG_RTT_SAMPLE flag). These don't really want a ktime, but all compute a RTT in microsecond

[PATCH 2/3] TCP: cubic - eliminate use of receive time stamp

2007-07-25 Thread shemminger
Remove use of received timestamp option value from RTT calculation in Cubic. A hostile receiver may be returning a larger timestamp option than the original value. This would cause the sender to believe the malevolent receiver had a larger RTT and because Cubic tries to provide some RTT friendlines

[PATCH 0/3] TCP timestamp hardening (update)

2007-07-25 Thread shemminger
These patches deal with issues brought up by Gavin McCullagh about reactions of Cubic and HTCP to hostile receivers that return bogus timestamp options. If the receiver crafts a timestamp that is larger than the original, then some of the congestion control algorithms maybe come unfair. The soluti

[PATCH 3/5] sky2: use dev_err for error reports

2007-01-26 Thread shemminger
Use the standard dev_printk functions instead of printk directly for error reports. Fix a bug where the initialization would return 0 if allocation of network device failed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 75 +--

[PATCH 2/5] sky2: add Wake On Lan support

2007-01-26 Thread shemminger
Adds basic magic packet wake on lan support to the sky2 driver. Note: initial WOL value is based on BIOS settings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 208 ++--- drivers/net/sky2.h | 28 ++- 2 files c

[PATCH 1/5] sky2: handle network device allocation failure

2007-01-26 Thread shemminger
If alloc_etherdev() failed, then sky2_init_netdev will return NULL, and sky2_probe would end up returning 0 instead of -ENOMEM. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.orig/drivers/net/sky2.c2007-01-25 13:09:31.0 -0800 +++ sky2-2.6/drivers/net/sky2.c 2007-01-

[PATCH 0/5] sky2 v1.11.1 patches

2007-01-26 Thread shemminger
These patches are against netdev-2.6#upstream. The enhancements are WOL support and use of dev_printk. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

[PATCH 4/5] sky2: software rx/tx stats

2007-01-26 Thread shemminger
Maintain packet statistics in software rather than hardware. This is slightly slower, but allows easier debugging of problems where packets are still being received by PHY but not being handled by hardware. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 21 +

[PATCH 5/5] sky2: version 1.11.1

2007-01-26 Thread shemminger
Version update to 1.11.1. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- sky2-2.6.orig/drivers/net/sky2.c2007-01-26 11:27:42.0 -0800 +++ sky2-2.6/drivers/net/sky2.c 2007-01-26 11:27:45.

[RFT 4/5] sky2: big endian fix

2006-09-05 Thread shemminger
Revised version of Ben's patch to fix big endian support. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-09-05 13:39:34.0 -0700 +++ sky2/drivers/net/sky2.c 2006-09-05 13:57:44.0 -0700 @@ -809,7 +809,7 @@ struct sky2_rx

[RFT 1/5] sky2: more device ids (resend)

2006-09-05 Thread shemminger
Some more Marvell device id's, these are from the latest SysKonnect driver version. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c |3 +++ 1 file changed, 3 insertions(+) --- sky2.orig/drivers/net/sky2.c2006-09-01 14:49:49.0 -0700 +++ sky2/drive

[RFT 2/5] sky2: accept flow control

2006-09-05 Thread shemminger
Don't program the GMAC to reject flow control packets. This maybe the cause of some of the receive hangs. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.h2006-09-05 15:17:38.0 -0700 +++ sky2/drivers/net/sky2.h 2006-09-05 15:18:00.0

[RFT 0/5] sky2 experimental patches

2006-09-05 Thread shemminger
These patches (against 2.6.18-rc6) may solve some of the mystery hangs and other open problems. Still seeking confirmation. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[RFT 3/5] sky2: handle forced settings

2006-09-05 Thread shemminger
Handle cases where pause parameters are forced. Need to program the GMAC before starting the PHY, not after. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-09-05 12:10:18.0 -0700 +++ sky2/drivers/net/sky2.c 2006-09-05 13:32:59.000

[RFT 5/5] sky2: fix fiber support

2006-09-05 Thread shemminger
Fix support for fiber based devices. Needed to keep track of PMD type to add workaround in setup. Add support for gigabit half duplex fiber. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 81 - drivers/net/sky2

[PATCH 5/9] sky2: TSO mss optimization

2006-08-28 Thread shemminger
The MSS in the transmit engine only has to change if TSO mtu changes. This means less commands to the chip when mixing TSO and regular data. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:07.0 -0700 +++ sky2/drivers/net/sky2.c

[PATCH 7/9] sky2: power down PHY when not up

2006-08-28 Thread shemminger
To save power, don't enable power to the PHY until device is brought up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:13.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-28 10:00:17.0 -0700 @@ -195,7 +195,6 @@ static

[PATCH 2/9] sky2: use netdev_alloc_skb

2006-08-28 Thread shemminger
Use netdev_alloc_skb for buffer allocation to allow for headroom. This prevents bugs in code paths that assume extra space at the front and makes sky2 behave like other drivers. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-25 16:01:33.00

[PATCH 0/9] sky2 1.7 non-critical bug fixes

2006-08-28 Thread shemminger
These are a set of non-critical fixes to the sky2 driver. 1. cloned skb tso bug fix 2. netdev_alloc_skb 3. don't use force status on transmit 4. MSI pci posting bug 5. TSO segment size optimization 6. checksum offload optimization 7. power up PHY only on network open 8. pci post bug

[PATCH 4/9] sky2: MSI test timing

2006-08-28 Thread shemminger
The test for MSI IRQ could have timing issues. The PCI write needs to be pushed out before waiting, and the wait queue should be initialized before the IRQ. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-25 16:05:10.0 -0700 +++ sky2/d

[PATCH 6/9] sky2: optimize checksum offload information

2006-08-28 Thread shemminger
Since many packets have the same checksum starting offset and insertion location; the driver can save the last information and only tell hardware when it changes. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:08.0 -0700 +++ s

[PATCH 3/9] sky2: dont use force status bit

2006-08-28 Thread shemminger
Don't use force status bit. It was never implemented on all chips, or has no impact. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-25 16:02:27.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-25 16:05:10.0 -0700 @@ -1192,7 +119

[PATCH 1/9] sky2: remove cloned/pskb_expand_head check

2006-08-28 Thread shemminger
The code to handle cloned skb overwriting is unnecessary in the sky2 driver and is buggy. The bug is that pskb_expand_head can change the skb but the driver has already mapped in the header. Since the sky2 hardware doesn't need to overwrite memory, the buggy code can just be removed; it was mistak

[PATCH 9/9] sky2: version 1.7

2006-08-28 Thread shemminger
Change version number for this bundle. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-22 14:55:42.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-22 14:55:46.0 -0700 @@ -50,7 +50,7 @@ #include "sky2.h" #define DRV_NAME

[PATCH 8/9] sky2: pci post bug

2006-08-28 Thread shemminger
Make sure that PCI write occurs before the delay. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:17.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-28 10:00:20.0 -0700 @@ -531,6 +531,7 @@ reg1 |= phy_p

[PATCH 3/4] bridge-netfilter: simplify nf_bridge_pad

2006-08-22 Thread shemminger
Do some simple optimization on the nf_bridge_pad() function and don't use magic constants. Eliminate a double call and the #ifdef'd code for CONFIG_BRIDGE_NETFILTER. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-nf.orig/include/linux/netfilter_bridge.h 2006-08-22 16:46:47.0

[PATCH 4/4] bridge-netfilter: debug message fixes

2006-08-22 Thread shemminger
If CONFIG_NETFILTER_DEBUG is enabled, it shouldn't change the actions of the filtering. The message about skb->dst being NULL is commonly triggered by dhclient, so it is useless. Make sure all messages end in newline. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-nf.orig/net/bridge

[PATCH 2/4] bridge-netfilter: code rearrangement for clarity

2006-08-22 Thread shemminger
Cleanup and rearrangement for better style and clarity: Split the function nf_bridge_maybe_copy_header into two pieces Move copy portion out of line. Use Ethernet header size macros. Use header file to handle CONFIG_NETFILTER_BRIDGE differences Signed-off-by: Stephe

[PATCH 0/4] bridge-netfilter fixes

2006-08-22 Thread shemminger
This set of patches fixes issues with bridge netfilter code. First patch is for 2.6.18 and fixes a crash. Later patches could be deferred, they just cleanup the style, usage, etc. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

[PATCH 1/4] bridge-netfilter: memory corruption fix

2006-08-22 Thread shemminger
The bridge-netfilter code will overwrite memory if there is not headroom in the skb to save the header. This first showed up when using Xen with sky2 driver that doesn't allocate the extra space. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-nf.orig/include/linux/netfilter_bridge.

Re: RX processing order for packet sockets and bridge

2006-03-29 Thread shemminger
> On Wed, 2006-29-03 at 11:14 -0800, Jouni Malinen wrote: > [..] > > A digression: One of the problems of the bridge in my opinion is having > STP, a control protocol, inside the kernel. I do hope someone with time > will rip it out of the kernel some day. I looked into it, but the size of STP is

[PATCH 08/15] bridge: netfilter VLAN macro cleanup

2006-03-13 Thread shemminger
Fix the VLAN macros in bridge netfilter code. Macros should not depend on magic variables. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: net-2.6.17/net/bridge/br_netfilter.c === --- net-2.6.17.orig/net/bridge/br_netfilt

[PATCH 12/15] bridge: use llc for receiving STP packets

2006-03-13 Thread shemminger
Use LLC for the receive path of Spanning Tree Protocol packets. This allows link local multicast packets to be received by other protocols (if they care), and uses the existing LLC code to get STP packets back into bridge code. The bridge multicast address is also checked, so bridges using other l

[PATCH 00/15] Bridge update for 2.6.17

2006-03-13 Thread shemminger
This patches includes previous bridge changes for 2.6.17 and new patches to enable using LLC to handle bridge STP packets. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

[PATCH 14/15] llc: llc_mac_hdr_init const arguments

2006-03-13 Thread shemminger
Cleanup of LLC. llc_mac_hdr_init can take constant arguments, and it is defined twice once in llc_output.h that is otherwise unused. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/include/net/llc.h +++ net-2.6.17/include/net/llc.h @@ -71,7 +71,7 @@ extern int llc_rcv(st

[PATCH 05/15] bridge: optimize frame pass up

2006-03-13 Thread shemminger
The netfilter hook that is used to receive frames doesn't need to be a stub. It is only called in two ways, both of which ignore the return value. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_input.c +++ net-2.6.17/net/bridge/br_input.c @@ -21,12 +21,6 @@

[PATCH 15/15] bridge: use LLC to send STP

2006-03-13 Thread shemminger
The bridge code can use existing LLC output code when building spanning tree protocol packets. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: net-2.6.17/net/bridge/br_stp_bpdu.c === --- net-2.6.17.orig/net/bridge/br_st

[PATCH 13/15] bridge: allow show/store of group multicast address

2006-03-13 Thread shemminger
Bridge's communicate with each other using Spanning Tree Protocol over a standard multicast address. There are times when testing or layering bridges over existing topologies or tunnels, when it is useful to use alternative multicast addresses for STP packets. The 802.1d standard has some unused a

[PATCH 04/15] bridge: use kzalloc

2006-03-13 Thread shemminger
Use kzalloc versus kmalloc+memset. Also don't need to do memset() of bridge address since it is in netdev private data that is already zero'd in alloc_netdev. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_if.c +++ net-2.6.17/net/bridge/br_if.c @@ -210,7 +2

[PATCH 10/15] bridge: forwarding remove unneeded preempt and bh diasables

2006-03-13 Thread shemminger
Optimize the forwarding and transmit paths. Both places are called with bottom half/no preempt so there is no need to use spin_lock_bh or rcu_read_lock. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-2.6.orig/net/bridge/br_fdb.c +++ br-2.6/net/bridge/br_fdb.c @@ -341,7 +341,6 @@ voi

[PATCH 09/15] bridge: netfilter inline cleanup

2006-03-13 Thread shemminger
Move nf_bridge_alloc from header file to the one place it is used and optimize it. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/include/linux/netfilter_bridge.h +++ net-2.6.17/include/linux/netfilter_bridge.h @@ -47,22 +47,6 @@ enum nf_br_hook_priorities { #define BR

[PATCH 03/15] bridge: use kcalloc

2006-03-13 Thread shemminger
Use kcalloc rather than kmalloc + memset. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: br-2.6/net/bridge/br_if.c === --- br-2.6.orig/net/bridge/br_if.c +++ br-2.6/net/bridge/br_if.c @@ -237,12 +237,11 @@ static int fin

[PATCH 01/15] bridge: remove unneeded bh disables

2006-03-13 Thread shemminger
The STP timers run off softirq (kernel timers), so there is no need to disable bottom half in the spin locks. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: br-2.6/net/bridge/br_stp_timer.c === --- br-2.6.orig/net/bridg

[PATCH 11/15] bridge: stp timer to jiffies cleanup

2006-03-13 Thread shemminger
Cleanup the get/set of bridge timer value in the packets. It is clearer not to bury the conversion in macro. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-2.6.orig/net/bridge/br_stp_bpdu.c +++ br-2.6/net/bridge/br_stp_bpdu.c @@ -19,8 +19,7 @@ #include "br_private.h" #include "br_

[PATCH 02/15] bridge: use setup_timer

2006-03-13 Thread shemminger
Use the now standard setup_timer function. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: br-2.6/net/bridge/br_stp_timer.c === --- br-2.6.orig/net/bridge/br_stp_timer.c +++ br-2.6/net/bridge/br_stp_timer.c @@ -144,39 +1

[PATCH 06/15] bridge: netfilter whitespace

2006-03-13 Thread shemminger
Run br_netfilter through Lindent to fix whitespace. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_netfilter.c +++ net-2.6.17/net/bridge/br_netfilter.c @@ -136,7 +136,7 @@ static void __br_dnat_complain(void) if (jiffies - last_complaint >= 5 * H

[PATCH 07/15] bridge: netfilter dont use __constant_htons

2006-03-13 Thread shemminger
Only use__constant_htons() for initializers and switch cases. For other uses, it is just as efficient and clearer to use htons Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_netfilter.c +++ net-2.6.17/net/bridge/br_netfilter.c @@ -61,14 +61,14 @@ static int

[Fwd: [Bug 6068] New: UDP packet loss and slow communication]

2006-02-13 Thread shemminger
--- Begin Message --- http://bugzilla.kernel.org/show_bug.cgi?id=6068 Summary: UDP packet loss and slow communication Kernel Version: 2.6.15.4 Status: NEW Severity: normal Owner: [EMAIL PROTECTED] Submitter: [EMAIL PROTECTED] Most recen

Re: [wireless-2.6] d80211/ieee80211 symbol clash

2006-02-02 Thread shemminger
On Thu, 2006-02-02 at 13:56 -0800, Jouni Malinen wrote: > On Thu, Feb 02, 2006 at 08:36:26PM +0100, Michael Buesch wrote: > > > net/ieee80211/built-in.o: In function `ieee80211_rx': > > : multiple definition of `ieee80211_rx' > > net/d80211/built-in.o:: first defined here > > > But how to solve i

Re: how to obtain detailed e1000 stats?

2006-01-18 Thread shemminger
On Wed, 2006-01-18 at 14:37 -0800, Ben Greear wrote: > Roberto Nibali wrote: > >>> It looks like the e1000 driver gathers all kinds of stats. How do I > >>> access these from userspace? > >> > >> > >> /proc/net/dev will have many of the common ones, and ethtool should > >> get the rest. > >> > >>

[PATCH 1/4] fls64: generic version

2005-12-14 Thread shemminger
a/bitops.h +++ bic-2.6/include/asm-xtensa/bitops.h @@ -245,6 +245,7 @@ static __inline__ int fls (unsigned int { return __cntlz(x); } +#define fls64(x) generic_fls64(x) static __inline__ int find_next_bit(const unsigned long *addr, int size, int offset) -- Stephen Hemminger <[EMAI

[PATCH 0/4] TCP Cubic updates for 2.6.16

2005-12-14 Thread shemminger
This set of patches: * precomputes constants used in TCP cubic * uses Newton/Raphson for cube root * adds find largest set bit 64 to make initial estimate -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from thi

[PATCH 3/4] TCP cubic precompute constants

2005-12-14 Thread shemminger
; 100 seconds +* HZ < 1,000,00 (corresponding to 10 nano-second) +*/ + + /* 1/c * 2^2*bictcp_HZ * srtt */ + cube_factor = 1ull << (10+3*BICTCP_HZ); /* 2^40 */ + + /* divide by bic_scale and by constant Srtt (100ms) */ + do_div(cube_factor, bic_scale * 10); + return tcp_register_congestion_control(&cubictcp); } -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] fls64: x86_64 version

2005-12-14 Thread shemminger
last set bit */ #define fls(x) generic_fls(x) -#define fls64(x) generic_fls64(x) #endif /* __KERNEL__ */ -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

[PATCH 4/4] TCP Cubic use Newton-Raphson

2005-12-14 Thread shemminger
+ x1 = x; + x = (2 * x + (uint32_t) div64_64(a, x*x)) / 3; + } while (abs(x1 - x) > 1); + + return x; } /* -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 10/13] sky2: byteorder annotation

2005-11-30 Thread shemminger
t; OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 07/13] sky2: change netif_rx_schedule_test to __netif_schedule_prep

2005-11-30 Thread shemminger
ep(struct net_device *dev) { - return netif_running(dev) && netif_rx_schedule_test(dev); + return netif_running(dev) && __netif_rx_schedule_prep(dev); } /* Add interface to tail of rx poll list. This assumes that _prep has -- Stephen Hemminger <[EMAIL PROTECTED]&g

[PATCH 13/13] sky2: update version number

2005-11-30 Thread shemminger
ICENSE("GPL"); +MODULE_VERSION(DRV_VERSION); -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 08/13] sky2: race with MTU change

2005-11-30 Thread shemminger
tr_mask); - sky2_read32(hw, B0_IMSK); - local_irq_enable(); + return err; } -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 09/13] sky2: dual port tx completion

2005-11-30 Thread shemminger
default: @@ -1816,6 +1820,8 @@ static int sky2_poll(struct net_device * } exit_loop: + sky2_tx_check(hw, 0); + sky2_tx_check(hw, 1); mmiowb(); -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this

[PATCH 02/13] sky2: add MII support

2005-11-30 Thread shemminger
tl; dev->hard_start_xmit = sky2_xmit_frame; dev->get_stats = sky2_get_stats; dev->set_multicast_list = sky2_set_multicast; -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 11/13] sky2: remove pci-express hacks

2005-11-30 Thread shemminger
phen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 03/13] sky2: fix receive flush/pause issues

2005-11-30 Thread shemminger
v->name, status, length); -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 12/13] sky2: use pci_register_driver

2005-11-30 Thread shemminger
e(void) { - return pci_module_init(&sky2_driver); + return pci_register_driver(&sky2_driver); } static void __exit sky2_cleanup_module(void) -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send t

[PATCH 04/13] sky2: improve receive performance

2005-11-30 Thread shemminger
b(); + return 0; + } else { + *budget -= work_done; + dev0->quota -= work_done; + return 1; } - - return work_done >= to_do; - } static void sky2_hw_error(struct sky2_hw *hw, unsigned port, u32 status) -- Stephen Hemminge

[PATCH 05/13] sky2: add Yukon-EC ultra support

2005-11-30 Thread shemminger
VLAN_TAG_ON = 1<<25,/* enable VLAN tagging */ TX_VLAN_TAG_OFF = 1<<24,/* disable VLAN tagging */ -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 00/13] sky2: version 0.9

2005-11-30 Thread shemminger
mainstream use. -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 01/13] sky2: eliminate special case for EC-A1

2005-11-30 Thread shemminger
ID_YUKON_EC && \ +(hw)->chip_rev == CHIP_REV_YU_EC_A1) #define RX_LE_SIZE 256 #define RX_LE_BYTES(RX_LE_SIZE*sizeof(struct sky2_rx_le)) -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send

[PATCH 06/13] sky2: handle DMA boundary crossing

2005-11-30 Thread shemminger
>ctrl = 0; le->opcode = OP_ADDR64 | HW_OWNER; - sky2->tx_addr64 = addr64; + sky2->tx_addr64 = high32(mapping + len); } /* Check for TCP Segmentation Offload */ -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://develop

[PATCH 2/6] sk98lin: add permanent address support

2005-11-23 Thread shemminger
Add permanent address and link status support via ethtool. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/skethtool.c +++ skge-2.6/drivers/net/sk98lin/skethtool.c @@ -549,4 +549,6 @@ struct ethtool_ops SkGeEthtoolOps = { .phys_id

[PATCH 4/6] sk98lin: allow ethtool checksum on/off per port

2005-11-23 Thread shemminger
Allow control of checksumming parameters via ethtool. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/h/skdrv2nd.h +++ skge-2.6/drivers/net/sk98lin/h/skdrv2nd.h @@ -298,6 +298,7 @@ struct s_RxPort { RXD *pRxdRingTail; /* Tail of Rx r

[PATCH 6/6] sk98lin: remove /proc interface

2005-11-23 Thread shemminger
Remove device specific proc interface. It doesn't handle renames correctly; it ain't worth fixing. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/Makefile +++ skge-2.6/drivers/net/sk98lin/Makefile @@ -26,8 +26,7 @@ sk98lin-objs:=\

[PATCH 0/6] sk98lin:

2005-11-23 Thread shemminger
These patches fix some lingering issues with the sk98lin driver. I expect the sk98lin driver to fade from use, but many users still unknowingly use it. They are ordered from most important to least important. Feel free to divide across releases as you see fit. -- - To unsubscribe from this list:

[PATCH 5/6] sk98lin: remove redundant fields in device info

2005-11-23 Thread shemminger
Shrink size of per device data by removing redundant fields or things that are only used at boot up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/h/skdrv2nd.h +++ skge-2.6/drivers/net/sk98lin/h/skdrv2nd.h @@ -268,8 +268,6 @@ typedef struct s_DevNet DE

[PATCH 1/6] sk98lin: fix checksumming code

2005-11-23 Thread shemminger
Remove code from sk98lin that does it's own checksum validation. This code is incorrect when dealing with nested protocols like VLAN's, and it is better to use regular receive code path to handle hardware checksum. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: skge-2.6/drivers/net/

[PATCH 3/6] sk98lin: avoid message confusion with skge

2005-11-23 Thread shemminger
Avoid possible confusion between skge and sk98lin driver by tagging messages properly. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-2.6.orig/drivers/net/sk98lin/skge.c +++ skge-2.6/drivers/net/sk98lin/skge.c @@ -4853,7 +4853,7 @@ static int __devinit skge_probe_one(stru d

[PATCH 2/8] tcp: simplify microsecond rtt sampling

2005-11-10 Thread shemminger
p(sk, NULL, 0); + tcp_ack_saw_tstamp(sk, 0); if (tp->rx_opt.tstamp_ok) tp->advmss -= TCPOLEN_TSTAMP_ALIGNED; -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/8] tcp: add tcp_slow_start helper

2005-11-10 Thread shemminger
tp->snd_cwnd = min_t(u32, tp->snd_cwnd, tp->snd_cwnd_clamp); - - /* Make sure that we are never so timid as to reduce our cwnd below -* 2 MSS. -* -* Going below 2 MSS would risk huge delayed ACKs from our receiver. -*/ - tp->snd_cwnd = max(tp

[PATCH 8/8] tcp:

2005-11-10 Thread shemminger
skb_hint = skb; - sk_stream_for_retrans_queue(skb, sk) { /* Similar to the retransmit loop above we * can pretend that the retransmitted SKB * we send out here will be composed of one @@ -1547,8 +1577,10 @@ void tcp_xmit_retransmit_queue(struct so

[PATCH 6/8] tcp: receive buffer growth limiting with mixed MTU

2005-11-10 Thread shemminger
icsk->icsk_ack.rcv_mss; - app_win = max(app_win, 2U*tp->advmss); - + if (atomic_read(&sk->sk_rmem_alloc) > sk->sk_rcvbuf) tp->rcv_ssthresh = min(tp->window_clamp, 2U*tp->advmss); - } } /* Receiver "autotuning" code. -- St

[PATCH 0/8] tcp:

2005-11-10 Thread shemminger
TCP congestion control update including: TSO fix SAC optimization receive autotuning threshold -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the b

[PATCH 1/8] tcp: fix congestion window update when using TSO deferal

2005-11-10 Thread shemminger
2.6.orig/net/ipv4/tcp_output.c +++ net-2.6/net/ipv4/tcp_output.c @@ -2058,3 +2058,4 @@ EXPORT_SYMBOL(tcp_connect); EXPORT_SYMBOL(tcp_make_synack); EXPORT_SYMBOL(tcp_simple_retransmit); EXPORT_SYMBOL(tcp_sync_mss); +EXPORT_SYMBOL(sysctl_tcp_tso_win_divisor); -- Stephen Hemminger <[EMAIL PROTEC

[PATCH 5/8] tcp: Appropriate Byte Count support

2005-11-10 Thread shemminger
if (tp->snd_cwnd_cnt >= tp->snd_cwnd) { + if (tp->snd_cwnd < tp->snd_cwnd_clamp) + tp->snd_cwnd++; + tp->snd_cwnd_cnt = 0; + } else + tp->snd_cwnd_cnt++; +

[PATCH 7/8] tcp: spelling fixes

2005-11-10 Thread shemminger
hole detection. :-( It is place to make it. It is not made. I do not want - to make it. It is disguisting. It does not work in any + to make it. It is disgusting. It does not work in any

[PATCH 3/8] tcp: eliminate packets acked hook in ca_ops

2005-11-10 Thread shemminger
.cong_avoid = tcp_reno_cong_avoid, + .cong_avoid = tcp_westwood_cong_avoid, .min_cwnd = tcp_westwood_cwnd_min, .cwnd_event = tcp_westwood_event, .get_info = tcp_westwood_info, - .pkts_acked = tcp_westwood_pkts_acked, .owner