Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-26 Thread Nikolay Aleksandrov
On 26/10/17 14:02, Nikolay Aleksandrov wrote: > On 26/10/17 13:16, Toshiaki Makita wrote: >> On 2017/10/26 7:52, Nikolay Aleksandrov wrote: >> ... >>> @@ -559,6 +574,7 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 >>> flags) >>> >>> ASSERT_RTNL(); >>> >>> + *changed = false; >>>

Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-26 Thread Nikolay Aleksandrov
On 26/10/17 13:16, Toshiaki Makita wrote: > On 2017/10/26 7:52, Nikolay Aleksandrov wrote: > ... >> @@ -559,6 +574,7 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 >> flags) >> >> ASSERT_RTNL(); >> >> +*changed = false; >> vg = br_vlan_group(br); >> vlan = br_vlan_fi

Re: [Bridge] [PATCH net-next v4 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-26 Thread Toshiaki Makita
On 2017/10/26 7:52, Nikolay Aleksandrov wrote: ... > @@ -559,6 +574,7 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags) > > ASSERT_RTNL(); > > + *changed = false; > vg = br_vlan_group(br); > vlan = br_vlan_find(vg, vid); > if (vlan) { > @@ -576,9 +592,12