Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages

2016-05-10 Thread David Miller
From: Lars Ellenberg Date: Tue, 10 May 2016 21:09:03 +0200 > On Tue, May 10, 2016 at 11:39:49AM -0400, David Miller wrote: >> From: Lars Ellenberg >> Date: Tue, 10 May 2016 11:40:23 +0200 > > excuse me for reordering the original: > >> Anyways, back to the topic, can you please just relent and

Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages

2016-05-10 Thread Lars Ellenberg
On Tue, May 10, 2016 at 11:39:49AM -0400, David Miller wrote: > From: Lars Ellenberg > Date: Tue, 10 May 2016 11:40:23 +0200 excuse me for reordering the original: > Anyways, back to the topic, can you please just relent and come to > some kind of agreement about the fix for this alignment bug?

Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages

2016-05-10 Thread David Miller
From: Lars Ellenberg Date: Tue, 10 May 2016 11:40:23 +0200 > If we introduce a new config option, > we have to add it to the config scanner (one line), > define min, max, default and scale (four short defines), > and add it to the netlink definition here (one line). > Done, rest of the code is ge

Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages

2016-05-10 Thread Nicolas Dichtel
Le 10/05/2016 11:40, Lars Ellenberg a écrit : > On Tue, May 10, 2016 at 11:09:53AM +0200, Nicolas Dichtel wrote: >> Le 09/05/2016 15:15, Lars Ellenberg a écrit : >>> On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: >> [snip] Maybe prefixing genl_magic_func.h and genl_magic_stru

Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages

2016-05-10 Thread Lars Ellenberg
On Tue, May 10, 2016 at 11:09:53AM +0200, Nicolas Dichtel wrote: > Le 09/05/2016 15:15, Lars Ellenberg a écrit : > > On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: > [snip] > >> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_' > >> could be interesting so that