Re: [INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 17:41:31 +1100 > On Tue, Jan 22, 2008 at 09:47:19PM -0800, David Miller wrote: > > > > I already checked in the ip_append_page() fix to net-2.6 so > > I simply removed that hunk when adding your fix. > > > > Thanks again! > > Thank you

Re: [INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread Herbert Xu
On Tue, Jan 22, 2008 at 09:47:19PM -0800, David Miller wrote: > > I already checked in the ip_append_page() fix to net-2.6 so > I simply removed that hunk when adding your fix. > > Thanks again! Thank you! I just received a message from Takahiro Yasui that my bug fix is buggy too :) So here is

Re: [INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 14:39:42 +1100 > [INET]: Fix truesize setting in ip_append_data > > As it is ip_append_data only counts page fragments to the skb that > allocated it. As such it means that the first skb gets hit with a > 4K charge

[INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread Herbert Xu
Hi Dave: [INET]: Fix truesize setting in ip_append_data As it is ip_append_data only counts page fragments to the skb that allocated it. As such it means that the first skb gets hit with a 4K charge even though it might have only used a fraction of it while all subsequent skb's that us