Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-14 Thread Stephen Hemminger
On Tue, 13 Mar 2018 14:14:14 -0700 Jesse Brandeburg wrote: > Maybe it's just that I've been doing this too long, but I regularly > (and many other customers/users do as well) depend on the ethtool stats > being atomically updated w.r.t. each other. This means that if

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Toshiaki Makita
On 2018/03/14 6:14, Jesse Brandeburg wrote: > which iproute2 tool shows the /proc/net/dev stats? ip -s -s link show -- Toshiaki Makita

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Eric Dumazet
On 03/13/2018 02:14 PM, Jesse Brandeburg wrote: On Tue, 13 Mar 2018 12:17:10 -0700 Eric Dumazet wrote: Yes, this is a recurring mistake See commit bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet statistics of netdev" Thanks for the pointer,

Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

2018-03-13 Thread Jesse Brandeburg
On Tue, 13 Mar 2018 12:17:10 -0700 Eric Dumazet wrote: > > Yes, this is a recurring mistake > > See commit > bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet > statistics of netdev" Thanks for the pointer, that was a useful thread to review. I